GitLab

The lowercase version comes from <cassert>, and shouldn't be used within Blink.

Review URL: https://codereview.chromium.org/1305353011

git-svn-id: svn://svn.chromium.org/blink/trunk@201923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=529370
TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/1333523002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201922 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=490608

Review URL: https://codereview.chromium.org/1328183002

git-svn-id: svn://svn.chromium.org/blink/trunk@201921 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Resource for https://codereview.chromium.org/1316673007/, landed
separately so that patch can go through CQ (as it won't upload the .xml
because it's too large.)

TBR=dominicc@chromium.org
BUG=528078, 463958

Review URL: https://codereview.chromium.org/1328093005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201920 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=529345
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/1330033003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201919 bbb929c8-8fbe-4397-9dbb-9b2b20218538

PresentationAvailability is listening to the page visibility but is using
the ExecutionContext to send messages to the controller. The ExecutionContext
might be destroyed before a page visibility change, for example, if the object
was created in a frame that has been removed from the frame tree.

BUG=526923,526116

Review URL: https://codereview.chromium.org/1322493006

git-svn-id: svn://svn.chromium.org/blink/trunk@201918 bbb929c8-8fbe-4397-9dbb-9b2b20218538

path().boundingRect() is exactly what objectBoundingBox() will return
for LayoutSVGPath, so the implementation from SVGGraphicElement can be
used.

Review URL: https://codereview.chromium.org/1315983012

git-svn-id: svn://svn.chromium.org/blink/trunk@201917 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Classes that keep a CancellableTaskFactory should create() these via the
provided factory method, which takes care of creating the task factory's
closure in a manner that doesn't cause an (Oilpan) leak.

Not using the factory method is convenient when testing, so accommodate
this by way of a protected CancellableTaskFactory<> constructor, and use
it in unit tests. The unit tests exercise functionality rather than direct
usage by Blink objects, so hiding the constructor is considered acceptable.

R=haraken
BUG=

Review URL: https://codereview.chromium.org/1320023009

git-svn-id: svn://svn.chromium.org/blink/trunk@201916 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, resetting a bookmark in a file with BOM would not account for
the BOM length, meaning the parser would be off by 2 (UCS2) or 3 (UTF-8)
bytes. Additional information in the comments and in the referenced bug.

It's not an off-by-1 error, it's an off-by-O(1) error.

R=jochen@chromium.org
BUG=527930

Review URL: https://codereview.chromium.org/1315873003

git-svn-id: svn://svn.chromium.org/blink/trunk@201915 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of
|lastEditableVisiblePositionBeforePositionInRoot()| for introducing composed
tree version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568

Review URL: https://codereview.chromium.org/1306053017

git-svn-id: svn://svn.chromium.org/blink/trunk@201914 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=528262

Note: this cannot land until after the Skia DEPS roll has landed

Review URL: https://codereview.chromium.org/1323753003

git-svn-id: svn://svn.chromium.org/blink/trunk@201913 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |endOfParagraph()|
by templatizing original |endOfParagraph()| to work both DOM tree
position and composed tree position version for introducing composed tree
version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1326323002

git-svn-id: svn://svn.chromium.org/blink/trunk@201912 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |nextPositionOf()|
by templatizing original |nextPositionOf()| to work both DOM tree
position and composed tree position version for introducing composed tree
version of |VisibleSelection| class.

This patch also |honorEditingBoundaryAtOrAfter()| and
|skipToEndOfEditingBoundary()| used by |nextPositionOf()|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1315443011

git-svn-id: svn://svn.chromium.org/blink/trunk@201911 bbb929c8-8fbe-4397-9dbb-9b2b20218538

instance, prototype and interface.

There should be no behavioral change.

BUG=43394,516274

Review URL: https://codereview.chromium.org/1322533002

git-svn-id: svn://svn.chromium.org/blink/trunk@201910 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Subtract border and padding when we're calculating the breadth of the
columns in LayoutGrid::computeUsedBreadthOfSpecifiedLength().

Added test to check the behavior for both columns and rows.

BUG=529203
TEST=fast/css-grid-layout/grid-percent-track-margin-border-padding.html

Review URL: https://codereview.chromium.org/1321723008

git-svn-id: svn://svn.chromium.org/blink/trunk@201909 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We skip those access checks when dealing with Location, as V8Location has its own checks in place according to the Location's cross-origin policy (https://html.spec.whatwg.org/multipage/browsers.html#security-location).

BUG=455160

Review URL: https://codereview.chromium.org/1262353002

git-svn-id: svn://svn.chromium.org/blink/trunk@201908 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews,yosin
BUG=513568
NOTRY=true

Review URL: https://codereview.chromium.org/1303993005

git-svn-id: svn://svn.chromium.org/blink/trunk@201907 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a partial revert of r201891

BUG=

Review URL: https://codereview.chromium.org/1315443010

git-svn-id: svn://svn.chromium.org/blink/trunk@201906 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Suppress timeout on scrollstate-after-http-equiv-refresh-fragment-identifier.html (patchset #1 id:1 of https://codereview.chromium.org/1326193002/ )

Reason for revert:
The timeout was fixed by https://codereview.chromium.org/1304383004

Original issue's description:
> Suppress timeout on scrollstate-after-http-equiv-refresh-fragment-identifier.html
> 
> This patch suppresses a timeout on [1] likely due to [2]. See:
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fnavigation%2Fscrollstate-after-http-equiv-refresh-fragment-identifier.html&testType=layout-tests
> 
> [1] http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
> [2] https://src.chromium.org/viewvc/blink?view=rev&revision=201780
> 
> NOTRY=true
> BUG=528352
> TBR=alexclarke
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201810

TBR=alexclarke@google.com,pdr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=528352

Review URL: https://codereview.chromium.org/1324403002

git-svn-id: svn://svn.chromium.org/blink/trunk@201905 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |isFirstPositionAfterTable()|
by templatizing original |isFirstPositionAfterTable()| to work both DOM tree
position and composed tree position version for introducing composed tree
version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1309963003

git-svn-id: svn://svn.chromium.org/blink/trunk@201904 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://codereview.chromium.org/393823003 added the loop for the purposes
of repeatedly polling the cross-thread-usable free page pool.
As we now take the first page & don't add that to the pool,
the loop looks redundant.

BUG=

Review URL: https://codereview.chromium.org/1319163003

git-svn-id: svn://svn.chromium.org/blink/trunk@201903 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We'll need to access DisplayItemList::newDisplayItems() to update
cacheable flag of BeginSubsequence display items for
https://codereview.chromium.org/1327563003/.

Update layout tests and make some cleanups.

Review URL: https://codereview.chromium.org/1323243011

git-svn-id: svn://svn.chromium.org/blink/trunk@201902 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Fix function names.
- Use const references as possible.
- Use range-based |for|.

This CL has no behavior changes.

BUG=528840

Review URL: https://codereview.chromium.org/1305063008

git-svn-id: svn://svn.chromium.org/blink/trunk@201901 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These methods are unused, and confusing. Let's remove them.

BUG=494880
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/1321683009

git-svn-id: svn://svn.chromium.org/blink/trunk@201900 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, remove FormDataList::setData and setBlob.  This simplifies the code.
This CL has no behavior changes.

BUG=528840

Review URL: https://codereview.chromium.org/1320463010

git-svn-id: svn://svn.chromium.org/blink/trunk@201898 bbb929c8-8fbe-4397-9dbb-9b2b20218538

testharnessreport: Hide elements in tests by removing them from the document tree, instead of visibility:hidden.

This fixes the flakiness of web-platform-tests/webrtc/datachannel-
emptystring.html.

[1] made the test flaky because:
 - It added a chance to invoke onSendChannelOpen()
 - It prints some lines into <div id=msg>.
 - Text dump of visibility:hidden doesn't remove EOLs represented by
   <br>s.

This CL resolves this issue by removing elements completely by
body.textContent = ''.  Setting display:none instead of visibility:hidden
also works, but body.textContent = '' is much simpler.

[1] https://src.chromium.org/viewvc/blink?revision=201628&view=revision
BUG=528120

Review URL: https://codereview.chromium.org/1332523002

git-svn-id: svn://svn.chromium.org/blink/trunk@201897 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of
|firstEditableVisiblePositionAfterPositionInRoot()| for introducing composed
tree version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1311543006

git-svn-id: svn://svn.chromium.org/blink/trunk@201896 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per the spec
https://html.spec.whatwg.org/multipage/forms.html#input-type-attr-summary
input types date, time, month, week, datetime-local, file, image, reset etc
should ignore placeholder attribute and in-turn should not affect placeholder-shown state.
Adding testcases for the same.

BUG=451120

Review URL: https://codereview.chromium.org/1332543002

git-svn-id: svn://svn.chromium.org/blink/trunk@201895 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebSearchableFormData.cpp created FormDataList instances.  However DOMFormData,
which is a subclass of FormDataList, is also acceptable, and we can remove
FormDataList factory.

This CL has no behavior changes.

BUG=528840

Review URL: https://codereview.chromium.org/1323023005

git-svn-id: svn://svn.chromium.org/blink/trunk@201894 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test flakes consistently on the bots:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Fsources%2Fdebugger-breakpoints%2Fdebugger-reload-breakpoints-with-source-maps.html

TBR=yurys@chromium.org
BUG=529123

Review URL: https://codereview.chromium.org/1308663006

git-svn-id: svn://svn.chromium.org/blink/trunk@201893 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently we run into an infinite loop when we hit the limit of the number
of mmapped regions OS can support. It is better to have a RELEASE_ASSERT
about it.

BUG=

Review URL: https://codereview.chromium.org/1320493006

git-svn-id: svn://svn.chromium.org/blink/trunk@201892 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All the memory stats should be displayed in memory-infra.
However, some memory stats are too heavy to profile in production builds.
We can use the DETAILED_MEMORY_INFRA flag for them.

BTW, GC_PROFILING flag will be removed soon. All the information in the GC profiler
has been migrated to memory-infra.

BUG=

Review URL: https://codereview.chromium.org/1302183010

git-svn-id: svn://svn.chromium.org/blink/trunk@201891 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're now hitting a bunch of out-of-virtual-address-spaces in various benchmarks
(e.g., tiny-innerHTML-setter.html, PseudoClassSelectors.html etc) on oilpan Linux builds.

The reason is that a GC is never scheduled during the benchmark because the current
GC heuristic is improper. In short, we're hitting a scenario like this:

- allocatedObjectSize = 3 GB
- markedObjectSizeAtLastCompleteSweep = 5 MB
- partitionAlloc = 1 GB

This doesn't hit the GC condition because (3 GB + 5 MB + 1 GB) / (5 MB + 1 GB)
is not large enough.

(Note: Accurately speaking, the esimated size becomes smaller than (5 MB + 1 GB)
as the number of collected persistent handles increases, but in those benchmarks
persistent handles are not collected so aggressively.)

This is clearly insane and we should have a way to trigger a GC
if the allocatedObjectSize is X% larger than the markedObjectSizeAtLastCompleteSweep.

With that motivation, this CL changes the GC condition as follows:

- Trigger a GC if a growing rate of PartitionAlloc _or_ Oilpan's heap is larger than X%.

BUG=474470

Review URL: https://codereview.chromium.org/1325783007

git-svn-id: svn://svn.chromium.org/blink/trunk@201890 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522791

Review URL: https://codereview.chromium.org/1305903007

git-svn-id: svn://svn.chromium.org/blink/trunk@201889 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Almost all validations in texImage2DBase() and texSubImage2DBase() have been done in 
their callers. These validations are executed twice. It is not necessary. For example, 
validateTexFuncParameters() is not very cheap. it is called in texImage2DBase(). This 
function is also called by validateTexFunc(). But all variants of texImage2D() calls 
both validateTexFunc() and texImage2DBase(). 

No WebGL 1.0 conformance test regression with this change.

BUG=528180

Review URL: https://codereview.chromium.org/1310003006

git-svn-id: svn://svn.chromium.org/blink/trunk@201886 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch enables additive keyframes in Web Animations element.animate().
"composite: 'add'" keyframe properties and neutral keyframes are now
enabled in experimental only.

This patch removes tests that assert we throw errors when additive
or neutral keyframes are used in element.animate().
The following existing tests ensure that stable behaviour has not changed:
virtual/stable/web-animations-api/additive-animations-unsupported.html
virtual/stable/web-animations-api/partial-keyframes-unsupported.html


BUG=437696

Review URL: https://codereview.chromium.org/1326443003

git-svn-id: svn://svn.chromium.org/blink/trunk@201885 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Support for CSSOM CSSNamespaceRule interface
Spec:http://drafts.csswg.org/cssom/#the-cssnamespacerule-interface
Changes include
1) Exposing CSSNamespaceRule interface
2) Reflecting namespace rules in stylesheet rule list

BUG=389549

Review URL: https://codereview.chromium.org/1321943002

git-svn-id: svn://svn.chromium.org/blink/trunk@201884 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch marks the SPV2 version of [1] as timing out.

[1] non-self-painting-layer-overrides-visibility.html

BUG=529100
TBR=wangxianzhu

Review URL: https://codereview.chromium.org/1314983005

git-svn-id: svn://svn.chromium.org/blink/trunk@201883 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |characterAfter()|
by templatizing original |characterAfter()| to work both DOM tree
position and composed tree position version for introducing composed tree
version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1328113005

git-svn-id: svn://svn.chromium.org/blink/trunk@201882 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds a layout test to ensure that the 'color' property works as
expected when used with `all:unset` or `all:inherit`.

BUG=420781

Review URL: https://codereview.chromium.org/1330573003

git-svn-id: svn://svn.chromium.org/blink/trunk@201881 bbb929c8-8fbe-4397-9dbb-9b2b20218538