- 22 Oct, 2018 40 commits
-
-
yoshiki iguchi authored
This CL updates the logic of handling click events and passes all the events to Chrome side at first. The chrome side may defer or cancel the user action and pass back the action to Android side. This CL also contains the mojo changes which is related with the lock screen notification and not directy related with defering. ARC-side: ag/4764629 Chromium-side: crrev.com/c/1174143 Bug: b/79951342 Test: Manual Change-Id: I42f9953029867d8e46124ba087a4f84a49fae99d Reviewed-on: https://chromium-review.googlesource.com/c/1174143 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#601526}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b20529ac11a6..23153d4a809c git log b20529ac11a6..23153d4a809c --date=short --no-merges --format='%ad %ae %s' 2018-10-22 perezju@chromium.org [pinpoint_cli] Fix get-csv for windows platforms Created with: gclient setdep -r src/third_party/catapult@23153d4a809c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3a0aabff11d0730d81723a7394ff83d6722d8ae5 Reviewed-on: https://chromium-review.googlesource.com/c/1293244Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601525}
-
Mythri Alle authored
Add support that lets embedder specify if code caching is enabled and if enabled the disk size that can be used by the cache. By default code caching is disabled. This cl also adds implementation for chrome that enables code caching. Bug: chromium:867552 Change-Id: I6edb4c0c4f3830d44731225ec91c5e95005be9da Reviewed-on: https://chromium-review.googlesource.com/c/1213093 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#601524}
-
Hans Wennborg authored
After compiler-rt r344751, CMAKE_CXX_FLAGS doesn't get passed to all objects. TBR=thakis Bug: 897627 Change-Id: Iea0eda192c6da8d6d662732e7ad456e0ba3c0b46 Reviewed-on: https://chromium-review.googlesource.com/c/1292883Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#601523}
-
Benoit Lize authored
A ParkableString underlying String may be atomic. In this case, as long as it it alive, there is a raw pointer reference to it in a per-thread table. This can lead to a use-after-poison as the string gets poisoned whereas it is still in the table. This is due to not freeing string_ in ParkableStringImpl. To fix that, don't poison AtomicStrings (which are not the majority of ParkableString). This is a false positive as when real parking happens the underlying string would be freed, hence removed from the AtomicStringTable. Bug: 883344,877044 Change-Id: I685260eafe31da4cafed150b74870a08aa61ed40 Reviewed-on: https://chromium-review.googlesource.com/c/1228057Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#601522}
-
Yuta Kitamura authored
This CL melds WebThreadBase's implementation into Thread, and removes WebThreadBase. Now WebThreadImpl* classes directly inherit from Thread. This is part of WebThread refactoring effort. The new implementation uses WTF::HashMap instead of std::map to store the mapping of TaskObservers. TaskObserverAdapters are stored in std::unique_ptr, so we don't need manual new/delete calls. Eventually, we will migrate to base::MessageLoop::TaskObserver instead of Blink's custom TaskObserver, which would eliminate this mapping object. Thread::IsCurrentThread() is now implemented in terms of its thread- local storage for Blink threads, just because we already have that knowledge ourselves. Also, {Add,Remove}Task{,Time}Observer() are simplified. Now the internal versions of those functions are removed, and TaskObserver functions are now non-virtual. Bug: 826203 Change-Id: I5aa56c152543af8f0e0270db86aa0f51d619b4d5 Reviewed-on: https://chromium-review.googlesource.com/c/1283015 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 894796 Change-Id: I368723376887cf830655cc20879c520a8ca9fdc8 Reviewed-on: https://chromium-review.googlesource.com/c/1292884Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601520}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ia80de6b1a257e88fb0cc4805a97e32bf8a9c096f Reviewed-on: https://chromium-review.googlesource.com/c/1293329 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#601519}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/20a8c2a7ccc6..ff08d94ee125 Created with: gclient setdep -r src-internal@ff08d94ee125 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ide3b2c8cd6b9f7e28bc94c3c5a2b46e7f443500c Reviewed-on: https://chromium-review.googlesource.com/c/1293241Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601518}
-
Yves Gerey authored
We were relying on brittle transitive #include. Bug: webrtc:8311 Change-Id: I1749d9159c4fbff6658f19fefa84f46b0acabf5c Reviewed-on: https://chromium-review.googlesource.com/c/1290935 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601517}
-
Mario Sanchez Prada authored
This will remove a dependency from OAuth2TokenService::Consumer, that will pave the way for further migrations to the IdentityManager. Bug: 809440 Change-Id: I81d77da696078cdc48eee63c466a815fd68062c5 Reviewed-on: https://chromium-review.googlesource.com/c/1288535Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#601516}
-
Nikita Podguzov authored
This is a reland of 43116fdd Original change's description: > Disable editing managed network config fields. > > * Disable network configuration field if the field is enforced by policy. > * Add policy network indicator if the field is controlled by policy. > > Bug: 877424 > Change-Id: Icfdb6d7fb3deb09696b6d2edce27d3c9851043a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1251447 > Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600735} Bug: 877424 Change-Id: I48473017b8656504de789f2cad9d0fabd89fcec7 Reviewed-on: https://chromium-review.googlesource.com/c/1290914Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#601515}
-
Florian Uunk authored
We have this check in ModelAssociationManager::Stop, so it makes sense to add it to ModelAssociationManager::StopDatatype too. Bug: 894852 Change-Id: If5f472ea74cba7bbe60f796b1255c8e54d65a069 Reviewed-on: https://chromium-review.googlesource.com/c/1290149 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#601514}
-
Peter E Conn authored
Bug: 888945 Change-Id: I2c2c803bbd51014cc70933fde8cef45e14ddb28b Reviewed-on: https://chromium-review.googlesource.com/c/1290915 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601513}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b026043a43f9..b20529ac11a6 git log b026043a43f9..b20529ac11a6 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 perezju@chromium.org [soundwave] Fix encoding when building RequestError message 2018-10-22 perezju@chromium.org [pinpoint_cli] Fix bug when iterating over output isolates Created with: gclient setdep -r src/third_party/catapult@b20529ac11a6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:897178,chromium:897052 TBR=sullivan@chromium.org Change-Id: I5ca0605b6d78dc87a31ef59c2d0257bf9bffe390 Reviewed-on: https://chromium-review.googlesource.com/c/1293242Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I63e4fd34b8bde448da84a6b2f578dc00a69cf33a Reviewed-on: https://chromium-review.googlesource.com/c/1293067Reviewed-by:
-
Kent Tamura authored
Focus navigation: Fix a null pointer dereference on disconnecting children including a focused shadow element crrev.com/599575 fixed a case where a single host including a focused shadow element is disconnected, but it didn't cover a case where multiple children including a focused shadow element is disconnected. Document::NodeChildrenWillBeRemoved() should handle sequential focus navigation starting point like Document::NodeWillBeRemoved(). Bug: 897403 Change-Id: I15c491ef9b789f1447be752f0ed41f4c7a8702a9 Reviewed-on: https://chromium-review.googlesource.com/c/1292664Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#601510}
-
Ramin Halavati authored
Traffic annotation auditor binaries for Linux and Windows are updates after the change crrev.com/c/1287097. Bug: 878760 Change-Id: I92e7f632cc9343fee93e16f0d6b48f099189d6da TBR: nicolaso@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1292877 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#601509}
-
Anders Hartvoll Ruud authored
This is prerequisite for a subsequent CL. R=futhark@chromium.org Bug: 641877 Change-Id: Ifc8c1df0f80f9c18205b103e13ae90b5e2c63b2e Reviewed-on: https://chromium-review.googlesource.com/c/1290980Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#601508}
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. Also, remove |using namespace XMLNames|. https://google.github.io/styleguide/cppguide.html#Namespaces > Do not use using-directives (e.g. using namespace foo). Also, remove unnecessary namespacePrefix definition of xml_attribute_names.json5. Bug: 889726 Change-Id: I5d3de504ad425af4a8ec096f84bc0be6c432aea4 Reviewed-on: https://chromium-review.googlesource.com/c/1293253Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#601507}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d206a4b9..b248a7f6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib05b0d61ade904fbbd6a4c3eb7ca1cb880f0b21f Reviewed-on: https://chromium-review.googlesource.com/c/1293188Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601506}
-
Michael Lippautz authored
Use GC without scanning stack for testing purposes when necessary. A different strategy for the current architecture would be making tests truly async and scheduling GC from the event loop. Bug: 843903 Change-Id: Ib479d4a090bc04cbc4fe28522f0b9e084f34181d Reviewed-on: https://chromium-review.googlesource.com/c/1292878Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I150167dadb44bac77af2145f9a87ffa9d0e769c2 Reviewed-on: https://chromium-review.googlesource.com/c/1293291Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium dfc636b6. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26523 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I02e62904f21d388797ba42a874e08859c43205a6 Reviewed-on: https://chromium-review.googlesource.com/c/1293186 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#601503}
-
Amos Lim authored
Generated header files need to follow chromium style on header guards. This CL has no behavior changes. Bug: 896720 Change-Id: I5ed457086e369fd515f5969daebfc8e1ef623112 Reviewed-on: https://chromium-review.googlesource.com/c/1293059Reviewed-by:
-
Hirokazu Honda authored
Reland "media/gpu/VEA unittest: Fill plane pointer and stride with NULL and 0 for 1- or 2- planes VideoFrame" When I enable VEA unittest to run any yuv format in crrev.com/c/1135106, I didn't realize the code assumed the I420 when creating frame. Therefore, it passes invalid pointer and wrong stride when the number of planes are less than 3. This change fixes it by creating video frame, taking into account the number of planes of input buffer format. BUG=chromium:894381 TEST=VEA unittest for NV12 and I420 on kevin Change-Id: Ie917d5240c05cb32c59f21367252682dc14b573e Reviewed-on: https://chromium-review.googlesource.com/c/1293066Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#601501}
-
Fergal Daly authored
This reverts commit 9e324215. Reason for revert: Breaks Jumbo build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-jumbo-rel/8154 Original change's description: > Rename RootScrollerUtil namepsace to root_scroller_util > > https://google.github.io/styleguide/cppguide.html#Namespace_Names > > Namespace names are all lower-case. > > This CL has no behavior changes. > > Bug: 889726 > Change-Id: I72347625710f8856e5e742fb4faf5e4ec1291d3e > Reviewed-on: https://chromium-review.googlesource.com/c/1293063 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> > Cr-Commit-Position: refs/heads/master@{#601493} TBR=tkent@chromium.org,zhuoyu.qian@samsung.com Change-Id: Ifae2126f4e28f2546b6887a41726dd3b00089b8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889726 Reviewed-on: https://chromium-review.googlesource.com/c/1293103Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#601500}
-
Marc Treib authored
...by *2 histograms. The old histograms had very weird semantics for when samples were taken. The basic idea was to record only when the state *changed*, which means that for users that just keep using Sync without changing settings, we'd never record anything at all. There were also additional oddities around recording, see bug. Taken together, this makes the old histograms very hard to interpret. The new histograms are recorded when Sync configures the data types, which usually means during Sync startup. These will actually let us answer questions like "how many users have selected custom data types". Bug: 895488 Change-Id: Ie67ddebd562c7007b576dcfc962a3bc058bb9452 Reviewed-on: https://chromium-review.googlesource.com/c/1286812Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#601499}
-
Jochen Eisinger authored
Also unlock any left-over parent profiles now that (legacy) supervised user profiles don't exist anymore. R=msarda@chromium.org Change-Id: I19231e38e9b086c77cb250d14366d6acfa481509 Reviewed-on: https://chromium-review.googlesource.com/c/1292872Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601498}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/06413e47c96e..20a8c2a7ccc6 Created with: gclient setdep -r src-internal@20a8c2a7ccc6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie04bf3d2d1d5dc6b53f335a7296f74bbc53462c7 Reviewed-on: https://chromium-review.googlesource.com/c/1293238Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ib4d4b483a224bb02217237d85220c3375238955a Reviewed-on: https://chromium-review.googlesource.com/c/1293295 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ie8abf5434c3501a4b94b99af00cc909a0afac1a2 Reviewed-on: https://chromium-review.googlesource.com/c/1292668Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: If8167502426867a143dc15200809b21b08dfb520 Reviewed-on: https://chromium-review.googlesource.com/c/1293293Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I72347625710f8856e5e742fb4faf5e4ec1291d3e Reviewed-on: https://chromium-review.googlesource.com/c/1293063Reviewed-by:
-
Heng-Ruey Hsu authored
Since blob stream needs higher resolution, it causes higher cpu loading to require higher resolution and resize to smaller resolution. In hangout app, we don't need blob stream. Enabling blob stream when needed can save a lot of cpu usage. BUG=b:114676133 TEST=manually test in apprtc and CCA. make sure picture taking still works in CCA. Change-Id: I9144461bc76627903d0b3b359ce9cf962ff3628c Reviewed-on: https://chromium-review.googlesource.com/c/1261242 Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#601492}
-
Fergal Daly authored
Revert "media/gpu/VEA unittest: Fill plane pointer and stride with NULL and 0 for 1- or 2- planes VideoFrame" This reverts commit 04f8f2c0. Reason for revert: breaks windowd compile Original change's description: > media/gpu/VEA unittest: Fill plane pointer and stride with NULL and 0 for 1- or 2- planes VideoFrame > > When I enable VEA unittest to run any yuv format in crrev.com/c/1135106, I didn't > realize the code assumed the I420 when creating frame. Therefore, it passes > invalid pointer and wrong stride when the number of planes are less than 3. > This change fixes it by creating video frame, taking into account the number of > planes of input buffer format. > > BUG=chromium:894381 > TEST=VEA unittest for NV12 and I420 on kevin > > Change-Id: I31e157ce9317139e7cc42a38ba77b34c13d70d70 > Reviewed-on: https://chromium-review.googlesource.com/c/1293095 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601489} TBR=hiroh@chromium.org,acourbot@chromium.org Change-Id: I02e53782dd3240da1dfd4548daefe275854601b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:894381 Reviewed-on: https://chromium-review.googlesource.com/c/1293099Reviewed-by:
-
Kent Tamura authored
This CL makes it blink::foo_names::kNamespaceURI. The new behavior is applied only to lower-cased blink::foo_names. Bug: 889726 Change-Id: Ib1b0e55a7e135941b87055f0fd4e75956568c59a Reviewed-on: https://chromium-review.googlesource.com/c/1293061 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
media/gpu/VEA unittest: Fill plane pointer and stride with NULL and 0 for 1- or 2- planes VideoFrame When I enable VEA unittest to run any yuv format in crrev.com/c/1135106, I didn't realize the code assumed the I420 when creating frame. Therefore, it passes invalid pointer and wrong stride when the number of planes are less than 3. This change fixes it by creating video frame, taking into account the number of planes of input buffer format. BUG=chromium:894381 TEST=VEA unittest for NV12 and I420 on kevin Change-Id: I31e157ce9317139e7cc42a38ba77b34c13d70d70 Reviewed-on: https://chromium-review.googlesource.com/c/1293095 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Dong-hee Na authored
SerializeForNumberType() should be used instead of AtomicString::Number() in Element::SetFloatingPointAttribute(). Bug: 894661 Change-Id: I6d4efd2d14fb7e01e0fb47cc703fd2d7d12cde18 Reviewed-on: https://chromium-review.googlesource.com/c/1288929 Commit-Queue: Dong-hee Na <donghee.na92@gmail.com> Reviewed-by:
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I3857cdbdd245658470a8919255b9d757288131b1 Reviewed-on: https://chromium-review.googlesource.com/c/1293093Reviewed-by:
-
