- 26 Nov, 2019 40 commits
-
-
Maggie Cai authored
This CL hides the page action icons by default when typing starts in the omnibox. Most icons already have the logic to hide the icon however this need to be done for every icon. This change ensures all the new icons have this behaviour by default unless overridden by developer intentionally. BUG=1004031 Change-Id: I6ddc6d80813d635c52fbfcb4eb4acbb599c2ccfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933852Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#719006}
-
Austin Tankiang authored
Also reverse the arrow's direction: use \25c0 (left arrow). While here, move the related ltr/rtl CSS rules together. Bug: 980503 Change-Id: I08e487a8699dd6f465f106511b4b40f789fc2951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935571 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719005}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4b53273c1292..f65b212492ec git log 4b53273c1292..f65b212492ec --date=short --first-parent --format='%ad %ae %s' 2019-11-25 felipearchondo@google.com [fuchsia] Change all Angle Presents to Present2s Created with: gclient setdep -r src/third_party/angle@f65b212492ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I94a5c0d1f183421d4f714351ed2fac98f0a9752b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935809Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719004}
-
Alex Danilo authored
When a button on the action bar has focus, clicking on any menu button fails to grab focus from any existing focus item, leaving the previously focused button as selected. Checks for currently focused element. If a button has focus, let the browser perform the default action which will set the menu button as the focused element. If the focus is on any other element, leave it alone (e.g. in the case where a row in the file list has focus, we don't want to change that due to the menu activation). Bug: 906566 Tests: browser_test --gtest_filter="*MultiMenu" Change-Id: I32ab6b5e52771298c13fae51c2b13fba9cf996b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935567 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
After this patch, WebBundleReader will be able to recover from data_decoder service disconnection. To prevent parser restart loop, in-flight parse requests when the parser is disconnected will not retried (they will just fail). Reconnection will be attempted at the first ReadResponse() call after disconnection. Bug: 969596 Change-Id: I8e34c52aa7f19662a33b796bba7412a64245cc28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903166 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#719002}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/32d6c8d02436..3e7af41224ee git log 32d6c8d02436..3e7af41224ee --date=short --first-parent --format='%ad %ae %s' 2019-11-26 reed@google.com Revert "switch to new filltype for SkPath" 2019-11-26 fmalita@chromium.org [skottie-wasm] Disable image pre-decoding 2019-11-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-25 reed@google.com switch to new filltype for SkPath Created with: gclient setdep -r src/third_party/skia@3e7af41224ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I81833b131a779786cb9566eba08932884309e198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935812Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<HTMLFieldSetElement>(element) in place of IsHTMLFieldSetElement(element) Bug: 891908 Change-Id: I7aa818e1cf1b75fe1c96c8a8e9fc781a32879a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930766Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#719000}
-
Timothy Loh authored
The ListUsbDevices function was added almost a year ago when adding USB support to Crostini but we haven't end up using it. Change-Id: Iee869b4757b8e6e5095f3671ade8cc5b15d4365c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930353Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#718999}
-
Abhijeet Kandalkar authored
This CL has goal to use DynamicTo<HTMLHRElement> as new downcast helper Bug: 891908 Change-Id: Icb20e0163d092e08e0bf71ecd75bfcfb140c6e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930539Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#718998}
-
Austin Tankiang authored
With the legacy drive sync client, drive paths had to be treated separately from native paths in certain situations. However, since now with DriveFS all drive paths are native, this separation can be removed. Bug: 1003238 Change-Id: I3fbbfaf5456b292c24c3f3b3c1ea8ef253101285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930274 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#718997}
-
Abhijeet Kandalkar authored
This CL has goal to Use IsA<HTMLMenuElement>(element) in place of IsHTMLMenuElement(element) Bug: 891908 Change-Id: Ia9c016f9c23481a60db63ee00ead1361090de3a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930541 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bee6bf4cd336..dde2188cbe9d git log bee6bf4cd336..dde2188cbe9d --date=short --first-parent --format='%ad %ae %s' 2019-11-26 chonggu@google.com [Fuchsia] Add SshForwarder for Fuchsia. 2019-11-26 erikchen@chromium.org Fix catapult sharder to produce more uniform sharding. 2019-11-25 eroman@chromium.org Update the contributing/deploying instructions for Net Log Viewer. Created with: gclient setdep -r src/third_party/catapult@dde2188cbe9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1028298 Tbr: skyostil@google.com Change-Id: I21bc5006cd80f798f9433341a8ea342b3399170e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935506Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<HTMLProgressElement>(element) in place of IsHTMLProgressElement(element) Bug: 891908 Change-Id: Ic141eeff5bddfe0bc897f969e3be3884b0dcd137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930543 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLLinkElement> and DynamicTo<HTMLLinkElement> as new downcast helper 2. Use IsA<HTMLLinkElement>(element) in place of IsHTMLLinkElement(element) Bug: 891908 Change-Id: I9c81898b569475eb05021f18a03e565a95d7b0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930768Reviewed-by:
-
Peter Kotwicz authored
This CL also makes StatusBarColorController#isDefaultThemeColor() return true when there is no tab BUG=1015627 Change-Id: I52af010b2befb7efb11d52c5b755371b542bb0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934784 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#718992}
-
Yuly Novikov authored
OpenGL passthrough as Failure. In addition to other video tests suppressed on it. Exclude from RetryOnFailure suppressions for crbug.com/979444 TBR=bsheedy Bug: 1026468, 979444 Change-Id: I43e0bbc6e219d5f64de75b48231a7dc915530e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935927Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#718991}
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<HTMLFrameElement>(element) in place of IsHTMLFrameElement(element) Bug: 891908 Change-Id: I97f4bd55fa1145bf70dbe776afb419e2fbd96822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930538Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#718990}
-
Navid Zolghadr authored
Change-Id: I97f014c264329c94dba9c576105f135c4faed8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935868 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Auto-Submit: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#718989}
-
Kenichi Ishibashi authored
{From,To}InternalValue() are deprecated so replace them with suggested {From,In}Microseconds(). This may not be the same as deprecated ones but these would be fine as we use them to store script response time. Bug: 634507 Change-Id: Ie4a4b1bbbd65692888b3a3a0abe8606feddae9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933836 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:Yuri Wiitala <miu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#718988}
-
Anand K. Mistry authored
Bug: 1027041 Change-Id: Ibb15074dcedc65e3275123b7bb7241c3f323a6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935308Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c3eb6750..5d28dbab Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If4470dda765c55d9bac3f3761ae255df6124534f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935448Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718986}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/13ea34f30537..72e6cb0b3f54 git log 13ea34f30537..72e6cb0b3f54 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 sprang@webrtc.org Fixes dynamic mode pacing issues. Created with: gclient setdep -r src/third_party/webrtc@72e6cb0b3f54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idf1ec77d6eee794cad7c23d90296109c1d40f16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935503Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/069565ced288..80271e61d1fa Created with: gclient setdep -r src-internal@80271e61d1fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:894616,chromium:None,chromium:b/144121590 Tbr: jbudorick@google.com Change-Id: I8d29e856ff7b3f32c9bbd55c910aad393888634b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935810Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718984}
-
Alexey Baskakov authored
It enables all PendingAppManager-based external web apps in kDesktopPWAsWithoutExtensions mode: 1) System Web Apps 2) Default-Installed Web Apps 3) Policy-installed Web Apps This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. Bug: 916381 Change-Id: I81343b43ea06e34d5b4f22e4565e819e7835010a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935574Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#718983}
-
meacer authored
This CL finalizes the interstitial implementation by handling the CERT_KNOWN_INTERCEPTION_BLOCKED error in SSL handler and recording a UMA entry for it. Bug: 1014711 Change-Id: Ic37cf2bd5c12e7df07a2cb23beb06037e3921136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906780Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#718982}
-
Minggang Wang authored
The NavigationImmediateResponse feature is enabled by default through a flag kNavigationImmediateResponseBody and a CL (https://chromium-review.googlesource.com/c/chromium/src/+/1911148) has been landed to remove the flag. However, it seems that there is still one we left over. This CL remove it. Bug: 1017705 Change-Id: Ifa7f1309e2dff55c2fbe1abff69b9ca5bb657119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925779 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts network::mojom::URLLoaderPtr to new Mojo types using PendingRemote and Remote. It also update |url_loader| of FetchEventPreloadHandle in dispatch_fetch_event_params.mojom and |url_loader| of TransferrableURLLoader in transferrable_url_loader.mojom with pending_remote. Bug: 955171 Change-Id: Ib457d18eb4b2dfe9f4a11f059b1674669c18e565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921594 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#718980}
-
Mohamed Heikal authored
android_resources targets are zipped into one directory with the contents of a res/ dir. However android_resources targets can take multiple res/ dirs as inputs. Files of the same name in multiple input dirs conflict and the last to be listed ellides the others. This cl changes that by including all input res/ directories as separate res/ directories inside the zip. Resource clobbering can then follow android aapt2 rules instead. Bug: 935982 Change-Id: I453622093ebe5fabb91cc147a5bc9030f98c7889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934649 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#718979}
-
Emircan Uysaler authored
This reverts commit c76ce4ab. Reason for revert: Look for an alternate way for blink features. Original change's description: > [Fuchsia] Allow enabling blink features > > This CL would allow us to enable work that are behind feature flags. > > Bug: 1026011 > Change-Id: Ifaa69e184811ffe0062cc10389b31e54fc8a76db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931657 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718541} TBR=sergeyu@chromium.org,emircan@chromium.org Change-Id: I90da52000325b1045836222e59b26c0c2d6e42b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935415Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718978}
-
Trent Apted authored
This reverts commit 3e9d66eb. Reason for revert: Widespread bot failures for Step "isolate tests" error like: isolate: isolate /b/s/w/ir/cache/builder/src/out/Release/devtools_type_check.isolate: partitioning deps: lstat /b/s/w/ir/cache/builder/src/third_party/blink/renderer/core/inspector/browser_protocol.pdl: no such file or directory Bug: 1028446 Original change's description: > Move browser_protocol.pdl to third_party/blink/public/devtools_protocol > > Bug: 1018108 > > This still retains a copy of protocol.json for compatibility with > devtools front_end. > Also, remove a presubmit for front-end compilation upon a change to PDL > since the front-end is in another repository now. > > Change-Id: I2faea62feca80776d2fc0a0b4ea00a90439ae005 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898538 > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718903} TBR=dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org,jochen@chromium.org Change-Id: I39435e4be7dde62ffd48d1f72a0ecbbac9165ae1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935479Reviewed-by:
-
Kenichi Ishibashi authored
This isn't used, might be replaced with one in ServiceWorkerVersion. Bug: N/A Change-Id: I672ea9fd15f3d3ce0db772b070ae81791075db01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935767 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718976}
-
Eric Seckler authored
This is a reland of 4da16526. Relanding after the bad event nesting in v8's GC events was fixed. Also increases the default trace buffer size, because the traces with split events are slightly larger and cause some benchmarks to lose data otherwise. Furthermore, includes a fix for a bug that caused us to emit COMPLETE events as atrace events twice. Original change's description: > perfetto: Split COMPLETE events into BEGIN/END pairs > > There are a few reasons why this is desirable: > (1) Reduces need for complete event stack in ThreadLocalEventSinks, > which was brittle before (e.g. crbug.com/983307). > (2) Makes it possible to flush event sinks while tracing in the future > without losing not-yet-completed COMPLETE events from the stack > (streamed tracing use case). Events that didn't end before the > flush will still be present in the trace as BEGIN only. > (3) Prevents reordering of nested COMPLETE events - something which > could confuse TraceProcessor in the past (events with identical > begin timestamps would be imported incorrectly). > > To achieve this, this patch also plumbs the EXPLICIT_TIMESTAMP flag > and thread id through to TraceLog::UpdateTraceEventDurationExplicit, > because it seems that android can add COMPLETE events with explicit > timestamps / threads [1]. > > [1] https://cs.chromium.org/chromium/src/base/android/early_trace_event_binding.cc?q=INTERNAL_TRACE_EVENT_ADD_WITH_ID_TID_AND_TIMESTAMPS&ss=chromium&l=31 > > Bug: 983307, 928738, 1006770 > Change-Id: I66e685c04c068646d550f182185d3c45febcbfa8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899852 > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716871} Bug: 983307, 928738, 1006770 Change-Id: I478ab4ade4bf5182d41cedb2f0b5fd22ba2e1604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931750 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#718975}
-
Peter Kasting authored
Intended change: Light mode: kGoogleRed700 -> kGoogleRed600 Dark mode: kGoogleRed700 -> kGoogleRed300 Bug: 1028245 Change-Id: Ida204c593a21f018fb39adc9091653012c1b259d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933943 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#718974}
-
Stuart Langley authored
- Change how arrays that are composed of other arrays are defined. - Fix some closure markup at while I'm here. Bug: 894342 Change-Id: I10355a93c6a5fae24a8626cd69a392158bdeba0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935667 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
-
Melissa Zhang authored
Code stub for reference. Change-Id: Ida9126ed845fcb4548ad7bd4b411054d14af3f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904565 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#718972}
-
Toni Barzic authored
Adds back fling from overview to home screen when kDragFromShelfToHomeOrOverview is enabled. With the feature disabled, drag/fling from bottom in overview transitions to home, and is handled by HomeLauncherGestureHandler. When the feature is enabled, the gesture is not propagated to HomeLauncherGestureHandler (as it might have to handle hotseat drag in split view). This adds handling for the fling in overview to shelf_layout_manager, to re-enable the gesture - the handling is moved from HomeLauncherGestureHandler to ShelfLayoutManager to better handle the case where the hotseat starts off in the hidden state (and fling in split view can either bring up the hotseat, or go to home screen, depending on the gesture length) - handling the gesture in HomeLauncherGestureHandler means that the drag event would not be handled as shelf drag event (which brings up the hotseat). The fling is expected to transition to home if: * in overview mode * in split view mode with overview, and fling is on the overview side (otherwise, the gesture should be handled by window_drag_controller_) BUG=1023910 Change-Id: I2385d195aa06f04d264da926091e6fc4b5f8fe26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935107 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718971}
-
Daniele Castagna authored
CreateSharedImage with usage SHARED_IMAGE_USAGE_SCANOUT tries to allocate the underlying buffer with BufferUsage::SCANOUT. BufferUsage::SCANOUT might fail in some circumentances when a buffer can still be allocated, but it's not possible to use it for scanout (e.g: on virtio_gpu AddFramebuffer will fail for buffers smaller than a certain threshold). This changes the logic of CreateSharedImage so that in cases where we fail to allocate a buffer for scanout, we try again to allocate just for GL. Bug: 1024019 Test: crrev.com/c/1918316 in webgl_conformance_tests on chromeos-amd64-generic-rel Change-Id: I20615e0780e47425a4074204f706bc66018e2071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933198 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718970}
-
nancy authored
BUG=1016159 Change-Id: Ide7712b6f6abf19c3ffcd054d69ecf1468cbe605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933673 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
-
Emircan Uysaler authored
This is a mitigation step as we observed DCHECKs hit and flickers with accelerated canvas. Bug: 1019212 Change-Id: I11948318dbd6905f2d9930823719871fd5832aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935412Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718968}
-
Stuart Langley authored
Add a specific message when trying to open a zip file that will exceed the limit of mounted FSPs. Bug: 1014806 Change-Id: I8231465c7f9f1f15f1226d5707f26b55bfdbc8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935309Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#718967}
-
