- 26 Apr, 2019 40 commits
-
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ib1d75e52f326a6e23cd42a5eee812fb02ef7579f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585818Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654439}
-
Dave Tapuska authored
There already was a pass expectation for the non-worker case but it appears we need one for the worker case in order to land the V8 change. BUG=948678 Change-Id: I6c670b52e93e4de4449835b31bc4d336f58140b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585814Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#654438}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2fca490a57e7c7dd2a45372afa05e5600f48e3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585812Reviewed-by:
-
Miyoung Shin authored
This is a followup CL of https://crrev.com/c/1575315. This CL uses bit_cast<float> to convert FloatSize's width/height for Hash similar to WTF::FloatHash and WTF::FloatHashTraits. Bug: 952716 Change-Id: Ibafa38c9f1481472066c5a556297ee2d630e1e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585286Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#654436}
-
Dan Zhang authored
R=rch@chromium.org Change-Id: I345efbb9d5ba4ba21eb50433b6d579307dffbb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568848 Commit-Queue: Dan Zhang <danzh@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#654435}
-
Mike Reed authored
Also, color values in skia are now explicitly floats, not SkScalar. Bug: skia:4872 Bug: skia:9012 Change-Id: Ia4fc7c20048d6d273c59f852741d9f7fd71d8d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582771 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
-
manuk authored
Document responses contain both an 'originalUrl' and a 'url' field. The 'url' field contains some extraneous query params that can hinder deduping. When document suggestions are initially constructed in `DocumentProvider::ParseDocumentSearchResults`, we set `stripped_url`, used for deduping, using the 'originalUrl' response field. When actually deduping suggestions later in `AutocompleteResult::SortAndCull`, we overwrite the `stripped_url` field with a new value computed from 'url'. This CL avoids overwriting `stripped_url` if it's already set during deduping. This is necessary for document suggestion deduping, but also non-harmful for other providers as the computed stripped_destination_url does not change during a match's lifecycle. Bug: 888093 Change-Id: I72ea697a661ffab496d385edead063caba366573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574781 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#654433}
-
Armando Miraglia authored
Some tests in webrtc_image_capture_browsertest.cc are still defined as MAYBE_* but they are currently always enabled. This CL is renaming the tests and dropping the MAYBE_* macros. BUG=793859 Change-Id: I3e45742b17da920138df872ecb8895dcc9ebcaa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583733Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#654432}
-
Armando Miraglia authored
From the review in http://crrev.com/c/1584271 it was suggested that I should be added to the OWNERS file of the WPT tests for mediacapture-streams for communication purposes. This CL adds the armax@chromium.org address as owner. BUG=None Change-Id: Ic2fedd21414ac25e28ffbfbe50c707d045e76433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584308Reviewed-by:
-
Peter Beverloo authored
Change-Id: I6a3f622284c720130a91ee508bffd0d44d08848a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583707 Commit-Queue: Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Auto-Submit: Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#654430}
-
Carlos Caballero authored
This check is adding no value. Enabling BEST_EFFORT queues multiple times in not bad per se. Moreover this does not play nicely with tests as some will run the initialization code in BrowserMainLoop::InitializeMainThread that posts a AfterStartupTask to enable the queues and also call SetBrowserStartupIsCompleteForTesting (to enable AfterStartupTasks). This leads to EnableBestEffortQueues() being called twice and thus a CHECK fail. We are in the process of refactoring all this code and eventually AfterStartupTaskUtils will go away, so it makes little sense to come up with a complicated workaround for this isse. Removing the check for now should be enough and in the future we might consider adding some sort of check back (it probably makes more sense to check that we do not signal BrowserStartupCompleted multiple times) Bug: 863341 Change-Id: I29acaccc281efe764579d968e38a06f9dcbe54dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584502Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#654429}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fab73b886ed6..809c46b7808b Created with: gclient setdep -r src-internal@809c46b7808b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: Ifc8f5e6e944e01829d5d69f09db1d038552621f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585810Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654428}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5ee4ec84de3c..6e345f4e28d3 git log 5ee4ec84de3c..6e345f4e28d3 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 nuskos@google.com Prevent the IPC layer from being included in builds it can't compile on. 2019-04-26 treehugger-gerrit@google.com Merge "trace_processor: Deal correctly with zero-duration scoped slices" 2019-04-25 gijosh@google.com Merge "Hardcode estimated size of local_t for X86 Android builds" 2019-04-25 treehugger-gerrit@google.com Merge "Allow chromium to build the IPC layer." 2019-04-25 hjd@google.com Merge "perfetto-ui: Fix thread state" 2019-04-25 hjd@google.com Merge "perfetto-ui: Fix crash in logs controller" 2019-04-25 bhamrick@google.com Merge "Add parser for Fuchsia traces" Created with: gclient setdep -r src/third_party/perfetto@6e345f4e28d3 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I6f9b901e36296a064a67038a1b6fcf98f5f878bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585809Reviewed-by:
-
Richard Knoll authored
We delete |service_proxy_| on the UI thread in Shutdown but access it from the |task_runner_| which leads to an ASAN error. Instead of that just set a flag and invalidate weak pointers to |service_proxy_|. This ties the lifetime of |service_proxy_| to its owner so we can skip null checks for it. Bug: 905352 Change-Id: I4aa105dac710496c2e988549fa4b5b4778f6d5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570027Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#654426}
-
Aditya Keerthi authored
The InvalidateFontCacheOnPurge experiment shows that font cache invalidation negatively impacts tab switch times. Furthermore, clearing the cache was shown to have no significant effect on memory. Consequently, we should not invalidate the font cache when a memory purge is triggered in a renderer. Bug: 926186, 939543 Change-Id: I315352f2f463f1ae1c8bca3bf649afbd556c2c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584882Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL fixes the test flaky on chromeos-rel by introducing additional waiting. Bug: 956043 Change-Id: Ia722f2634bbf17e037bfde02f5ec53a2500f2fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584505 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#654424}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/84650dc1..c6fbb279 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8ddf3f03da0f819225f428032789c46ee1d362a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585808Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654423}
-
Anders Hartvoll Ruud authored
This reverts commit 65046b8f. Reason for revert: broke Android CFI. Original change's description: > Update Linux Seccomp syscall restrictions to EPERM posix_spawn/vfork > > Glibc's system() function switched to using posix_spawn, which uses > CLONE_VFORK. Pepperflash includes a sandbox debugging check which > relies on us EPERM-ing process creation like this, rather than crashing > the process with SIGSYS. > > So whitelist clone() calls, like posix_spawn, that include the flags > CLONE_VFORK and CLONE_VM. > > Bug: 949312 > Change-Id: I3f4b90114b2fc1d9929e3c0a85bbe8f10def3c20 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568086 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653590} TBR=jorgelo@chromium.org,thestig@chromium.org,tsepez@chromium.org,rsesek@chromium.org,mpdenton@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 949312 Change-Id: I4628a3883a4aa5ac9f14c815380c2e52b0469715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584305Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#654422}
-
Jan Krcal authored
This CL fixes a few integration tests using custom passphrases by introducing additional waiting. Bug: 956012, 956043 Change-Id: Ie28e9f99c71db30c1df5067991c8b6867f36a9e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585880Reviewed-by:
-
Jan Krcal authored
This CL fixes the test UnifiedConsentBrowserTest.SettingsOptInTakeOverServicePrefChanges that has been recently disabled. Bug: 954167, 956043 Change-Id: Ibcbd5119afb1e91dce22d377b10a1414eac8420a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584273Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#654420}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f82158fb7fdc..152ac9be2f84 git log f82158fb7fdc..152ac9be2f84 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 halcanary@google.com Fix MoltemVk Bots Created with: gclient setdep -r src/third_party/skia@152ac9be2f84 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: Ia9e0f27cb14d0022f28246062e2ddec727c5ad34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585807Reviewed-by:
-
Anders Hartvoll Ruud authored
BUG=956990 TBR=dmazzoni@chromium.org Change-Id: I0b01b937951938b1116d22e250b8cc505f57754c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583898Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be4f95d279c6..fab73b886ed6 Created with: gclient setdep -r src-internal@fab73b886ed6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: I7c1452d942832b053a4e80f413db7207fc61ce94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585806Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8e97b4c8a512..15d4c2e63b72 git log 8e97b4c8a512..15d4c2e63b72 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 jiawei.shao@intel.com Emulate store and multisample resolve on Metal Created with: gclient setdep -r src/third_party/dawn@15d4c2e63b72 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@chromium.org Change-Id: Ibaf6e11999d8a9920d75d94d395dd82ef40dd8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585805Reviewed-by:
-
Askar Aitzhan authored
Show DeviceQuickFixBuildTokenPolicy value in chrome://policy page Bug: 932465 Change-Id: I4c24452647d201dce2ba7317b11ce7f845d1d0e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556784Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Cr-Commit-Position: refs/heads/master@{#654415}
-
Anders Hartvoll Ruud authored
BUG=956870 TBR=bsep@chromium.org Change-Id: Id91a5ae261327ca375883a71517e35a920398caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584287Reviewed-by:
-
Jan Krcal authored
This CL changes behavior of the wallet_metadata sync bridge to ignore remote deletions. This is safe as every deletion should be eventually processed locally and for corner cases there is anyway already a GC routine. This is motivated by observed ping-pongs of deletions-creations between clients running Directory code and clients running USS code, leading to considerably increased number of address conversions on USS. This CL breaks these ping-pongs and should get the conversion counts on comparable levels. Bug: 953693 Change-Id: I1a30f51d4727a08f84ef33091089d2a7a366b4df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583896 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#654413}
-
Javier Ernesto Flores Robles authored
Bug: 951300 Change-Id: I3804f763398b9ad3780183db2745b726ce54f3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584262Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#654412}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e2998717f12..517f7f858d97 git log 2e2998717f12..517f7f858d97 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 perezju@chromium.org [Telemetry] Disable flaky testTraceCaptureUponFailure on win Created with: gclient setdep -r src/third_party/catapult@517f7f858d97 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:956812 TBR=eyaich@chromium.org Change-Id: I9355ad7ad59873e0cb2fff7d4ffa794d3d10bf69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585803Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b70d658fc0e6..be4f95d279c6 Created with: gclient setdep -r src-internal@be4f95d279c6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: I4ead1a004263965a23f6bfda7813da49bb95e394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585802Reviewed-by:
-
Mohamed Amir Yosef authored
In earlier version, we relaxed the error handling in the PasswordSyncBridge to mitigate some other issues, however this could have introduced in consistency in the passwords metadata. Recently, many run failures are observed, so we are introducing this check to rule out other reasons of failure. Bug: 956011 Change-Id: I86f77c8c821daf5897223c9c98b347c3c8a45134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583897Reviewed-by:
-
Raphael Kubo da Costa authored
Adapt to the parts of https://github.com/w3c/wake-lock/pull/160, "Require user activation", that fix https://github.com/w3c/wake-lock/issues/159, "SecurityError vs NotAllowedError". Bug: 257511 Change-Id: Iab4720096ba86b1a414ad640d0f74a7c5127e976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584303 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Kuo Jen Wei authored
This CL include following UI changes: 1. Set height of mode icons to 32px. 2. Set height of clickable area of mode icons to 48px. 3. No margin space between clickable area of mode icons. 4. Set total height of mode selector to 140px so that it can fit two and half of mode icons after icon height adjustment. 5. Fix click on label introduce extra focus ring bug. Bug: 956867, 956858 Change-Id: Ic7b23f39029c7c80666e6125df9b4fe2f6583462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584490 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#654407}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/637bed5f8d90..42fa30fdac9a git log 637bed5f8d90..42fa30fdac9a --date=short --no-merges --format='%ad %ae %s' 2019-04-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ad14b36f..19227549 (654160:654383) Created with: gclient setdep -r src/third_party/webrtc@42fa30fdac9a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ica1cde0749f4ea59dd0af1f9c29edec7647394fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585801Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3e4d6b25..84650dc1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ica7a2e45b0b86bcb95c062d2bd35034b7057bc64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585716Reviewed-by:
-
Anders Hartvoll Ruud authored
BUG=947673 TBR=jamwalla@chromium.org Change-Id: I0c2d8f3114f30afa388ed9e1eeb764bda78b5d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584286Reviewed-by:
-
Naoki Fukino authored
To make the virtual files openable by browser, we need to handle DocProvider files via external file URL in the similar way as we handle (legacy)Drive, FileSystemProvider, and media-view files. Bug: 956974 Test: Manually tested on an ARC-enabled device with Box DocProvider. Change-Id: I5d3e14e70475bb4e16d403d55c43c2c222052149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584530Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#654403}
-
Dominik Röttsches authored
On Windows 10 systems we can use DWrite API to lookup fonts uniquely directly, without scanning the system fonts and building the lookup table index. The Blink side change and Mojo IPC extension for doing these single lookups is already implemented. But when the FontSrcLocalMatching feature is active, Windows 10 machines were still nevertheless building the lookup index. This CL disables that. Bug: 951978 Change-Id: Ibf9fceac407b61febffa79406374481833c81437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572125 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#654402}
-
Alex Ilin authored
Shared memory implementation on POSIX uses fallocate() to reserve the disk space so that subsequent writes to a memory-mapped file don't result in a SIGBUS crash. fallocate() may fail if the filesystem does not support this operation. Chrome should handle this case gracefully, falling back to some less-optimal implementation. POSIX already provides posix_fallocate() that serves exactly this purpose. Unfortunately, posix_fallocate() isn't available on all POSIX systems supported by Chrome. Chrome already had a manual fallback for fallocate() in memory_mapped_file_posix.cc. This CL extracts this code into AllocateFileRegion() helper function that can be used both from memory_mapped_file_posix.cc and platform_shared_memory_region_posix.cc Bug: 953029 Change-Id: Idd0532b7be2c33e00fb3cdda63267a74be3c4807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582499Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#654401}
-
Stephen McGruer authored
This allows us to plumb the source and dest rect through to the raster code, which means that PW content is now properly positioned and clipped when the size changes (e.g. resizing the checkerboard in https://googlechromelabs.github.io/houdini-samples/paint-worklet/checkerboard/). Bug: 890764 Change-Id: Ie62c73008e94ba1c3b717bc50bfd3829b96c0b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566902Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#654400}
-
