- 25 Jun, 2019 40 commits
-
-
Dominic Battre authored
Bug: 975939 Change-Id: I7a92d33e966cb315508c7ee795aea1ea676829ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675351Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#672192}
-
Greg Thompson authored
All signs indicate that it is exceptionally rare for initialization to fail. BUG=975750 R=pmonette@chromium.org,jwd@chromium.org Change-Id: I5cee019454c882c9702d69d3c4877d7cda97d5a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670889 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#672191}
-
Eugene But authored
CHROME_EG_ASSERT_NO_ERROR is unnecessary anymore, because helpers can assert with correct file name and line number. Bug: 963613 Change-Id: Ied9d4595c04f81a70e93cd32da24449a74618b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672707 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#672190}
-
Nate Fischer authored
The gitiles navbar doesn't correctly render the "home" link. It's unclear why this started happening recently, but this CL fixes the issue by explicitly specifying the path instead of using the "[home]" alias (which is already used to make the logo clickable). Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I4e3db63f43f2cbe5809c44d247fd293faecbdad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674846 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#672189}
-
Fabrice de Gans-Riberi authored
The call was renamed in Fuchsia, the transitional *_new variant is going to be removed soon. Bug: 977753 Change-Id: I4d189066cb7ceff1ed4bfc18a9a434a3c2e6ec34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677010 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#672188}
-
Avi Drissman authored
-[NSView inputContext] will create an input context if one does not exist. -[NSTextInputContext initWithClient:] takes a weak reference to the view. Pre-Catalina, that weak reference was just a raw pointer; in Catalina, that weak reference is an actual __weak reference, accessed with objc_storeWeak() et al. Pre-Catalina, a call to -[NSView inputContext] in a dealloc impl that ends up trying to create an input context just ends up taking the raw pointer reference; not the best idea, but not the end of the world. With Catalina, doing so involves trying to create a weak reference to a dying object, which makes the ObjC runtime incredibly unhappy. This is a sanity check that is breaking the code; remove it. BUG=977918 TEST=as in bug Change-Id: Ic3d242117c3c5ada0852e4a77296a507b0fccfdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676424Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#672187}
-
Lucas Furukawa Gadani authored
Bug: 908139 Tbr: boliu@chromium.org, lazyboy@chromium.org, scottmg@chromium.org, johannes@chromium.org, seantopping@chromium.org Change-Id: I56fafc55cdb6e77f479c6d657be8dd20162cd2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667790 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#672186}
-
Eric Stevenson authored
Currently provides access to a subset of the items in the dex format including method items, proto items, type items, type lists, and strings. Bug: 976358 Change-Id: I002645358a83ec01eb5bcf848c5bfa50b5f03af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660123 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#672185}
-
Caleb Raitto authored
This doesn't include the libcurl implementation -- just headers and samples to build an alternative implementation of the libcurl API. The full libcurl repo with its implementation and repo history would be nice to have, but not strictly necessary. Since this code isn't intended to be shipped with Chrome, but rather as headers for an alternative API for the components/cronet library, it makes sense to avoid having Chromium developers sync the full library. Bug: 973603 Change-Id: I3879241ab7b2aa0177cd09cc2e8ef73739fd5feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664790Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#672184}
-
Shakti Sahu authored
This reverts commit 3bf50ad5. Reason for revert: <INSERT REASONING HERE> Original change's description: > Download Home V2 : Cleanup externally removed downloads > > Bug: 976402 > Change-Id: Icef1bce64612e489c575d4ede2d892d76383b529 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669990 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671875} TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org Change-Id: Iaefa934e69969e7a09fe9b145d6663c5e12bd2ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676877Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#672183}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d628747dfb54..69881fb0b5fb git log d628747dfb54..69881fb0b5fb --date=short --no-merges --format='%ad %ae %s' 2019-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms d7303797becf..4f682a1d0b94 (1 commits) Created with: gclient setdep -r src/third_party/skia@69881fb0b5fb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@google.com Change-Id: Ibb7e692f0a48484f92cc52ca3bcbb9c6712fa6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676354Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672182}
-
yilkal authored
This reverts commit 573e2eab. Bug: 977019 Original change's description: > Suppress Stylus Welcome bubble in KioskNext in Chromeos > > Bug: 969227 > Change-Id: Ide1703ae4e37a22535c6d1f4034f7d55d716e635 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638963 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665655} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 969227 Change-Id: Ide208a7ad01f15005c59e481fda81f4486eebc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673923Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#672181}
-
Sergey Ulanov authored
Previously runner scripts implemented system logs collection in two enabled by default, but could be turned off with --exclude-system-logs. (2) was disabled by default, but can be turned on with --system-log-file. (2) is enabled on the bots now. This CL removes (1) in order to remove noice from runner script output and to simplify code. When necessary --system-log-file=- flag can be used to get the previous behavior. places: (1) in RunPackage, and (2) in Target implementations. (1) was Change-Id: I787ff4d8ac54f5c0cd13d0e9d8a71aad05cdd45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674668 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#672180}
-
Eugene But authored
No one from ios/web OWNERS is familiar with this code. Code was originally forked from //content and evolved during last few years. rohitrao@ was a reviewer for all new changes and is generally familiar with thread directory. Bug: None Change-Id: I2ec069d1746466d76e016554f86e51e7aee037f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670057 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#672179}
-
wutao authored
Certain punctuation isn't verbalized by ChromeVox, i.e. period, comma, semicolon, hyphen or brackets. So, whenever one of these is used in a keyboard shortcut, it just will speak "Ctrl plus [silence]" so you don't actually hear what the correct command is. This patch adds special labels mapping to those chars. Bug: 974799 Test: manual Change-Id: I548c9e0a179245c42e40ae63b1b457a0c9cba3cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674634 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#672178}
-
Mugdha Lakhani authored
Add getTags to the PeriodicSyncManager idl file and add a web test to verify it works as expected. Also update test expectations. Bug: 925297 Change-Id: I7902474ad236803a40ac630100ecccebb0652a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669306 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#672177}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/70ec83098831..52ceb42ee515 Created with: gclient setdep -r src-internal@52ceb42ee515 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=reillyg@google.com,yhirano@google.com,futhark@google.com Change-Id: I1e13028690769ca705693787a35d4b419053ad32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676352Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672176}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0d7d36e8..6abe28c3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3f60f56c09af967f9a80e0dafd79ccf2aa6a181a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676504Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672175}
-
Eric Stevenson authored
The builder used for this option has been changed and does not archive all artifacts needed. Now that the android-binary-size trybot exists, downloading builds locally generally isn't necessary. Change-Id: Ibf24646dce4db1ae926885937dbe11fb7728a9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676676 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#672174}
-
Min Qin authored
splt->split Change-Id: I53cdeb3145c666f19272f842208b2e1b548e8a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676486Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#672173}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dcd49b01615f..db8b1cb70185 git log dcd49b01615f..db8b1cb70185 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 ilkos@google.com add ion memory metric Created with: gclient setdep -r src/third_party/perfetto@db8b1cb70185 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/135925438 TBR=perfetto-bugs@google.com Change-Id: Ibc1eeda810fd71d0f2474e66af3a3af8cc3b4683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672172}
-
Sean Gilhuly authored
Enable the blending and masks tests that are passing on Vulkan, and add TODOs for the rest. Bug: 963446 Change-Id: I384d97772be9ae9c96b7695e94423ecfaf848737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673440Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#672171}
-
Will Harris authored
BUG=977723 Change-Id: If2a239a2e5029eaf8449279a1c8abcd0e808a789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674603 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#672170}
-
Robert Ogden authored
This utility class is the basic shape of the end result, documented in the bug. There's several members and arguments which aren't used yet, but will be in future CLs. This CL adds a simple URLLoader and status checker. The prober's behavior will become richer in future CLs. Bug: 977603 Change-Id: Iba9c15c27d83012e357a793c5ecabd3fe4e94e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671487 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#672169}
-
Robert Kroeger authored
Add RetryOnFailure to the ScreenshotSync_GPURasterWithDivs and ScreenshotSync_SWRasterWithCanvas tests. BUG: 978492 Change-Id: Ia378e3b7113ad2ec4ca8d2e4247c6fc6fc1a1dd4 TBR: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676446Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Auto-Submit: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#672168}
-
Devlin Cronin authored
Enable the action.setIcon function (define the extension function, add histogram values, and add custom bindings), and add a parameterized end-to-end test for setting the icon from both a local path and canvas image data. Bug: 893373 Change-Id: I249d6e980469fe3af2c541db92bba09b2d87ce03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658421Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#672167}
-
Sunny Sachanandani authored
crrev.com/c/1646540 changed the default SDR white level to 200 nits from previous value of 80 nits when forcing an HDR color profile via chrome://flags. This doesn't seem to work well on some displays, and leads to washed out colors. Bug: 974894 Change-Id: I900cbe8e85aaf72a2b15119379022f3ec878e5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674616 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#672166}
-
Matthew Jones authored
Bug: 976803 Change-Id: Ia076e9e97ce5d7bdadb8634cfa587e1e5996d757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674492 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#672165}
-
Ryan Hansberry authored
Different AccountId objects were being built with either raw or canonicalized emails (canonicalized emails remove characters not used for identification, such as periods). Without this change, two separate AccountId objects with a raw and canonicalized email won't be recognized as equal and won't have the same hash, even though they have effectively the same email and in fact should. This change fixes callers of the constructor which were passing raw emails; notably, account_info's AccountIdFromAccountInfo() is tweaked to canonicalize the email. If the platform is Chrome OS, user_manager::known_user::GetAccount() is used instead for the extra checks it provides. Bug: 953027 Change-Id: I8491698fdd005e79c564efcc0256c0b975f33065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667747Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#672164}
-
danakj authored
They do async initialization after that anyway, this does redundant resource loading. The method will be going away shortly. R=boliu@chromium.org Bug: 961849 Change-Id: Iea16a3873bf060abd2a13333f3508fa2a0df0593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675342Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#672163}
-
John Lee authored
The mixin got removed during MD refresh and adding it back seems to make it looks worse than it currently does Bug: 973674 Change-Id: I561c41b5d3a204823db1578902a11e0a6f0cd42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674453Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#672162}
-
Fabrice de Gans-Riberi authored
* Remove deprecated SDK build targets. * Fix the manifest merging logic to prevent metadata duplication. * The script can now build an SDK containing both x64 and arm64 archs. * Pretty-print the resulting manifest. * Remove unused code. Change-Id: I2b4b2527427c9c668b1b7405e547fcc7ac466f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674331 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#672161}
-
Wei-Yin Chen (陳威尹) authored
Interpolators in BakedBezierInterpolator are marked deprecated, and replacements are added to the comments. Bug: 971534 Change-Id: I607b9070f77015aee939c481b11385b6acdbc371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647336 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#672160}
-
Clark DuVall authored
This also fixes URLLoaderInterceptor to work with this change. Bug: 976990 Change-Id: Icd72956170dee911e51e43063951d44cc7634617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671067 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#672159}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/74e98f6cb07d..4c0a23611b39 git log 74e98f6cb07d..4c0a23611b39 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 geofflang@chromium.org Update ValidateSamplerParameterBase to use const parameters. Created with: gclient setdep -r src/third_party/angle@4c0a23611b39 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: Ic635867d11382c399b55c8f4b5af7d1e0211433a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672158}
-
Tibor Goldschwendt authored
Bug: 978509 Change-Id: I67b21a9d8e2276bfbf15bcd220be6cb82c949c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676668 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#672157}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5767fb8cbd2a..04cffe3289f7 git log 5767fb8cbd2a..04cffe3289f7 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 mbonadei@webrtc.org Switch example peerconnection server to ABSL_FLAG. 2019-06-25 nisse@webrtc.org Reland "Raise IllegalStateException for calls to retain() or release() on zero ref count" 2019-06-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6c5bbd86..42482d4f (671957:672061) Created with: gclient setdep -r src/third_party/webrtc@04cffe3289f7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2b3257cd1e930c98eef35c48cb47f2517c729e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676351Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672156}
-
Yue Zhang authored
Bug: 978236 Change-Id: If2bd37ed4182597e7ee0175f367604b9ec2bca42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674669Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@google.com> Cr-Commit-Position: refs/heads/master@{#672155}
-
danakj authored
The android startup tasks were run synchronously when a |ui_task| was present (ie in browser tests) because android browser tests were expecting synchronous initialization, however java initialization is asynchronous anyways. So we have a RunLoop in BrowserTestBase pumping tasks and waiting for java initialization to complete, which is done as a (possibly asynchronous) side effect of the |ui_task| running. Thus we can stop branching here for tests and just post the startup tasks in browser tests as we would do normally in production. And the RunLoop in BrowserTestBase::SetUp() will run them all, eventually running the |ui_task|. R=avi@chromium.org Bug: 961849 Change-Id: Ic4724895e7b3762c401f2e781907816e2048e1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671069 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#672154}
-
Mohamed Heikal authored
Previously some JNI calls that used to pass Profile.java objects to native, were switched to use ProfileKey. However, since there was no implementation of ProfileKey.java, the JNI calls passed nothing from Java's side and native called ProfileKey's equivalent of ProfileManager::GetLastUsedProfile. Now that ProfileKey.java exists, JNI calls should pass in ProfileKey.java objects to native instead. Change-Id: I90f83e4c837a6d12613354c9bca5a8d52bf01d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657752 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#672153}
-