- 16 Oct, 2018 40 commits
-
-
Tarun Bansal authored
In Network Quality Estimator (NQE), remove the logic to compute increase in RTT since this is not being used anymore. Change-Id: Icf1785cf5a11152c529ac40da7da43110dce382e Bug: 895878 Reviewed-on: https://chromium-review.googlesource.com/c/1279946 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#600117}
-
Wez authored
In https://chromium-review.googlesource.com/c/chromium/src/+/754130 we switched to populating the is-repeat flag of ui::KeyEvent solely based on the flags in the underlying native event, if present. In the case of a key event triggering a pop-up window to appear, this caused the first auto-repeat of that event to be dispatched without the repeat flag set. To address this we restore the "fallback" path to manually determine whether an event should be flagged as a repeat, in the case of where a native event does not itself have the repeat flag set. Bug: 895266 Change-Id: Ia224e38768d67bf0dc74d60d7e5ed7b6b6663d80 Reviewed-on: https://chromium-review.googlesource.com/c/1281874Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#600116}
-
Andres Calderon Jaramillo authored
This CL changes JpegImageDecoder so that it doesn't advertise that it can support smaller decode sizes if the original size cannot fit a whole number of MCUs in both dimensions. This is done to prevent artifacts from showing up when downscaling certain images. dark line at the bottom. Test: opened the JPEG attached to the bug and verified that there is no Bug: 890745 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I884edcefc4bbd0612e621109c24aedc09cad3452 Reviewed-on: https://chromium-review.googlesource.com/c/1274845Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#600115}
-
Collin Baker authored
This is to reflect a change in the design doc. Bug: 887991 Change-Id: I8dbc058549ffd6bc9fbaf9d0d20d0d8d6ce30158 Reviewed-on: https://chromium-review.googlesource.com/c/1283938Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#600114}
-
Clark DuVall authored
Bug: 872343 Change-Id: Icb7aef94a64039b45f2284fc9ff9fe2dba33296e Reviewed-on: https://chromium-review.googlesource.com/c/1284062Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#600113}
-
rbpotter authored
Sometimes when the user is not signed in on debug builds, only ~5 destinations show up in the "Print destinations" list. Fix this by firing iron-resize when all destinations are done loading. Bug: None Change-Id: Id406b8aaaeccffd3a6419ea30a3396fc6ca7d157 Reviewed-on: https://chromium-review.googlesource.com/c/1282034Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#600112}
-
Xianzhu Wang authored
Android truncates long logs in __android_log_write. This is useful to avoid too verbose logs and save cpu/memory, but we do need some complete verbose logs for debugging. Now if DCHECK_IS_ON(), split long logs by new lines and call __android_log_write for each line to avoid the truncation. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib19c718a8f1d2fe1f2e155c38e1106174b38ae02 Reviewed-on: https://chromium-review.googlesource.com/c/1281883 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#600111}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ab45d6915434..b407163ef346 git log ab45d6915434..b407163ef346 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 stevenperron@google.com Checks for variable pointers (#1976) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b407163ef346 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id4af123bcdb7f3bba922473ce27837100ebbbf56 Reviewed-on: https://chromium-review.googlesource.com/c/1284013Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600110}
-
Eric Karl authored
This is failing on the N9 FYI bot, see issue 895945. TBR=kbr@chromium.org Bug: 895945 Change-Id: Ib735cbfcc04e334cc9204acf8ccc2792239323c5 Reviewed-on: https://chromium-review.googlesource.com/c/1283952Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600109}
-
Sammie Quon authored
This may happen if all windows other than the app in question are minimized because overview tells app list to slide in/out if all windows are minimized (the dragged app is excluded from overview). Test: manual Bug: 888149 Change-Id: Ib883b138939991195c1dc939a1a5b513384a8cfb Reviewed-on: https://chromium-review.googlesource.com/c/1241562Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#600108}
-
James Wallace-Lee authored
Partial revert of crrev/c/1189044. Bug: 894006 Change-Id: I2c2fea22a417f6ae1b97289a4f261263333d5864 Reviewed-on: https://chromium-review.googlesource.com/c/1284055 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#600107}
-
Koji Ishii authored
CachedLayoutResult is cleared in the early phase of layout if NeedsLayout(). This makes hard to re-use part of cached fragments for inline layout. The clearing seems no longer necessary, as FinishLayout() always SetCachedLayoutResult before it calls CopyFragmentDataToLayoutBox(), which calls ComputeOverflow(). Bug: 35619, 844751 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id728deb5bc5c5b29e73c0835d6ffc5b22ee92121 Reviewed-on: https://chromium-review.googlesource.com/c/1282802Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#600106}
-
Christopher Cameron authored
Bug: 895700 Change-Id: I4d62c1c4550609db7433b3109f920524f8aab77d Reviewed-on: https://chromium-review.googlesource.com/c/1283948 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#600105}
-
Jeremy Roman authored
Bug: 670615 Change-Id: Ia42b62d84082a431e615721cb0065d5d6b43fdd3 Reviewed-on: https://chromium-review.googlesource.com/c/1280856Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600104}
-
Tom Anderson authored
Some GTK themes respond to the "prefer dark mode" preference. Reset all colors when this preference changes to play nicely with these themes. BUG=None R=pkasting Change-Id: I7758bab27e99e7f88df4ffcfb3ff0cf6a18530d5 Reviewed-on: https://chromium-review.googlesource.com/c/1284269 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#600103}
-
Sunny Sachanandani authored
This reverts commit c19106d1. Reason for revert: Causing multiple mac gpu fyi failures crbug.com/895984 Original change's description: > Remove WaitSyncTokenCHROMIUM command > > After migrating InProcessCommandBuffer to use GPU scheduler, most tasks > are scheduled after their sync token dependencies are satisifed (see > crrev.com/c/1157874). > > The one exception was the WaitSyncToken IPC used by ReturnFrontBuffer > for pepper, which specifies a sync token, and waits while handling the > message. > > Change ReturnFrontBuffer to contain the sync token, and use it to > specify the dependency to the scheduler. > > Remove WaitSyncTokenCHROMIUM command, since sync token dependencies are > specified as task metadata in all cases. > > Make other cleanups such as removing unnecessary sync token tests, and > make sure the sync token code paths are not used where unsupported by > using NOTREACHED. > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ieee4f6e2427a59a4e0c4b3c983cb489741241272 > Bug: 778753 > Reviewed-on: https://chromium-review.googlesource.com/c/1168155 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599849} TBR=dcheng@chromium.org,boliu@chromium.org,sunnyps@chromium.org,piman@chromium.org Change-Id: I87347c05dded27955410b08e40f37388a484d5f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 778753, 895984 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1284394Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#600102}
-
Koji Ishii authored
This patch changes PositionFloats to have NGPositionedFloatVector* to return the positioned floats, instead of it to return the vector. NGPositionedFloatVector has inline buffer that returning it involves a bit of memory copy overhead. Pinpoint shows slight improvement. We could see them within errors, but mostly positive, and running twice shows similar trends. https://pinpoint-dot-chromeperf.appspot.com/job/11f3134ce40000 Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I29c23e370b398f54a9acc1745f37ea9ffcb1b2fc Reviewed-on: https://chromium-review.googlesource.com/c/1282689Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#600101}
-
Aga Wronska authored
Change-Id: Ie36b88ba98d7190fab4bc613c7ad8714d7b1c118 Reviewed-on: https://chromium-review.googlesource.com/c/1282223Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#600100}
-
Yue Li authored
Bug: b/117567490 Test: Manual Test Change-Id: Iff6f062791e32810a54b83e35d0801cf03429f24 Reviewed-on: https://chromium-review.googlesource.com/c/1277683Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#600099}
-
Scott Chen authored
This CL actually makes use of the NUX modules in the onboarding welcome page, instead of the placeholder pages. There will be follow-up CLs to style them to mock. Bug: 874151 Change-Id: Iac750fac5ec744e658770937adab69f0b81f8309 Reviewed-on: https://chromium-review.googlesource.com/c/1256010 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#600098}
-
Alexander Timin authored
Add an ability to subscribe to the notifications about ScopedTaskEnviroments being created and destroyed, which should help with content unittests, where we have multiple ScopedTaskEnvironments changing under one SequenceManager. R=gab@chromium.org CC=alexclarke@chromium.org BUG=892139 Change-Id: Ib56fd0f1b465edd3a6dd6693b36ef3d8b9234140 Reviewed-on: https://chromium-review.googlesource.com/c/1251449 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#600097}
-
Eric Karl authored
This CL moves the memory dump internals into SharedImageBacking, which will allow for new backing types to implement their own dump logic. Bug: 891059 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4f239ab76e75d3b51fe3a120e7c34b20376f559c Reviewed-on: https://chromium-review.googlesource.com/c/1279167 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600096}
-
David Black authored
The timer notification fires a deep link to initiate a text query within Assistant to stop the firing timer. The pending query was set before the view was fully initialized so view state was not in sync with model state. When this happened, we would eventually try promote the pending query view to be the committed query view, but the pending query view did not exist. To fix this, we need to sync view state with the model state to ensure that a pending query view always exists when there is a pending query in the interaction model. Bug: b:117771379 Change-Id: I7ad05836c95ffdd8973f11fae67051603dbfa76f Reviewed-on: https://chromium-review.googlesource.com/c/1281169Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#600095}
-
Xiaohui Chen authored
Currently when view tree is updating, we visit each view in this subtree and for each view we rebuild the subtree with that view as root and recurse. This causes very complicated view tree, e.g. ChromeOS launcher to flood the HTTP websocket server and overrun the buffer. Now we avoid rebuilding subtree if we already visited it, and only send view tree update on the root view which covers the whole subtree. Bug: 894107 Test: locally build and run devtools with ChromeOS launcher Change-Id: I53c87813729eb4983ce613628ae2b83e86adcd30 Reviewed-on: https://chromium-review.googlesource.com/c/1279357Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#600094}
-
Fady Samuel authored
If a child surface's activation is throttled then use the system default deadline as the lower bound for the throttling. This ensures that even if a child does not have activation dependencies, it will still be throttled by at least the system default deadline. This CL also adds some debugging methods and comments on FrameDeadline. Bug: 672962, 890767 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If675908fb2657d5d83b5717339a4060e1eb95f77 Reviewed-on: https://chromium-review.googlesource.com/c/1284050Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#600093}
-
Mike Wittman authored
Adds GUARDED_BY/EXCLUSIVE_LOCKS_REQUIRED annotations for the parts of the sampling profiler implementation using locking. Bug: 887645 Change-Id: Ibe96c541a50254af3822d6811fe03250543a98eb Reviewed-on: https://chromium-review.googlesource.com/c/1283483Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600092}
-
Joey Arhar authored
Bug: 871998 Change-Id: I7b1f69418ccae1d8e8edc867f7264d571b3986b3 Reviewed-on: https://chromium-review.googlesource.com/c/1277246 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600091}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ffad1c5fd295..c3f52fd0306b Created with: gclient setdep -r src-internal@c3f52fd0306b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3c7c6c3b0f1e50f247c6d0ddfaba053b4a11e3e3 Reviewed-on: https://chromium-review.googlesource.com/c/1283951Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600090}
-
Sky Malice authored
Bug: 888767 Change-Id: Iaac4393ba4609095b58d00dbcfb1234e20296a0e Reviewed-on: https://chromium-review.googlesource.com/c/1279045 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#600089}
-
Brandon Wylie authored
Bug: 872370 Change-Id: Idda57db7658d52b09224686f3f4925e6f57d7113 Reviewed-on: https://chromium-review.googlesource.com/c/1247402Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#600088}
-
Richard Baranyi authored
Change-Id: I26225f54154ea39225d5b6ee8d0b74024a614448 Reviewed-on: https://chromium-review.googlesource.com/c/1275845Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#600087}
-
Mirko Bonadei authored
Recently a WebRTC CL had to be reverted because it was breaking Blink compilation. Since WebRTC integrates with it, it makes sense to build these tests in order to discover compiler errors before submitting WebRTC CLs. Bug: None Change-Id: I01d88695e641c37c58e4bb000e22844fa0862fe9 Reviewed-on: https://chromium-review.googlesource.com/c/1277991Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#600086}
-
Moe Ahmadi authored
This runs the tests on the CQ as well as the main waterfall Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifea4b88205c34bb8f31a529bd51d272729c0752d Reviewed-on: https://chromium-review.googlesource.com/c/1234357 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#600085}
-
Ian Swett authored
Remove CreateOutgoing*() methods from QuicSession, since those are not called in base class. n/a (no functional change) Merge internal change: 215784817 https://chromium-review.googlesource.com/c/chromium/src/+/1279378 In GFE, switch QUIC server push stream to use unidirectional stream. Protected by FLAGS_quic_reloadable_flag_quic_unidirectional_server_push_stream. Merge internal change: 215613395 https://chromium-review.googlesource.com/c/chromium/src/+/1279377 Remove flag protection introduced in cl/213521442 as client side code doesn't need it. Merge internal change: 21560864 https://chromium-review.googlesource.com/c/chromium/src/+/1279376 Don't save out of order timestamps in QuicReceivedPacketManager. Protected by existing flag FLAGS_quic_reloadable_flag_quic_send_timestamps. Merge internal change: 215294650 https://chromium-review.googlesource.com/c/chromium/src/+/1279375 Replace QuicUrl platform API with GURL-based implementation n/a (not used in production) Merge internal change: 215147358 https://chromium-review.googlesource.com/c/chromium/src/+/1279374 R=rch@chromium.org Change-Id: Ic58d919bf39a8309af83a46c803f87d26948b8a1 Reviewed-on: https://chromium-review.googlesource.com/c/1279379 Commit-Queue: Ian Swett <ianswett@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#600084}
-
Tom Tan authored
This change mostly contains build script change under //chrome/build only. It is targeting MSVC arm64 toolset, but enable clang-cl could be based on this change. Bug: 893460 Change-Id: Ia6f69f067a97fcaeb77021c1019bc594b0859eda Reviewed-on: https://chromium-review.googlesource.com/c/1272076 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#600083}
-
Orin Jaworski authored
This CL introduces another experimental action Pedal to launch an incognito tab in a new browser window. Bug: 893183 Change-Id: I9b0a671f80037ee646a8bfa6401474d9315e430d Reviewed-on: https://chromium-review.googlesource.com/c/1274204 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#600082}
-
Victor Vasiliev authored
Merge internal change: 217080074 R=rch@chromium.org Change-Id: Ifce950a7a7e1d53e6c49317ccb786ba02fe01b94 Reviewed-on: https://chromium-review.googlesource.com/c/1281663Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#600081}
-
Mikel Astiz authored
Sync.USSMigrationEntityCount.<datatype> metrics are introduced to count the number of entities that go through a USS migration procedure. In particular, it's useful to know how many entities were migrated from directory to USS in order to explain differences in metric Sync.ModelTypeEntityChange during rollout, because the USS migrator doesn't really involve fetching updates from the server. NOPRESUBMIT=true Bug: 895899 Change-Id: I5c3b731187fadab30dc499426d0121d6f97769ec Reviewed-on: https://chromium-review.googlesource.com/c/1280583 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#600080}
-
David Benjamin authored
The tests need to test mail.google.com with known and unknown roots, to check that some of the metrics work correctly. This trips the pin list on Chrome builders. Disable the pins to avoid this. Bug: 895801 Change-Id: Iee41b9729157bb71df0ba5619ce83e9bef5255eb Reviewed-on: https://chromium-review.googlesource.com/c/1283933Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#600079}
-
mrefaat authored
Create a work around to force getAllCookies: completion handler to be executed as soon as possible. Workaround description and reasoning on the document: https://docs.google.com/document/d/1aPNO5p44T-LMQT1Mocdll-SG7xq_9DIjb4N0oOTHZUs Bug: 894540, 885218 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I94090ed1b6b6aa1dce3f764bfa46bc1d700ddf4d Reviewed-on: https://chromium-review.googlesource.com/c/1281685 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#600078}
-