- 07 Jan, 2020 25 commits
-
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3987.18-1577704324-benchmark-81.0.4016.0-r1 to 81-3987.18-1578307857-benchmark-81.0.4016.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If8de18d112da424a0f996c894050a879fd17ba67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989147Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728729}
-
Wez authored
Verify that RunUntil*() calls are not returning prematurely, when the required conditions have not actually been met, e.g. due to Run() timeout. Bug: 1032620 Change-Id: Ia2d2b2028c494705bd4e9502f1d9c19257c58f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985605Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#728728}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-3987.18-1577705382-benchmark-81.0.4016.0-r1 to 81-3987.18-1578307131-benchmark-81.0.4016.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7b944506d5c9933c83a45504aad2898e7a8eee77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987811Reviewed-by:
-
Philip Rogers authored
Several typos were landed in https://crrev.com/728635: * hisotgrams -> histograms * AddBackMisplacedHisotgrams -> AddBackMisplacedHistograms * hsitogram_suffixes -> histogram_suffixes There was also a recursive call to "FixMisplacedHisotgrams" that was renamed in a previous patchset to AddBackMisplacedHistograms. This has been updated to "AddBackMisplacedHistograms". The test has been updated with a comment node inside "<histogram-configuration>" to exercise this codepath. This has been manually tested by ensuring https://chromium-review.googlesource.com/c/chromium/src/+/1988857 can successfully run "git cl format". Bug: 1039447 Change-Id: I95097c0d4acd23301a7fad0d9d33521be405aa53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988375Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728726}
-
dalyk authored
If the host resolution process fails, the top level error code should now be only ERR_NAME_NOT_RESOLVED. A more specific error code (e.g. ERR_CONNECTION_REFUSED if a secure mode DoH server was offline) may be found in ResolveErrorInfo. Bug: 1016325 Change-Id: I9f5f857fffd71be6485d05280239cd0b649d7a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974678 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#728725}
-
James Forshaw authored
This CL updates the expiry date for sandbox launch warning histograms. Bug: 1037210 Change-Id: I552ccd2380b2a6c42aef23dead36da12bba88f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985811Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to logic. This disables 2 tests in PushMessagingTest across all OS levels, as we've observed flakiness on several testers. TBR=mvanouwerkerk@chromium.org Bug: 707528 Test: None Change-Id: I5fc8e4bea44f132771b65b5eda3e843adf708137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980267Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728723}
-
Alexandre Courbot authored
Do not specify the full path of Fourcc members when we are accessing them from Fourcc itself. BUG=None TEST=Chromium builds for arm-generic. Change-Id: I9ecd045f3c7835966e3a9b29c739e115a6c70d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986536 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#728722}
-
Sammie Quon authored
Currently ends overview when changing shelf alignment since display area doesn't get updated on shelf alignment changes. The overview is ended when locking because self alignment changes from shelf bottom locked to shelf bottom. Detect this case and do not end overview. Change OnShelfAlignmentChanged to pass old alignment otherwise we would have to store and track the alignment in OverviewSession. Test: added test Bug: 1038705 Change-Id: I0a47967cb5685a9b5f4724340f800faf3337469f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988591 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728721}
-
Yuzu Saijo authored
base::Bind and base::Callback are deprecated in favor of either base::BindOnce/Repeating and base::Once/RepeatingCallback, depending on whether callback is invoked once or multiple times. Bug: 1007732 Change-Id: I6072508b5c2d7d7f0f157da3998c9f8f79183cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933863Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#728720}
-
Olivier Li authored
The feature will soon be flipped to ENABLED_BY_DEFAULT. This will make HistoryServiceBackend's task runner dispatch to the ThreadPool instead of a dedicated base::Thread. The tests need to be prepared to stay functional when that happens. This includes advancing mock time now that the history backend tasks happen within the mocked time environment. This is done as the last mile of the chrome-wide effort to coalesce as much work as possible to the ThreadPool. Bug: 661143 Change-Id: Id3cd0dbf77bc18bd5a407174af3b7d9b743a5db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979153 Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#728719}
-
Etienne Pierre-Doray authored
This reverts commit de5ec163. Reason for revert: Perftest regressions (see bugs). This should confirm this change is the culprit. Original change's description: > [base] Migrate the Mac/iOS MessagePump to DoSomeWork > > Recycling https://chromium-review.googlesource.com/c/chromium/src/+/1470938/13 > This CL also fixes DetachToBrowserTabDragControllerTest.PressEscapeWhileDetached > to make CQ happy. > > Bug: 885371 > Change-Id: I0b54ade1fd3481a9248c89ec2993738b20fce002 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906337 > Reviewed-by: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722094} TBR=gab@chromium.org,rsesek@chromium.org,kylixrd@chromium.org,mark@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 885371, 1032204, 1032188, 1032135 Change-Id: Ide06e03130a1fb420719bb1969e6aa901f8fb716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988985Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#728718}
-
Mitsuru Oshima authored
This allows drag-scrolling at px boundary. Bug: 1038998 Test: manually tested on device Change-Id: I6b5d87191bcc97ab5cf770c55fc48c36401b45fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987753Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#728717}
-
nancy authored
This CL is pure refactor, to move ArcAppWindowInfo out of AppServiceAppWindowArcTracker to a separate file. BUG=1011235 Change-Id: I967c43b8a53d7ba57a78c0ca3ab4c8e47803091e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986567Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6dbd7ff34a49..6ea680581fa6 git log 6dbd7ff34a49..6ea680581fa6 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 benjaminwagner@google.com Remove Win2016 jobs. 2020-01-06 bsalomon@google.com Remove SkIRect::EmptyIRect 2020-01-06 herb@google.com Move the exit code to a common switch 2020-01-06 brianosman@google.com Add a few more SkRuntimeEffect unit tests 2020-01-06 bsalomon@google.com Revert "Revert "Clean up GrSimpleTextureEffect."" Created with: gclient setdep -r src/third_party/skia@6ea680581fa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I5f1d2e11b9168b33c53ea2c1d89bb55c594973e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988694Reviewed-by:
-
Caleb Raitto authored
Example usage: $ autoninja -C out/Default generate_high_entropy_list $ cat out/Default/gen/third_party/blink/renderer/bindings/high_entropy_list.txt Example output: Keyboard.getLayoutMap VisualViewport.offsetLeft VisualViewport.offsetTop VisualViewport.pageLeft VisualViewport.pageTop VisualViewport.width ... Bug: 915620 Change-Id: I88543f614ea3082b0ff187846a338d6a45d63254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974895Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#728714}
-
Martin Kreichgauer authored
Add high-level methods for interacting with Touch ID authenticator credentials to the existing TouchIdCredentialStore class, and replace code in TouchIdAuthenticator and {GetAssertion,MakeCredential}Operation that currently interacts with the macOS keychain API directly. Also make TouchIdAuthenticator and the Operation classes hold a TouchIdCredentialStore member, rather than the AuthenticatorConfig that they previously required to perform operations on the Keychain API directly. The FindCredentialsInKeychain() and FindResidentCredentialsInKeychain() non-member methods in keychain.h are made obsolete by the new TouchIdCredentialStore member methods and deleted. This is mostly a refactoring, with a few minor functional changes: - When looking for credentials from |exclude_list|, MakeCredentialOperation now ignores credential descriptors with a transports() set that explicitly excludes platform authenticators (even if the descriptor's ID matches a known credential). This is equivalent to how allow_list is handled in GetAssertionOperation. - The new CredentialStore methods explicitly signal unexpected macOS Keychain API errors in the return value, whereas with Find{Resident,}CredentialsInKeychain() was indistinguishable from the case where no matching credentials were found. Hence, when encountering an error while querying an exclude list e.g. a MakeCredential operation would have previously been allowed to proceed, but now the authenticator will return a CTAP error to the request handler instead. Change-Id: Ib3a0a881d06fe0e20822281cbb0e3dac66b9399f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984468 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#728713}
-
Daniel Nicoara authored
Reason: Breaks Webview sizing. This reverts commit 35ac419d. Bug: b/147002958 Test: Manually Change-Id: Iee3eebcd2991036a0592ebf5b91ef7b18a11b0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987292Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#728712}
-
Xing Liu authored
This CL renames the feature name to be UseChimeAndroidSdk to be more specific to android, to avoid conflict with other platforms. TBR=dtrainor@chromium.org Bug: NONE Change-Id: I2b99573384b9bfb9986a15e5d12b6fe172622ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978855Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#728711}
-
Lachlan Ford authored
Fixes: 1037975 Change-Id: I11fa5fd35989d468bbd364a549e1ee747aa9b95f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982668Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Lachlan Ford <laford@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728710}
-
Min Qin authored
For download service, it could issue multiple DownloadUrl() calls to the download system that have the same GUID at the same time. This CL fixes the issue by checking the GUIDs that are already pending or are already persisted in the DB, so that the same GUIDs cannot be used to create a new download. BUG=1029746 Change-Id: Ifc17167454b6eee4132fffa08b7d2666571cce35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980758 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
-
Avery Musbach authored
Consistent with UpdateDropTargetBackgroundVisibility, RearrangeDuringDrag shall have a dragged item parameter rather than a dragged window parameter. OverviewWindowDragController has the item which is what RearrangeDuringDrag really needs in the first place, meaning it is unnecessary that OverviewWindowDragController gets the window from the item and then RearrangeDuringDrag gets back the item from the window. Also, when RearrangeDuringDrag calls SetBoundsAndUpdatePositions, for dragging from the top or from the shelf, ignored_items shall be {} instead of the confusing {nullptr}. Bug: None Change-Id: Ia724128f6dcaf0adc71fa69f4501309e3994c398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987827Reviewed-by:Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#728708}
-
Pavel Yatsuk authored
- A few SearchEngineStatusIcon related values are passed through and shouldn't be retained - mVoiceRecognitionHandler made private and checks for null are removed as it is created in ctor. - LocationBarTablet uses cached mVoiceSearchEnabled instead of calling mVoiceRecognitionHandler - mUrlFocusChangeInProgress made private - SearchActivityLocationBarLayout explicitly sets the property to display mic button even when location bar is not focused instead of manipulating visibility through focus change percent R=pnoland@chromium.org BUG=1035210 Change-Id: I38435e0d7b5363e7ae05cb58f257af800a6ca0d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972785 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#728707}
-
Dave Tapuska authored
There is a downcast in resizing the segmented buffer into a single buffer. If it exceeds wtf_size_t it shouldn't be truncated but crash. BUG=1034491 Change-Id: I877b314277fb2b219ff59b11ea043da743948139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988512Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#728706}
-
Carlos IL authored
MixedContentSiteSetting will launch to stable, this CL enables the feature by default and removes it from the fieldtrials_testing_config. Bug: 987294 Change-Id: I7967b5be2cb3abab712693f0d95881b36aa35784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967885 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#728705}
-
- 06 Jan, 2020 15 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a46886a357c..8ccbcf70c079 Created with: gclient setdep -r src-internal@8ccbcf70c079 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1037892,chromium:790886,chromium:972084 Tbr: jbudorick@google.com Change-Id: Iffba2bda383a1bc8f24205c22ceb728b2d32d49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988696Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728704}
-
Christopher Thompson authored
Bug: 1039339, 1037656, 1037558, 1037551, 1037544, 1037263 Change-Id: Ib882922e81418ee02262c496e0dedb5d0fcb4dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988686 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Auto-Submit: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#728703}
-
Istiaque Ahmed authored
It currently uses param_type::StrongAlias(..) to construct the type, which seems wrong as param_type = util::StrongAlias<TagType, UnderlyingType>. Which causes following compile error: In file included from ../../ipc/ipc_message_utils_unittest.cc:5: ../../ipc/ipc_message_utils.h:1075:10: error: missing 'typename' prior to dependent type name 'param_type::StrongAlias' *r = param_type::StrongAlias(value); ^~~~~~~~~~~~~~~~~~~~~~~ Call StrongAlias constructor directly to fix this. Add a regression unit test to fix the regression. Bug: None Change-Id: If172c83abd22498117c47a8721b7d9057c18a1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983570Reviewed-by:Ken Rockot <rockot@google.com> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728702}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I13975f359746cbe1bb4ddd7f8c7b64387fdd1a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987704Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#728701}
-
Benjamin Beaudry authored
We had this bug with UIA that was preventing us of navigating with word or character inside of empty objects devoid of a static text child. e.g. <div> <label for="input1">Some text </label> <input id="input1"> </div> In this case, when reading by word/character using UIA, we would never jump inside the empty input since it doesn't have a text child in the AXTree. The same would happen with any object embedded in text that is devoid of static text child, such as images and text areas. While I investigated this issue, I stumbled upon the concept of "embedded object characters" which is used for IA2 and ATK. I couldn't use it the same way it is used in those other accessibility APIs, but the idea behind this CL is the same. This CL introduces the concept of empty object replacement characters. When an empty object is replaced (only with UIA), the character is treated the exact same way as an ordinary character in a text node would be. The expectations are the same as if there really was an "empty object replacement character" (the character used for empty object, U+FFFC) inside this node. For now, all leaf nodes that aren't text are considered as empty objects expect the document node and ignored nodes. I don't think this will be causing issues, but I can be wrong. If it is, we'll scope down the condition inside of IsEmptyObjectReplacedByCharacter(). Known issue: crbug.com/1028843 Bug: 928948 Change-Id: Ic2e7d37495615dce19258630a39aaa2f5b7c88f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937858 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728700}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4ada619d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I6070533875b12057ede2af9282d0f6f83a749d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988681Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728699}
-
Peter Kasting authored
This isn't actually used except by tests, which can be rewritten to not need it. Bug: none Change-Id: Ia9f5957f161aea8bb57625729a14e1d214660ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982623Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#728698}
-
meacer authored
This CL adds a list of Greek characters that look like Latin characters. A domain consisting only of these characters and not having a .gr ccTLD or other Greek TLDs such as .ελ will be converted to punycode, as is done for other whole-script-confusables such as Cyrillic and Hebrew. Bug: 722167 Change-Id: Id0157503c605a6a73eb49147c26b48d5995d1ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986209 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#728697}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1ca8124e..fcd83e09 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I67867d71115b2a60146664a01a795273aa85ba3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988680Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728696}
-
kjd564 authored
Recent changes to the scheduler have revealed a race condition with this benchmark. This benchmark is triggered when we do a frame and DidUpdateLayers is called. After the benchmark completes, the impl will schedule a NotifyDone task on the main thread and the results will be recorded when that task is run. The change made in the scheduler will prioritize BeginMainFrame at set intervals. What was happening in the regression was a race condition between NotifyDone and the next frame. If a frame was run before NotifyDone, it would trigger DidUpdateLayers and the benchmark would run a second time, adding its results to the previous runs results, effectively doubling them and causing the benchmark results to oscillate between two ranges of timing. This change fixes this by checking a boolean that tells us whether the benchmark has already been run before running it. Bug: 1030954 Change-Id: Iade1bc20c0cc43e643293f23a631c11c3ff9653e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986970Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#728695}
-
Dave Tapuska authored
Reland 547be407. It was previously reverted because CFI bot started to fail. That was fixed here: crrev.com/2708646c Since the class is no longer memcopied between processes we can use virtuals. - Add virtual destructor - Add pure virtual cloning - Remove memset - Remove size attribute BUG=836826 TBR=nasko@chromium.org,bokan@chromium.org,jbroman@chromium.org Change-Id: I091683184ada8d693c11f8cb7aff9dae3eaf93e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988849Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#728694}
-
Tarun Bansal authored
Add a new field trial param to the config. The param was added to Chromium in M-80. Change-Id: I2532c680e24456cda42a10ee2e0cde3df6dc6a92 Bug: 983721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988207 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
jongdeok.kim authored
This CL makes omnibox clear input text while reloading current page by context menu. Bug: 583241 Change-Id: I8e14a781bf03e239913aac7c3d9b85a71e50fa11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984788Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers: - components/metrics/ - components/metrics_services_manager/ as well as the minimal set of dependent client code to keep everything compiling. Fixed: 1007701, 1007702 Change-Id: I42231f52b33478d4e874b0ecd96d1a4ccab5313f Tbr: siggi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977854 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#728691}
-
Sophie Chang authored
Code to even log this from Previews land was removed in M79 Change-Id: I649467f73f909f73cba940f32710196ab2807023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988852Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
