- 26 Feb, 2019 25 commits
-
-
Ahmed Fakhry authored
We used to allow listing a couple of display modes that have the same size as that of the native mode, even though the display configurator will always choose the native mode as the best mode for that size, regardless of the user choice. This lead to user confusion, when they attempt to set the resolution of their external display with a mode with a higher refresh rate (e.g. 75 Hz) while the native mode has the same size but with lower refresh rate (e.g. 60 Hz). The native mode will always be the one selected, not what the user wanted. BUG=931799 TEST=Expanded tests Change-Id: I6c2391a259a26f7d77facafeaf5b336906600ea4 Reviewed-on: https://chromium-review.googlesource.com/c/1487696Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#635344}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/967b98310a63..8bb5b647cd02 Created with: gclient setdep -r src-internal@8bb5b647cd02 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iea9ca06c118f52b9b2d94d3f52dc4a6ab24ddaca Reviewed-on: https://chromium-review.googlesource.com/c/1487138Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635343}
-
Jacques Newman authored
This change exposes a few more UIA properties through GetPropertyValue. - Added function: IsWebContent to ax_platform_node_delegate to allow AXPlatformNodeWin::IsUIAControl to have different implementations between web content and non web content. - Moved AXPlatformNodeWin::ShouldHaveReadonlyStateByDefault to ax_role_properties so it could be used by ViewAXPlatformNodeDelegate Relevant unit tests have been added for each of the new properties. Bug: 844149 Change-Id: I70603a6346dda6a15f5d9917762ed3ab1579682a Reviewed-on: https://chromium-review.googlesource.com/c/1480814 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#635342}
-
Jazz Xu authored
Subtitle never get cleaned up when loading a video. Remove all tracks from previous video before loading new ones. Bug: 909963 Change-Id: I7cf35b2c31db8eab3f99877a51f0401606cbc12a Reviewed-on: https://chromium-review.googlesource.com/c/1478451Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635341}
-
Travis Skare authored
Bug: 930912 Change-Id: I5b3b0ac945359b2e7bab860d4be31d2985cd9453 Reviewed-on: https://chromium-review.googlesource.com/c/1487849 Commit-Queue: Travis Skare <skare@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635340}
-
Luum Habtemariam authored
Relaxed use_cups rules to just require a copy of libCUPS to allow fuzzing. Bug: chromium:831914 Test: ran fuzz test Change-Id: I190eab4f7de3bbb4d096a39cabb4bb7fb9e3de3b Reviewed-on: https://chromium-review.googlesource.com/c/1479899Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#635339}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fc3897b5f585..002ef361cabc git log fc3897b5f585..002ef361cabc --date=short --no-merges --format='%ad %ae %s' 2019-02-25 jbolz@nvidia.com Add validation for SPV_NV_cooperative_matrix (#2404) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@002ef361cabc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ifa2f5ceedc9a854ca8c8eaee08a2230532a1291b Reviewed-on: https://chromium-review.googlesource.com/c/1487139Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635338}
-
Findit authored
This reverts commit 3dc09a0d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 635263 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vM2RjMDlhMGQ1OTQzOWEwODY3ZWJkNTBhYjY3ODQ2OTFlMTI0NTBlYQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/WebKit%20Mac10.13%20%28retina%29/10723 Sample Failed Step: webkit_layout_tests on ATI GPU on Mac Retina on Mac-10.13.6 Sample Flaky Test: http/tests/devtools/application-panel/storage-view-reports-quota-and-clear.js Original change's description: > [DevTools] Application>Clear Site Data: stop service worker when unregistering it > > We should stop the service worker before unregistering it. > > Originally, clicking "Clear site data" will unregister the service worker. In > Application>Service Workers, the service worker's tab title is marked as > "deleted", but its "status" says it's still running. > > Bug: 894783 > Change-Id: Ib1550cfab8274a27495bb795501f54e9a19f6a36 > Reviewed-on: https://chromium-review.googlesource.com/c/1480725 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635263} Change-Id: I8f08b6b9a63cc6ea516d2c0b988423fb5f16c2f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894783 Reviewed-on: https://chromium-review.googlesource.com/c/1488153 Cr-Commit-Position: refs/heads/master@{#635337}
-
Tarun Bansal authored
Fix crash in NotifyRequestCompleted in Network Quality Estimator (NQE). The crash only happens in DCHECK builds. The CL replaces DCHECK by a simple erase statement which is safer. Bug: 849604 Change-Id: I15513599acdf695ec86ea3b2f39c2a88c8f70135 Reviewed-on: https://chromium-review.googlesource.com/c/1487847 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#635336}
-
Natasha Lee authored
The corresponding ANGLE bug has been fixed and merged for this test. ANGLE Bug: angleproject:2126 Bug: 757098 Change-Id: Ib7c894a8dba3d8b9f6af7eac17facf343d664654 Reviewed-on: https://chromium-review.googlesource.com/c/1487111Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Natasha Lee <natlee@microsoft.com> Cr-Commit-Position: refs/heads/master@{#635335}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9dc060116dbd..2722083cbe1f git log 9dc060116dbd..2722083cbe1f --date=short --no-merges --format='%ad %ae %s' 2019-02-25 kjlubick@google.com [pathkit][canvaskit] roll versions 2019-02-25 ethannicholas@google.com fixed SPIR-V constant swizzling 2019-02-25 csmartdalton@google.com Stack-allocate pipelines for GrMeshDrawOp 2019-02-25 herb@google.com Calculate SDFT strike in common code 2019-02-25 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-25 brianosman@google.com Change particle affector to work on N particles 2019-02-25 brianosman@google.com Add "enabled" flag to affectors, fix curve interaction with stable random Created with: gclient setdep -r src/third_party/skia@2722083cbe1f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ibc02de72392a5ceb6e1a92a81876ddcac004608b Reviewed-on: https://chromium-review.googlesource.com/c/1487841Reviewed-by:
-
Yuwei Huang authored
Mac and iOS linker throws out warning when gRPC tries to access misaligned pointer address. This CL defines the PB_NO_PACKED_STRUCTS flag on Mac and iOS to force nanopb to align the structs. This makes the struct size slightly bigger but performance slightly better. Bug: 935654 Change-Id: I1b6be001137f3d34d1dd66856710e6fb9dd2053b Reviewed-on: https://chromium-review.googlesource.com/c/1488034 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#635333}
-
David Bertoni authored
Change-Id: Ifbb3c0ba7717b264384dc17679a86aabf8341988 Reviewed-on: https://chromium-review.googlesource.com/c/1475740Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#635332}
-
Jérôme Lebel authored
Opens the kSyncGoogleDashboardURL url when the user taps on the "Data from Chrome Sync" item. Bug: 914059 Change-Id: Id85156f52412a223924a68be3d0b77f06e9917d5 Reviewed-on: https://chromium-review.googlesource.com/c/1477236 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#635331}
-
Katie D authored
Bug: 905419 Change-Id: I67112e7a50fd45f417ab082589a33ca554fcf721 Reviewed-on: https://chromium-review.googlesource.com/c/1484581 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
-
Oksana Zhuravlova authored
Change-Id: Iad779efca6df4c8b8a2743497b34a7fe84fcc724 Reviewed-on: https://chromium-review.googlesource.com/c/1487592Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#635329}
-
Alan Cutter authored
This CL adds a plus icon to the omnibox that replaces the bookmark star when the active tab's site is considered to be installable by Chrome's PWA standards. This icon is hidden behind the --enable-features=DesktopPWAsOmniboxInstall flag. Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=380835&signed_aid=_10PeH93S54eGlcXu2GM7w==&inline=1 Still to come: - Accessibility tool tip - Showing the plus as soon as installability checks pass - Refactoring the installability check out of AppBannerManager - Showing a pop out icon if the site is already installed Bug: 907351 Change-Id: If21ce11cd02ef1138897b35a68ac0f702879a011 Reviewed-on: https://chromium-review.googlesource.com/c/1460203 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#635328}
-
Chris Palmer authored
Add some color and examples. Bug: None Change-Id: Iacd9a21eeaf212d6b553f076bd27db36b544a3d0 Reviewed-on: https://chromium-review.googlesource.com/c/1483696Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#635327}
-
Kalvin Lee authored
Change Ic56fff645c2fbc078559b4dc37b33f589415ef87 landed before Tricium could raise a complaint about a D-Bus (C) header below its recommended position. This change moves it into place. R=stevenjb@chromium.org Bug: 929772 Change-Id: I1282b290fe74320fa991ba70c2da2ff03baf3e6a Reviewed-on: https://chromium-review.googlesource.com/c/1487833Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#635326}
-
Yuwei Huang authored
This commit fixes extra semicolons in gRPC public headers. This CL also removes suppressions on Wextra-semi around gRPC includes. Bug: 933949 Change-Id: I4946ce244f37397bdff71c37efb63b1efb5038bb Reviewed-on: https://chromium-review.googlesource.com/c/1487931 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
-
Ben Kelly authored
Bug: 933866 Change-Id: I80852f2e446afc1a360f86341d086da8e2cd5e6f Reviewed-on: https://chromium-review.googlesource.com/c/1483692 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#635324}
-
Oystein Eftevaag authored
Previously a repeating timer to request the trace buffer status was started at the same time as tracing was started, rather than waiting for the BeginTracing callback. The http/tests/devtools/tracing/buffer-usage.js web test is relying on the order of the BeginTracing callback happening before any BufferStatus callbacks. This happened to work in the past because the tracing service would multiplex these two along the same message pipes to all of the subprocesses, but this is no longer the case (with Perfetto we get the buffer status from the size of a central buffer, and don't need to query each subprocess). R=caseq@chromium.org Bug: 839084 Change-Id: Ifb110d521d5829c7abf1ec522d0d280029729b7f Reviewed-on: https://chromium-review.googlesource.com/c/1483354 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#635323}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/73f6992d3486..16c7224d7b9b git log 73f6992d3486..16c7224d7b9b --date=short --no-merges --format='%ad %ae %s' 2019-02-25 dgarrett@google.com branch_archive_stages: FactoryArchive includes test image. Created with: gclient setdep -r src/third_party/chromite@16c7224d7b9b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I8cacd7f8f97cf119d3935f49e4ad649c2455dc60 Reviewed-on: https://chromium-review.googlesource.com/c/1487955Reviewed-by:
-
kylechar authored
Post[Delayed]TaskWithTraits() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?TaskWithTraits)\((?:\n\s*)?FROM_HERE,\n?\s*(\{.*?\n?.*?\}),(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=tapted@chromium.org Bug: 714018 Change-Id: I875c9d84c41f43fb1032da0fb906a46f544c41e9 Reviewed-on: https://chromium-review.googlesource.com/c/1486153 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by: -
Noel Gordon authored
Add standard node package.json and add a .gitignore file. Testing will need test images: add images.sh used to fetch the raw images for tests into ./images. To setup the node project and its dependencies, run the 'npm install' command. Bug: 935285 Change-Id: I734482d9a5fd5e16c2c2007d429ceb748899a388 Reviewed-on: https://chromium-review.googlesource.com/c/1485626Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635320}
-
- 25 Feb, 2019 15 commits
-
-
Brad Hall authored
This is needed on the mac bots when xcode isn't in the standard place in order to run otool. Bug: 861357 Change-Id: Idbad0b07afdf1b7b214735b6a7db1371427ef145 Reviewed-on: https://chromium-review.googlesource.com/c/1479293 Commit-Queue: Brad Hall <bradhall@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#635319}
-
Adam Ettenberger authored
1. Implementing ITableProvider::get_RowOrColumnMajor. It looks like Chromium only supports row-major ARIA tables, so returning |RowOrColumnMajor_RowMajor|. 2. IGridProvider was already implemented, but ARIA colcount/rowcount was being ignored; the actual table size was being returned. (a) For UIA, ARIA attributes take precedence over actual size. (b) The value (-1) is significant for ARIA colcount/rowcount, but should result in E_UNEXPECTED for UIA. 3. Adding unit tests for IGridProvider and ITableProvider methods. 4. Fixed an issue where AXTableInfo could calculate the wrong aria-colcount when it was unspecified on the table, but there were cells that specified aria-colindex. 5. Make AXTableInfo |aria_col_count| and |aria_row_count| optional so that callers don't have to worry about the special (-1) case |ax::mojom::kUnknownAriaColumnOrRowCount|, and changed relevant method signatures in the accessibility platform code. Bug: 847971 Change-Id: I7202c59e75351b6de1fb06656c3ad1c9fd08a81e Reviewed-on: https://chromium-review.googlesource.com/c/1476207Reviewed-by: -
Eric Willigers authored
The (unshipped) desktop implementation of Web Share now has access to the method, enctype and files entries in the manifest of each Web Share Target. BUG=903010 Change-Id: Icd0b6daaee71ab9b9412118e1eba3b484438d4a1 Reviewed-on: https://chromium-review.googlesource.com/c/1485693 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#635317}
-
Fergus Dall authored
Currently it's possible to open the crostini uninstaller while the installer is still running. While crrev.com/c/1453956 prevents them from actually running at the same time, this can still lead to confusing UI states. This CL prevents the uninstall crostini option from appearing in the settings page and the terminal context menu while the crostini installer is running. Bug: 919153 Change-Id: I424fb8ba625087782fe08b7e8b978242c7465695 Reviewed-on: https://chromium-review.googlesource.com/c/1472013Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#635316}
-
Lukasz Anforowicz authored
Bug: 932766, 933862, 935095, 935705, 935707 Change-Id: I9f7af9a1fca4d791f3eeab761ed5b0810c33c3b9 Reviewed-on: https://chromium-review.googlesource.com/c/1478101Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#635315}
-
Yiming Zhou authored
The captured sites test uses Web Page Replay Go (WPR Go) to replay captured sites traffic. The captured sites test bots uses a script in the catapult project to download WPR Go binaries. At the moment these bots are failing to download WPR Go, presumably because bots' gn isolate is missing references to the catapult project. This fix attempts to address this problem by following the example of existing perf/telemetry test targets in src/chrome/test/BUILD.gn and adding a dependency to the telemetry_chrome_test_support target. Bug: 916361 Change-Id: Ie999bc5c64edb6aca180ac98ec68864875e831a1 Reviewed-on: https://chromium-review.googlesource.com/c/1487693 Commit-Queue: Yiming Zhou <uwyiming@google.com> Auto-Submit: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#635314}
-
Xiaocheng Hu authored
NoTry: True Tbr: dtrainor@chromium.org Bug: 932092 Change-Id: Ie1484936cd92f1d48c69d02c7efdeb3c47d6f6b3 Reviewed-on: https://chromium-review.googlesource.com/c/1488054Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635313}
-
Daniel Cheng authored
Change-Id: Id3444dca74b55269c4f07c303f2f9c49cc0e6049 Reviewed-on: https://chromium-review.googlesource.com/c/1485699Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#635312}
-
Anand K. Mistry authored
This is a reland of https://crrev.com/634562. The original change didn't handle failures as expected for the watcher API functions. BUG=934541 Change-Id: I964dc908a35f02e237604bfd18f931d282b3a4d5 Reviewed-on: https://chromium-review.googlesource.com/c/1484965Reviewed-by:
-
Andrew Moylan authored
This CL uses ScopedFeatureList to control the UserActivityPredictionMlService flag to toggle between the ML Service and old TfNative codepath for Smart Dim. Both codepaths are now tested. In order for the ML Service codepath to work in a unit test environment, where there is no real ML Service daemon, we need to inject a fake MlServiceClient implementation. Quite a bit of refactoring was applied to separate the tests that don't apply to both codepaths from the tests that do apply to both codepaths, and to control the different combinations of flags we need to test. Bug: 933638 Test: unit_tests --gtest_filter=SmartDim* Change-Id: I95f19c1fcc925422effef1ec4221a76cbe1fc8e6 Reviewed-on: https://chromium-review.googlesource.com/c/1478666 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#635310}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: I9517216cc228282085f0676ec676ea5157c46360 Reviewed-on: https://chromium-review.googlesource.com/c/1486877Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#635309}
-
Xiaocheng Hu authored
[Sheriff] Mark two more external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/ tests as failure on Mac Tbr: xiaochengh@chromium.org NoTry: True Bug: 935689 Change-Id: Ic831b15257501a092f9e33610165f6a3d0baa5e1 Reviewed-on: https://chromium-review.googlesource.com/c/1488014Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f78131dac076..fe14b2e503a5 git log f78131dac076..fe14b2e503a5 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 ynovikov@chromium.org Revert "Add system util to execute app and retrieve its output" 2019-02-25 tobine@google.com Vulkan:Adding custom pool allocator 2019-02-23 syoussefi@chromium.org Add system util to execute app and retrieve its output Created with: gclient setdep -r src/third_party/angle@fe14b2e503a5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I4e9aec9815b57f6262abff44cc86175dacf4faac Reviewed-on: https://chromium-review.googlesource.com/c/1487845Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8c1e8f1fb771..9b433073ba38 git log 8c1e8f1fb771..9b433073ba38 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 hliatis@google.com Fix minor issue in vkCreateInstance extension loop Created with: gclient setdep -r src/third_party/swiftshader@9b433073ba38 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/125943360 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I4d09db4a8744991c5d852f5ae0ac8d404ca9bf38 Reviewed-on: https://chromium-review.googlesource.com/c/1487136Reviewed-by:
-
Ryan Sturm authored
I am targetting fixing one test before moving on to other tests. By calling the UI thread version of the method (instead of the general one) we guarantee a more synchronous interaction, and by disabling the hints installer from sending actual hints, we guarantee that nothing overrides the test hints. This fix is motivated by two facts: the installer and the test both might try to install hints that override each other, and the PreviewsOptimizationGuide starts observing after the HintCache is fully initialized (meaning a DB is read). Bug: 932913 Change-Id: I9f0dc5ef85c9ac1d2e099e7227182890e2114338 Reviewed-on: https://chromium-review.googlesource.com/c/1487174Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#635305}
-
