GitLab

Revert of Improve ios/web/public/test/web_js_test.h (patchset #2 id:20001 of https://codereview.chromium.org/2148723003/ )

Reason for revert:
I'm afraid DCHECK_NSEQ is not defined, just EXPECT and ASSERT. It seems to break compilation downstream. Let me revert and fix.

Vaclav

Original issue's description:
> Improve ios/web/public/test/web_js_test.h
>
> This CL does some minor changes to web_js_test.h based on eugenebut's
> recommendations in https://codereview.chromium.org/2150513002/#msg21.
>
> R=eugenebut@chromium.org
> BUG=627775
>
> Committed: https://crrev.com/2de879b6567bdd5383db462d0d3ee194bb4d998b
> Cr-Commit-Position: refs/heads/master@{#405234}

TBR=eugenebut@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627775

Review-Url: https://codereview.chromium.org/2146793003
Cr-Commit-Position: refs/heads/master@{#405280}

To match the TimeDeltas in page_load_metrics, the
DataReductionProxyPageLoadTiming TimeDeltas are changed to
base::Optional TimeDeltas. Functionally, this will only change the case
where the TimeDelta is zero.

The constructor for DataReductionProxyPageLoadTiming is moved to a new
cc file due to the templated variables creating a complex constructor.

BUG=626040

Review-Url: https://codereview.chromium.org/2145743002
Cr-Commit-Position: refs/heads/master@{#405279}

This CL implements the OpenGL canvas, rendering layer, and desktop. This is part
of the project of implementing OpenGL rendering component for Android and iOS.
Please see design doc in crbug for more information.

BUG=385924

Review-Url: https://codereview.chromium.org/2045963004
Cr-Commit-Position: refs/heads/master@{#405278}

Given std::unique_ptr<T> t, t.get()-> is the same as t->.
Similarly, *t.get() is the same as *t. Simplify extensions
code to conform.

BUG=None

Review-Url: https://codereview.chromium.org/2137013005
Cr-Commit-Position: refs/heads/master@{#405277}

The mock GL bindings are useful, but they are very complex to setup and use
(gmock), and too slow for some uses (e.g. a fuzzer), and painful to maintain as
the decoder code evolves.

This CL introduces a GLStubApi as an alternative:
- GLStubApi hooks at the GLApi level rather than the DriverGL level, that is, it
implements a full interface rather than individual functions looked up through
GetProcAddress. It is simpler to override.
- the CL implements an auto-generated GLStubApiBase which only has trivial
functions, as well as a more concrete GLStubApi that implements enough to
initialize and run a GLES2Decoder.
- GpuChannelTest was changed to use the GLStubApi

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2136223002
Cr-Commit-Position: refs/heads/master@{#405276}

The current Dockerfile uploaded with the testing package is just a NOOP stub.  This change creates a functional stub from the shared base used by test and engine and handles additional filesystem setup steps for testing.

The updated Dockerfile will be used to validate service support.

BUG=616945, 608487

Review-Url: https://codereview.chromium.org/2136363002
Cr-Commit-Position: refs/heads/master@{#405275}

VideoCaptureDeviceClient buffer warnings show that capture is
stopped. In most of the capture related errors, capture stops
and we print this warning for each following frame. As a result,
it is much harder to read through the error logs, such as below
as we print this line hundreds of times.

This CL addresses this issue by removing the logs and replacing with
a DCHECK that comes in after consistent errors.

https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/26646/steps/browser_tests/logs/stdio

Review-Url: https://codereview.chromium.org/2124073006
Cr-Commit-Position: refs/heads/master@{#405274}

Users can add "use_new_wrapper_types = true" to their mojom targets to make the generator map mojom array/map/string to STL types (for chromium variant) or WTF types (for blink variant).

This CL also switches bindings tests to use the new mode

BUG=624136

Review-Url: https://codereview.chromium.org/2136733002
Cr-Commit-Position: refs/heads/master@{#405273}

This removes trace endpoints from the content interface and moves them
to TracingControllerImpl. We don't want to expose both TraceDataSinks
and TraceEndpoints currently to avoid confusion.

Review-Url: https://codereview.chromium.org/2052773002
Cr-Commit-Position: refs/heads/master@{#405272}

TBR=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2145123002
Cr-Commit-Position: refs/heads/master@{#405271}

Shell operations can cause 3rd-party shell extensions to be
loaded into the caller's process. The utility process protects the browser process from potential instability.

Also convert the IPC mechanism to Mojo.

BUG=73098

Review-Url: https://codereview.chromium.org/2122303002
Cr-Commit-Position: refs/heads/master@{#405270}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8b7bf3c29a56..04bbb644880f

$ git log 8b7bf3c29..04bbb6448 --date=short --no-merges --format='%ad %ae %s'

BUG=577224

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2140173005
Cr-Commit-Position: refs/heads/master@{#405269}

flaky on Windows 7 and fix TestExpectations for picker appearance tests.

BUG=627782,593567
TBR=engedy

Review-Url: https://codereview.chromium.org/2150523003
Cr-Commit-Position: refs/heads/master@{#405268}

SurfaceId is 128-bits and so it cannot fit in a single register.
Thus passing it around by const reference is potentially more
efficient, and more consistent with how we pass around other non-trivial
structs such as gfx::Rect.

BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2150633002
Cr-Commit-Position: refs/heads/master@{#405267}

BUG=622707
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2133833002
Cr-Commit-Position: refs/heads/master@{#405266}

Increase allowed percentage of pixels that differ in ImageBackgroundFilter.BackgroundFilterRotated_GL test

The old value was 3.1% and on Windows a Skia change causes slightly more pixels to be different. It is increased to 4%.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2145043002
Cr-Commit-Position: refs/heads/master@{#405265}

This reverts r403440 (commit c825d655),
as it caused a security regression.

BUG=626790
TBR=shanmuga.m@samsung.com

Review-Url: https://codereview.chromium.org/2147003002
Cr-Commit-Position: refs/heads/master@{#405264}

Now that cpplint.py doesn't trigger a false positive with
base::hash_map, we don't need the NOLINT tag anymore.

BUG=627202
TEST=git cl lint  # clean output

Review-Url: https://codereview.chromium.org/2146833003
Cr-Commit-Position: refs/heads/master@{#405263}

Implements migration of a QUIC connection to a different destination address if specified by the server in an ASAD tag in the Server Hello. Quietly falls back to original socket if creation and connecting a new socket fails.

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2124753005
Cr-Commit-Position: refs/heads/master@{#405262}

Use the cursor theme that GTK tells us is the default,
instead of always using the default white cursor theme.

BUG=377525

Review-Url: https://codereview.chromium.org/2135353002
Cr-Commit-Position: refs/heads/master@{#405261}

All clients have transitioned to using the respective devil modules
directly, so these are no longer needed.

BUG=617761

Review-Url: https://codereview.chromium.org/2139133004
Cr-Commit-Position: refs/heads/master@{#405260}

Cleaning up auto-play-in-sandbox* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2146923002
Cr-Commit-Position: refs/heads/master@{#405259}

Make the empahsized "https:" scheme text match the connection state indicator
icon color. (In the new design, the color changed.) Also, per the new design,
don't emphasize (color) the scheme for Incognito or theme colors.

BUG=626646
TBR=tedchoc

Review-Url: https://codereview.chromium.org/2144443002
Cr-Commit-Position: refs/heads/master@{#405258}

Previously GN iterated through the deps and added the all_dependent followed by the public configs for each target.

But the ordering is documented to be all of the all_dependent_configs, followed by all of the public_configs. This patch brings the ordering in line with the documentation and adds a test.

BUG=474000

Review-Url: https://codereview.chromium.org/2140363002
Cr-Commit-Position: refs/heads/master@{#405257}

This fixes the deqp/data/gles3/shaders/linkage.html tests that were
checking that compilation fail if interface blocks have different
layouts.

BUG=621031
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2147663002
Cr-Commit-Position: refs/heads/master@{#405256}

... originally removed by https://codereview.chromium.org/1514483002

BUG=627875

Review-Url: https://codereview.chromium.org/2150653002
Cr-Commit-Position: refs/heads/master@{#405255}

Changes MojoBootstrap - the implementation of master endpoints for
IPC::ChannelMojo - to use custom message routing logic in lieu of
the Mojo public Binding and InterfacePtr primitives and the underlying
MultiplexRouter implementation.

This is part a series of CLs to support Channel-associated interfaces.

BUG=612500

Review-Url: https://codereview.chromium.org/2136193003
Cr-Commit-Position: refs/heads/master@{#405254}

It is necessary to restore the keyboard/touchscreen devices at the end
of the tests, so that subsequent tests are not affected.

BUG=545533

Review-Url: https://codereview.chromium.org/2151603002
Cr-Commit-Position: refs/heads/master@{#405253}

Minor change to ensure that paper-toggle-button is actionable.
Also removes an unnecessary paper-toggle-button include.

BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2152503002
Cr-Commit-Position: refs/heads/master@{#405252}

When adding a new child to a ViewAndroid, it tries to remove the child
from the parent of the View to which the child is being added rather
than removing it from its existing parent. Fix that.

Review-Url: https://codereview.chromium.org/2147853002
Cr-Commit-Position: refs/heads/master@{#405251}

This patch removes the code which sets the application title from the launcher, since now the title is set from Android-side and we don't need to set it in Chrome-side.

BUG=621166

Review-Url: https://codereview.chromium.org/2113633002
Cr-Commit-Position: refs/heads/master@{#405250}

Currently, the user can unlock their device using one of three methods:
  - their password,
  - a PIN or password,
  - no authentication.

The setup pin screen is in a dependent CL.

The choose-method screen is available from the /quickUnlock/chooseMethod
endpoint.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2097673002
Cr-Commit-Position: refs/heads/master@{#405249}

BUG=627578
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2141063003
Cr-Commit-Position: refs/heads/master@{#405248}

Mostly removing unneeded methods, reworked mute console.

BUG=none

Review-Url: https://codereview.chromium.org/2139363003
Cr-Commit-Position: refs/heads/master@{#405247}

Now that the shards are more evenly distributed, this is feasible.
Increase the number of shards to handle the additional ~15 minutes of
run time.

BUG=586033
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2133673003
Cr-Commit-Position: refs/heads/master@{#405246}

no_pch and disable_precompiled_headers do the same thing; drop one of them.

No behavior change.

BUG=none

Review-Url: https://codereview.chromium.org/2148953002
Cr-Commit-Position: refs/heads/master@{#405245}

Clean up compositor_model_bench code.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2145543002
Cr-Commit-Position: refs/heads/master@{#405244}

Got reverted due to breaking
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in some WebRtc Mac bot, possibly because it has no real WebCam
or it has one without  AVCaptureStillImageOutputClass support.

This CL adds a guard  [captureSession_ canAddOutput:...]
before [captureSession_ addOutput:...]

Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.

Review-Url: https://codereview.chromium.org/2146973002
Cr-Commit-Position: refs/heads/master@{#405243}

When file loading is finished ResourceMultiBufferDataProvider count
DataBuffer queue size twice, so GetSize returned incorrect value.

BUG=625515, 627525, 624853

patch from issue 2110853006 at patchset 1 (http://crrev.com/2110853006#ps1)

Review-Url: https://codereview.chromium.org/2133803004
Cr-Commit-Position: refs/heads/master@{#405242}

StopReason is passed to following observer methods:
- ArcBridgeBootstrap::Observer::OnStopped
- ArcBridgeService::Observer::OnBridgeStopped

Those callbacks can now tell the reason the bridge stopped.

I am planning to use this soon to show notifications on failures.
See the bug entry for more details.

BUG=chromium:625923
TEST=components_unittests --gtest_filter=ArcBridgeTest.*
TEST=Manually verified that ARC boots.

Review-Url: https://codereview.chromium.org/2133653002
Cr-Commit-Position: refs/heads/master@{#405241}