GitLab

(1) Prerenders an Instant search base page on the receipt of a high-confidence search suggestion.
(2) Prefetches the search results for the high-confidence suggestion using the prerendered page.
(3) When the user commits the search query, Android Chrome submits the query to the prerendered page and swaps the active tab contents with the prerendered contents.

BUG=382694
TEST= Apply this patch, build Android Chrome and run it against the server url specified in go/yzcku. Type a search query in the LocationBar. Android Chrome should identify the high-confidence suggestion for the typed query and prefetch the results for that suggestion. Commit the typed query. Android Chrome should swap the active tab contents with the prerendered page contents. You should see the search results instantaneously.

Review URL: https://codereview.chromium.org/321943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277818 0039d316-1c4b-4281-b951-d872f2087c98

glFlush() in render_widget_host_view_mac.mm requires gl.h since
10.9 SDK (I suppose it was included implicitly before).

Review URL: https://codereview.chromium.org/332383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277817 0039d316-1c4b-4281-b951-d872f2087c98

It's possible that we end up hanging the browser
process waiting for the response to a popup window
due to a bug in the AwContents hand-over when swapping
out the popup content into the user-supplied WebView.

This patch ensures that we don't end up with two AwContents
instances pointing to the same java AwContentsClientBridge
java object during deletion.

BUG=

Review URL: https://codereview.chromium.org/305823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277816 0039d316-1c4b-4281-b951-d872f2087c98

- use high dpi resources
- add a logo to the tray
- css fixes: increase the tray height, hover/focused states of pods,
increase the profile name box
- ensure non-focused pods are faded out
- update/make equal the padding between pod rows and columns
- change the style of the action box drop down arrow

See crbug for mocks.
Screenshots:
https://drive.google.com/file/d/0B1B1Up4p2NRMUDFqWmgtSGVlbmM/edit?usp=sharing

BUG=380273

Review URL: https://codereview.chromium.org/330283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277815 0039d316-1c4b-4281-b951-d872f2087c98

> Modifies AudioInputCallback::OnData and use media::AudioBus instead of plain byte vector
>
> BUG=375155
> TEST=WebRTC and WebSpeech demos
>
> Review URL: https://codereview.chromium.org/314713002

R=henrika@chromium.org
TBR=henrika@chromium.org

Review URL: https://codereview.chromium.org/335343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277814 0039d316-1c4b-4281-b951-d872f2087c98

If resolution failed, callback receives empty pointer.

BUG=385392

Review URL: https://codereview.chromium.org/333243007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277808 0039d316-1c4b-4281-b951-d872f2087c98

setlocale() isn't part of the std:: namespace. This was breaking libc++ builds.

BUG=318770
TBR=stgao@chromium.org
NOTRY=true
TEST=built with libc++ and libstdc++

Review URL: https://codereview.chromium.org/342433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277805 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Change HungPluginTabHelper to listen for infobar changes through Observer style. (https://codereview.chromium.org/297293002/)

Reason for revert:
Caused a crash on Windows. See crbug.com/354380

Original issue's description:
> Change HungPluginTabHelper to listen for infobar changes through Observer style.
> 
> Test plan:
> 
> 1) out/Debug/chrome --no-sandbox --ppapi-flash-path=/opt/google/chrome/PepperFlash/libpepflashplayer.so --ppapi-flash-version=`grep -i version /opt/google/chrome/PepperFlash/manifest.json | awk '{print $2}' | awk -F"\"" '{print $2}'`
> 2) Go to a site that has flash, e.g., http://www.flash-game.net/
> 3) Open Task Manager, Shift+Esc
> 4) Search for "Plug-in: Shockwave Flash" in the list.
> 5) Select it and click on "End process" button.
> 6) Go to the website and observe the infobar.
> 
> Another way to test it is:
> 
> 1) Add an infinite loop into ppapi/examples/scripting/post_message.cc
> 2) Build ppapi_example_post_message
> 3) out/Debug/chrome --no-sandbox --register-pepper-plugins="/home/tfarina/chromium/src/out/Debug/lib/libppapi_example_post_message.so;application/x-ppapi-post-message-example" ppapi/examples/scripting/post_message.html
> 
> BUG=354380
> TEST=see above
> R=pkasting@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277292
NOTRY=true
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/338353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277804 0039d316-1c4b-4281-b951-d872f2087c98

This updates actions.xml to account for the new extended reporting option.

BUG=383866
NOTRY=true

Review URL: https://codereview.chromium.org/340553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277803 0039d316-1c4b-4281-b951-d872f2087c98

Generated using
src/tools/metrics/histograms/update_use_counter_feature_enum.py

NOTRY=true

Review URL: https://codereview.chromium.org/335373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277802 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we would use the X-coordinate of the left edge of the dragged tabs,
and check whether it fell within the left or right half of each tab in the
strip.

This had a couple problems.  First, because tabs are wider than they appear (due
to a significant portion of the tab being the outside pieces that are flush or
nearly-flush with the top of the toolbar), the true left edge of the dragged
region is "to the left of" where the user thinks the drag point ought to be, and
this discrepancy becomes noticeable as tabs get narrow, with the insertion
sometimes seeming to happen a tab to the left of where it "ought to".  Instead,
we now use a (hardcoded) 16-px offset into the drag region, which is much closer
to where the user perceives the "start" of the region to be.

Second, again because tabs are wider than they appear, the right half of one tab
can overlap with the next tab, indeed sometimes even overlapping with the right
half of that next tab, so the insertion point can be calculated in a way that
appears to be off by a tab or so.  Instead, we now simply use the regions
between successive tab midpoints to calculate the desired insertion index.

The result of this is that the apparent "slop zone" between tabs gets slightly
larger, and it takes a slightly further drag to drag to the very beginning of
the tabstrip; but most noticeably, when dragging tabs that are very narrow (e.g.
in tabstrip overflow), dragging feels much more predictable and less like the
instant you grab a set of tabs, they get moved to somewhere strange.

BUG=none
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/338263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277801 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384575

Review URL: https://codereview.chromium.org/339113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277800 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372306

Review URL: https://codereview.chromium.org/338113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277799 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/344463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277798 0039d316-1c4b-4281-b951-d872f2087c98

The tool-bar is being phased out as part of the apps v2 work, but as
part of the transition, the functionality it provides needs to be shared
between it and the window frame. Step one is to disentangle some of the
event handling code from client_session.js and toolbar.js.

NOTRY=true

Review URL: https://codereview.chromium.org/336293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277797 0039d316-1c4b-4281-b951-d872f2087c98

This class isn't used in multithreaded fashion anymore.

BUG=NONE

Review URL: https://codereview.chromium.org/337163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277796 0039d316-1c4b-4281-b951-d872f2087c98

Histogram names are case-sensitive. Histograms.xml have the prerender source as "instant" instead of "Instant".

BUG=none
TEST=none
R=asvitkine@chromium.org
TBR=tburkard@chromium.org

Review URL: https://codereview.chromium.org/339203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277795 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375155
TEST=WebRTC and WebSpeech demos

Review URL: https://codereview.chromium.org/314713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277794 0039d316-1c4b-4281-b951-d872f2087c98

BUG=288859

Review URL: https://codereview.chromium.org/323133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277793 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes 'Disconnect from Google account' dialog show the correct message in all usage scenarios. Further, the cancel button is made the default in the dialog.

BUG=374715,374723

Review URL: https://codereview.chromium.org/339023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277792 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/332193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277791 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385318
TEST=test manually that new finch groups behave as expected.

Review URL: https://codereview.chromium.org/338093007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277790 0039d316-1c4b-4281-b951-d872f2087c98

This is the 1st step towards removing sign-in enforcement for GCM.

We also remove the logic to pass account IDs to check-in request
since it seems to work fine without them and TokenService::GetAccounts
returns the empty list.

BUG=384041
TEST=existing and new tests
R=bartfab@chromium.org, fgorski@chromium.org, zea@chromium.org
TBR=jochen@chromium.org, rogerta@chromium.org

Review URL: https://codereview.chromium.org/330733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277789 0039d316-1c4b-4281-b951-d872f2087c98

Make the base class QuadSink concrete instead of pure virtual, and
remove QuadCuller class. Testing class MockQuadCuller is still derived
from QuadSink, which also manipulates its own MockOcclusionTracker.

This CL is part of clean up QuadSink. Next step would to plum LayerImpl
through so QuadSink will no longer need to hold that variable, in order
to split up QuadSink into just RenderPass and OcclusionTracker.

This CL follows 302603006 and 306683002.

BUG=344962
TEST=cc_unittests

Review URL: https://codereview.chromium.org/309493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277788 0039d316-1c4b-4281-b951-d872f2087c98

The three tests being flaky (testContentUrlAccessWithTwoViews, testFileUrlAccessWithTwoViews and testCacheModeWithTwoViews) are all implicitly rely on the fact that when a page load error happens, onPageFinished is only called once. This behaviour had been broken since about M33, but due to happy timing, it just didn't cause the tests to fail.

The solution is to filter onPageFinished callbacks on AwContentsClient side, since the flow of passing the URL of the error page appears perfectly normal in the context of Chrome.

Other changes:

  -- testContentUrlAccessWithTwoViews was in fact incorrect, as it wasn't expecting an error in case when access to content: URLs is blocked;

  -- modified ClientOnPageFinishedTest.testOnPageFinishedCalledAfterError to catch situations when onPageFinished / onReceivedError is called twice, to avoid future regressions;

  -- added ClientOnPageStartedTest to catch similar problems with onPageStarted.

BUG=370950,371983

Review URL: https://codereview.chromium.org/281563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277787 0039d316-1c4b-4281-b951-d872f2087c98

This change ensures that the extension that generated a key with enterprise.platformKeys can use that key at most once for signing data. Any attempt to sign data afterwards with the same key will fail.

BUG=382983

Review URL: https://codereview.chromium.org/323093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277784 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds trace links to chrome://inspect if you add the
"tracing" parameter to chrome://inspect. Clicking on the trace link
opens up chrome://tracing.

BUG=

Review URL: https://codereview.chromium.org/337803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277781 0039d316-1c4b-4281-b951-d872f2087c98

To ease failure diagnosis.

BUG=385421
R=gab@chromium.org

Review URL: https://codereview.chromium.org/338273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277780 0039d316-1c4b-4281-b951-d872f2087c98

We'll want this to be able to implement efficient, base/logging.h-like
macros (with the similar behavior -- i.e., don't evaluate the stream if
it's not going to be logged).

R=darin@chromium.org

Review URL: https://codereview.chromium.org/334263010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277779 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277777 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176255:176311&mode=html
TBR=schenney@chromium.org,jamesr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/336383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277776 0039d316-1c4b-4281-b951-d872f2087c98

ViewTreeNode*->Node*
ViewManagerSynchcronizer->ViewManagerClientImpl

R=sky@chromium.org
TBR=sky@chromium.org
http://crbug.com/384443

Review URL: https://codereview.chromium.org/338093008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277775 0039d316-1c4b-4281-b951-d872f2087c98

When BeginFrame scheduling is enabled, the browser compositor
automatically adjusts the deadline it passes down to the renderer to
account for its own draw time. Make sure we don't also subtract the
estimated draw time in the renderer.

BUG=359566

Review URL: https://codereview.chromium.org/335873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277774 0039d316-1c4b-4281-b951-d872f2087c98

According to crbug.com/307827 - the code that used media_galleries_handlers has been removed.

BUG=NONE
NOTRY=true

Review URL: https://codereview.chromium.org/338473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277773 0039d316-1c4b-4281-b951-d872f2087c98

JSONReader produces base::Value objects that share a string buffer. See comment at the JSON_DETACHABLE_CHILDREN option.
Since Remove on a child node was used, this potentially lead to use-after-free. 

BUG=NONE

Review URL: https://codereview.chromium.org/335103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277772 0039d316-1c4b-4281-b951-d872f2087c98

Should be below accounts list, but above list of other profiles.

BUG=372812,372381

Review URL: https://codereview.chromium.org/338093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277771 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/323343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277770 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277762 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org, jochen@chromium.org, jschuh@chromium.org

Review URL: https://codereview.chromium.org/334483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277761 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162827

Review URL: https://codereview.chromium.org/293033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277759 0039d316-1c4b-4281-b951-d872f2087c98