GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/be58a3b3..21cb7e30

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I238ab2263e99c10d200d788f1c673c320530b8a5
Reviewed-on: https://chromium-review.googlesource.com/959580Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542737}

The extract_unwind_tables script dumps the breakpad symbol file and
extracts cfi unwind table from it.
The output format is discussed in this doc:
https://docs.google.com/document/d/1TLuUZ1HaMO6Rv0Q9Y1-w4a-9wcyia1VygQbs4Osb7Oo
This is just a basic format and will be changed in subsequent cl for
size efficiency and performance.

BUG=819888

Change-Id: I987aa2e4ef37f86b6553410d7ee73c15f655495b
Reviewed-on: https://chromium-review.googlesource.com/956971
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542736}

Removing UtilityProcessMojoClient now that it is not used anymore.
As a result UtilityProcessHost::SetExposedDir() is removed as well as
its actual implementation in the sandbox code.

Tbr: bradnelson@chromium.org
Bug: 775677
Change-Id: I4147a2482c51132afa7a43927d6351e63169cb06
Reviewed-on: https://chromium-review.googlesource.com/937962
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542735}

Bug: 676224
Change-Id: I9b0c8266d1b45fa0371cea4fc0cd94e9909b6534
Reviewed-on: https://chromium-review.googlesource.com/957863
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542734}

DevTools prints console System-type Info-level messages only in 2 cases
- MainFrame navigations "Navigated to ..."
- Dumping size of large Common.Settings that failed to save

This CL sets text color to blue in these cases, and also sets
dark-theme violation text to original warning colors.

Screenshot: https://imgur.com/a/yaIbr

Bug: 817429
Change-Id: Id3f2c7ad16a3f02b40b4aafe93f5ca3dcf04f4b1
Reviewed-on: https://chromium-review.googlesource.com/955893Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542733}

Bug: n/a
Change-Id: I26db9c9ffbbfc55245f6ddc29c1e8088047e91c2
Reviewed-on: https://chromium-review.googlesource.com/959463Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542732}

Using wpt-import in Chromium 32c4f747.
With Chromium commits locally applied on WPT:
072aa316 "[css-typed-om] Fix DCHECK when creating a CSSUnitValue an empty unit."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13794

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=foolip

No-Export: true
Change-Id: Ibb89c6568c271c3f356df0a1c857d2cccfcb84bb
Reviewed-on: https://chromium-review.googlesource.com/959680
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542731}

https://chromium.googlesource.com/catapult.git/+log/548a5bc4b828..c6434b02c577

$ git log 548a5bc4b..c6434b02c --date=short --no-merges --format='%ad %ae %s'
2018-03-12 simonhatch Pinpoint - Upload results2 to bucket with more open permissions

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ia333862276c80fdb7e801d267fd67de6cdc4627a
Reviewed-on: https://chromium-review.googlesource.com/959579Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542730}

https://webrtc.googlesource.com/src.git/+log/5b9c6840b1d9..207a75d8f3fa

$ git log 5b9c6840b..207a75d8f --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I3298ff426f0d6f5d609ed3f669a03a393d1d9bff
Reviewed-on: https://chromium-review.googlesource.com/959749
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542729}

This CL fixes a combination of two bugs that resulted in crash due to
internal inconsistencies. The first bug is that we forgot to clear
ClipPath node when an element lost all of its effect nodes. The second
bug is that the paint property nodes were not invalidated when a SVG
clipPath element was removed.

BUG=818821

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3e7ba8507c60c4a09f4e88417c76c7e33f1bd1c1
Reviewed-on: https://chromium-review.googlesource.com/959595
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542728}

This CL applies //tools/clang/base_bind_rewriters to
//chrome/browser/extensions.
It rewrites base::Bind to base::BindOnce where the resulting base::Callback
is immediately converted to base::OnceCallback, which is considered safe
to use base::BindOnce.

E.g.:
  base::PostTask(FROM_HERE, base::Bind([]{}));
  base::OnceClosure cb = base::Bind([]{});
are converted to:
  base::PostTask(FROM_HERE, base::BindOnce([]{}));
  base::OnceClosure cb = base::BindOnce([]{});

This reduces the number of 'base::Bind' in //device from from 648 to 612
as tracked at http://goo.gl/LUVhDj

Bug: 714018
Change-Id: I1a92511d1fa36f9fb2ed048c8e44ca4247b46e78
Reviewed-on: https://chromium-review.googlesource.com/952404Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542727}

Bug: None
Change-Id: I034500f7ac6f551ddcb6b53a728796e9d55dd8a5
Reviewed-on: https://chromium-review.googlesource.com/958890Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542726}

.. and prepared V8PrivateProperty::V8PrivateProperty for terminate
execution.

R=haraken@chromium.org

Bug: chromium:820640
Change-Id: I1d31466f2a4c8f7dcb4eaf225c082bededddb768
Reviewed-on: https://chromium-review.googlesource.com/959148Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542725}

This CL includes the test for "Accept-CH" header.

If the origin includes "Accept-CH" in the response header,
then the browser should include the specified client hints
in the HTTP request headers for the resources contained
in that page.

Bug: 817049
Change-Id: Id74193ab7a1cc3c4b03d66e080c43c64a6fcfbb2
Reviewed-on: https://chromium-review.googlesource.com/951867Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542724}

needed for https://skia-review.googlesource.com/c/skia/+/113940

Change-Id: I4db6feb9e518cdacbaba10fcbd3e790927f3d4a3
Reviewed-on: https://chromium-review.googlesource.com/959531Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542723}

Flaky.

TBR=scottmg@chromium.org

Bug: 819924
Change-Id: Id6a337392ec94bbc1b3ae2f83a914bc4d2565996
Reviewed-on: https://chromium-review.googlesource.com/958666Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542722}

This CL renames the classes as follows:
* UserActivityLogger -> UserActivityManager
* UserActivityLoggerDelegate -> UserActivityUkmLogger
* UserActivityLoggerDelegateUkm -> UserActivityUkmLoggerImpl
* UserActivityLoggingController -> UserActivityController

Design doc:
https://docs.google.com/document/d/1QXXnRFKiRDvXaxwNTc6djMDC-5e7SXk4i2FI3fpxMdA/edit?usp=sharing

Change-Id: Id8a1b2e35c3bfde9e07ee47613510da5415f038a
Reviewed-on: https://chromium-review.googlesource.com/956164
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542721}

Change-Id: I4578a80f4c49c381109efaddf326934b834978ec
Reviewed-on: https://chromium-review.googlesource.com/953646
Commit-Queue: Manu Cornet <manucornet@google.com>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542720}

In this patch, we covert the scale factor from Direct Manipulation
to GesturePinch event. The ctrl+wheel will create by WebViewImpl::
HandleSyntheticWheelFromTouchpadPinchEvent.

Bug: 647140
Change-Id: Ib041d7805daac7e71b2f43872c818a9f36b14abd
Reviewed-on: https://chromium-review.googlesource.com/786348Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542719}

This patch cleans up an unused variable I happened to find
while debugging.

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I4498954e510e0a64362b688fe20ea46014906f0e
Reviewed-on: https://chromium-review.googlesource.com/958649Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542718}

TBR=ricea@chromium.org

Bug: 820334
Change-Id: Ie25ebb66474e51cb87a2908e233ba8e0438720f9
Reviewed-on: https://chromium-review.googlesource.com/958944Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542717}

https://skia.googlesource.com/skia.git/+log/8103ecae7b53..c25e2693ab00

$ git log 8103ecae7..c25e2693a --date=short --no-merges --format='%ad %ae %s'
2018-03-12 brianosman Fix several bugs in SkDebugCanvas/SkDrawCommand

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I7e4668f530ae3ab6a2416b13cbd37aa5fcff0714
Reviewed-on: https://chromium-review.googlesource.com/959534Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542716}

This CL breaks out the dialog-specific functionality of ui::WebDialogUI
into a new class, ui::WebDialogUIBase. ui::WebDialogUI now derives from
both WebDialogUIBase and content::WebUIController.

The new ui::MojoWebDialogUI class integrates Mojo functionality into
web dialogs via ui::MojoWebUIController. Classes deriving from
ui::MojoWebDialogUI can produce dialogs that make Mojo calls in JS.

Change-Id: Ie91ae935aba5d65f7bcde1c13dfd9ecdee28ffab
Reviewed-on: https://chromium-review.googlesource.com/947048Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542715}

Bug: 809756
Change-Id: I1a2fed0038ea40c0bae1781ae088f686b3a9e90b
Reviewed-on: https://chromium-review.googlesource.com/959741Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542714}

This reverts commit b4603176.

Reason for revert: Reverting as one of the fixs for an interactive_ui_test failure got reverted.

Original change's description:
> Adds WindowService-ChromeOS fieldtrial
> 
> I'm not sure on the name here. I went with WindowService-ChromeOS as
> at some point we will launch the WindowService on other platforms, but
> that won't be anytime soon and is likely to be very different. So, I'm
> thinking later on we have the field trial WindowService-Desktop.
> 
> BUG=814898
> TEST=none
> 
> Change-Id: I5bf45c2a463de0fefaeb06939429977e36c3681e
> Reviewed-on: https://chromium-review.googlesource.com/932821
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542680}

TBR=sky@chromium.org,rkaplow@chromium.org

Change-Id: Id63c00a90c6fd05ff74f0ffaa6ed738a98bd74e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 814898
Reviewed-on: https://chromium-review.googlesource.com/959763Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542713}

This is to fix the 2 unit tests on CFI builds:
  ServiceWorkerHandleTest.DispatchExtendableMessageEvent_FromClient
  ServiceWorkerHandleTest.DispatchExtendableMessageEvent_Fail

BUG=820620,772713,813749

Change-Id: Iaf4a6f4a464fe97a44f63bf2ca5a1a2e04400b9b
Reviewed-on: https://chromium-review.googlesource.com/958126Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#542712}

Following bot results are included.
4164 4165 4166 4167 4168 4170 4172 4174 4177 4178 4180 4181 4183

233 lines were removed and 10 lines were deflaked by consecutive
results since 4126.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I88db7f2b1bb88cc7fcb3c04aee0507b3b949bf19
Reviewed-on: https://chromium-review.googlesource.com/958362
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542711}

This test is inherently flaky, so disable it pending a fix.

TBR: rockot
Bug: 821254
Change-Id: Ic9db63f5a66d1e775033e6e2c9fa029beb7c5e42
Reviewed-on: https://chromium-review.googlesource.com/959746Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542710}

Flaky.

TBR=sky@chromium.org

Bug: 820435
Change-Id: I32621c2152ef4b089c3990ccfb4f46e8fb1f5f29
Reviewed-on: https://chromium-review.googlesource.com/958892Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542709}

This change takes the O(n^2) computation of a node's bounds down to O(n) by caching previously computed bounds.

It also solves a crash which seemed to result from corruption of the incoming node data. This was observed while using NY Times with webviews containing many nodes and firing many events.

Change-Id: I43c9295864fdcaf3775348eb17f55a4cf66da281
Reviewed-on: https://chromium-review.googlesource.com/956413
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542708}

Pepper CDM support is being deprecated. This CL removes all CDM
adapter (pepper plugin) registration/checking code.

Bug: 772160
Change-Id: I5b6c538a0b96360c7c32a2d35d1dab41f0ed34c1
Reviewed-on: https://chromium-review.googlesource.com/956255Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542707}

Flaky.

TBR=mathp@chromium.org

Bug: 821202, 516052
Change-Id: Ic697ed6f0c3ae27f9a8b6358071a584a6026d30d
Reviewed-on: https://chromium-review.googlesource.com/958891Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542706}

This reverts commit c8c4c686.

Reason for revert: Causes EventRewriterTest.EventRewriting to fail on Android/Linux CFI starting

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Android%20CFI/builds/241

error like

../../ui/events/event.cc:306:10: runtime error: control flow integrity check for type 'ui::LocatedEvent' failed during base-to-derived cast (vtable address 0x0000002689b0)
0x0000002689b0: note: vtable is of type 'ui::(anonymous namespace)::TestEvent'
    #0 0x62afb5 in ui::Event::AsLocatedEvent() const ./../../ui/events/event.cc:306:10
    #1 0x63063a in ui::(anonymous namespace)::IsLocatedEventWithDifferentLocations(ui::Event const&) ./../../ui/events/event_source.cc:19:45
    #2 0x630083 in ui::EventSource::SendEventToSink(ui::Event*) ./../../ui/events/event_source.cc:46:34
    #3 0x4a23e2 in ui::(anonymous namespace)::TestEventRewriteSource::Send(ui::EventType) ./../../ui/events/event_rewriter_unittest.cc:69:5
    #4 0x4a1fe4 in ui::EventRewriterTest_EventRewriting_Test::TestBody() ./../../ui/events/event_rewriter_unittest.cc:188:5


Original change's description:
> chromeos: provide ability to supply event for rewriting
> 
> EventRewriters don't honor the target, and so generally expect the
> root_location and location to be the same. This patch changes EventSource::SendEventToSink()
> to create a new Event if the existing has differing locations (and a target).
> 
> BUG=817112
> TEST=covered by tests
> 
> Change-Id: Iaabe019fed4350610306576a054b7d395def92ff
> Reviewed-on: https://chromium-review.googlesource.com/956925
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542653}

TBR=sadrul@chromium.org,sky@chromium.org

Change-Id: I5ee070c74eba97a446c1a8e71e12f64b90b27401
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 817112
Reviewed-on: https://chromium-review.googlesource.com/958806Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542705}

TBR=jbudorick@chromium.org, tandrii@chromium.org

Bug: 811974
Change-Id: I1cbeab2333cd9a243177cf9a4e1d1bd73b1efc19
Reviewed-on: https://chromium-review.googlesource.com/959745Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542704}

VectorIcons currently have two representations - a version used at 100% scale
(its |path_1x|) and a version used at all other scale factors (|path|). This
isn't scaleable and can't support having more than two icon representations per
VectorIcon, so add gfx::VectorIconRep to prepare for this.

Bug: 647286
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iff59deb2064ce0f0995016fee9dcdeda16999605
Reviewed-on: https://chromium-review.googlesource.com/942647
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542703}

The presubmit had the wrong file used as a test, and didn't trigger on
unpack_pak.py changes.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia7125e6b034261c29a2acdb067896f2ac9c9f216
Reviewed-on: https://chromium-review.googlesource.com/956650Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542702}

Apply snake_case to CSSPrimitiveValueUnit.json5, generated CSSPrimitiveValueUnitTrie.cpp, and generated CSSTokenizerCodepoints.cpp.

This CL has no behavior changes.

Bug: 770603
Change-Id: I41c913ec0dfa9e51d0ddc5f7a5b782c6c128e461
Reviewed-on: https://chromium-review.googlesource.com/958052Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542701}

This CL has no behavior changes.

Bug: 770603
Change-Id: I1669bca88648ad866882a8dad7ae5b9137af7af3
Reviewed-on: https://chromium-review.googlesource.com/958650Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542700}

The unwind tables are stripped from release builds. This CL adds a
script to extract the unwind table sections from unstripped binary and
adds it as an asset file in the apk.
This script is first used in the test apk, when add_unwind_tables_in_apk
is specified. Will be used later added to chrome apk.

BUG=819888

Change-Id: I68d2ea843ed0c7a7a3ee60c48f683e01809ff217
Reviewed-on: https://chromium-review.googlesource.com/954421Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542699}

This reverts commit e9605182.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 542634 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U5NjA1MTgyNTE4Njc4NDVlZDIzYmYyYWI4ZjA0MmE3N2FmZTE4ODUM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/8479

Sample Failed Step: mojo_unittests

Original change's description:
> Delay Channel::OnError() in case of kDisconnected during Write().
> 
> Write() operations to a Channel can fail due to the peer having closed
> it, while there are still messages waiting to be read from it. We must
> therefore defer notifying the caller of the Channel::Error until we
> observe end-of-stream via a readable notification, otherwise those
> messages may be dropped (depending on whether the posted OnError task
> is processed before or after a pending Channel-readable event).
> 
> Bug: 816620
> Change-Id: I75bd34a48edf4022809d27ce49f9cfba7a5d4daf
> Reviewed-on: https://chromium-review.googlesource.com/956932
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542634}

Change-Id: I9d212ecb8dde1e90422b60e950547e823357f0d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 816620
Reviewed-on: https://chromium-review.googlesource.com/959761
Cr-Commit-Position: refs/heads/master@{#542698}