GitLab

Misc Ash windows incorrectly get new style BubbleFrameViews.
Revert new dialog style change to CreateDefaultNonClientFrameView.
This reverts non-dialog Ash windows to the old CustomFrameViewAsh.
See before/after pics at http://crbug.com/241810#c17

Dialogs get frames from DialogDelegate::CreateNonClientFrameView.
( where 'dialogs' are DialogDelegate[View] [subclass] instances )

BUG=241125,241810,166075
TEST=Only dialog windows have the new-style bubble border. No windows have a double-border issue.
R=derat@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15685017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203092 0039d316-1c4b-4281-b951-d872f2087c98

By this patch, a search result entry whose metadata is not fetched yet is
temporarily added to the hidden "drive/other" directory for making it possible
to appear in the search result UI. Normal feed loading routine will move it
back to the right place once the real metadata is loaded.

BUG=181075
TEST=Search "a" during the initial load of an account with large number of files
R=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/16142003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203091 0039d316-1c4b-4281-b951-d872f2087c98

Patch by Adam Langley.

R=agl@chromium.org
BUG=90392
TEST=net_unittests

Review URL: https://chromiumcodereview.appspot.com/14772023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203090 0039d316-1c4b-4281-b951-d872f2087c98

This also uses the new blue button style for
the app launcher signin button.

Binaries were landed in: https://codereview.chromium.org/15848008/

BUG=159733

Review URL: https://chromiumcodereview.appspot.com/14631022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203089 0039d316-1c4b-4281-b951-d872f2087c98

It has been converted to Telemetry and is no longer run on the bots.

BUG=None
TEST=compile performance_ui_tests

Review URL: https://chromiumcodereview.appspot.com/14566005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203088 0039d316-1c4b-4281-b951-d872f2087c98

* Fill in v4l2_buffer.m.planes field for VIDIOC_DQBUF
* Support both V4L2_CID_GLOBAL_ALPHA and V4L2_CID_ALPHA_COMPONENT
  ioctls for setting GSC alpha.

BUG=230698
TEST=Ran VDA unittest on  snow with 3.8 kernel

Change-Id: Id633c4ed75ee807400536cea056e14a2d8ae5cf6

Review URL: https://chromiumcodereview.appspot.com/14328033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203087 0039d316-1c4b-4281-b951-d872f2087c98

This accounts for test environments that may have the TMP directory
on drives that aren't C:.

R=vandebo@chromium.org,ajwong@chromium.org
BUG=None

Review URL: https://chromiumcodereview.appspot.com/15767005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203086 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244143
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16072018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=232200

Review URL: https://chromiumcodereview.appspot.com/14979008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203084 0039d316-1c4b-4281-b951-d872f2087c98

These all pass locally, but they fail on the bot. I'm
disabling them all for now to get content_browsertests
on the waterfall and will renable them once we figure
out what's wrong with the bot.

BUG=180861
R=piman@chromium.org
TBR=piman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16071003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203083 0039d316-1c4b-4281-b951-d872f2087c98

This CL includes:
 - Move webkit/quota/quota_{types.{h,cc},callbacks.h} webkit/common/quota/,
 - Move other webkit/quota/ files to webkit/browser/quota/,
 - #include and include guard fix for the move,
 - Split webkit/quota/webkit_quota.gypi to webkit/{browser,common}/quota,
 - Change DEPS to allow #include webkit/common from chrome/browser.

BUG=244363
TEST=should build successfully and should pass deps check.
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/16010007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203082 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/15989008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203081 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178307
R=qinmin@chromium.org,bulach@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15876006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203080 0039d316-1c4b-4281-b951-d872f2087c98

base/string16.h was moved into base namespace in r191198 by Brett.

BUG=None
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/15759009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203079 0039d316-1c4b-4281-b951-d872f2087c98

This creates a separate SynchronousCompositorImpl class that is owned
by the RenderWidget. This will be needed for hooking up the root layer
scroll offset delegate.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/15875009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203078 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239392,9096213

Review URL: https://chromiumcodereview.appspot.com/15871003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203077 0039d316-1c4b-4281-b951-d872f2087c98

Currently preview panel is transparent and does not affect the size of other
components. Thus this CL just removed call for onResize.

This CL also removes unused function requestResize.

BUG=238867
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/15675007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203076 0039d316-1c4b-4281-b951-d872f2087c98

ResourceMetadata::GetResourceEntryById no longer returns FilePath.
FileSystemInterface::GetResourceEntryById no longer returns FilePath.
Remove GetFilePath related code from FakeFileSystem.

BUG=244135
TEST=unit_tests
R=satorux@chromium.org

Review URL: https://codereview.chromium.org/16107004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203075 0039d316-1c4b-4281-b951-d872f2087c98

Allow specifying proxy scripts using file:, data:, and ftp: URLs.  This addresses a regression from r198915.

BUG=243974

Review URL: https://chromiumcodereview.appspot.com/15665006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203074 0039d316-1c4b-4281-b951-d872f2087c98

Android can have tabs without any web contents. Tab association logic
assumes that all tabs have web contents. This prevents Android from
cleanly doing session reassociation. This change adds a
SyncedTabDelegate which does not depend on existence of web contents.
It also ensures that SessionID for a tab does not change when web
contents get attached to the tab.

BUG=139670, 125549

Review URL: https://chromiumcodereview.appspot.com/15499005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203071 0039d316-1c4b-4281-b951-d872f2087c98

webstore_private_api returns "already_installed" when an install request specifies an extension id that is either already installed or is in the process of installing.

BUG=222735

Review URL: https://chromiumcodereview.appspot.com/15292011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203070 0039d316-1c4b-4281-b951-d872f2087c98

buffer_pool_lock_ is not needed on the UI thread for this test, but if the
camera started and stopped without an OnFrameInfo, then it's possible that
the buffer_pool_ was never created.

BUG=231723

Review URL: https://chromiumcodereview.appspot.com/15070008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203069 0039d316-1c4b-4281-b951-d872f2087c98

This is generally not applicable to autofill as we either filter out incomplete
profiles or there's no associated phone number (in the case of credit cards).

BUG=180149
R=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15892013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203068 0039d316-1c4b-4281-b951-d872f2087c98

This timeout was long to work around a problem that has been resolved
elsewhere.
I'm also changing the histogram name to match the condensed format
that is now preferred. In addition I've added a new boolean histogram
to indicate if the data was ready or not.

BUG=244939
BUG=242726

TEST=None

Review URL: https://chromiumcodereview.appspot.com/16189009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164227
TEST=No

Review URL: https://chromiumcodereview.appspot.com/16171008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203064 0039d316-1c4b-4281-b951-d872f2087c98

Remove the overenthusiastic DCHECK from PictureLayerImpl to make sure
that every tile that intersects the visible content rect also has a
distance to the viewport of zero.  Because the projection of the
viewport is done more precisely than the enclosing rect for the visible
content rect, it may be possible for a tile to be outside the viewport
but inside the visible content rect.

Therefore, the current DCHECKS are bogus.  Instead, skip these tiles
because they're not truly required for activation.

R=reveman@chromium.org
BUG=243437

Review URL: https://chromiumcodereview.appspot.com/16160005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203063 0039d316-1c4b-4281-b951-d872f2087c98

R=mgaba@chromium.org
BUG=244897
TEST=none

Review URL: https://chromiumcodereview.appspot.com/16114010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203062 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203056 0039d316-1c4b-4281-b951-d872f2087c98

This CL alters SpellcheckMessageFilter to check for NULL spellcheck service when
it periodically receives a list of document markers from the renderer.

BUG=244521

Review URL: https://chromiumcodereview.appspot.com/16075005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203054 0039d316-1c4b-4281-b951-d872f2087c98

Example (new on top, old on bottom): http://imgur.com/a/vx7pW

BUG=99426

Review URL: https://chromiumcodereview.appspot.com/16019014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203052 0039d316-1c4b-4281-b951-d872f2087c98

The bugs fixed are:
- programs required for -o2 weren't checked for when using -o2
but were checked for lower -o levels.
- if no savings could be found the results printed at the end
were confusing and the script had a divide by zero error.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/15970004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203051 0039d316-1c4b-4281-b951-d872f2087c98

This removes third_party/IconFamily from Chrome, which creates
questionable results when adding icon sizes < 128px. Since OSX 10.5, OSX
hasn't used indexed icons or alpha masks when a 32-bit icon is available
(see notes in OSServices.framework/IconStorage.h).

BUG=241304
TEST=Create an app shim and inspect Resources/app.icns using OSX Preview
-- ensure the icons are correct.
TBR=darin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15650005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203050 0039d316-1c4b-4281-b951-d872f2087c98

Fix some style nits while there.

TEST=Robot Unicorn Attack.
BUG=

Review URL: https://chromiumcodereview.appspot.com/15990006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203049 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242227
TEST=unittest

Review URL: https://chromiumcodereview.appspot.com/15862014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203048 0039d316-1c4b-4281-b951-d872f2087c98

These headers have moved from Source/Platform/chromium/public to
public/platform. This CL updates content's references to the old location to
point to the new location. After this CL lands, I'll remove the forwarding
headers that are letting these references still work.

TBR=jamesr@chromium.org
BUG=239545

Review URL: https://chromiumcodereview.appspot.com/15822010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203047 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the heapchecker+components release build.

BUG=241938

Review URL: https://chromiumcodereview.appspot.com/15797009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203046 0039d316-1c4b-4281-b951-d872f2087c98

It makes the test more self-contained.

This patch converts only the tests not involving file deletion feed,
which is not supported yet in FakeDriveService.

BUG=244316

Review URL: https://chromiumcodereview.appspot.com/15741023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203045 0039d316-1c4b-4281-b951-d872f2087c98

Add per-dialog UseNewStyleForThisDialog() style control.
(by default this returns the static UseNewStyle() control)
Update DialogDelegate to respect this per-dialog control.

Have TaskManagerView always use the old style; cleanup.
See before/after pics at http://crbug.com/245000#c1

Do DialogClientView background init in ViewHierarchyChanged.
(check the dialog delegate instance for styling control)

BUG=245000,166075
TEST=The task manager always uses the old dialog style.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15731007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203044 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=mtomasz@chromium.org, hirono@chromium.org

Review URL: https://codereview.chromium.org/16216006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203043 0039d316-1c4b-4281-b951-d872f2087c98

The ui::CompositorTestSupport class existed to initialize WebKit since
ui::Compositor depends on cc which used to depend on WebKit being initialized
to function properly.  cc no longer has this requirement, so this class is
unnecessary.

R=piman, sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202787

Review URL: https://chromiumcodereview.appspot.com/14744016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203042 0039d316-1c4b-4281-b951-d872f2087c98