- 17 Jul, 2017 40 commits
-
-
Daniel Bratell authored
Both InterpolableValueTest and InterpolationEffectTest use an identical class for value testing. These classes collided in jumbo builds where they were compiled in the same translation unit. This patch moves the class to AnimationTestHelper.h and changes its name to be more descriptive now when it isn't as close to where it is used anymore. Also changing the name of the kDuration constant that interfered with blink::kDuration. R=fs@opera.com Change-Id: Ic90cec2972f5464d7932b2ba91994273968e87c4 Reviewed-on: https://chromium-review.googlesource.com/574489Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#487067}
-
Daniel Bratell authored
IdleDeadlineTest and ScriptedIdleTaskControllerTest both use similarly names mock classes, MockScheduler, MockThread and MockPlatform which collide in jumbo builds where they are merged into the same translation unit. This patch gives the classes unique names. R=fs@opera.com Change-Id: I305cb3fbdfbd3b3b6fc7c18e8c3ceccf89da863e Reviewed-on: https://chromium-review.googlesource.com/574487Reviewed-by:
-
Daniel Bratell authored
PageOverlayTest and PrintContextTest both use a local mock test class named MockCanvas for testing. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the classes unique names. R=fs@opera.com Change-Id: Icfcb2b4b553e50e08cb6ac56712e4e9aa5f2b69e Reviewed-on: https://chromium-review.googlesource.com/574349Reviewed-by:
-
Daniel Bratell authored
There is blink enum class LineBreakType used to correctly layout text. That makes it unsuitable to use the same name in a unit_test since they may collide, and actually will collide in jumbo builds. This patch changes LineBreakType to NewlineType R=fs@opera.com Change-Id: I3c5ae6ea5b6e199990c8b51c3a55eb1d17a8f19e Reviewed-on: https://chromium-review.googlesource.com/574238Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/86deba2a..0ceb5bb0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ib74be404e4cf7d34cf13eb8aa1ab5f8056d0ec79 Reviewed-on: https://chromium-review.googlesource.com/574408Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487063}
-
Pavol Marko authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/137ec42a355f..69b19fbcbec5 $ git log 137ec42a3..69b19fbcb --date=short --no-merges --format='%ad %ae %s' 2017-06-30 pmarko system_api: Support for temporary policy read Created with: roll-dep src/third_party/cros_system_api This will be used by CL:564609. BUG=722371 Change-Id: Ieadd125ff2aa83a3ca69c3611d2c60aae3c1e2d6 Reviewed-on: https://chromium-review.googlesource.com/574347Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#487062}
-
Jérôme Lebel authored
On iPad, the user can show the bookmarks with the sign-in promo and open the settings. If they sign in with the settings, then the sign-in promo will be removed from the bookmarks. The mediator from the bookmarks should not send the dismiss histogram. To avoid this problem, the sign-in promo view mediator needs to check if the user is logged in before sending the dismiss histogram. Bug: 742514 Change-Id: Id5c189e68a06e82874ef487155831593911a9ef4 Reviewed-on: https://chromium-review.googlesource.com/567508 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#487061}
-
Eddy Mead authored
[CSS Typed OM] Correctly use const on the CSSStyleValue subclass typed members of CSSTransformComponents - Members shouldn't be const (they need to be able to be modified after being returned to JS) - Match the style guide for pointer getters: https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Use-const-correctly) - The DOMMatrix function being changed was added for Typed OM in https://codereview.chromium.org/2907973002/ Bug: 545318 Change-Id: Id4399ceaf9290f4f52847696c57a37f8022894fb Reviewed-on: https://chromium-review.googlesource.com/544576 Commit-Queue: meade_UTC10 <meade@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#487060}
-
Jérôme Lebel authored
Adding an explicit method to send histograms when the sign-in promo view is removed. Bug: 709286 Change-Id: I32c4091e9db05edeb497ab1583fe9b6e3017f5f6 Reviewed-on: https://chromium-review.googlesource.com/567923 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Reviewed-by:
-
Daniel Bratell authored
CSSTokenizerTest already uses functions named Ident and Dimension so to avoid special casing in jumbo builds where the tests are compiled together, rename them here. R=fs@opera.com Change-Id: I6b600c269463d897b6d56287e450e37d027b2911 Reviewed-on: https://chromium-review.googlesource.com/574173Reviewed-by:
-
Daniel Bratell authored
HTMLMediaElementTest and MediaCustomControlsFullscreenDetectorTest both use a local TestParam struct/enum for testing. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the classes unique prefixes. R=fs@opera.com Change-Id: I17a4d3a25e38bc0789071fcec31b066a385d34a0 Reviewed-on: https://chromium-review.googlesource.com/574178Reviewed-by:
-
Daniel Bratell authored
There is a shared RegisterMockedURLLoad in URLTestHelpers and a couple of local ones imported with "using" or locally declared. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the functions will collide. This patch removes a "using" and renames a function to make the names more unique. R=fs@opera.com Change-Id: I6866f13bd1903e42269b7286645a9f07396b68a8 Reviewed-on: https://chromium-review.googlesource.com/574180Reviewed-by:
-
Suchit Agrawal authored
Create new BUILD.gn file for media/video and moved respective media component changes from media/filters/BUILD.gn file to new BUILD.gn file. BUG=613033 Signed-off-by:
Suchit Agrawal <a.suchit@samsung.com> Change-Id: Iaa2ff8c16d697ede5e8e249fbc01c058eaef6d78 Reviewed-on: https://chromium-review.googlesource.com/569528Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org> Cr-Commit-Position: refs/heads/master@{#487055}
-
David Roger authored
Dice signout did not cancel the token exchange request, which could lead to a situation where the token is eventually added to Chrome and propagated back to the web by the account reconcilor. Change-Id: I1c1a2b218694e3de5783e6a29dbcec29a6e0aa0d Reviewed-on: https://chromium-review.googlesource.com/570423Reviewed-by:
-
Daniel Bratell authored
HTMLResourcePreloaderTest and HTMLPreloadScannerTest both use a local PreconnectTestCase struct for testing. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the classes unique prefixes. R=fs@opera.com Change-Id: I99f315843fd6908ba94595e852e6c1fac6acdedb Reviewed-on: https://chromium-review.googlesource.com/574177Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#487053}
-
Hector Dearman authored
This use after free crash was caused when a client with a pending response unregisters (via UnregisterClientProcess) and that pending response is the last pending response for the current request. UnregisterClientProcess iterates over request->pending_responses calling OnProcessMemoryDumpResponse or OnOSMemoryDumpResponse when it finds a pending response which matches the client. OnOSMemoryDumpResponse/OnProcessMemoryDumpResponse removes the pending response and calls FinalizeGlobalMemoryDumpIfAllManagersReplied which (if there are no more pending responses) destroys the request we're iterating over. We had a test which attempted to test this but for subtle reasons it didn't actually cover this case. This CL fixes the bug by not-calling OnOSMemoryDumpResponse/OnProcessMemoryDumpResponse from UnregisterClientProcess and adds a test to cover this case. Bug: 742265 Change-Id: I96504edf98ea1b0e530e0daf3f4adbfaa509bc15 Reviewed-on: https://chromium-review.googlesource.com/570247Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Hector Dearman <hjd@chromium.org> Cr-Commit-Position: refs/heads/master@{#487052}
-
Dan Elphick authored
This reverts commit 67fac36a. Reason for revert: Causes several CPU load, time and memory regressions. Fixes crbug/740469 Original change's description: > Increase priority of compositor TQ in NONE Usecase > > This allows animated GIFs to keep updating even in the presence of timer > storms. > > Reland change partially reverted in > WebRtc and CrSettings tests have been landed. > > https: //chromium-review.googlesource.com/c/508792/ now that fixes to > Bug: 703608 > Change-Id: Id014fda26b7168658c679a7bf74359485c5262e5 > Reviewed-on: https://chromium-review.googlesource.com/559345 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#484863} TBR=skyostil@chromium.org,delphick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 703608, 740469 Change-Id: I172f61626446462bb5582c942ae58d09a13dad71 Reviewed-on: https://chromium-review.googlesource.com/573902 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#487051}
-
Daniel Bratell authored
There is a ::Function template in wtf/Functional.h and if someone else defines a function with the same name that template will be harder to use. This is more of a problem in jumbo builds where more code is visible so that both the definitions becomes visible at the same time. R=fs@opera.com Change-Id: I0be2f2e2441f3e5db0049f65e1b4c0be8997d586 Reviewed-on: https://chromium-review.googlesource.com/574028Reviewed-by:
-
Daniel Bratell authored
There is a gtest namespace ::testing and a helper namespace in blink called ::blink::testing. If both are visible to the compiler, ::blink::testing will be used first and classes in ::testing will not be found. This happens in jumbo builds so we better be more specific. R=fs@opera.com Bug: Change-Id: I912ed721a0ccae7b8e8b622020f87f15204362cf Reviewed-on: https://chromium-review.googlesource.com/574027Reviewed-by:
-
hans authored
It was previous calling the out-of-line method WeakReference::is_valid(). That means that code like if (my_weak_ptr) my_weak_ptr->foo(); would do two calls to is_valid(), plus tests and branching. The is_valid() method showed up as one of the most frequently called non-inline functions during browser start-up on Windows (about 1M calls). is_valid() was also inefficient in itself, because it had to do a null-check flag_, as well as checking if the flag was marked valid. This patch removes the null-pointer check by using a sentinel Flag object instead of a nullptr. And instead of storing a bool in the Flag, it stores a pointer-sized bitmask 0 or ~0, so it can be AND'ed with the pointer value and conveniently setting EFLAGS so that the code above just becomes a few loads, AND, branch, and call. (The size of Flag is unchanged; it grows into the padding only.) This is expected to reduce the binary size by ~48KB on Android, and increase it by 79KB on x64 Linux -- something that's paid for by the split-out refactorings to WeakPtr and WeakPtrFactory. Exposing the SequenceChecker calls in inline functions caused the MessageLoopTestType*.Nesting test to overflow on Win64 dcheck release builds, which is why this patch also lowers the recursion depth there. BUG=728324,738183,738193 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2963623002 Cr-Commit-Position: refs/heads/master@{#487048} -
stkhapugin@chromium.org authored
Automatically generated ARCMigrate commit Notable issues: - added bridged casts where necessary - replaced retain-autorelease with NS_VALID_UNTIL_END_OF_SCOPE BUG=624363 TEST=None Change-Id: Ibd7f03942d784bdcf2b95a30f693cfd736ef13c9 Reviewed-on: https://chromium-review.googlesource.com/570031 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#487047}
-
jdoerrie authored
This change removes GetHumanReadableOrigin and GetHumanReadableOriginForAndroidUri. These methods are now dead code following http://crrev.com/c/571227. Bug: 628988 Change-Id: I24cc948a29f709cd3e8280698616114d05d4c87c Reviewed-on: https://chromium-review.googlesource.com/574169Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#487046}
-
Jérôme Lebel authored
Issue: The impression count is sent to the dismiss histogram even if the sign-in promo has been previously used. Since the interaction sign-in controller starts the sign-in as soon as the "Continue as..." is clicked, then the sign-in mediator from BookmarkCollectionView is deallocated. The issue is if the sign-in is canceled, then the new created mediator doesn't know that the sign-in promo has just been used. BookmarkCollectionView should keep the sign-in promo view as long as the sign-in started by the mediator is in progress. Therefore, the mediator will report the right histogram when it will be destroyed. Bug: 742335 Change-Id: I85a89c647a89691007af4942ebd89aef15b28231 Reviewed-on: https://chromium-review.googlesource.com/567081 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c374229c..86deba2a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I2c37e2305a47b6ecb52eefe5ce0bb6cb03692019 Reviewed-on: https://chromium-review.googlesource.com/574060Reviewed-by:
-
Hidehiko Abe authored
This CL migrates ArcTracingBridge. BUG=672829 TEST=Ran try. Change-Id: Ibc52186e24f7e042dfc86541cecf7fc18d2dea50 Reviewed-on: https://chromium-review.googlesource.com/572887Reviewed-by:
Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#487043}
-
Bernhard Bauer authored
Bug: 739331 Change-Id: Id36a03f537feac9ec561300830df4966e3afc349 Reviewed-on: https://chromium-review.googlesource.com/566802 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#487042}
-
Alexandr Ilin authored
The project was turned down and the precache code is no longer executed. Removal is done in three steps: 1. Unwire precache from chrome/browser/predictors. (done http://crrev.com/c/561523) 2. Delete the rest use of precache. (done http://crrev.com/c/563409) 3. Delete all precache directories. (current) Bug: 739439 Change-Id: Ide5e797602a71d2dc657f11b84bed99a2ac17020 Reviewed-on: https://chromium-review.googlesource.com/561538 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#487041}
-
Christian Dullweber authored
md-select is not aligned with its label due to unbalanced paddings and a 3px md-select-underline. This Cl fixes this by balancing md-select with an additional margin-top and reducing the height of md-select-underline to 0px + 1px border. Bug: 740887 Change-Id: I1b8a5b6bea9c30a686427fdffb96ee05df686259 Reviewed-on: https://chromium-review.googlesource.com/566826 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#487040}
-
Mohamed Amir Yosef authored
Bug: 735465 Change-Id: I4810c94f4c5a0f9fd61915affd2a2fd8c7f7e29c Reviewed-on: https://chromium-review.googlesource.com/570638 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#487039}
-
Nicholas Verne authored
Bug: 712963 Change-Id: Ib2f117d83dcf34c505249335197f797ccd962554 Reviewed-on: https://chromium-review.googlesource.com/572477 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#487038}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4b582195..c374229c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ib7ab57ad7c2feeb6406131218bc06ae7e7034472 Reviewed-on: https://chromium-review.googlesource.com/572375Reviewed-by:
-
Mohamed Amir Yosef authored
Bug: 735465 Change-Id: I4e1aa8d74be22dd96479f1d5c53e11c89358cfa0 Reviewed-on: https://chromium-review.googlesource.com/562757 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
-
Ramya Sharma authored
This CL moves editing, editIndexPaths, editingBar properties and their callbacks to super class BookmarksHomeViewController. from handset and tablet subclasses. Bug:705339 Change-Id: I7f1a7c5fa29aff104fbcba0d1f2a62d5647c6be2 TEST=Bookmarks functionality Change-Id: I7f1a7c5fa29aff104fbcba0d1f2a62d5647c6be2 Reviewed-on: https://chromium-review.googlesource.com/569506Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Cr-Commit-Position: refs/heads/master@{#487035}
-
Lutz Justen authored
DeviceStatusCollector collects resource usage stats every 2 minutes. The ActivityTimesKeptUntilSubmittedSuccessfully test compared two full instances of DeviceStatusReportRequest. In one run of the test, the test failed because the resource usage collection happened right in between. This CL compares activity times only (aka what the test is interested in) and removes the full status comparison. Also fixes an uninteresting mock function call and moves some functions from public to protected. BUG=chromium:743061 TEST=out/Release/browser_tests --gtest_filter=DeviceStatusCollectorTest.* Change-Id: I39d65260794326cae90d57ec583ff28e2d9a9092 Reviewed-on: https://chromium-review.googlesource.com/573901Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#487034}
-
Vaclav Brozek authored
GetShownOriginAndLinkUrl was recently updated to handle Android credentials correctly, by replacing the android:// URIs with a human-readable Play Store name for display and a Play Store web URL for linking to the app description. Android credentials are credentials stored in Android apps and uploaded to Chrome Sync. They can be used for filling on affiliated websites, so they are important on iOS as well. The change affects Android credentials as described above, but also web credentials, by changing slightly the presentation of the web origin (e.g., https:// prefix is removed). The new state is consistent with Chrome settings on desktop and soon also on Android. Screenshots with before and after are at https://crbug.com/628988#c19. Bug: 628988 Change-Id: Ib0f8219ed0eb652196aaa1717f075a14ee47db3d Reviewed-on: https://chromium-review.googlesource.com/571227 Commit-Queue: Louis Romero <lpromero@chromium.org> Reviewed-by:
-
beaufort.francois authored
BUG=739670 Review-Url: https://codereview.chromium.org/2971903004 Cr-Commit-Position: refs/heads/master@{#487032}
-
beaufort.francois authored
BUG=739698 Review-Url: https://codereview.chromium.org/2967373002 Cr-Commit-Position: refs/heads/master@{#487031}
-
Trent Apted authored
With *and without* --secondary-ui-md: * Removes the colons from the field labels * Alters the text for insecure domains to say "Your connection to this site is not private" * Makes the dialog title and "Log in" button text sentence case on non-Mac/iOS * Removes " requires a username and password" after the domain for non-Proxy auth requests * Removes the insets on the sides of the textfield stack relative to the dialog title. * Removes the close button from the http-auth dialog With --secondary-ui-md only: * Uses SECONDARY / gray text for the second line of header text * Makes textfields 28px tall 3 general adjustments applicable to a class of dialogs remain to be done: * Too much spacing from the title to the body text, and * Too little spacing from the last textfield to the button row. * Textfields should horizontally align "somehow" we don't know how yet Adds ui/views/harmony/layout_helper.h to encapsulate methods for creating a textfield stack in the standard layout. Bug: 602392 Change-Id: I27fbc52c95d9bd8ac2a3551d916d3f161f51593f Reviewed-on: https://chromium-review.googlesource.com/559205Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#487030}
-
Timothy Loh authored
This patch make the lifetime of PermissionPrompt objects more sensible and match what we occasionally think it actually is. Currently these objects exist when a tab is active, or on Android all the time. This patch changes it so that, as the name might suggest, it corresponds to when a prompt is actually visible. We retain the distinction between desktop/Android where desktop hides the UI (now deletes the object) on tab switching, while Android retains the UI (keeps the object alive) as the InfoBar system manages hiding the prompt. Since we don't explicitly manage lifetimes of the actual UI surface on Android (infobars in particular, as it's clearer for modals when the UI is actually destroyed) from the PermissionPrompt, we change the pointer to a WeakPtr for safety. When the PermissionPrompt is destroyed due to navigation, if an infobar happens to still persist due to a bug it won't be able to be resolve different permission requests. Bug: 606138, 737102 Change-Id: I26a8843b9b446e91282a9b0ce67c4b442bf440e9 Reviewed-on: https://chromium-review.googlesource.com/567940 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#487029}
-
Tim Sergeant authored
MD Bookmarks stamps a large amount of the same folder icon: 1 for every node in the sidebar, and 1 for every item in the list. While iron-icon is fast as far as Polymer elements go, stamping 50+ of them is still expensive. This CL switches all folder icons across the page to a plain divs that have an SVG background. This appears to save at least 5% of page load time on profiles with a large number of folders. Bug: 727177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I439f83ad3c3f645108d1a3d744cce2e402acbcee Reviewed-on: https://chromium-review.googlesource.com/566264Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#487028}
-
