- 08 Feb, 2019 40 commits
-
-
John Chen authored
All ChromeDriver builds will be using Chrome version numbers, instead of having its own version. Bug: chromedriver:2080 Change-Id: I845289296c21329ba5e6e8d2adc44eb234981bd8 Reviewed-on: https://chromium-review.googlesource.com/c/1459921Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#630211}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/38769c1f96a3..8338670f9829 git log 38769c1f96a3..8338670f9829 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 crouleau@chromium.org Revert "Devil: add --quiet option to logging_common" 2019-02-08 rmhasan@google.com Adds 'RetryOnFailure' result tag to test expectations format 2019-02-08 rmhasan@google.com Fixes bug in test expectations parser 2019-02-07 ntfschr@google.com Devil: add --quiet option to logging_common Created with: gclient setdep -r src/third_party/catapult@8338670f9829 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:929892,chromium:698902,chromium:929439,chromium:929892 TBR=sullivan@chromium.org Change-Id: Id5ff79c24021ef51d7fa86494ef7c4ae8adc89c8 Reviewed-on: https://chromium-review.googlesource.com/c/1460497Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630210}
-
CJ DiMeglio authored
This CL disables the time scrubber when there is no source or we have not loaded the metadata. Since we cannot do anything with the scrubber in these cases, we shouldn't enable it. Bug: 927153 Change-Id: I60636ccaaa66d03bc4dc24814be0071109e3c5f3 Reviewed-on: https://chromium-review.googlesource.com/c/1453539Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#630209}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b9ae2ca9a55d..9f3b5566dab7 git log b9ae2ca9a55d..9f3b5566dab7 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-07 tikuta@chromium.org [autoninja] change default -j multiplier 20 -> 40 Created with: gclient setdep -r src/third_party/depot_tools@9f3b5566dab7 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie504a37613ea22acbd65da35299160a63ff30f32 Reviewed-on: https://chromium-review.googlesource.com/c/1460496Reviewed-by:
-
Rossen Atanassov authored
The changes adds an experimental support for UIAutomation provider interface implementation. A new command line switch is added in order to enable implementation of UI Automation implementation progress without destabalizing existing IAccessible (MSAA) clients. Enabling UIA currently disables IAccessible in order to limit the possibility of clients that expect complete UIA implementations to fail due to doubled events. The render widget (and legacy) are hooked up as IRawElementProviderSimple UIA providers allowing the most simplistic use of UIA client APIs. Bug: 845471 Change-Id: I68db1508caf38b8ee8f70a40c1358d34cbc613a7 Reviewed-on: https://chromium-review.googlesource.com/c/1450696 Commit-Queue: Rossen Atanassov <ratan@microsoft.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#630207}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/088e521769f9..cd4f1fbaabce git log 088e521769f9..cd4f1fbaabce --date=short --no-merges --format='%ad %ae %s' 2019-02-08 jmadill@chromium.org Fix gtest main from including the wrong headers. 2019-02-07 jmadill@chromium.org Suppress EGLSurfaceTest.MessageLoopBugContext on Ozone. 2019-02-07 spang@chromium.org Vulkan: Enumerate instance & device extensions provided by layers 2019-02-07 timvp@google.com Revert "Vulkan: Reduce Default Descriptor Pool Max Sets" 2019-02-07 syoussefi@chromium.org Vulkan: implement swapchain resizing Created with: gclient setdep -r src/third_party/angle@cd4f1fbaabce The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I817cc4e225ac314cad18047f32fd2be3516c7080 Reviewed-on: https://chromium-review.googlesource.com/c/1460258Reviewed-by:
-
Darwin Huang authored
- read/write now use Blobs instead of DataTransfer, and can only read/write one type at a time. - read/write can now read/write images in addition to existing text support. - readImageExperimental and writeImageExperimental removed. - Images will be encoded in the same manner as before this CL, whereas text will be emitted with utf-8 encoding. - read will prefer to return an image if one is available, and will return text otherwise. - Relevant tests updated. Future Work: - Use vectors or lists or some collection of Blobs to read/write many types at a time, to work towards feature parity with DataTransfer. Bug: 916823, 150835 Change-Id: I89d12ba137954731acb7180ac2fb6d15b0c264ae Reviewed-on: https://chromium-review.googlesource.com/c/1435220 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#630205}
-
Jacob DeWitt authored
Bug: 916589 Change-Id: I4b53d4c58fcb0b518144741153fb746c90fb435c Reviewed-on: https://chromium-review.googlesource.com/c/1446850 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#630204}
-
Kai Ninomiya authored
Bug: 682815 Change-Id: I8b1ece30465b3e9737ccd9e090661b58874a8dea Reviewed-on: https://chromium-review.googlesource.com/c/1459330Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#630203}
-
John Lee authored
This also adds a basic skeleton test for the proxy and nux-ntp-background Bug: 924176 Change-Id: I040c22b383966d27a0861f093ee0ddfde6ee1d0f Reviewed-on: https://chromium-review.googlesource.com/c/1455641 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#630202}
-
Anastasia Helfinstein authored
When the Switch Access menu is opened, we want the first item to be highlighted so the user can easily select the first action. This change implements that behavior. Bug: 864796 Change-Id: I9e2903209954a82ad4b68b726be737818a253c39 Reviewed-on: https://chromium-review.googlesource.com/c/1457219 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#630201}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f2c1116f97a6..43ecc6793a5c git log f2c1116f97a6..43ecc6793a5c --date=short --no-merges --format='%ad %ae %s' 2019-02-08 tcwang@google.com chromite: Add a new flag in toolchain builders to perform 2019-02-07 dhanyaganesh@chromium.org topology: Delete the need to query CIDB for a constant dictionary 2019-02-07 dtor@chromium.org usergroup_baseline: add seneschal-client group 2019-02-07 dgarrett@google.com chromeos_config: Don't force moblab_vm tests. 2019-02-07 bhthompson@google.com Add eve-arcnext builder to master-arc-dev PFQ 2019-02-07 manojgupta@google.com chromeos_config: make arm64-generic-{full|chromium-pfq} important. Created with: gclient setdep -r src/third_party/chromite@43ecc6793a5c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If29fbffd3bbc8f4998eb74ea83167507ab1de002 Reviewed-on: https://chromium-review.googlesource.com/c/1460093Reviewed-by:
-
Karan Bhatia authored
BUG=929929 TBR=peter@chromium.org, rayankans@chromium.org Change-Id: I0a352095bd5254db868a5d3bbebb5f83011824ae Reviewed-on: https://chromium-review.googlesource.com/c/1460122 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630199}
-
Yue Ru Sun authored
The new flag can be switched on and off on "chrome://flags". It is disabled by default, and if turned on, all tasks of lowest priority "base::TaskPriority::BEST_EFFORT" will not be executed. This is equivalent to the command line flag "--disable-best-effort-tasks". Change-Id: Ic098e08f9f61b7ad8239da52d779c4660074ba5c Reviewed-on: https://chromium-review.googlesource.com/c/1452488 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#630198}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c81766320762..7fb0b73b1aa7 git log c81766320762..7fb0b73b1aa7 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 sugoi@google.com Update and Fill Buffers Created with: gclient setdep -r src/third_party/swiftshader@7fb0b73b1aa7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I1dc6f8336a7734d2c1fbcd1b8944d683423e23c9 Reviewed-on: https://chromium-review.googlesource.com/c/1460264Reviewed-by:
-
Reilly Grant authored
This API should follow the example of WebUSB and require explicit authorization via feature policy when used in a cross-origin iframe. Bug: 884928 Change-Id: Ia953c86a45e8b38b901b790b8aee912fd991e1a1 Reviewed-on: https://chromium-review.googlesource.com/c/1392357Reviewed-by:
Luna Lu <loonybear@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#630196}
-
Stuart Langley authored
The ChromeOS feedback mechanism (alt-shift-i) is hard for users to discover. By making it easier to find we hope to get better signals from users on pain points or items that the team should consider prioritizing. Here we add an explicit Gear Menu item for users to "Send feedback", which will invoke the ChromeOS feedback tool from the application. Feedback filed using this route will also be added to a "chromeos-files-app" bucket in the reporting tool making it easy to discover any user filed feedback reports. Bug: 921472 Change-Id: I1f04710f92f3e77b45af66f4cb27fa4d944cefe6 Reviewed-on: https://chromium-review.googlesource.com/c/1457559Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#630195}
-
mark a. foltz authored
This patch removes various 'trampoline' methods used to handle move-only parameters or set expectations on callback parameters. In most cases these can be replaced by standard GMock idioms. This patch does keep RouteResponseCallbackHandler, which is used to unpack and set expectations on parts of RouteRequestResult. A duplicate copy is removed in this patch. Bug: 851567 Change-Id: I4309327df4a437b4aa565837c4f7b0861dd3f208 Reviewed-on: https://chromium-review.googlesource.com/c/1459327 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#630194}
-
Kunihiko Sakamoto authored
This adds SignedExchangeRequestMatcher class, which will be used to check Signed Exchange's Variants / Variant-Key headers against the request headers (Step 3- of [1]). It supports three content negotiation mechanisms (Accept, Accept-Encoding, and Accept-Language) defined in [2]. [1] https://wicg.github.io/webpackage/loading.html#request-matching [2] https://httpwg.org/http-extensions/draft-ietf-httpbis-variants.html#backports Bug: 923229 Change-Id: I88d1d528379936011d5d668533420427f6f415af Reviewed-on: https://chromium-review.googlesource.com/c/1426205 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#630193}
-
Robbie McElrath authored
On ChromeOS, when the network service crashes, NetworkChangeManagerClient currently reconnects to it, and then tells it that the DNS config, IP address, and connection type/subtype all changed to make sure that it updates its data into the correct state. However, when the network service restarts it will read in the latest DNS config on its own, and it doesn't actually do anything with the IP address change notification, it just forwards it to its listeners. That means that those two notifications aren't actually needed. This CL removes those two but leaves the connection type change notification, since the network service still does need to know what the correct connection type is. Bug: 927293 Change-Id: I973a8dcda4547538eff64d9074b03ae06356129b Reviewed-on: https://chromium-review.googlesource.com/c/1460185Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#630192}
-
Bill Orr authored
Change-Id: I10ba823a8ab5cc2bc5de69d99e536c105ca12be0 Reviewed-on: https://chromium-review.googlesource.com/c/1459059Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#630191}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/413f0052c89e..ee4a5ccc89d4 git log 413f0052c89e..ee4a5ccc89d4 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 treehugger-gerrit@google.com Merge "Add fuzzer for shared ring buffer." Created with: gclient setdep -r src/third_party/perfetto@ee4a5ccc89d4 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I36696803bd12c02d61a1ccbd2aedcc8913b16bd8 Reviewed-on: https://chromium-review.googlesource.com/c/1459937Reviewed-by:
-
Ken Rockot authored
This reverts commit 834353f1. Reason for revert: broke official builder Original change's description: > Convert remaining JSON service manifests [part 3] > > This converts the following service manifests from JSON to C++: > > - Chrome OS assistant service > - Chrome OS assistant audio decoder service > - Chrome OS device sync service > - Chrome OS IME service > - Chrome OS multidevice setup service > - Chrome OS secure channel service > > These are the last of the JSON manifests under src/chromeos/. > > Bug: 895616 > Change-Id: Ia1c345d9b2acafec59eaa1a3ba3344c7f8180c17 > Reviewed-on: https://chromium-review.googlesource.com/c/1456955 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630155} TBR=rkc@chromium.org,rockot@google.com,dominickn@chromium.org Change-Id: If425977d741701c8099533bf973f0d565fbc2d9f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 895616 Reviewed-on: https://chromium-review.googlesource.com/c/1460487Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#630189}
-
Pavel Feldman authored
This reverts commit 84b0216a. Reason for revert: <INSERT REASONING HERE> Original change's description: > DevTools: roll third_party/inspector_protocol > > Bug: 929862 > > Change-Id: I3c12584095a1d2a45a3b6181bece071a2cd34dae > Reviewed-on: https://chromium-review.googlesource.com/c/1460186 > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630185} TBR=dgozman@chromium.org,pfeldman@chromium.org Change-Id: I250784ec2a83b539b640a14188e17980c7a9e9ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 929862 Reviewed-on: https://chromium-review.googlesource.com/c/1460485Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#630188}
-
Karan Bhatia authored
BUG=929967 TBR=jlebel@chromium.org Change-Id: Ia1ecb18d5b253de971a04912993588c32258ba92 Reviewed-on: https://chromium-review.googlesource.com/c/1460399Reviewed-by:
-
Erik Luo authored
Bug: 925314 Change-Id: Ida50ee3cd4820295461354aeb5b935009268a4eb Reviewed-on: https://chromium-review.googlesource.com/c/1435702Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#630186}
-
Pavel Feldman authored
Bug: 929862 Change-Id: I3c12584095a1d2a45a3b6181bece071a2cd34dae Reviewed-on: https://chromium-review.googlesource.com/c/1460186 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#630185}
-
Karan Bhatia authored
BUG=843467 TBR=erikchen@chromium.org Change-Id: I2e0c6838bef9181b82bb97daa4e42276903a63ea Reviewed-on: https://chromium-review.googlesource.com/c/1459979Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630184}
-
Yiming Zhou authored
Bug: 916361 Change-Id: I8a7c661d2305652dba476db7f3d00412e5cb49bf Reviewed-on: https://chromium-review.googlesource.com/c/1460131Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yiming Zhou <uwyiming@google.com> Cr-Commit-Position: refs/heads/master@{#630183}
-
Peter Boström authored
This adds text to better highlight that the current window is an Incognito one. It does not apply when the Incognito window-counter experiment is active. Bug: chromium:929842 Change-Id: I11eb7ae8cd18b62e6cbc5be46c027dccf5f12040 Reviewed-on: https://chromium-review.googlesource.com/c/1459790 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#630182}
-
Robbie McElrath authored
In ChromeOS chrome/ browser tests, a NetworkChangeManagerClient gets created, which initializes the network connection state. This initialization was also happening in BrowserTestBase, which meant that for chrome/ tests it was happening twice. This CL moves the initialization logic into ContentBrowserTest, which isn't used in chrome/ tests. Bug: 927293 Change-Id: If506d90b1fe074e49b795a2e206b9ced68c5b9ba Reviewed-on: https://chromium-review.googlesource.com/c/1457478Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#630181}
-
Kenneth Russell authored
In the Telemetry-based GPU tests, the most common reason the renderer process hangs is that the GPU process has hung, and the renderer's waiting for it. In order to debug hangs like these, it's necessary to be able to crash the GPU process on demand. In these situations the GPU process's main thread is hung, but its IO thread is very likely still responsive. Add an experimental crashGpuProcess method to DevTools' Browser domain. (Other existing facilities like the GpuBenchmarkingExtension won't work because the target renderer process's main thread is hung.) Separately, handle GpuChannelMsg_CrashForTesting earlier in the GPU process, on its IO thread. The fact that the GpuBenchmarkingExtension's CrashGpuProcess API wasn't robust to GPU process hangs was discovered during development of this CL. Tested by manually injecting a GPU process hang in one WebGL conformance test, decreasing the timeouts, and verifying that the GPU process's symbolized minidump showed up in the logs. Bug: 911772 Change-Id: Id41e3168c1f9411411755c92b6e20717813f7c71 Reviewed-on: https://chromium-review.googlesource.com/c/1459328 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
Ken Rockot authored
This converts the following service manifests from JSON to C++: - Mirroring service - NaCl broker service - NaCl loader service - Heap profiling service - Patch service - Unzip service - PDF compositor service These are the last of the JSON manifests under src/components/ NOPRESUBMIT=true (to bypass TBR vs OWNERS change restriction since this is mechanical beyond security review) Bug: 895616 Change-Id: Ic5be4bb8cf5ee589961b3741a32cdbd87348295e TBR: miu@chromium.org,dschuff@chromium.org,eseckler@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1457416 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#630179}
-
Martin Kreichgauer authored
Add my own @google.com account which I tend to use more. Also move Jan and Jun to the Emeriti list. Change-Id: Ifd478f68a08b8bbdf413c5bdd9242c9be7f6cd33 Reviewed-on: https://chromium-review.googlesource.com/c/1455684 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#630178}
-
Daniel Ng authored
This reverts commit 4d5a709c. Reason for revert: Due to refactoring coming from CL:1447912, we need to update the protos involved, therefore we need to revert this change so that changes to the proto don't break chrome. Original change's description: > Installation functionality for Crostini App search > > CL updates the Crostini Repository Search Results in the app launcher > to install Linux packages when clicked. This contains the relevant > app launcher and crostini manager changes. This feature is still behind > a flag and there are plans to incorporate an installation dialogue > into the installation process. > > Bug: 921429 > Change-Id: I17eeb6af488e56be2d9eb34edefb0194975839c8 > Reviewed-on: https://chromium-review.googlesource.com/c/1444901 > Commit-Queue: Daniel Ng <danielng@google.com> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628648} Change-Id: Ia2cecd862b947ee8b6b29b4acaef8b4fccb434fe TBR=xiyuan@chromium.org Change-Id: Ia2cecd862b947ee8b6b29b4acaef8b4fccb434fe Reviewed-on: https://chromium-review.googlesource.com/c/1459864 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#630177}
-
Gyuyoung Kim authored
As a step to make to use IdentityManager, this CL replaces all uses of ATS with IdentityManager in arc_auth_service.h/cc except for the use of AccountMapperUtil. The use of AccountMapperUtil should be replaced by crbug.com/922744. Bug: 922745, 922746, 922747 Change-Id: I4f5bbb545e7bf5bb31f1ba4bec30414752ae8401 Reviewed-on: https://chromium-review.googlesource.com/c/1436421 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#630176}
-
Daniel Libby authored
Currently ETW logging for TraceArguments uses TraceValue.AppendAsJSON, which ends up emitting surrounding quotes and escaping certain characters, which harms readability. This change introduces an AppendAsString method on TraceValue, which doesn't do the typical munging for JSON. Bug: 781991 Change-Id: Ia9d0f795f85819f0cee630f460fe82a373ffe337 Reviewed-on: https://chromium-review.googlesource.com/c/1448981Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#630175}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff3805a63456..248eabeb7086 Created with: gclient setdep -r src-internal@248eabeb7086 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:929520 TBR=mmoss@chromium.org Change-Id: Icd634ace7cb8aa8960917b1c9e5518cbf1076c95 Reviewed-on: https://chromium-review.googlesource.com/c/1459943Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630174}
-
Dmitry Gozman authored
This is incompatible with binary protocol plans. Bug: 929862 Change-Id: I3d1a26ebd2cc173544df67a69c5642740ea7a1f4 Reviewed-on: https://chromium-review.googlesource.com/c/1459807 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Lei Zhang authored
Delete code that assume it can be. Change-Id: I2e2344d4c04ff957cf403698bdfa17bffdd602b6 Reviewed-on: https://chromium-review.googlesource.com/c/1457431Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#630172}
-
