- 27 May, 2020 40 commits
-
-
Dale Curtis authored
Prep work for enabling these experiments on the beta channel. Bug: 982799, 1062849 Test: Passes CQ. Change-Id: Ibe880a566f741e695d9cf416def2180e822eaec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208082 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#772350}
-
Leonard Grey authored
TBR=rohitrao@chromium.org Bug: 1084280 Change-Id: I220f5ba04f8c974947764cdb883a9f78af14cd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218613Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#772349}
-
Stephan Hartmann authored
The move assignment operator in PaintPreviewClient::PaintPreviewData is noexcept. Because this class has a member of type base::FilePath, the move assignment operator of base::FilePath must be noexcept too. Otherwise GCC fails like this: ../../components/paint_preview/browser/paint_preview_client.cc:107:1: error: function 'paint_preview::PaintPreviewClient::PaintPreviewData& paint_preview::PaintPreviewClient::PaintPreviewData::operator= (paint_preview::PaintPreviewClient::PaintPreviewData&&)' defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification '' 107 | PaintPreviewClient::PaintPreviewData::operator=( | ^~~~~~~~~~~~~~~~~~ Bug: 819294 Change-Id: I87b88a81e8af6b7e61f0d1a8c8444fd6707e50d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218168 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#772348}
-
Andrew Xu authored
A shelf arrow button should not get the accessibility focus ring. Because when spoken feedback is enabled, if a hidden shelf icon receives the accessibility focus, scrollable shelf will ensure the icon to be visible by scroll animation. So ignore the arrow button in spoken feedback. Bug: 1086943 Change-Id: Ibe82d0315bcd71b01255fe496ccba875f38e7fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218447 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772347}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c95dd320931c..1443c9df589b 2020-05-27 csmartdalton@google.com Create indirect index buffer for tessellation during onPrepare 2020-05-27 rmistry@google.com [Infra] Create AMD Rome test bots 2020-05-27 mtklein@google.com shader dither in SkRPBlitter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I619c29596fc07b402c80bbc0d9f1d29dbfa90501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218731Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772346}
-
Nate Chapin authored
These were regressions tests added to chromium based on recent crashes. Bug: 1083437, 1083721, 1083793 Change-Id: I2fe8ec74957539ba4c0ac587b4829ca44124e65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216512 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#772345}
-
Anastasiia Nikolaienko authored
Rename account_migration_browser_proxy to account_manager_browser_proxy to use it on all account_manager_* pages. Bug: 1083147 Change-Id: Ib2058fd25ef905b1920d3aafade1247601738a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210231Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#772344}
-
Gayane Petrosyan authored
Bug: 1086565 Change-Id: I7f13079b352c09cab272566aaf498d58d72d5540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218527Reviewed-by:
Travis Skare <skare@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#772343}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 84-4136.1-1589189756-benchmark-84.0.4142.0-r1 to 84-4136.1-1589799722-benchmark-84.0.4147.17-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2259bad5a60c4599d3947cb1111ca9972542adc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218736Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/212c527f90e9..800891e5ad60 2020-05-27 tvanderlippe@chromium.org Use ESM build for acorn 2020-05-27 tvanderlippe@chromium.org Fix node_modules/OWNERS file after updating a dependency If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4c097d5f9bd9d74882ff0c952aebfb35ff95dbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218727Reviewed-by:
-
Wei Li authored
Refactor the time view to use two subviews to manage different layouts. This will allow us to remove the usage of set_owned_by_client() since all the labels will always owned by the views hierarchy. In addition, this will simplify the process of updating layouts and re-layout. BUG=1044687 Change-Id: I234fd2315d73d2508dc60f3544a04a12fbd170d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211085Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#772340}
-
Ben Joyce authored
Need to add espresso_web, idling, and contrib to migrate androidx espresso tests. espresso_web has tagsoup is a dependency. Should only need license review for tagsoup as others are covered when espresso_core was added. Bug: 1005891,1054152 Change-Id: Ie8937b7083d6b8141122001fd114f65601d495f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115942 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#772339}
-
Roman Aleksandrov authored
Add handling new status code 906 from DMServer on an erollment request. It occurs when user tries to enroll device while the administrator has not accepted enterprise ToS. Bug: 1053831 Change-Id: I2984ae671727771b1c6e8bf538a6fd8a37ee7df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213528 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772338}
-
Mounir Lamouri authored
These videos are, as far as the user is concerned, non-existent. This is the first part into strengthening the conditions in which the video element takes a screen lock. Bug: 1086776 Change-Id: Ife302518d45986a75fbb27a91fc5dc77d5f07d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213933Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#772337}
-
Fredrik Söderqvist authored
The argument is the list to copy from, marking it const makes that clear and reduces the risk for accidental mutations. Change-Id: I38fbcc64dc9dd6d2a54444ccd8c76c1959ccda7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218272 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#772336}
-
Gang Wu authored
SearchActivity did not handle image search data since image search need post data, so the fix is add the post data into intent to pass to chrome. Bug: 1078773 Change-Id: I04efdad0bba315508e0b05d3d9e444d8c1a5d955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187191 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#772335}
-
Annie Sullivan authored
BUG=943668 Change-Id: I0157278fa1b7f8f5a0358e8811f21d4be1dd990c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208026Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772334}
-
Sophey Dong authored
This fixes the bug where the STTS icon overlaps with the bookmark icon when the animation gets interrupted by reloading the page. Bug: 1085708 Change-Id: I1296d282afb2a8e5e6ec1500db9828856701be57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217768Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#772333}
-
Alexander Surkov authored
Regressed by 487bd8ec change-id when class attribute serialization was switched from html to string attribute serialization type. Bug: 1086941 Change-Id: I1fc17f1ce05589e6005d3bf233944e2bbfe68fff AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218467Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#772332}
-
Angela Yoeurng authored
When a button on the button row is highlighted (by pressing tab), the focus ring was rectangular shape. No highlight path generator was specified so the default path generator with a corner radius of 3 was used. This was fixed by specifying a pill shaped path generator. Bug: 1084320 Change-Id: I203ed3cdb47904c8d414842b3e4ea531ccfad1ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211183Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#772331}
-
Steven Bennetts authored
This includes a few minor fixes to the network config UI: * Eliminates an error log when AutoConnect has not been set for a network by initializing it to a default (false) value. * Fixes an unlikely but possible edge case in CrosNetworkConfig::GetManagedPropertiesSuccess found while testing. * Uses network-config-toggle instead of cr-toggle in network_config.html for 'Share' for consistency. * Fixes network-config-toggle so accept clicks anywhere on the toggle for consistent behavior with other Settings UI. Bug: 971704 Change-Id: I0fb5a33fa7ca5ec42241fb634eca8f697d02c279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212977Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#772330}
-
Liviu Tinta authored
Move mouse pointerevents compat events to wpt Change-Id: I5b64c7108222d68f52711c2a19069ccb5cd3f379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211913Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#772329}
-
Gauthier Ambard authored
This CL fixes the display when showing the NTP on a cold start. It prevents the animation by directly adding the BVC to the view hierarchy when the animations are disabled. It is also making sure that the location bar isn't shown on the NTP when doing a cold start. Fixed: 1082726 Change-Id: I02658837b177bbe07d58b507311657d09107fde0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216250Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#772328}
-
Reilly Grant authored
This change replaces the CHECKs added in r770407 with logic to reject invalid lengths from IOCTL_USB_GET_DESCRIPTOR_FROM_NODE_CONNECTION. Crash reports from when the original DCHECKs were replaced with CHECKs indicate that the hub driver will sometimes return a response which is shorter than the struct originally passed to it. This is invalid and so is treated as a failure. Bug: 1084316 Change-Id: I8462a5d535935e139f6cd511c26a0ab79db5950e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216548 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#772327}
-
chrome-untrusted://resourcesTommy Steimel authored
This CL fixes a bug in chrome-untrusted://resources where the Access-Control-Allow-Origin policy would only allow for chrome:// origins. This changes it so that chrome-untrusted://resources only allows for chrome-untrusted:// origins and chrome://resources only allows for chrome:// origins. Bug: 1086327 Change-Id: Icbf05aa66e587ed3cb5d5f26ef2b46c0628641c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216282 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#772326}
-
Rushan Suleymanov authored
This CL breaks down previously reported sync commit failures per data type into particular syncer errors. Bug: 1086877 Change-Id: I3ff3290b0857624d9a08f645d10f29e382f992eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218111Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#772325}
-
nancylingwang@google.com authored
Ash(ShelfController) should observe AppRegistryCache to get the app notification badging information. Ash can't depend on chrome/*, so we can't use AppServiceProxy to get AppRegistryCache, and we can't use profile as well, because that is in chrome/browser/chromeos directory. Create a new AppRegistryCacheWrapper to map account id to AppRegistryCache, so that Ash or other external browser components can access AppRegistryCache. This could help offload AppServiceProxy, extend AppRegistryCache to be used out of chrome/browser, and benefit for the future if we have an AppRegistryCache out of AppServiceProxy. BUG=1068884 Change-Id: Ib5caa94d944a0d031df9dbee0e3d2c00587ab402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212285 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#772324}
-
Mohamed Amir Yosef authored
screencast: https://screencast.googleplex.com/cast/NTE3OTA5NzIxMjc4MDU0NHw3YjdhZDQ1OC05MQ Bug: 1044038 Change-Id: If729650f517848014cb7bd406af2a77c67edba70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210980 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#772323}
-
Rune Lillesveen authored
Bug: 1086855 Change-Id: I47f4d3891172721c3c12e3985172be9156592f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218091 Auto-Submit: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/df95f5d43f28..65dd291c8da7 2020-05-27 titovartem@google.com Fix documentation for some public API methods If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3e1b8d0a1421807ca29b45e01ccacf68691b063b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218435Reviewed-by:
-
Danan S authored
The crash is fixed by null checking the profile, and made further robust by removing the call to the crashing code and instead using the AppService's own API for checking whether an app is a system app, AKA "sticky". Bug: 1026859 Change-Id: I7da239c74aa18e3bed157a7e0ce3c91cdb1e13bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216601Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Dan S <danan@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772320}
-
Brian Sheedy authored
Removes the crashpad_database_util dependency from ChromeOS, as CrOS currently still uses Breakpad and attempting to use the locally compiled version currently fails due to missing .so files. Bug: 1054583, 1084334 Change-Id: Ibdf1ed486507a83635d75ab0ff9ce39f04ee0384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216592 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#772319}
-
Chris Hamilton authored
The bug was as follows: - mechanism binds to NavigationHandle, storing its NavigationId - main frame does a subsequent same-document navigation - PMTabHelper observes this navigation, and updates the internally stored NavigationId. - PM dispatches policy message to mechanism to terminate throttles. - Policy message looks up WCProxy::LastNavigationId (taken from PMTabHelper), and feeds that into the mechanism. - This doesn't match the original NavId stored in the mechanism, and the policy message is dispatched. Fix: - Have PMTabHelper/WCProxy independently track same-doc and new-doc navigation IDs. Use the last new-doc navigation ID with the policy message. BUG=1084555 Change-Id: I726ace3e06ca83cff99b0dec18372647789910c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218228Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#772318}
-
Nate Chapin authored
Currently, for some non-attached Documents, we skip providing CSP. There doesn't seem to be any specific reason for this, or pattern for when we do or don't provide it. This has the added benefit of fixing a corner case where we can end up inspecting a CSP that was not completely initialized. Bug: 1067034 Test: http/tests/security/contentSecurityPolicy/csp-violation-in-detached-document.html Change-Id: Ic8f30cc24469618b967f1c8325f7cf144b8cb876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209621 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#772317}
-
Juanmi Huertas authored
Marking kAcceleratedDirect2DUsage as deprecated. Refactoring tests to use directly CreateSwapChainProvider or CreateSharedImageProvider when needed. Refactoring CanvaResourceProviderHost to stop using ::Create. Bug: 1035589 Change-Id: I24ca7823809735654a3f57dc05be60d4b78a2638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198922Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#772316}
-
Yao Xiao authored
Background: The current heuristic (i.e. continuously tracking the position of each frame) has the issue that it doesn't know whether the frame has overlays on top. We have seen false positives where there's a fixed large ad that spans the viewpor, and the main content overlays on top, such that only a small area of the ad is visible. Another false positive is the parallax ad, which can be dismissed (i.e. blocked by the scrollable main content) along with scrolling even though its position never changes. To be able to handle the false positives, we deprecate the original heuristic and switch to a hit-testing based heuristic. See the comment in sticky_ad_detector.h. Bug: 1013070 Change-Id: Iceec4e058a14e6b19aa5db1980a9320956739963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160729Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#772315}
-
Egor Pasko authored
Introduce a histogram reporting successes and failures at pulling code residency data from /proc/self/pagemap. Opening and reading /proc/self/pagemap can fail at fopen(3), fseek(3) and fread(3). We think that we can potentially mitigate errors at fopen, see the bug for details. The current code distinguishes two error kinds: 1. at fopen 2. at fseek or fread The histogram mirrors this separation. In the future the fopen errors can also be broken down into several errno values. At this point the extra detail seems unnecessary. Bug: 1070618 Change-Id: I2b88c24c0861b46845707dbf88b16b2e4817ae22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215856 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772314}
-
Sigurdur Asgeirsson authored
Bug: 998546 Change-Id: I1a356768fad7914992631ce1d740029c8f61d39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213885Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772313}
-
Yi Gu authored
This was missed in crrev.com/c/2204224 and it should be no-op. Bug: None Change-Id: Iac8597d4693a95eae50c9e62f63fe41c71de598e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204649Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772312}
-
Andrew Xu authored
ScrollableShelfView records the number of corner buttons whose ripple ring is activated. However, the count does not work as expected in the following two scenarios: (1) After transition between clamshell and tablet, the shelf icon's context menu should be closed. However, when the count of activated corner buttons updates at the end of ripple ring fadeout animation, due to change in scrollable shelf's layout, the button whose ripple ring is deactivated is not at the corner of shelf anymore. As a result, the count does not decrease as expected. (2) The count fails to decrease when removing an icon from context menu. Because the ripple ring animation ends after shelf icon removes itself from the ink drop listener list. This CL fixes the issue by creating a scoped count owned by ShelfAppButton Bug: 1086484 Change-Id: Ib31f8b52d4da845d4a7dc945d44c7f38f3a4662f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213877 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
