GitLab

If you compile without preprocessing (first clang -E then clang, like
ccache does by default without CCACHE_CPP2), you will see warnings like:

you will see warnings like:

../../content/browser/accessibility/browser_accessibility_cocoa.mm:1155:12:error: implicit conversion of NULL constant to 'NSUInteger' (aka
'unsigned long') [-Werror,-Wnull-conversion]
    return __null;
    ~~~~~~ ^~~~~~
           0

It's because we return nil when 0 or NO should be returned instead,
normal clang compile won't catch that for some reason, perhaps because
its checking is less strict for preprocessed code.

Review URL: https://codereview.chromium.org/565383003

Cr-Commit-Position: refs/heads/master@{#294848}

The variable is set in this file but there is no other references to
it in the code base.

BUG=None

Review URL: https://codereview.chromium.org/564523003

Cr-Commit-Position: refs/heads/master@{#294847}

R=sdefresne@chromium.org,cmasone@chromium.org

Review URL: https://codereview.chromium.org/570563002

Cr-Commit-Position: refs/heads/master@{#294846}

https://skia.googlesource.com/skia/+log/5087b2c06762d0ea8b471f63953a587ecafaae0f..a63d5df455e5fb32ac995f753709893221de6147

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/574453002

Cr-Commit-Position: refs/heads/master@{#294845}

This pulls in the following Native Client changes:

r13740: (dschuff) Update revision for PNaCl r13726->r13739
r13741: (dbrazdil) Implemented sysconf(), sbrk(), malloc() in MinSFI.
r13742: (dyen) Added testing for file dup/dup2 functions for irt_ext.
r13743: (jvoung) Add a checkdeps stage to the PNaCl bots/trybots as well.
r13744: (bradnelson) Only allow fastbuild to affect symbol level.
r13745: (jvoung) PNaCl: Update Subzero revision in pnacl/COMPONENT_REVISIONS
r13746: (sbc) Add creat() declaration to newlib fcntl.h

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg

Review URL: https://codereview.chromium.org/569133002

Cr-Commit-Position: refs/heads/master@{#294844}

We report when:
1, The first time a file is fully read.
2, After the CDM throws an error with a special system code.

BUG=413812
TEST=Tested and both new UMA show in about://histograms.

Review URL: https://codereview.chromium.org/568623003

Cr-Commit-Position: refs/heads/master@{#294843}

We need to make a copy of them first in order to keep Buildbot working.
Only after this lands we can update the Buildbot code to use the new
path.

BUG=338338
TEST=None
R=sky@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/563383003

Cr-Commit-Position: refs/heads/master@{#294842}

This is similar to https://codereview.chromium.org/328423002/ where we started archiving browser_tests for Windows.

BUG=

Review URL: https://codereview.chromium.org/568143003

Cr-Commit-Position: refs/heads/master@{#294841}

Upon receiving a notification that network connectivity has been
restored, ASI will clear any backoff delay for uploading attachments.

BUG=411981

Review URL: https://codereview.chromium.org/569463002

Cr-Commit-Position: refs/heads/master@{#294840}

It also adds a Manifest struct in content/public/common.

BUG=409696

Review URL: https://codereview.chromium.org/550173002

Cr-Commit-Position: refs/heads/master@{#294839}

Keeps a vector of cache names in creation order.  They're written to and read from the the index file in the same order.

This simplifies the keys unit tests as the order of the vectors is always the same and they can now be compared directly.

BUG=408787

Review URL: https://codereview.chromium.org/565913002

Cr-Commit-Position: refs/heads/master@{#294838}

Adding overview / layer framework to Activities so that unloaded / sleeping activities can be shown with as little resources as possible

The new |ContentProxy| object is a placeholder for now which only creates a single color view. It can use the |web_view| to generate the image preview in the next step and will work for WebContents as well as App's.

So more work is necessary, this patch is mainly to get the overview mode working again when running out of memory (and avoiding that it gets too big).

Adding sky for the DEPS inclusion.

BUG=408837
TEST=unittests and visual
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/548633005

Cr-Commit-Position: refs/heads/master@{#294837}

- this-null.patch has landed upstream, remove the patch file
- msvs2013 has a stdint.h, so remove our downstream stdint.h copy in re2
- msvs2013 has va_copy, so don't define it locally

BUG=414049
NOTRY=true

Review URL: https://codereview.chromium.org/564293002

Cr-Commit-Position: refs/heads/master@{#294836}

The new utility function should be used instead of manually flushing the
blocking pool.

This CL replaces BlockingPool::FlushForTesting and RunLoop::RunUntilIdle()
wherever it was obvious. Along the way lint errors have been fixed.

TEST=Refactoring only. All current tests should pass.
BUG=392716

Review URL: https://codereview.chromium.org/409743003

Cr-Commit-Position: refs/heads/master@{#294835}

The Clone() method was added in https://codereview.chromium.org/6670033, but is no longer called anywhere. This CL removes that dead code.

BUG=384873

Review URL: https://codereview.chromium.org/546663003

Cr-Commit-Position: refs/heads/master@{#294834}

TBR=hellner@chromium.org

Review URL: https://codereview.chromium.org/571113002

Cr-Commit-Position: refs/heads/master@{#294833}

typedef std::vector<std::pair<std::string, std::string> > StringPairs;
And use iterator to iterate stl::vector element.

BUG=412250

Review URL: https://codereview.chromium.org/545193008

Cr-Commit-Position: refs/heads/master@{#294832}

internals page tab
This CL fixes that issue by always making sure that at the end
of each test, the current tab is changed from the password
internal page to the test page even if an exception is thrown.

BUG=413273

Review URL: https://codereview.chromium.org/562013003

Cr-Commit-Position: refs/heads/master@{#294831}

password manager python tests.
This cl changes the way how the saved passwords are removed.
before, they were removed from the the password manager
setting page. Now they are cleaned by going to the clean
history page, because the tests go already there to clean the
cookies.

BUG=413237

Review URL: https://codereview.chromium.org/561203002

Cr-Commit-Position: refs/heads/master@{#294830}

BUG=413370,402005

Review URL: https://codereview.chromium.org/557373002

Cr-Commit-Position: refs/heads/master@{#294829}

BUG=391005

Review URL: https://codereview.chromium.org/569173004

Cr-Commit-Position: refs/heads/master@{#294828}

https://chromium.googlesource.com/chromium/blink/+log/4f50841c49c5e333a874d1a06d9d4972b79e6896..1588dd41f3260c463323681a0d22a2180b6e6330
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/571093002

Cr-Commit-Position: refs/heads/master@{#294827}

getRawAcceptableDirectories method.

The use of PACKAGE_NAME variable is unnecessary which can be avoided, hence refactoring using passing context down till getRawAcceptableDirectories() and using getPackageName() method directly.

BUG=None.

Review URL: https://codereview.chromium.org/561743003

Cr-Commit-Position: refs/heads/master@{#294826}

TBR=mad@chromium.org
BUG=

Review URL: https://codereview.chromium.org/573733002

Cr-Commit-Position: refs/heads/master@{#294825}

https://codereview.chromium.org/511253003 added top control content offset
to LayerTreeHost and LayerTreeImpl but didn't sync the two properly on
startup, causing the top controls to hide on navigations. This patch makes
the initial value of the top controls such that the top controls are hidden
(and rely on the initial UpdateTopControlsState from the browser). At the
same time, it also changes LayerTreeImpl's offset to be the content offset,
rather than top controls offset, to match LayerTreeHost.

BUG=412918

Review URL: https://codereview.chromium.org/565673003

Cr-Commit-Position: refs/heads/master@{#294824}

cryptohome::RetrievedKeyData and cryptohome::KeyDefinition both represent
subsets of the Key protobuf. This CL merges the two classes and makes the
resulting cryptohome::KeyDefinition contain all of Key's fields.

TBR=pamg (manager_password_service.cc)

BUG=367847
TEST=Updated unit tests

Review URL: https://codereview.chromium.org/526353002

Cr-Commit-Position: refs/heads/master@{#294823}

Revert of Use a C++11 feature in a single file, to discover if this works everywhere. (patchset #5 id:70001 of https://codereview.chromium.org/443483002/)

Reason for revert:
Breaks Arm compile of Chrome on ChromeOS.

http://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%29/builds/1732

chromeos-chrome-39.0.2157.0_alpha-r1: In file included from threading/watchdog.cc:5:0:
chromeos-chrome-39.0.2157.0_alpha-r1: ../base/threading/watchdog.h:68:29: error: override controls (override/final) only available with -std=c++11 or -std=gnu++11 [-Werror]
chromeos-chrome-39.0.2157.0_alpha-r1:      virtual void ThreadMain() OVERRIDE;

Original issue's description:
> Use a C++11 feature in a single file, to discover if this works everywhere.
>
> Similar to https://codereview.chromium.org/385743002 , but in a file
> that's also built in host targets. Depends on r#294584.
>
> If your bot can't deal with this, please let me know!
>
> BUG=none
>
> Committed: https://crrev.com/5928c2f978a43488a2f45fe7da1d91dfdba1d593
> Cr-Commit-Position: refs/heads/master@{#294687}

TBR=ajwong@chromium.org,thakis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/570083002

Cr-Commit-Position: refs/heads/master@{#294822}

Propagate the user's supervised state to the ash system
so that it becomes available for views

https://chromereviews.googleplex.com/79527013/

BUG=394417

Review URL: https://codereview.chromium.org/561713002

Cr-Commit-Position: refs/heads/master@{#294821}

BUG=414268
TBR=jam@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/567413002

Cr-Commit-Position: refs/heads/master@{#294820}

Move ScreenOrientationProvider and ScreenOrientationDispatcherHost from content/browser/screen_orientation/ to content/public/browser/ to expose them to other libraries. This will allow Ash to use them to implement the ScreenOrientationProvider on Chrome OS. Created an implementation of ScreenOrientationDispatcherHost.
BUG=396760

Review URL: https://codereview.chromium.org/508603003

Cr-Commit-Position: refs/heads/master@{#294819}

BUG=none
R=
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/566063003

Cr-Commit-Position: refs/heads/master@{#294818}

https://skia.googlesource.com/skia/+log/e6cb48382db869f8e194b83aec80fd495be76db7..5087b2c06762d0ea8b471f63953a587ecafaae0f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/571063002

Cr-Commit-Position: refs/heads/master@{#294817}

Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (patchset #1 id:1 of https://codereview.chromium.org/554583003/)

Reason for revert:
It looks like the moto E perf bots are broken. This change looks like it makes sense so I'm reverting.

crbug.com/414267

Original issue's description:
> Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not have been created at this point.
>
> BUG=413481
>
> Committed: https://crrev.com/9bb65868ce3ac1e5aae3a844beacf62281c332b6
> Cr-Commit-Position: refs/heads/master@{#294703}

TBR=nduca@chromium.org,nednguyen@google.com,tonyg@chromium.org,chrishenry@google.com,wuhu@google.com
NOTREECHECKS=true
NOTRY=true
BUG=413481

Review URL: https://codereview.chromium.org/562243004

Cr-Commit-Position: refs/heads/master@{#294816}

TBR=yurys,dsinclair
BUG=409733,361045

Review URL: https://codereview.chromium.org/567383002

Cr-Commit-Position: refs/heads/master@{#294815}

Add visual feedback to AppListButton. The background will draw active in response to touch downs.

TEST=ShelfViewTest.AppListButtonTouchFeedback, ShelfViewTest.AppListButtonTouchFeedbackCancellation
BUG=398398

Review URL: https://codereview.chromium.org/558703002

Cr-Commit-Position: refs/heads/master@{#294814}

Paths of stripped libs in the device used to look like:

    /data/app-lib/*/*.so

But they now look like

    /data/app/*/.../*.so

This patch fixes this function, so that now its associated unittest
(the most time consuming one in telemetry) does not fail.

BUG=396367

Review URL: https://codereview.chromium.org/554283004

Cr-Commit-Position: refs/heads/master@{#294813}

Revert of Telemetry: Fix exact_matches in telemetry.test_runner. (patchset #4 id:60001 of https://codereview.chromium.org/560153004/)

Reason for revert:
Can't find the webrtc tests.

http://build.chromium.org/p/chromium.perf/builders/Win%207%20x64%20Perf%20%281%29/builds/2649

Original issue's description:
> Telemetry: Fix exact_matches in telemetry.test_runner.
>
> Previously, if exact_matches was True but there were no exact matches,
> it would return fuzzy matches instead. This is not what the caller asked
> for.
>
> GPU test names are changed to match the buildbot config, since they were
> previously relying on fuzzy matching.
>
> SHERIFFS: May cause errors like:
>
>   No test named "some_test_name".
>
>   Available tests are:
>     ...
>
> If so, this CL can be safely reverted.
>
> BUG=413334,413442
>
> Committed: https://crrev.com/566ed9f6e71cea313c88e8f259eca76581b72d67
> Cr-Commit-Position: refs/heads/master@{#294757}

TBR=nednguyen@google.com,ariblue@google.com,dtu@chromium.org,kbr@chromium.org,tonyg@chromium.org,jbroman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413334,413442

Review URL: https://codereview.chromium.org/555703005

Cr-Commit-Position: refs/heads/master@{#294812}

This CL changes the app list item drag zones to use the app icons as
folder creation zones and the space between icons as reorder zones.

The main difference from the previous implementation is that the space
between icons no longer is a drop zone of both adjacent tiles.

These new drag zones attempt to allow the user to move apps into the
gaps between icons which will then create a space for it by moving other
apps out of the way.

The non-folder drag has been unified with the folder drag, causing the
non-folder drag to lose the ability to drop onto the page switcher.

BUG=411775

Review URL: https://codereview.chromium.org/553753003

Cr-Commit-Position: refs/heads/master@{#294811}

BUG=398856
TEST=existing browser_tests and unit_tests
R=erg@chromium.org, jochen@chromium.org, nkostylev@chromium.org, pastarmovj@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/46a58bffbe303d3484d7cc288b47bfae5388109c

Committed: https://chromium.googlesource.com/chromium/src/+/40979bf265c3ffbe1736a87935418da72be5d1f1

Review URL: https://codereview.chromium.org/548323003

Cr-Commit-Position: refs/heads/master@{#294810}

Cr-Commit-Position: refs/heads/master@{#294809}