- 31 Jul, 2020 40 commits
-
-
Marc Treib authored
It was used by the UssMigrator which was deleted a few months ago. Bug: 1084499 Change-Id: I792e2493aed494229a0b0c6c3cdd34892630a2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332175 Commit-Queue: Rushan Suleymanov <rushans@google.com> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#793623}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/01ef15ed..2a2392d4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2fadaf3525edf01e4e9d8e6dceed16472c2f1831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331861Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793622}
-
adamta authored
Ensures that label and menu button don't surpass Discover feed cards in Bling NTP. Mulder team recommends hardcoding a value since they can't easily expose the card content width. Bug: 1109685, 1085419 Change-Id: I2458a48464625d58009317cef3e4fc4ffc3453df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325378 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#793621}
-
Matthias Körber authored
Disabled test due to a P1 flakiness bug. TBR: twellington@chromium.org Bug: 1111655 Change-Id: I772ff68d69dfc415cff8945ac8c514d4ad877a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332159Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#793620}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f6c424bb5923..4766bd88cf78 2020-07-31 fmayer@google.com Merge "Remove HeapGraph.type_names." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia869b98520c9b1b3e6b247fdfd7a0e4b22c4a74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332548Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793619}
-
Benjamin Beaudry authored
This change adds the containing block offset inside NGPhysicalOutOfFlowPositionedNode and NGLogicalOutOfFlowPositionedNode. This is part of the work for handling layout of positioned elements at the fragmentainer level rather than at the containing block level. A follow-up change will make use of this offset to compute where the layout of an OOF positioned node should start in a multicolumn context. Bug: 1079031 Change-Id: I2e3370a4ec0a4011203d0c3e916a64584aceaa2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321405 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#793618}
-
Jeffrey Young authored
Add new UMA Ash.Assistant.AnimationSmoothness.ResizeAssistantPageView to be used in animation smoothness tast tests. BUG=b:161888779,b:161700638 TEST=open launcher, press assistant key, view chrome://histograms TEST=press assistant key, search "weather" view chrome://histograms Change-Id: Idef3e07e9ca13ce34e26727d82fc05e1b6512a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314236 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#793617}
-
Michael Crouse authored
This is a reland of 57fd8da7 This improves the test that was flaking and disables it on ChromeOS for now. Bug filed to improve test reliability. Original change's description: > [LiteVideo] Observe MediaPlayer rebuffer events to stop throttling. > > This change adds plumbing to allow the LiteVideo optimization to > observe when rebuffer events occur so that all throttling can be > stopped. > > A future change will record the even in the user blocklist and > record the event in UKM. > > Bug: 1082554 > Change-Id: I9109fe221800b355e46c78e80254f75f433f9448 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316849 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: rajendrant <rajendrant@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793232} TBR=dalecurtis@chromium.org,tbansal@chromium.org Bug: 1082554 Change-Id: I8ead8df5c6e0046bc4d7f6c592307e66f5676762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330076 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#793616}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/74ee66401627..2146ce8055a5 $ git log 74ee66401..2146ce805 --date=short --no-merges --format='%ad %ae %s' 2020-07-30 wub Stop tracking http response size and latency from QuicConnectionStats. Not protected. 2020-07-30 fayang Internal QUICHE change 2020-07-30 dschinazi Introduce QUIC version T051 2020-07-30 renjietang Rename retransmission in QuicTransmissionInfo to first_sent_after_loss. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I29b23fae215c01ca61f52ff0ae07dcc0ab3ca1e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331290 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#793615}
-
Joey Arhar authored
Before this patch, the "today" button in the popup date picker for <input type=date> will be disabled if today's month is outside the range of any valid month, but if today's particular day of the month is not within the valid range of days, the button will be enabled rather than being disabled. This patch checks the day of the month in addition to the month when deciding to enable or disable the "today" button. Bug: 1105813 Change-Id: I25fdc0a5656bcfe42920db0410b30037b942b2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302911 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#793614}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7d627545cbb4..81bbd7199a2e 2020-07-31 terelius@webrtc.org Roll chromium_revision 88f89d7a..4d0815dc (793251:793545) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie0ec7a99c7de6ec0896517a3e74f7a4da01743a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332545Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793613}
-
Mugdha Lakhani authored
PrerenderManagerFactory will not move to components, PrerenderContents will. Remove the dependency of the former from the latter. Bug: 1096088 Change-Id: I712e44976122efca9d1e1343bf05d06ea16c81a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329537 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#793612}
-
Clark DuVall authored
This also fixes another related bug where the filename was incorrect in the notification being displayed on Q. The issue is that Q already has the location in the form of a content URI, so we can just use that directly. Bug: 1111448 Change-Id: I20485efab2a93abd439bd972d00bde908183aa2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330943Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#793611}
-
Matthias Körber authored
This CL adds the new tokens for addresses and validation statuses for more structured addresses and names to the AutofillProfileSpecifics. Change-Id: If1c05447703f08b65a203208953b314f5f35a256 Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321308 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#793610}
-
Olivier Robin authored
ExitReason requires iOS14 SDK. Do not test the values if compiled with iOS13 SDK. Change-Id: I2a9a2669cef2c80ffc131e16b2d22ddd8adec1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332696 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#793609}
-
Chris Hamilton authored
This merges the various token definitions to a single file for each of C++ definitions, Mojo definitions and Mojo traits. BUG=1096617 Change-Id: I2e2f1f95324ffd9ec95d44ffc26ca9f8f5b59565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330652Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#793608}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/06f2818574c9..03677716c86d 2020-07-31 alexrudenko@chromium.org Fix line name labels positioning 2020-07-31 janscheffler@chromium.org Migrate `front_end/cookies_table` to `devtools_entrypoint` 2020-07-31 janscheffler@chromium.org Migrate `front_end/snippets` to `devtools_entrypoint` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738,chromium:1106681 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id543108ab8979c50f2cf36966b9c73c0cf0bc79e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332541Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793607}
-
Renato Silva authored
LoginAuthUserView::SetAuthMethods has been misusing its AuthMethods enum to control the visibility of the pin pad on the lock/login screen. Change the code so that it properly uses AuthMethods to indicate if PIN authentication is possible and use an extra parameter to control the visibility of the pin pad. Bug: 1075994 Change-Id: I8f1a2eea009dc0d922f02bc9ced3f7005f773b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328860Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#793606}
-
Sean McAllister authored
This migrates is_linux (which is also set for chromeos) to explicitly include chromeos as is_linux || is_chromeos in preparation for separating those flags. Bug: 1110266 Change-Id: I2820ed1b76d5eed10947d5150a392551efef18c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326293 Commit-Queue: Sean McAllister <smcallis@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#793605}
-
Gauthier Ambard authored
This CL makes sure that the AUTOMATIC UserAgentType is restored in the WebState when the flag to have the AUTOMATIC UserAgent is enabled. In some cases (for example after updating the flag), the session is restored with the AUTOMATIC UserAgent, leading to a DCHECK. Bug: None Change-Id: Iceb9e8b2af25db987e80f07e9fbb2911d0c4f0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329709Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#793604}
-
Matt Mueller authored
The 10.15 test expectation for SSLUITest.SHA1IsDefaultDisabled has been fixed. Bug: 973650, 1108632 Change-Id: If10c88e4f12c9844dbbc0c28afd1ca9dce4af637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324803 Auto-Submit: Matt Mueller <mattm@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#793603}
-
Michael Thiessen authored
Bug: 1065377 Change-Id: Id51e30bb496513a30d639fc62537ffd525f10da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326450Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#793602}
-
Tim Volodine authored
Flaky on Marshmallow Tablet Tester. BUG=1111770 NOTRY=true TBR=fhorschig@chromium.org Change-Id: I7e4d763801e30badc42dd54e25f1a38dc8c1c864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332400Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#793601}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596171509-d368534e2598d7e86852dfa3435d6200fa4b1623.profdata to chrome-win32-master-1596185080-c872132dd1db16f5ff75ea8e09512987a9ceadc2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iec2d13f8173b385a7b63a44a3b965b7ca2cbd309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793600}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596174933-7cf492c3635c483cb828a9ec34bd05bd116669be.profdata to chrome-mac-master-1596193635-6128c4835e91dec9617eb88a5ffdf98aa76979d0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia34efd02c71b67b95d9e3033b400c7272a15d15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793599}
-
Peng Huang authored
The problem is because gpu_host_impl.cc includes some ozone headers for non onzon builds, but the build target doesn't depend on necessary ozone libraries for non ozone builds, so sometimes, generated mojom headers may not be ready when gpu_host_impl.cc is being compiled. Bug: 1111742 Change-Id: Iab47fa08f63fccaaf99f7c90a8bce7b221a9365c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332636Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#793598}
-
Viktor Semeniuk authored
Replaced [controller().tableView cellForRowAtIndexPath:indexOfPassword] with [controller() tableView:controller().tableView cellForRowAtIndexPath:indexOfPassword] Bug: 1111183 Change-Id: I1554377a9f149dfd2ece052a6dcc248141a5aa65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330013Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#793597}
-
Olivier Robin authored
Bug: 1111307 Change-Id: Ied4969e60772cf0574cd22c02c0e6688fd89acba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332438 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793596}
-
adamta authored
Adds 'Turn Off' and 'Turn On' actions in the header menu to hide/expand the Discover feed. Bug: 1085419 Change-Id: I786294df284d1fa82f4380c0bad112c042af7064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331076Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#793595}
-
Mugdha Lakhani authored
Removes the following chrome dependencies from PrerenderContents: ChromeNotificationTypes Profile WebContentsTags TabHelpers HistoryTabHelper The only dependencies left now are chrome/prerender ones which will move to components/prerender along with PrerenderContents. PrerenderContentsDelegate has been introduced to let the content embedder override PrerenderContents logic, and will also move to components/prerender eventually. Bug: 1096088 Change-Id: I3ca2e834624d16651ca5ff7a677ac5275df65f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319165 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#793594}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2ebb6ba9000e..fc8ba49c06f7 2020-07-31 jcgregorio@google.com Upgrade the version of CockroachDB we test against. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I31e41da319ea47db8f5945b2463fef23c1985a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332544Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793593}
-
Liviu Tinta authored
The study name is the same as the Finch experiment here: https://critique-ng.corp.google.com/cl/323787252 Bug: 1098467 Change-Id: I2649613121d33b3d40ba13df8b0b81f6cb1a3d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329993Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#793592}
-
Jonathan Ross authored
This reverts commit 5c8c9a69. Reason for revert: Two Vulkan angle_perftests have begun crashing consistently with this change in the blame range. Reverting to confirm if this is the cause. Otherwise there is also an Angle roll in the range. crbug.com/1111764 Original change's description: > vulkan: reuse gl semaphores > > For passthrough, with extension EGL_ANGLE_display_semaphore_share_group, > semaphores are shared globally. > For GLES2Decoder, all GL contexts are in the same shared group, so > semaphores are also shared globally. > So we can reused GL semaphores cross GL contexts. > > Bug: 1004772 > Change-Id: I1d23cdc991b2e99d6fe70fdd0560c97dafe73e7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319368 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793398} TBR=penghuang@chromium.org,backer@chromium.org,vasilyt@chromium.org Change-Id: I63953b02f7f06a6e77a3266e3fc4eadee2f882f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1004772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332677Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#793591}
-
Irina Fedorova authored
Bug: 377410 Change-Id: Id6bb117f757c37d153637301be89f01560513a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316203 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#793590}
-
Dylan Cutler authored
identifability study. We prefer using this pattern over casting the string to a sequence of bytes, and we can also delete the private method I added for the casting. Bug: 973801 Change-Id: Ida8b71addf1b473b4b9d5b33b0df9c89fa36a5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329912Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#793589}
-
Dan Elphick authored
Renderer Scheduler trace events now use the location of the TraceableState/TraceableCounter to generate the local ID instead of all using the address of the MainThreadSchedulerImpl. This is done by removing the object_ field from TraceableState/TraceableCounter and just using "this" to generate the ID. Change-Id: I33f126b23e1f4f149d939e08c09843b695a2073a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324121Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#793588}
-
Robbie Gibson authored
This CL migrates to use the new asynchronous clipboard APIs when determining which search menu items to show. To handle asynchronous updates to the popup has a few steps. First, the popup menu table view controller now updates its preferred content size when its items are reloaded. This allows the containing popup menu view controller to listen to this change through UIKit container methods. The popup view controller can then inform the popup menu presenter that the preferred content size of the content has changed. The presenter then updates the constraints for the menu itself. Bug: 1110849 Change-Id: I1c30ce46ab811b4e29379eddaf3babc489b1ed6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324383 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#793587}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ba362087..01ef15ed Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifa2e43876b5bdb99547365e42ec243df8a038348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331859Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793586}
-
Clemens Arbesser authored
This CL removes the direct dependency of service_impl on |client|. All relevant code has been moved into the new client_context. Allowing to inject the client_context in the constructor of service_impl allows the construction of services with empty client contexts. Most importantly, since service_impl no longer holds a reference to the client, it is enforced that it can't pull in any sensitive information. Bug: b/160859107 Change-Id: Ifba193bbe78f3f26feaa17e60e699f117586437d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326671 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#793585}
-
Nohemi Fernandez authored
Current sign-in test class names are inconsistent with existing code across Chrome iOS. Update these before proposing new APIs. Bug: 1103274 Change-Id: I5d8940d44f21ec047d6399087af44466231903c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330010 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#793584}
-