GitLab

This caused breakage because many places create a LabelButton then call SetBorder. By calling SetBorder whenever the NativeTheme changes, the custom border is overridden.

BUG=367614,367625,367607

Review URL: https://codereview.chromium.org/256103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266736 0039d316-1c4b-4281-b951-d872f2087c98

We create a new NaClSandbox class, with InitializeLayerOneSandbox() and
InitializeLayerTwoSandbox() methods.

This class centralizes existing code and adds important security checks as
to whether or not threads are running or directory file descriptors are open.

BUG=359230, 358719
R=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/250773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266735 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367788

Review URL: https://codereview.chromium.org/254743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266734 0039d316-1c4b-4281-b951-d872f2087c98

Also simplify the encoding/decoding code in the bindings generator.

Review URL: https://codereview.chromium.org/250253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266733 0039d316-1c4b-4281-b951-d872f2087c98

Allow notifications of unhandled taps via the GestureStateListener. This change
makes GestureTap events blocking, but there are several use-cases for which this
will be necessary, e.g., WebView and contextual search.

This was landed in r26143 and reverted in r261470 due to to a failure in
TouchEditableImplAuraTest.TouchCursorInTextfieldTest. The test has been fixed
and reviewed previously in crrev.com/218633008.

BUG=355154
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/256213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266732 0039d316-1c4b-4281-b951-d872f2087c98

This is added behind --apps-keep-chrome-alive.

When Chrome is quit, a notification is shown to let the user know that
Chrome will continue running.

The browser session should be shut down like on Windows, but that is
not yet implemented. Similarly, quitting all the apps should quit
Chrome. These will be added in followup CLs.

BUG=333429

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265889

Review URL: https://codereview.chromium.org/220373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266731 0039d316-1c4b-4281-b951-d872f2087c98

It is assumed that even though the buildbots have 32-bit userland,
they also have a 64-bit kernel and a 64-bit libc installed.

BUG=366523

Review URL: https://codereview.chromium.org/255023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266729 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/252683006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266728 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/232483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266727 0039d316-1c4b-4281-b951-d872f2087c98

The GPU broker policy was allocated in the main GPU process and then used in
the broker process. We switch the logic so that the broker policy is only ever
allocated in the broker process itself.

Besides fixing a small memory leak (in the GPU process), this makes sure that a
policy is only ever used in the process that allocated it. This will allow to
bind policies with properties such as "which processes does this policy allow
to send signal to".

BUG=367986
R=jorgelo@chromium.org

Review URL: https://codereview.chromium.org/251183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266726 0039d316-1c4b-4281-b951-d872f2087c98

It seems not to needed.

Review URL: https://codereview.chromium.org/250883007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266725 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364564

Review URL: https://codereview.chromium.org/242163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266723 0039d316-1c4b-4281-b951-d872f2087c98

The refactoring is done to accomodate a new callback to be introduced
in the next CL. In addition, the change improves the tests by:
* verifying the content of the downloaded file is correct.
* deleting the temporary file, which was left behind.

BUG=366388
TBR=waffles

Review URL: https://codereview.chromium.org/254793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266722 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366127

Review URL: https://codereview.chromium.org/246533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266721 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/259913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266720 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Adding test to ensure context restoration due to GC doesn't crash (https://codereview.chromium.org/251443006/)

Reason for revert:
The new test is failing on multiple GPU bots. Will add links and stack traces to Issue 365747.


Original issue's description:
> Adding test to ensure context restoration due to GC doesn't crash
> 
> BUG=365747
> R=kbr@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266696

TBR=bajones@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=365747

Review URL: https://codereview.chromium.org/258073007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266719 0039d316-1c4b-4281-b951-d872f2087c98

Check http://crbug.com/334204 for details

BUG=334204,367962
R=alokp@chromium.org, kbr@chromium.org

Review URL: https://codereview.chromium.org/251113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266716 0039d316-1c4b-4281-b951-d872f2087c98

1. Removed Google+ domains from the whitelist.
2. Chromecast extension ID is no longer hashed.
3. Deduped list of Chromecast extesions.

R=jiayl@chromium.org, mfoltz@chromium.org

Review URL: https://codereview.chromium.org/255553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266715 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/220023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266714 0039d316-1c4b-4281-b951-d872f2087c98

Re-land: Add perf tests for simd yuv->rgb conversion functions (https://codereview.chromium.org/238353008/).

Fixes missing FILE_PATH_LITERAL which broke the win64 build.

BUG=367676
TBR=scherkus

Review URL: https://codereview.chromium.org/258083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266713 0039d316-1c4b-4281-b951-d872f2087c98

BUG=363994

Review URL: https://codereview.chromium.org/251173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266712 0039d316-1c4b-4281-b951-d872f2087c98

Also includes some nits from jar@'s review of that CL.

BUG=329620

R=jar@chromium.org
R=mmenke@chromium.org

Review URL: https://codereview.chromium.org/248123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266711 0039d316-1c4b-4281-b951-d872f2087c98

When the document dimensions are initially set, the zoom should be initially
set to fit the document width. If the zoom is greater than 100%, it should be
set to 100% as per the current PDF plugin behavior.

BUG=303491
R=arv@chromium.org

Review URL: https://codereview.chromium.org/253423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266709 0039d316-1c4b-4281-b951-d872f2087c98

When saving a media file, we can reuse the WebContents::SaveFrame().

Review URL: https://codereview.chromium.org/260043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266708 0039d316-1c4b-4281-b951-d872f2087c98

presubmit tests.

BUG=356226

Review URL: https://codereview.chromium.org/250943009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266707 0039d316-1c4b-4281-b951-d872f2087c98

The latest Android NDK finally provides a timegm implementation.
No need to re-define in the compat layer anymore for 64-bit devices.

BUG=366054, 354405

Review URL: https://codereview.chromium.org/256103005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266706 0039d316-1c4b-4281-b951-d872f2087c98

Reformats how auth message is converted to string for logging, so it doesn't log binary data and prints on one line.

TESTED=chrome --vmodule="cast_auth*=1"
BUG=365452

Review URL: https://codereview.chromium.org/250713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266705 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266703 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=172770:172784&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/252973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266701 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266700 0039d316-1c4b-4281-b951-d872f2087c98

$ git log 4eeada947..b19319e0b --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-04-27 vadimsh Refactor retry loop in swarming 'collect'.
2014-04-26 vadimsh Make task names unique by default by appending timestamp to them.
2014-04-18 vadimsh Print list of shards that are still running while waiting in 'collect'.

R=maruel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/252023008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364409
TEST=Able to receive incomming connections via the chrome.bluetooth API.
R=keybuk@chromium.org, rpaquay@chromium.org

Review URL: https://codereview.chromium.org/243963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266698 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349645

Review URL: https://codereview.chromium.org/251023005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266697 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365747
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/251443006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266696 0039d316-1c4b-4281-b951-d872f2087c98

Move ImageCursors from ash/wm/ to ui/base/cursors/ and add a
NativeCursorManager implementation for
ShellDesktopController to use.

BUG=364290
TEST=cursor is visible when running app_shell on a Chrome OS
     device and changes after mousing over a link

Review URL: https://codereview.chromium.org/258893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266694 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239179

Review URL: https://codereview.chromium.org/252923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266693 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/253723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266692 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Breaks ash_unittests FullscreenWindow 

VideoDetectorTest.FullscreenWindow (run #1):
[ RUN      ] VideoDetectorTest.FullscreenWindow
[21122:21122:0428/162209:675210655:WARNING:cras_audio_handler.cc(472)] Audio input allowed by policy, sets input id=0x0 mute=false
[21122:21122:0428/162209:675210697:WARNING:cras_audio_handler.cc(508)] SetInputMuteInternal sets active input device id=0x0 mute=0
[21122:21122:0428/162209:675210737:WARNING:cras_audio_handler.cc(429)] SetupAudioInputState for active device id=0x2715 mute=0
[21122:21122:0428/162209:675210757:WARNING:cras_audio_handler.cc(508)] SetInputMuteInternal sets active input device id=0x2715 mute=0
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[21122:21122:0428/162209:675250984:FATAL:window_observer.cc(18)] Check failed: 0 == observing_ (0 vs. 1)

Original issue's description:
> Adds back some debugging code
> 
> We're getting another crash that looks like an observer is being
> destroyed before removing itself.
> 
> BUG=365364
> TEST=none
> R=flackr@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266681

TBR=flackr@chromium.org,sky@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=365364

Review URL: https://codereview.chromium.org/252963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266691 0039d316-1c4b-4281-b951-d872f2087c98

Specifically, when the bubble is in 'customize' mode, the UI to change
the setting of a permission (allow/deny) will be a drop-down menu rather
than a checkbox.

BUG=None

Review URL: https://codereview.chromium.org/242443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266689 0039d316-1c4b-4281-b951-d872f2087c98

The async readback case can be hard to follow with existing traces. Add an async
lifetime trace for each valid CopyOutputRequest, making clear both the lifetime
and frequency of such requests.

BUG=321624

Review URL: https://codereview.chromium.org/239183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266688 0039d316-1c4b-4281-b951-d872f2087c98