GitLab

Add a WidgetBase which will eventually be the owner of the compositing
machinery. For now it holds onto objects passed in from RenderWidget.

There was indirection of going via the WebWidgetClient to LayerTreeHost
indirectly. blink depends on cc and can call APIs on LayerTreeHost
so do just that.

See design doc:
https://docs.google.com/document/d/10uBnSWBaitGsaROOYO155Wb83rjOPtrgrGTrQ_pcssY/edit?ts=5e3b26f7

Change-Id: I1cd4119fc3275cfcfcf8c5806d82c1745efa4c14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015784
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742660}

Wanted to minimize the amount of manual change in the clang-format
patch itself.

Bug: 1053845
Change-Id: I893c61571967f50d2d8a141caf72ac953000d1d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063899
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742659}

This CL introduces
ToolbarColors#canUseIncognitoToolbarThemeColorInOverview() which
determines whether the incognito theme color can be used in overview
mode. The purpose is to share code between
AppThemeColorProvider#updateTheme() and
StatusBarColorController#calculateBaseStatusBarColor()

BUG=None

Change-Id: I671a40084f670655a39395fa365bb1b64d8fec52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063872Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742658}

This is a precursor CL to replace ExternalPopupMenu class by a
mojo connection, and replace blink::WebTextDirection with
base::i18n::TextDirection.

Bug: 1044268
Change-Id: Ie6bc0879b7afde81cb565afa513eacb270dab169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060208
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742657}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1c25d4b5c206..8e303f0eba46

git log 1c25d4b5c206..8e303f0eba46 --date=short --first-parent --format='%ad %ae %s'
2020-02-19 vapier@chromium.org scripts: convert more random programs to python3
2020-02-19 woodychow@google.com Retire eve-arcvm
2020-02-19 vapier@chromium.org scripts: convert a few scripts to python3 only
2020-02-18 vapier@chromium.org run_tests: detect more stale symlinks
2020-02-18 vapier@chromium.org Revert "cros_env_whitelist: relax Python 3 warning temporarily"
2020-02-18 ruiu@google.com Copy ARM32/ARM64 master images to gs://chromeos-arc-images/builds
2020-02-18 vapier@chromium.org cros lint: catch misuse of Params over Args
2020-02-18 vapier@chromium.org cbuildbot: delete old cbuildbot program
2020-02-18 morg@google.com Add eve-arc-r overlay to build config

Created with:
  gclient setdep -r src/third_party/chromite@8e303f0eba46

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I2f5623df9414c3bbae826ea802815162917cc7ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063682Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742656}

Code in //base/profiler is the primary driver of feature requirements
for ModuleCache, and ModuleCache needs to be further updated to allow
removing modules to support profiler use of the new V8 async unwinder
API. So move the code into that directory and have the sampling heap
profiler use it from there.

TBR=thestig@chromium.org,petermarshall@chromium.org,ssid@chromium.org

Bug: 1035855
Change-Id: I0151939fb1f193759c4beda3d3d336ee4df7fca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057157Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742655}

And fix or suppress a few issues that the msan bot found.

The components/download change is a real bug fix: If we compared N
bytes but the file is only M < N bytes long, we used to read M
bytes and then compare N - M bytes of uninit memory, and if we were
unlucky we could've had a false positive. (Unlikely, but possible.)

Bug: 523428
Change-Id: I01b4c9bf312160eceb81980c731ab301a927341b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062290
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742654}

This ensures that adding fields to Mojo structs which are not defined
within the struct's definition causes a compiler error.

Fixed: 1031385
Change-Id: I56cc509a192be882227763f47cec05ef6a8c5ad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006413
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#742653}

Right now, only the zoom in/out buttons adjust based on whether zooming
in or out would change anything. The reset button should adjust the
same way.

Bug: 1053977
Change-Id: I83903b4a55953e4984a61f9ba6b7eaa8858d95fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063134
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742652}

This reverts commit 0b25b17e.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 742520 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMGIyNWIxN2VkYThlMWY0YjRiN2MxMDI0ZmRjZWQ2Mjg0Nzc5Y2RlYQw

Sample Failed Build: https://ci.chromium.org/b/8888021964038070960

Sample Failed Step: content_browsertests

Sample Flaky Test: All/DumpAccessibilityTreeTest.DisplayLockingViewportActivation/blink

Original change's description:
> Reland "DL: Don't include skip-viewport-activation subtrees in the AX tree"
> 
> This is a reland of c08274e9
> 
> The CL was previously reverted because the viewport activation test is
> flaky, probably due to uncertain timing of near-the-viewport activation.
> I've updated the test to only test for in-the-viewport activation,
> I'll investigate further on why it's flaky for near-the-viewport
> (manual testing shows activation happens consistently).
> 
> SHERIFFS: please don't revert this CL if it introduces a new flaky test.
> Instead, please disable them and I'll investigate.
> 
> Original change's description:
> > DL: Don't include skip-viewport-activation subtrees in the AX tree
> >
> > Now both render-subtree: skip-viewport-activation and skip-activation
> > subtrees are not in the AX subtree at all, as discussed in
> > https://github.com/WICG/display-locking/issues/102#issuecomment-564205445
> >
> > Now only render-subtree:invisible subtrees are in the AX tree, and they
> > are automatically marked as offscreen because the nodes are activated
> > when they are on screen.
> >
> > Bug: 1001930
> > Change-Id: I1de511672f60078a02b3ddf3d989f2da1c44ae9d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028883
> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> > Reviewed-by: vmpstr <vmpstr@chromium.org>
> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> > Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#740531}
> 
> Bug: 1001930
> Change-Id: Icdf43cff86ade7e7e8f2aee76933dfc51e3f022c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054649
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742520}


Change-Id: I9258a82fa5a36921963dda0d12ce6efde1895e4b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1001930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063667
Cr-Commit-Position: refs/heads/master@{#742651}

This CL renames the class to allow creating a service with
the name PlatformKeysService from
chrome/browser/chromeos/platform_keys/platform_keys* files.
That will allow to mock functions from there and write unit
tests for a code that depends on them.

Bug: 1045895
Change-Id: I179c75aa1efc19acf5d6f10a06cf6ea62a11bf30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064211
Commit-Queue: Michael Ershov <miersh@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742650}

This reduces the byte size of TextureDrawQuad using 1 bit for booleans
members and 2 bits for an enum with 4 values.

Since QuadList uses the size of the biggest DrawQuad to allocate any
quad, this CL will reduce the memory used by QuadList, even if
TextureDrawQuads are not used.

Bug: None

Change-Id: Ic89e932a582c1a25e530d838e7d5a9f3c68d6462
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058835Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742649}

https://skia.googlesource.com/skia.git/+log/2e941d00c837..86b4388fdcb4

git log 2e941d00c837..86b4388fdcb4 --date=short --first-parent --format='%ad %ae %s'
2020-02-19 reed@google.com Revert "Support adding attributes to PDF document structure nodes."
2020-02-19 reed@google.com allow client to pass null if there are no uniforms
2020-02-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c8676d4ba37d..fa9eff37c38a (11 commits)
2020-02-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 0bbf7ba9f909..8def9063c4fd (2 commits)
2020-02-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 0f78b586..f5ddd865 (448 commits)
2020-02-19 reed@google.com Use careful_memcpy in case one of the args is null
2020-02-19 herb@google.com Move memory usage calculation to SkStrikeCache::Strike
2020-02-19 bsalomon@google.com GrBicubicEffect uses GrTextureEffect.
2020-02-18 mtklein@google.com remove -Wno-bad-function-cast
2020-02-18 mtklein@google.com turn on -Wreturn-std-move-in-c++11
2020-02-18 herb@google.com Have SkScalerCache return memory used
2020-02-18 brianosman@google.com Revert "allow client to pass null if there are no uniforms"
2020-02-18 brianosman@google.com Fix path to GN on Windows when running presubmit hooks
2020-02-18 robertphillips@google.com Store ProgramDesc on DDLs alongside the GrProgramInfo
2020-02-18 reed@google.com allow client to pass null if there are no uniforms
2020-02-18 robertphillips@google.com Make GrGLGpu's program cache be held as a unique_ptr
2020-02-18 jvanverth@google.com Start adding D3D backend
2020-02-18 brianosman@google.com Roll SPIRV-Cross to latest (2020-02-14)
2020-02-18 brianosman@google.com Revert "Move runtime shader/colorfilter into SkRuntimeEffect.cpp"
2020-02-18 brianosman@google.com Move runtime shader/colorfilter into SkRuntimeEffect.cpp
2020-02-18 reed@google.com add skotties to cube demo
2020-02-18 dmazzoni@chromium.org Support adding attributes to PDF document structure nodes.

Created with:
  gclient setdep -r src/third_party/skia@86b4388fdcb4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1039816
Tbr: lovisolo@google.com
Change-Id: Ic2cb56e97a0426243854c6ce4b8c8935be2e0064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063681Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742648}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b1227d53e69..2d44550a1bd9


Created with:
  gclient setdep -r src-internal@2d44550a1bd9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I6b796057d57046b7b3ab357625999350b0a386ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063679Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742647}

If WindowAndroid* is null when trying to display or update the bounds
of the popup, then there is no way/no reason to do it. Thus, the
display attempt is abandoned.

Bug: 1051031
Change-Id: I95f90b7240393d9f09de14e50917095694e8471b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061810Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742646}

ChromeFeatureList moved out of chrome/android. Now we can remove the dep.

Bug: 1022172
Change-Id: Ia107a48832bdf4784229d576a46c341090ae7b07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063774Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742645}

As IndexedDBContext is going to go away, remove this call.  This will
help move IndexedDB to storage service.  There's still some callers of
this in RenderProcessHostImpl and in StoragePartitionImpl, but these
will be removed only once IndexedDB is moved to the storage service
proper.

Bug: 1015214
Change-Id: If0ea7c7ab616a2ad86eed37bd66413e563bed1f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055847
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742644}

This reverts commit e8f078f3.

Reason for revert:
BeginWriteSkia() call is moved out of critical path. This change is not
necessary anymore. For code health revert it. 

Original change's description:
> Import GLFence in EndOverlayAccess for AHB
> 
> When using SurfaceControl after surface has been returned we need to
> wait until fence provided by system will be signaled. When using GL
> for compositing, this is implemented as importing provided file
> descriptor as egl fence and issue ServerWait().
> 
> GLRenderer does it when we get surface back. With SkiaRenderer it
> happens on next BeginWrite for the SharedImage. Import is expensive
> operation and BeginWrite is on critical path.
> 
> This CL moves import to EndOverlayAccess as we will do it anyway.
> Then at BeginWrite time we only issue ServerWait().
> 
> In local tests with scrolling simple page it saves 200us in
> DrawToSwapUs metric.
> 
> Change-Id: I6efb2783d0e287dc5e4fbb5707c507328e75a32f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019607
> Reviewed-by: Jonathan Backer <backer@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735577}

TBR=backer@chromium.org,kenrb@chromium.org,vasilyt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I20831d283c657d2f3245a454ed26b5a7529788ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057044Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742643}

Sample run:
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/4415

TBR=kyleju@chromium.org

No-Try: true
Bug: 856601
Change-Id: I84c5d046c4e925810aeef5774fe93a3efc6b08bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062284Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742642}

Password Manager tries local heuristics for detecting single username
forms, and whether users save or not usernames are good signal whether
heuristics were correct. But there is no username in the Android save
prompt which is different from Desktop UI. So users can't make
knowledgeable decision no fix the username if it's taken incorrect.

Bug: 1051913
Change-Id: I63d093b5a4890f8ab88c12a1ed2b79ebe000466a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053886
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742641}

The regression was caused by
https://chromium-review.googlesource.com/c/chromium/src/+/1963375
(recording histograms outside the ThreadPoolImpl::lock_ -- to avoid
entering tracing while holding this lock which can cause reentrancy
deadlocks when tracing itself posts tasks...).

R=fdoray@chromium.org

Bug: 1047733
Change-Id: I7dd401a28599de67eb9851265261fc384580d25d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062250Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742640}

This is a step towards better encapsulation, for shelf components to
manage their own layout.

Change-Id: Ic02334423e7477523151b4f5992105c7c5b0919f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058704Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742639}

Bug: 1052578: Add verbose logging to GCPW and move most messages under verbose.
Change-Id: I2bd51f2c59c0ca2487b5337abec81186784728be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058257Reviewed-by: Tien Mai <tienmai@chromium.org>
Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Commit-Queue: Emre Kanlikilicer <emreknlk@google.com>
Cr-Commit-Position: refs/heads/master@{#742638}

Bug: None
Change-Id: Ie67b4d30b3158e90d403219cbe5913021d09655c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062352
Commit-Queue: Aya Elsayed <ayaelattar@google.com>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742637}

https://chromium.googlesource.com/angle/angle.git/+log/fa9eff37c38a..90c9f66cc4cc

git log fa9eff37c38a..90c9f66cc4cc --date=short --first-parent --format='%ad %ae %s'
2020-02-19 cwallez@chromium.org Revert "Provide default implementation of rx::DisplayEGL"

Created with:
  gclient setdep -r src/third_party/angle@90c9f66cc4cc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I9ceee50bfc3a9fcb47efa572fb7d07711940b295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063962Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742636}

This reverts commit 4e60310e.

Reason for revert: [sheriff]
The tests are still flaky:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=ServiceProcessStateTest.ReadyState
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=ServiceProcessStateTest.ForceShutdown
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests

Original change's description:
> core: re-enable service process tests
> 
> Two of these were disabled as flaky several years ago.
> They have not flaked on my workstation in a few dozen runs,
> so let's speculatively re-enable them.
> 
> Bug: None
> Change-Id: Iea9a6953d71c5935a4b36f99d75bf81ae83eb464
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057286
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#741546}

TBR=ellyjones@chromium.org,thakis@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I0c7c550223562e6ce61a797ed51a3e6081fc5981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064249Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742635}

TBR=kyleju@chromium.org

No-Try: true
Bug: 856601
Change-Id: Ifb3b7137617e785e66af0c3864f082958205e2d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064175Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742634}

[sheriff] Disable LoginShelfViewTest.ClickShutdownButtonOnLockScreenWithVerticalInSessionShelf test as flaky

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ash_unittests&tests=ClickShutdownButtonOnLockScreenWithVerticalInSessionShelf
Sample run:
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3322

TBR=manucornet@chromium.org

Bug: 1053980
Change-Id: If67ea27a99c1940d122d2cceebf1389afc7e82de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062281Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742633}

GCC throws an error if noexcept is specified on declaration and
definition. Specifing on declaration is enough.

Bug: 819294
Change-Id: I89f03cf3ee73e63b3f711082315a67f93ccc9dbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059999Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742632}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ice5662baf9d84fc2940df8a391df8a9b744d2d1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063661Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742631}

Chromium now requires 10.10+, so weak-linking a framework that is
always available is not necessary.

Bug: 840435
Change-Id: I88bed9c971450441b79b961e3d08443acadc9644
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062928Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742630}

Bug: 778317
Change-Id: I4e61655092747c02a18faae294d836876e6015a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063211Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742629}

Bug: 710376
Change-Id: I27b03d27dec71f0f755be83c0de9d72167383fd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063531Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742628}

(This CL should not have any user-visible impact.)
Currently, ShowSuggestionPopup can fail and not show the popup.
Additionally, it also requires FillingData to show a popup which is not
necessarily correct for popups with the main purpose to display a button
to unlock account-stored credentials.

This CL ensures that ShowSuggestionPopup always shows the popup when
called by moving the failure conditions up.
By handling focused username elements early, it simplifies some cases.

Bug: 1052783
Change-Id: Ibe4ac9b8d23277325291e144f3db242a6c7774ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061254Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742627}

Removing an image decode from the queue should not also delete info
about which decode is currently in progress, since that causes the
queuing mechanism to think new requests should be sent for decoding.
This adversely affects flinging, because requests that had been queued
up (but are about to be deleted because the user has already flung past
them) would be sent for decoding when new entries are added.

This change also removes the Map of current requests, which may give
off the impression that we're switching from parallel to serial
decoding. However, that is not the case since it was serial to begin
with -- we currently only fire off one request at a time, so a Map is
not required to track what is in progress.

Bug: 1051925, 895776, 656015
Change-Id: Ieaef6d905148eb67d813de397d1582ca151aca79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054249Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742626}

BUG=none
R=zmin@chromium.org

Change-Id: Ifa45fb938240b0b4d277ce3bd32c19151140673c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063012
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742625}

Bug: 1053958
Change-Id: I07aeae7ebbd5259e030dfad7f1792b44a49b8fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063905Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742624}

This CL has two goals,
  1. Use To<GestureEvent> and DynamicTo<GestureEvent> as new
   downcast helper
  2. Use IsA<GestureEvent>(element) in place of
   IsGestureEvent(element)

Bug: 891908
Change-Id: Ie84f3f844be8687b57bba1a27083e08648f5f491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064163Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#742623}

In case when there are duplicate bookmark nodes and one of them was
created locally (and removed shortly) the removed node was trying to
access. Also some unit tests were added by the way.

Bug: 1050716
Change-Id: I6dc910f9002822cef45dfc4b4cb669eb472199ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057303
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742622}

This reverts commit 0fce13aa.

Reason for revert: It broke the chromium.webrtc bot (example: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Android%20Tests%20(dbg)%20(K%20Nexus5)/5712)

Original change's description:
> Update and enable CanSetupH264VideoCallOnSupportedDevice.
> 
> - Ensure that call actually uses H264 by checking codec type in
> video track stats.
> 
> - Enable CanSetupH264VideoCallOnSupportedDevice test.
> 
> Bug: webrtc:11244, 1047994
> Change-Id: I5ba241828500de9e465d5200e651640394d2ce6a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033511
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Commit-Queue: Sergey Silkin <ssilkin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742572}

TBR=hta@chromium.org,mcasas@chromium.org,guidou@chromium.org,ssilkin@chromium.org

Change-Id: I4ea3badad7ed564801a458263eb6366991f2924c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11244, 1047994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063135Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742621}