GitLab

Further, and hopefully the last step for refactoring needed for the feature.
 1) We need mime types on the task running time as well. Added a cycle for it.
 2) Split the task enumeration function for the placeholder for ARC stuff and
   post processing part.
 3) For the efficiency and clarity for the split of 2), changed std::vector
   value copying to movement by std::unique_ptr.

BUG=607059
TEST=unit_tests --gtest_filter='*FileManagerFileTask*'
TEST=browser_tests --gtest_filter='FileManagerJsTest.FileTasks'

Review-Url: https://codereview.chromium.org/1923953005
Cr-Commit-Position: refs/heads/master@{#390326}

R=
BUG=
NOTRY=true

Review-Url: https://codereview.chromium.org/1928743002
Cr-Commit-Position: refs/heads/master@{#390325}

This CL changes the behavior of METER element with -webkit-appearance:none.

Before this CL:
  -webkit-appearance:none had almost no effect because -webkit-appearance:meter
  has no theme painting.

After this CL:
  -webkit-appearance:none disables all of UA-provided rendering of METER elements.
  meter::-webkit-meter-* pseudo elements don't work, and web authors need to
  render METER elements by themselves.
  This behavior follows appearance:none defined by css-ui-4 [1].

Implementation:
Because we can't update METER Shadow DOM structure in response to CSS style
resolution, a METER has the following structure.

  METER
    #shadow-root
      MeterInnerElement pseudo=-webkit-meter-inner-element
        DIV pseudo=-webkit-meter-bar
         DIV pseudo=-webkit-meter-*-value
      MeterFallbackElement
        CONTENT

When the METER has -webkit-appearance:meter, MeterFallbackElement has display:
none. Otherwise, MeterInnerElement has display:none.

[1] https://www.w3.org/TR/css-ui-4/#appearance-switching

BUG=51182

Review-Url: https://codereview.chromium.org/1877763002
Cr-Commit-Position: refs/heads/master@{#390324}

This dummy class was accidentally re-introduced in PersistentNode.cpp during the
r389469 revert; remove it.

R=
BUG=

Review-Url: https://codereview.chromium.org/1925973002
Cr-Commit-Position: refs/heads/master@{#390323}

if a class does not have exposed attributes.

Currently, all script wrappable classes have definition of
installConditionallyEnabledProperties(), and all the definition
is an empty function.
Beside it, WrapperTypeInfo checks if the method exists and
calls it.

This CL removes such definition and replaces the function
pointers in WrapperTypeInfo with nullptrs to avoid calling
empty functions.

BUG=503508

Review-Url: https://codereview.chromium.org/1924763002
Cr-Commit-Position: refs/heads/master@{#390322}

This CL adds support in Blink and content/ for capturing
VideoFrames via ImageCapture.grabFrame() method.
For that, it adds a web/WebImageCaptureFrameGrabber
interface implemented in a new content class
ImageCaptureFrameGrabber.

In order to pass ImageBitmaps in WebCallbacks,
ImageBitmap gets a method take().

It also splits the current LayoutTests into extended
-creation.html and -grabFrame.html.

BUG=518807

TEST= run demo html in
https://cdn.rawgit.com/Miguelao/demos/master/imagecapture.html
with flag --enable-blink-features=ImageCapture
(click on "Open Camera 320x240", then on
"Create Image Capturer" and finally, repeatedly,
on "grabFrame").

Review-Url: https://codereview.chromium.org/1899403002
Cr-Commit-Position: refs/heads/master@{#390321}

Previously, the update job would use the script url provided when the
job was scheduled.

This change fixes the crash when the update job starts after the registration
has no versions, and also matches the spec.

BUG=604991

Review-Url: https://codereview.chromium.org/1928443003
Cr-Commit-Position: refs/heads/master@{#390320}

We are going to make WTF::bind() to depend less on ParamStorageTraits and
simplify ParamStorageTraits, for WTF::bind() refactoring and merging
WTF::bind() and base::Bind().
This CL removes uses of ParamStorageTraits from outside WTF::bind() to make
those activities easier.

BUG=597856

Review-Url: https://codereview.chromium.org/1920213002
Cr-Commit-Position: refs/heads/master@{#390319}

The file only contains one owner, who no longer works on this part of
chrome.

BUG=NONE

Review-Url: https://codereview.chromium.org/1925533005
Cr-Commit-Position: refs/heads/master@{#390318}

In some cases, we would navigate the main frame when going back/forward
in a subframe.  This was because the FTN ID had changed from what was
stored in the FrameNavigationEntry.  We now use the frame's unique name
for subframes and the position in the tree for main frames, as is done
in default Chrome (in HistoryController).

This also relaxes the restriction that a FrameNavigationEntry's item
and document sequence numbers don't change, at least until
https://crbug.com/596707 is fixed.

This is a second attempt, after r386756 caused issue 603245.

BUG=586324, 568768
TEST=See bug for repro steps.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1906213003
Cr-Commit-Position: refs/heads/master@{#390317}

Change the LayoutInline::linesBoundingBox method, and subclass overrides
in LayoutText and LayoutSVGInlineText, to return a LayoutRect instead of
an IntRect. Thereby exposing more correct and consistent offsetWidth and
offsetHeight values through the DOM. Move enclosing int logic to callers
as needed, particularly for PaintLayer, editing, and spatial navigation.

TEST=fast/sub-pixel/width-of-inline-in-float.html
BUG=414264
R=drott@chromium.org

Review-Url: https://codereview.chromium.org/1922223003
Cr-Commit-Position: refs/heads/master@{#390316}

In this CL, we implement the changes to the platform independent and BlueZ
specific class changes to support local GATT services. The major changes
from the code in trunk are,

.) Cleaning up of the classes and implementing all missing parts.
.) Adding code to properly take ownership of attributes of all three kinds.
.) Adding structure to the attributes to correctly setup the hierarchy
expected (services <-- characteristics <-- descriptors).
.) Addition of an AttributeDelegate to handle calls from DBus and wrappers
to translate them to the BluetoothLocalGattService::Delegate.
.) Cleanup in all the code touched.

Part 1 of a 3 patch series:
https://crrev.com/1915803002 Bluetooth class changes <<<
https://crrev.com/1914893002 DBus class changes
https://crrev.com/1919683002 Adapter changes + tests

R=ortuno@chromium.org, scheib@chromium.org
BUG=601935

Review-Url: https://codereview.chromium.org/1915803002
Cr-Commit-Position: refs/heads/master@{#390315}

BUG=606944

Review-Url: https://codereview.chromium.org/1917223004
Cr-Commit-Position: refs/heads/master@{#390314}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b86a9f9c..8e49b3ef

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/1932643002
Cr-Commit-Position: refs/heads/master@{#390313}

BUG=606097
TEST=Manually on device. Start OptIn workflow and pin
     (before pin disabled for ArcSupport window)  OptIn
     window into the shelf. Once OptIn workflow is done
     click on shelf icon. There is no more poping window.
TEST=Manually on device. No pin menu for Arc Support app.
TEST=unit_tests passes.

Review-Url: https://codereview.chromium.org/1919593003
Cr-Commit-Position: refs/heads/master@{#390312}

These classes all only depend upon ash/wm/common

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
TBR=reveman@chromium.org

Review-Url: https://codereview.chromium.org/1926913002
Cr-Commit-Position: refs/heads/master@{#390311}

For example the current entry id 51 from kGpuDriverBugListJson,
is never selected on Windows because gpu::ApplyGpuDriverBugWorkarounds
(from gpu_main.cc) is currently not called on Windows.
It is only called on chromeos, android and linux. On osx no problem since
no entry id relies on gl_renderer.

This CL also adds DriverBugWorkaroundsUponGLRendererPage to gpu_process_test.py

Also this CL adds a new base class DriverBugWorkaroundsTestsPage to factor
some common code.

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org

BUG=600741

TEST=./content/test/gpu/run_gpu_test.py gpu_process
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1860823004
Cr-Commit-Position: refs/heads/master@{#390310}

Targets that depend on serializing ui/gfx/geometry types over IPC
should not need to pull in other parts of ui/gfx (in particular skia-
dependent parts).

BUG=586390
TBR=jam@chromium.org for various build files in components/ and extensions/ and media/
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1924613002
Cr-Commit-Position: refs/heads/master@{#390309}

This patch implements CustomElement::IsValidName().

A valid custom element name is PotentialCustomElementName except all
hyphen-containing element names from the applicable specifications,
according to the spec below:
https://html.spec.whatwg.org/multipage/scripting.html#valid-custom-element-name

BUG=594918

Review-Url: https://codereview.chromium.org/1914383002
Cr-Commit-Position: refs/heads/master@{#390308}

This patch adds the Hyphenation class that abstracts hyphenation
dictionaries.

Actual implementation for each platform will be in following patches.

BUG=605840

Review-Url: https://codereview.chromium.org/1917423002
Cr-Commit-Position: refs/heads/master@{#390307}

This makes it easy to associate a LayoutAnalyzer event with other trace
events.

BUG=507790

Review-Url: https://codereview.chromium.org/1922823003
Cr-Commit-Position: refs/heads/master@{#390306}

BUG=None

Review-Url: https://codereview.chromium.org/1903103002
Cr-Commit-Position: refs/heads/master@{#390305}

* Use PointerWatcher to observe for clicks outside the widget bounds
* Add ScreenPositionClientMus to correctly transform the click locations

This changes the behavior of the system tray bubble on classic ash. Clicks
outside the bubble will now be handled (e.g. you can click outside the bubble
and start dragging a window). This is consistent with the menu behavior of
the hamburger menu and similar system tray bubbles on Windows. I've cleared
with PM kuscher@ that we want this behavior change.

Depends on https://codereview.chromium.org/1921673005/

BUG=599142
TEST=Run mash, click outside bubble, it closes. Ditto for ash. In both cases
you can start a window drag, click on a web page, etc. with the same click.

Review-Url: https://codereview.chromium.org/1918183003
Cr-Commit-Position: refs/heads/master@{#390304}

The runnable can run after the Activity has already died,
so be extra careful about getting rid of it.

* Let the ToolbarPhone know when the Activity is destroyed
  when the ToolbarManager gets destroyed.

* Keep track of the Handler and the Runnable that call
  #dismiss(), canceling it when necessary.

* Only let the Runnable dismiss the PopupWindow when it
  still thinks it is showing.

BUG=582539,607391

Review-Url: https://codereview.chromium.org/1932623002
Cr-Commit-Position: refs/heads/master@{#390303}

If the ShellConnection never made a valid connection, then the
WaitForIncomingMethodCall() returns false, but the ipc-endpoints
may not have encountered any errors [yet].

BUG=594600

Review-Url: https://codereview.chromium.org/1928733002
Cr-Commit-Position: refs/heads/master@{#390302}

BUG=601209
TBR=kojii@chromium.org

Review-Url: https://codereview.chromium.org/1930793002
Cr-Commit-Position: refs/heads/master@{#390301}

Precache listens for CONNECTIVITY_ACTION in ChromeTabbedActivity to
update the precache shared preference, and to schedule/cancel GCM task
for precache.

This is redundant since the same happens via DeferredStartupHandler::
onDeferredStartup

BUG=585263

Review-Url: https://codereview.chromium.org/1923443002
Cr-Commit-Position: refs/heads/master@{#390300}

This CL attempts to fix yet more places where run-webkit-tests
can crash when running tests on Android because we get confused
over whether the byte stream coming from the device is unicode
or not.

R=jbudorick@chromium.org, mgiuca@chromium.org, mithro@chromium.org, robertshield@chromium.org
BUG=598449

Review-Url: https://codereview.chromium.org/1930783002
Cr-Commit-Position: refs/heads/master@{#390299}

This is another attempt at flipping the first simplechrome bots to GN.

R=stevenjb@chromium.org
BUG=433082, 607362

Review-Url: https://codereview.chromium.org/1926963002
Cr-Commit-Position: refs/heads/master@{#390298}

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/1923983003
Cr-Commit-Position: refs/heads/master@{#390297}

The copy is an extra unnecessary allocation on every message read.

BUG=None

Review-Url: https://codereview.chromium.org/1923373004
Cr-Commit-Position: refs/heads/master@{#390296}

BUG=581865

Review-Url: https://codereview.chromium.org/1924743005
Cr-Commit-Position: refs/heads/master@{#390295}

Remove an out of date comment that no longer applies in SimpleFontData.

TBR=drott@chromium.org

Review-Url: https://codereview.chromium.org/1932593002
Cr-Commit-Position: refs/heads/master@{#390294}

Using update-w3c-deps in Blink 570d6f82.

Updated TestExpectations:

New failures:
crbug.com/505364 imported/csswg-test/css-scoping-1/css-scoping-shadow-slot-display-override.html

Missing expectations (reftests):
crbug.com/586413 imported/csswg-test/css-snap-size-1/snap-width-block-in-available-001.html
crbug.com/586413 imported/csswg-test/css-snap-size-1/snap-width-block-in-fixed-001.html
crbug.com/586413 imported/csswg-test/css-snap-size-1/snap-width-block-in-max-001.html
crbug.com/586413 imported/csswg-test/css-snap-size-1/snap-width-inline-in-available-001.html
crbug.com/586413 imported/csswg-test/css-snap-size-1/snap-width-inline-in-fixed-001.html
crbug.com/586413 imported/csswg-test/css-snap-size-1/snap-width-inline-in-max-001.html
crbug.com/586413 imported/csswg-test/css-snap-size-1/snap-width-table-in-available-001.html
crbug.com/586413 imported/csswg-test/css-snap-size-1/snap-width-table-in-fixed-001.html
crbug.com/586413 imported/csswg-test/css-snap-size-1/snap-width-table-in-max-001.html

New success:
crbug.com/582836 imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-font-face-01.html
crbug.com/582836 imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-font-face-02.html
crbug.com/492664 imported/csswg-test/css-writing-modes-3/text-orientation-script-001e.html
crbug.com/467127 imported/csswg-test/css-flexbox-1/getcomputedstyle/flexbox_computedstyle_flex-basis-percent.html
crbug.com/553838 imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-with-pseudo-elements-003.html

Removed tests:
crbug.com/553838 imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-table-fixup-001a.xhtml
crbug.com/553838 imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-table-fixup-001b.xhtml

BUG=467127, 492664, 505364, 553838, 586413, 582836

Review-Url: https://codereview.chromium.org/1922043004
Cr-Commit-Position: refs/heads/master@{#390293}

BUG=603384

Review-Url: https://codereview.chromium.org/1903103005
Cr-Commit-Position: refs/heads/master@{#390292}

BUG=580337

Review-Url: https://codereview.chromium.org/1924913002
Cr-Commit-Position: refs/heads/master@{#390291}

Mark estade@ as emeritus
Add dpapad@ and michaelpg@
Move achuith@ to login/signin-related stuff only

R=estade@chromium.org,michaelpg@chromium.org,dpapad@chromium.org,achuith@chromium.org
BUG=letting us touch the code

Review-Url: https://codereview.chromium.org/1931503003
Cr-Commit-Position: refs/heads/master@{#390290}

Add ShelfID to app_id mapping, to complement the inverse map.
(these are 1-to-1 mappings, but two maps eases usage)

Remove mappings when shelf items are removed.
Implement the ShelfDelegate interface mapping functions.

TODO: Add unit/shell testing of ShelfDelegateMus.

BUG=607271
TEST=|ShelfDelegaeMus::app_id_to_shelf_id_| shrinks as appropriate.
R=sadrul@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/1932503002
Cr-Commit-Position: refs/heads/master@{#390289}

This CL is a refactor and has no intended behavior change.

BUG=

Review-Url: https://codereview.chromium.org/1924963003
Cr-Commit-Position: refs/heads/master@{#390288}

Follow-up to https://codereview.chromium.org/1839193004.

Review-Url: https://codereview.chromium.org/1847353002
Cr-Commit-Position: refs/heads/master@{#390287}