- 26 Sep, 2018 40 commits
-
-
Kevin Marshall authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org TBR=sergeyu@chromium.org TBR=mmenke@chromium.org Change-Id: I470f7f3a9b10ed9c31b40b02e1f5a01a36ff25f4 Reviewed-on: https://chromium-review.googlesource.com/1246955 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#594479}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c6bd073ee01..5767fc042834 git log 6c6bd073ee01..5767fc042834 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 96a1ceb171cf..3d27f2e721ed (1 commits) 2018-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 82ea7fbce65f..0eb21d4ecadd (1 commits) 2018-09-26 mtklein@google.com refactor downsamplebitmap GM Created with: gclient setdep -r src/third_party/skia@5767fc042834 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I8193bbb55af0b0c38bcb8501b413a950b2110246 Reviewed-on: https://chromium-review.googlesource.com/1246835Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594478}
-
Pavel Feldman authored
This is a reland of 3321d814 Original change's description: > DevTools: allow addScriptToEvaluateOnNewDocument accept optional worldName parameter. > > Change-Id: Ic22c1bf38aaf8e5d3e7caabf3c686c8c45b985b0 > Reviewed-on: https://chromium-review.googlesource.com/1244460 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594161} Change-Id: I8a33e70976a2e52b7f69c5b2d0fa4e5af3594c6a Reviewed-on: https://chromium-review.googlesource.com/1246901Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594477}
-
chrome://discardsSigurdur Asgeirsson authored
Bug: 874968 Change-Id: I289e12b23e3bac144615ca5cfbe861e22404170a Reviewed-on: https://chromium-review.googlesource.com/1244497Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594476}
-
Chris Palmer authored
Bug: 888926 Change-Id: Iab0d82d272e2f24a5e91180d64bc8e2aa8a8238d Reviewed-on: https://chromium-review.googlesource.com/1246827Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#594475}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/74114507769e..74419b36e4b2 git log 74114507769e..74419b36e4b2 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 dgarrett@chromium.org chromeos_config: Mark eve/nocturne as important again. 2018-09-26 chrome-bot@chromium.org Update config settings by config-updater. 2018-09-26 dgarrett@google.com chromeos_config: Mark initial firmwarebranch builds active. 2018-09-26 dgarrett@google.com chromeos_config: Create firmwarebranch builders. Created with: gclient setdep -r src/third_party/chromite@74419b36e4b2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3d93c09b8e19bb4abecc0e7f350b6c8fb57209a6 Reviewed-on: https://chromium-review.googlesource.com/1246237Reviewed-by:
-
Sergey Ulanov authored
GN now supports string_replace(), which allows to remove namespace_path TBR=dcheng@chromium.org (trivial change in //base) Change-Id: Iac8a71b6962cf48bc7a79e2f7fc62a88969f80a1 Reviewed-on: https://chromium-review.googlesource.com/1246834 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Weidong Guo authored
Bug: 884889 Change-Id: If9c93d44de4693ded68e09947d8bee1fff00c471 Reviewed-on: https://chromium-review.googlesource.com/1246151 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#594472}
-
Shakti Sahu authored
This CL connects offline item with the download shelf. Some of the OfflineItemModel methods are still not implemented. Bug: 881499 Change-Id: I2f0cd71815a08bcddfca753378543749389d78db Reviewed-on: https://chromium-review.googlesource.com/1239875 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594471}
-
Kevin Marshall authored
This CL adds cookie support to the browser, so that the content layer can set and query cookies. * TestLauncher modified to give isolated /data directories to child processes. * Browsertests added to test cookie support in incognito/in-memory and persisted cases. Bug: 858853 Change-Id: Ia22e27778323e5b08fd872a2b29b4c7d879f80a0 Reviewed-on: https://chromium-review.googlesource.com/1168479Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#594470}
-
Jeffrey Kardatzke authored
Recently we updated all timeouts in cicerone to be longer because we were running into too many failures relating to timeouts and we should be much more lenient with that for now. We also avoid using the D-Bus default timeout now as well in here so the values are well known. BUG=chromium:849438 TEST=Builds Change-Id: I6fef4a25c1056d91fc4059146fa2a67094ad9a5d Reviewed-on: https://chromium-review.googlesource.com/1246784Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#594469}
-
Jordy Greenblatt authored
Note that there will be a separate CL with password page formatting because it requires some additional tweaks. Specs: https://drive.google.com/file/d/1UqHV67OrdGT0_G0L98nV5IVr26OkHu9F/view?usp=sharing New change screenshots: Start Setup Page: http://screen/1PkWGgTYmVG Setup Complete Page: http://screen/drwnruTOBNw Bug: 878646, 878644 Change-Id: Idf2afceb75dbb1c5b0157ffd8405fceea59cff46 Reviewed-on: https://chromium-review.googlesource.com/1246781Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#594468}
-
Bailey Berro authored
This change adds Start/ContinueReadDirectory methods to SmbProviderClient. These map 1:1 to corresponding smbprovider daemon methods. Bug: chromium:757625 Change-Id: Idb33b81492949b5499fb402686c211948d736f00 Reviewed-on: https://chromium-review.googlesource.com/1228438 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#594467}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b07993ebf420..bfcdc913c418 git log b07993ebf420..bfcdc913c418 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 antiagainst@google.com [ci] Checkout a specific Google Test commit (#1931) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@bfcdc913c418 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8cb0a648eb3496c3191c27a89892a961b60faf40 Reviewed-on: https://chromium-review.googlesource.com/1246478Reviewed-by:
-
Alexey Kozyatinskiy authored
Corresponded V8 change was rolled to Chromium. TBR=pfeldman@chromium.org Bug: v8:8200 Change-Id: If887514a6baa6fb293a8ed600a2ca0477debbcb7 Reviewed-on: https://chromium-review.googlesource.com/1246365Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#594465}
-
David Tseng authored
TBR=dtseng@chromium.org Change-Id: Ie4a1691308224d015856d93cbee256f6420a0b51 Reviewed-on: https://chromium-review.googlesource.com/1246663Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#594464}
-
Dominic Mazzoni authored
This call makes no sense. There's no reason that loading the speech synthesis component extension should trigger enabling the filesystem in guest mode for a related, but entirely different, extension (ChromeVox). If ChromeVox needs EnableFileSystemInGuestMode, we should be calling this from code that loads the ChromeVox component extension, but I suspect that it doesn't need it at all. As far as I can tell this was accidentally added here as part of a refactoring: https://codereview.chromium.org/1162283002 Note that OnceClosure() would be better, but that'd require a big cleanup of many other functions, so I don't want to do that as part of the same change. Bug: none Change-Id: I1f67b78548048fffa9194083b10e0ff5c5aaa863 Reviewed-on: https://chromium-review.googlesource.com/1246364Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#594463}
-
agrieve authored
Follow-up from original review. Change-Id: I375b2f266d3712f20efc769fc822df67701297a3 Reviewed-on: https://chromium-review.googlesource.com/1246836Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#594462}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a53f1444701..1b71de973c63 Created with: gclient setdep -r src-internal@1b71de973c63 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8b3480c33e076d89f23e5f059d998e31ea6c4b86 Reviewed-on: https://chromium-review.googlesource.com/1246474Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594461}
-
David Benjamin authored
It's the exact same code, but no sense in implementing it twice. Bug: none Change-Id: Ie3688b2d56c80b1d513fc5eab37b04aa365417ee Reviewed-on: https://chromium-review.googlesource.com/1246271Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#594460}
-
liberato@chromium.org authored
This CL adds a new flag, UseSurfaceLayerForVideoPIP, which will switch to SurfaceLayer only when entering PIP mode. The player does not switch back when exiting PIP. When doing this, the VideoFrameCompositor, VFS, etc. all run on the compositor impl thread rather than a dedicated media thread. This is to simplify the switchover. This CL also changes the default from Use...Video to Use...PIP. This is based on https://chromium-review.googlesource.com/c/chromium/src/+/1219948 Bug: 883931 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibb612d83df721712929aeab42aba790e32c1a8ea Reviewed-on: https://chromium-review.googlesource.com/1220562Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#594459}
-
Robert Sesek authored
Bug: 832676 Change-Id: Ife9b271854db2b4379d9df1869cc51eb9c2dbaa0 Reviewed-on: https://chromium-review.googlesource.com/1246722 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#594458}
-
rbpotter authored
This reverts commit 525b54bb. Reason for revert: Major changes to input behavior required, pushing to later milestone. Original change's description: > Print Preview Refresh: Make pages a dropdown > > Make pages a dropdown, and only show the custom input if "Custom" > page range is selected > > Bug: None > Change-Id: If29a941ca2ff9d75f08bc1e103ac3d0a836e540c > Reviewed-on: https://chromium-review.googlesource.com/1237241 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594076} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: Id2bbfedbf7ab5406a7a583c9acaf9fd5eeac930b No-Presubmit: true No-Tree-Checks: true No-Try: false Bug: 889382, 889383, 889389 Reviewed-on: https://chromium-review.googlesource.com/1246407Reviewed-by:
-
Joey Arhar authored
This patch adds two fields, _initiator and _priority, to each entry in each HAR file. I chose to use underscores in the exported names because they are not part of the HAR standard and the other non-standard fields we export also have underscores. I tested by importing this new type of HAR file in chrome 69, importing a chrome 69 HAR file with this new patch applied, and by exporting and importing with all types of initiators. Bug: 654536 Change-Id: Ibd96eb6374900f29b03880d3292933b539708f18 Reviewed-on: https://chromium-review.googlesource.com/1232374 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
-
Xida Chen authored
This CL removes an un-necessary included header file in the touch_action_filter.h, there is no behavior change. TBR=nzolghadr@chromium.org Bug: None Change-Id: Iebc8e3269cc96c101392a60f2717662a49b80f21 Reviewed-on: https://chromium-review.googlesource.com/1246410Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594455}
-
Majid Valipour authored
This reverts commit 701add99. Reason for revert: The tests introduced in original CL was failing because it was not being run with the right flags. This happened because CL landed at the same time as another CL which migrated all the tests. Moving test and updating expectations accordingly. https://chromium-review.googlesource.com/c/chromium/src/+/1237235 Original change's description: > Revert "[animation-worklet] Transfrom related worklet animations should respond to zoom" > > This reverts commit dec72e86. > > Reason for revert: > virtual/threaded/fast/animationworklet/worklet-animation-responsive-to-zoom.html seems to be failing most of the time on all platforms. > > Sample failures: > https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/91172 > https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/146546 > https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/193114 > > Original change's description: > > [animation-worklet] Transfrom related worklet animations should respond to zoom > > > > Worklet animation compositing state should be updated when a zoom or viewport > > resize changes css pixel to dip ratio. > > > > The fix is to simply match what we already do for regular animations for worklet > > animations. > > > > TEST=virtual/threaded/fast/animationworklet/worklet-animation-responsive-to-zoom.html > > > > Bug: 879107 > > Change-Id: I0b74bd8297e83b18afd087247f09339aedcc618b > > Reviewed-on: https://chromium-review.googlesource.com/1237133 > > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > > Reviewed-by: Majid Valipour <majidvp@chromium.org> > > Commit-Queue: Majid Valipour <majidvp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#593171} > > TBR=majidvp@chromium.org,smcgruer@chromium.org > > Change-Id: I9eaf621c931ad9003fd7413aeea9f2ec3a7824a4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 879107 > Reviewed-on: https://chromium-review.googlesource.com/1239773 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593414} TBR=mmenke@chromium.org,majidvp@chromium.org,smcgruer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 879107 Change-Id: Ib174c0e257c893d9cd5df3d1e6c5157b04603f44 Reviewed-on: https://chromium-review.googlesource.com/1243572Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#594454}
-
Kartik Hegde authored
Partners will frequently share debug logs to provide context when filing a bug or diagnosing a problem. Feedback reports have this information, but it's not stored in any of the files that are packaged up with debug logs. This commit follows the CL below, which makes debugd responsible for fetching the lsb release contents: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1217083 BUG=chromium:880851 TEST=Manually checked chrome://system to ensure that lsb release contents are present even after removing them from the chrome source. Also checked that chrome://system loads properly and with correct output when both debugd and chrome are reporting the lsb release contents. Change-Id: I4651c5168c26ac696d5799c44126e5dcd6b4ce19 Reviewed-on: https://chromium-review.googlesource.com/1217344Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Justin TerAvest <teravest@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#594453}
-
François Beaufort authored
This CL makes sure DetectedText interface is serializable so that DetectedText can easily be transfered from workers. Change-Id: Ic5ac034ae4f472c34ae75ec001cfda5af97cf6a9 Reviewed-on: https://chromium-review.googlesource.com/1243023 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#594452}
-
Simeon Anfinrud authored
This allows some Java code to be compiled on CQ that wasn't previously. Bug: None Test: build cast_shell_apk Change-Id: Icaa97f7fef8a805942355aac14634a270bff57e3 Reviewed-on: https://chromium-review.googlesource.com/1241847Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594451}
-
Chris Mumford authored
Relax redirect safety checks, which exist in the network service but were not present in URLRequestJob, to allow the loading of a file/filesystem scheme to redirect to the file/filesystem scheme. One example of a redirect is where the following URL: file:///path/to/directory during reload is redirected to: file:///path/to/directory/ This change also fixes redirects of Windows file links (with network service) as it redirects back to the client before following the redirect. This avoids an infinite recursion bug triggered by circular symbolic links. Bug: 884277,887039 Change-Id: I13923fc29397b1d3aa6679d861e9edc3af1c816b Reviewed-on: https://chromium-review.googlesource.com/1234335Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#594450}
-
Peter Kvitek authored
Changed ScriptDuration to exclude recalc style and layout durations. Introduced OtherTasksDuration metrics that tracks task time that is is not accounted for in other metrics. Change-Id: Id68d8eaaf4fa0264eeae7995d71632e71b212537 Reviewed-on: https://chromium-review.googlesource.com/1244245Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#594449}
-
Nico Weber authored
From what I can tell, we changed the translate UI on desktop from an infobar to a bubble; this transition is completed with macviews. Try to make this a bit more explicit in the code. Also rename SESSION_CRASHED_INFOBAR_DELEGATE_MAC_IOS to SESSION_CRASHED_INFOBAR_DELEGATE_IOS since it's no longer used on Mac, and remove a browser_test for it that was dead code. Bug: 832676 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id979dc996a49dabe5a073e53d1b3f60616316878 Reviewed-on: https://chromium-review.googlesource.com/1246024Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594448}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/03a36fd1b06d..6c6bd073ee01 git log 03a36fd1b06d..6c6bd073ee01 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 benjaminwagner@google.com Revert "[infra] Enable QuadroP400 bots on rack:2" 2018-09-26 robertphillips@google.com Fix bug in GM's DDL drawing mode Created with: gclient setdep -r src/third_party/skia@6c6bd073ee01 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I9c19b7d5763560ea168ad7ede72077b3729e173f Reviewed-on: https://chromium-review.googlesource.com/1246475Reviewed-by:
-
Adithya Srinivasan authored
This reverts commit 9594a943. Reason for revert: https://crrev.com/c/1217506 is causing crashes in Canary (https://crbug.com/889422). Reverting this CL is necessary in order to be able to revert that CL. Original change's description: > [FileSystem] Add support for selecting multiple files or directories. > > Bug: 878581 > Change-Id: I65fc0029da2e3951495a6cd96704085e5c1b942c > Reviewed-on: https://chromium-review.googlesource.com/1227366 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594132} TBR=dcheng@chromium.org,dmurph@chromium.org,mek@chromium.org Change-Id: I8af7db79f5156bc354ade87b2ac5e31955b41cc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878581 Reviewed-on: https://chromium-review.googlesource.com/1246862Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#594446}
-
Evan Stade authored
it's flaky. TBR=rsesek@chromium.org Bug: 888308 Change-Id: If250e1233fe58cc699358e879cbedc2ff797760c Reviewed-on: https://chromium-review.googlesource.com/1246829Reviewed-by:
-
Robert Sesek authored
A lot of c/b/u/cocoa/fullscreen is still used to implement views-mode fullscreen. Bug: 832676 Change-Id: I58ae4caff28d69c1be047c079b1ea95ae7a486e0 Reviewed-on: https://chromium-review.googlesource.com/1246601Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#594444}
-
Chris Sharp authored
Change-Id: Ie928765aba5e902396fa2272b56ed322386d8f29 Reviewed-on: https://chromium-review.googlesource.com/1241772Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#594443}
-
Camillo Bruni authored
Change-Id: Ic2248c098bf0f7c965ae09ebcbf552a0bebf430e Bug: 886965 Reviewed-on: https://chromium-review.googlesource.com/1245703 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#594442}
-
François Beaufort authored
This makes sure the MediaPlayerId of the Picture-in-Picture video is reset when user closes Picture-in-Picture window manually or when user requests Picture-in-Picture several times. Bug: 879592, 889011 Change-Id: I3ceea8de7fc5ee0e2c81268154daaa065b29b92b Reviewed-on: https://chromium-review.googlesource.com/1236276Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
http://crbug.com/866739 changed local Chromium builds to use a real "version name" instead of "Developer Build". WebAPKs determine whether a candidate host browser is WebAPK-compatible based on the host browser's version-name. This CL removes the special case logic for browsers with version-name "Developer Build". BUG=817263 Change-Id: I0b92e78adb2e57128ee958e8b12f61c196c6c874 Reviewed-on: https://chromium-review.googlesource.com/1244360Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#594440}
-
