- 14 Feb, 2020 40 commits
-
-
Colin Blundell authored
This CL implements the feedback from boliu@ that the Activity is more suitable than the ApplicationContext for launching external Intents. This change should also make it easier to add an integration test of launching external Intents in WebLayer. A couple notes on the implementation changes: - I explored various ways to change the API but ended up just passing the Java Tab from content_browser_client_impl.cc to the static Java method that implements intent launching. Given the fact that the content_browser_client_impl.cc callsite needs to interact with the JNIEnv object after making the call, this seemed like the most straightforward change. - It's debatable what action to take if the Activity is not available: bail out or use the ApplicationContext? In this CL I decided on the former; if we find any evidence that there are user flows for this use case we could change it to the latter. Bug: 1031465, 1029710 Change-Id: I23f3006422d47818e3873678fa936b3350cd4b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054864Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#741388}
-
Alice Wang authored
This CL added two signout and wipe data integration tests. This is a refactoring of the current SigninTest. Bug: 1038326 Change-Id: I50bffddc3fef8819e617d2b925d0b9f8733f7d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027410 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#741387}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I09c7ac3589b2d9f7c0b63a7f4f96a2682ff542e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056194 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#741386}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0618cbc98994..e7c4f9065168 git log 0618cbc98994..e7c4f9065168 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 phoglund@webrtc.org Add perf testers to mb_config.pyl. Created with: gclient setdep -r src/third_party/webrtc@e7c4f9065168 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I21e0118d7b3401dffab248ae3e4ca3b9c7ead752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056209Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741385}
-
Yingbing Wu authored
Change-Id: Iaa7137065146970f40d6c29ca27ad866424bd6fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054124 Commit-Queue: Yingbing Wu <wuyingbing@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#741384}
-
Kent Tamura authored
This CL introduces blink::SelectType, blink::MenuListSelectType, and blink::ListBoxSelectType. Also, add SelectType::DidSelectOption() to simplify HTMLSelectElement::SelectOption(). This CL has no behavior changes. Bug: 1052232 Change-Id: I436cfdd70edf0668b03996b35008ae12f8b6c9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055950Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#741383}
-
Takashi Toyoshima authored
Marks newly added failed tests as [ Failure ]. NOTRY = true TBR: nhiroki@chromium.org, yhirano@chromium.org, hiroshige@chromium.org Bug: 835821, 906850 Change-Id: I309b44ca418c4c8ebd68278390a0f1e628f86e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055914Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#741382}
-
Mikel Astiz authored
base::GenerateGUID() produces lower-case GUIDs and they should get exposed to the sync protocol exclusively in this canonical form to avoid running into issues. This patch replaces all occurrences in sync codebase with: git grep -l 'IsValidGUID' -- components/sync* | \ xargs sed -i 's/IsValidGUID/IsValidGUIDOutputString/g' In addition, the implicit GUIDs used for bookmark sync, in particular for permanent nodes, are updated to adopt lower-case GUIDs. These are never committed to the server so there are no backward-compatibility considerations. Change-Id: I0d0468f3475e1a27a161e2af15853c757f53e201 Bug: 978430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054154Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#741381}
-
Alex Danilo authored
Wraps the search button and input fields to allow them to be styled as a single larger container. Moves the #search-box styles out from main.html and moves them to file_manager.css and makes the selector a bit more specific. Bug: 992823 Change-Id: Ia2bfae92e3e51358d84b0aeb7c694bd564c0176a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054630 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741380}
-
Luciano Pacheco authored
Change NavigationListModel constructor to accept only FolderShortcutsDataModel in shortcutListModel argument because NavigationListModel uses methods specific to FolderShortcutsDataModel that aren't available on ArrayDataModel. Add method asFolderShortcutsDataModel() to MockFolderShortcutDataModel to type cast to FolderShortcutsDataModel to pass the mock to NavigationListModel. NOTE: Currently MockFolderShortcutDataModel doesn't implement the whole FolderShortcutsDataModel API, it rather implements the API needed by the tests. Fixes: 931481 Change-Id: Iac0c08dcb900fd2a16249baa6eb16c7d8c137a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056003 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Rachel Sugrono authored
Add feature flag to control the new gm2 styling for Quick View and the metadata box. No change in behavior, no tests. Change-Id: I3de3cd6ad9ff93b93cf8c77499e17a44c068f5a2 Bug: 992824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054629 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Alex Danilo authored
Bug: 992823 Change-Id: I7e112d7e113914b0ca8088bbe2843715ec12a2c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054469 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a175ef2c68a..ddad4c60aec3 git log 7a175ef2c68a..ddad4c60aec3 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 74ab0bffb526..d5861a68d9f7 (9 commits) Created with: gclient setdep -r src/third_party/skia@ddad4c60aec3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I8e32cd481c7a6741cacc15311203521c97f18bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056305Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 1419 1423 1426 1427 1429 1430 1433 30 lines were removed and 7 lines were deflaked by consecutive results since 1393. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I5cddb1096106180c0f89e63a6b6cf14c0b435715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054463Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "elementFromPoint.html" to call |getBoundingClientRect()| on <img> instead of <area> because all browsers returns different value for <area>, maybe size-less inline element, for improving robustness of test. Because test itself verifies |elementFromPoint()| instead of |getBoundingClientRect()|, this patch doesn't change testing Change-Id: I40fc2c6c9cef696dc5c9f3428913b2d73ffaf5f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054472 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4deaf25c..d2e26f01 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0f1f217c690bc4aeeaa700ff8de5235124acd7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055251Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741373}
-
shrekshao authored
They should be fixed as they are passing now after removing the suppressions. TBR=kbr@chromium.org Bug: 931016 Change-Id: I759adca3e15ba6b6f91cd3e968f63ebd195ce354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055343Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#741372}
-
Eric Willigers authored
The IFrameDynamicMixedContentInPWAReparentWebContentsIntoAppBrowser EXCPECTs mixed-content behavior that only occurs when the auto-upgrade flag is disabled. The ...WithAutoupgradesDisabled was accidentally omitted when moving the test from extensions/ to web_applications/ This caused the test to fail when the ForceWebRequestProxyForTest or NetworkServiceInProcess feature flags are enabled (as occurs in Network Service Linux bot runs. Bug: 1052230 Change-Id: Ibad555736525f3f60d9311914b8cd429518530fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054471Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#741371}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 46f6c9f2. With Chromium commits locally applied on WPT: acd8a467 "SharedWorker: Use CSP headers to outside settings" ec83d167 "Update performance.measureMemory to the latest proposal" ce4a5462 "[css-scroll-anchoring] Add WPT for zero scroll offset suppression." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I732e7d1db0d668fb6ab827e6bf24a61442f28063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055250Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741370}
-
Maksim Sisov authored
We used to be requesting a SkCanvas from the bitmap presenter and creating own SkSurface for that canvas despite the fact that X11BitmapSoftwarePresenter has already stored a SkSurface for that canvas. This resulted in a weird behaviour - frames were not presented. So, instead of doing that roundtrip and looking for solutions for creating a surface storage for that SkCanvas, change the SurfaceOzoneCanvas to return SkCanvas instead of SkSurface. This does not imply any behavioural changes. Bug: 1045347 Change-Id: I09442a6019b1c073f4b1b3407c529792cf74c984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017432 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#741369}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ead42e7cfb59..cd356bb63f57 Created with: gclient setdep -r src-internal@cd356bb63f57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8a7f7307835858022cda8d15d0364fe7718d6b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056304Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741368}
-
Hiroki Nakagawa authored
This CL renames data-url.html to data-url.any.js in order to run the tests on a dedicated worker. Previously these tests only ran on window. Bug: n/a Change-Id: I4be0cfdddc01fa4865763868c4947ea63e62d491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054656Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#741367}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/99254a9a1e17..32115a7d6f3d git log 99254a9a1e17..32115a7d6f3d --date=short --first-parent --format='%ad %ae %s' 2020-02-14 dberris@chromium.org Regenerate p-value bounds for performance tests Created with: gclient setdep -r src/third_party/catapult@32115a7d6f3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I3e025f854e07b27971bedd95de3fc36b2e5fdc1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056303Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/53c909e05f23..7a175ef2c68a git log 53c909e05f23..7a175ef2c68a --date=short --first-parent --format='%ad %ae %s' 2020-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 07e508f1..57a7afeb (388 commits) Created with: gclient setdep -r src/third_party/skia@7a175ef2c68a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: Iaf20b436398030a6164177454d3d994406e0bf00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056002Reviewed-by:
-
Maggie Cai authored
Currently when there is a redirect link open on in new tab (e.g. link from gmail, youtube sharing link), the get start URL gets empty URL and hence didn't trigger an app query. The reason is that we were using the SiteInstance's Site URL. This is no longer working in some cases due to the site isolation fixes. Change it to use initiator origin from the NavigationHandle. BUG=1048042 Change-Id: Ib264d35c31284826dabdfc65056fbc99d5fe9014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055908 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#741364}
-
Yury Semikhatsky authored
Target.setAutoAttach on the top level Target handler now allows attaching to all new pages. Top level TargetHandler will attach to each main frame as soon as it is created (right after sending targetCreated event). All subsequent navigations will be throttled until Runtime.runIfWaitingForDebugger is received. Experimental parameter 'windowOpen' is removed in favour of the new more generic functionality. Bug: 1051687 Change-Id: Ia9b58133b97999383cd44016f8d3041f71b5d3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042302 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Auto-Submit: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#741363}
-
Kuo-Hsin Yang authored
Utility process might be forked from zygote process, set proper OOM score adj in this case. Move oom score constants to content/public/common/content_constants.h. Bug: 1051360 Change-Id: Ia0750d5f7aafe10580acdcb5d88c717da131d569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051796Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#741362}
-
Eric Willigers authored
WebAppBrowserController::GetTitle() uses the web app's short name when the custom tab bar is being shown. .../extensions/hosted_app_browsertest.cc no longer contains any web app browser tests - they have all been moved to .../web_applications/... Previously landed as https://chromium-review.googlesource.com/c/chromium/src/+/2050286 and reverted due to a failure in another CL's mixed-content browser tests https://chromium-review.googlesource.com/c/chromium/src/+/2054628 Bug: 966290 Change-Id: Ifc3a1c305eeaf79d8d039bb9edf6c321a6a8738b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055909 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4f9608ca6afd..d5861a68d9f7 git log 4f9608ca6afd..d5861a68d9f7 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 ynovikov@chromium.org Fix ASAN errors in end2end tests. Created with: gclient setdep -r src/third_party/angle@d5861a68d9f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029378 Tbr: courtneygo@google.com Change-Id: I2f4ff3b0fb2718430b5c182a1cd4a8ee1a2e576e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056155Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6f95788326bb..b24890e5d8d3 git log 6f95788326bb..b24890e5d8d3 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@b24890e5d8d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iccc38cd953ecd84822dc8b4be56c7665907363d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055999Reviewed-by:
-
Jason Lin authored
... but empty username should still cause the install button to be disabled. Bug: 1016195 Change-Id: I14685367b280c833e389a777b6e1960bbf3fb978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054023 Auto-Submit: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#741358}
-
Nicholas Verne authored
Bug: 1024693 Change-Id: Ie2c40ad0c6050cf8d2be19ee50b7ea9e030b2d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055907Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#741357}
-
David Tseng authored
The ChromeVox sources are a little misleading because the js files are each pulled into separate page contexts: - background: the main background page that gets loaded on startup - learn mode: the page which interactively described pressed user input (keyboard, gestures, braille) - panel: the page contents displayed in the floating accessibility panel at the top of the screen - options: page contents of the options page Pulling in js between any two pages can lead to subtle errors. Re-organizing sources to reflect the above structure helps with future maintenance. Change-Id: I36b17856d831c03b67f05d9ee41c5e7a883ad3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055584 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#741356}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/abffb2887781..99254a9a1e17 git log abffb2887781..99254a9a1e17 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 abennetts@google.com Switch to using FILE_LOADS with dynamic destinations that resolve to individual partitions. Created with: gclient setdep -r src/third_party/catapult@99254a9a1e17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1019944 Tbr: skyostil@google.com Change-Id: I70c00363c2adcea73e1d0d48568d577de722398f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056001Reviewed-by:
-
Tim Song authored
This CL adds more hooks into MessageView and MessagePopupCollection to log when certain user actions occur, so we can log them. BUG=1050809 Change-Id: Ic2e23d0c8169e588d2d86556685f0e4549ed128c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045191 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#741354}
-
Wan-Teh Chang authored
The VideoFrame::IsValidConfig() call in FFmpegVideoDecoder::GetVideoBuffer() is no longer necessary. It is called by the frame_pool_.CreateFrame() call. The chain of calls is: VideoFramePool::CreateFrame() --> VideoFramePool::PoolImpl::CreateFrame() --> VideoFrame::CreateZeroInitializedFrame() --> VideoFrame::CreateFrameInternal() --> VideoFrame::CreateFrameWithLayout() --> VideoFrame::IsValidConfig() Bug: N/A Change-Id: Id597f6ef5eb2c144cbc6c7b2f97a1c751be67a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042928Reviewed-by:Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#741353}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Ibc44ae40f3050ef9d11205811f636d4529cf6444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054346Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#741352}
-
Yoshifumi Inoue authored
This patch changes |NGInlineBackwardCursor| in |MoveToNextSkippingChildren()| instead of "deprecated" function |MoveToNextSibling()| to reduce usage of it. Bug: 982194 Change-Id: I5d83abba1eeeeed2aa76c828ff46c0c0f3e1d6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050413 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following up r741013 <crrev.com/c/2053633>, this patch passes |NGInlineCursor|. This |NGInlineCursor| can be the source of all necessary operations when painting/hit-testing |LayoutInline|. Bug: 982194 Change-Id: I43bdb8354a3e63ad58b2f9334e19e43cda39eb6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053904Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#741350}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I7ceb70571b1ee8b6219707f51b642187894ae51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054623Reviewed-by:
-
