- 19 Dec, 2019 40 commits
-
-
Kunihiko Sakamoto authored
This disables the following tests failng on Win7 Tests (dbg)(1): - GlTestEnvironmentTest.InitializeAndCleanup - UiPixelTest.DrawVrBrowsingMode Bug: 1035767 Tbr: mthiesse@chromium.org Change-Id: Idfa12ccd58421cd79c9d46c57a8fad1d4e672954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975471Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726293}
-
Chih-Yu Huang authored
The Chromium smart pointer guidelines [1] says "don't pass or return a smart pointer by reference". This CL remove "const scoped_refptr<T>&" at VP8Decoder. [1] https://www.chromium.org/developers/smart-pointer-guidelines Bug: 1020668 Test: run vda_tests on kevin and octopus Change-Id: Ic22d3317c9f1f92dda76bba4c56c150883b1e7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974718Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726292}
-
Alan Cutter authored
ThemeService::UsingAutogeneratedTheme() was DCHECKing that the ThemeSupplier being autogenerated was 1:1 with having an autogenerated color pref. This is not the case for PWA windows which disables user themes. Bug: 1035187 Change-Id: Ide044833a9863e937645946b59cf221b0c4ab2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974715 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#726291}
-
Omar Morsi authored
This CL changes network interface reporting tests such that it is clear how should the device status collector behave in the default case in which the ReportDeviceNetworkInterfaces is set to false. Also, it makes it clear that if the network interfaces/states are reported then the ReportDeviceNetworkInterfaces policy should be set to true. Bug: None Test: browser_tests --gtest_filter=DeviceStatusCollectorNetwork* Change-Id: Iff8b6443d581a70e07cf4f3aefe19ab97f90ef9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970474Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#726290}
-
Kunihiko Sakamoto authored
This reverts commit 404028ee. Reason for revert: CHECK() added in this CL caused flaky crash in content_browsertests on Cast Linux: - RenderFrameHostImplBeforeUnloadBrowserTest.RendererInitiatedNavigationInABAB - SitePerProcessBrowserTest.Unload_ABAB Example build: https://ci.chromium.org/p/chromium/builders/ci/Cast%20Linux/85787 Original change's description: > Speculative fix for crash in occlusion hit test for viz hit test data > > If a frame is throttled, then it may have dirty layout by the time > PageAnimator::UpdateHitTestOcclusionData runs. There is no empirical > evidence that render throttling is actually causing the crashes in the > wild, so also add a diagnostic CHECK. > > BUG=1035029 > R=chrishtr@chromium.org > > Change-Id: Ie8d1aa5d48cf94832616403e27965722b809020b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972230 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Stefan Zager <szager@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726170} TBR=szager@chromium.org,chrishtr@chromium.org Change-Id: Ib1a399fc231ba7c2e4d7c2c3269360246eac2ad2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975493Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6423b7fc7ded..4b80fbc8f94a git log 6423b7fc7ded..4b80fbc8f94a --date=short --first-parent --format='%ad %ae %s' 2019-12-19 syoussefi@chromium.org Fix textureGatherOffsets classification Created with: gclient setdep -r src/third_party/angle@4b80fbc8f94a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Iff183d24807bf140174792f034dd141e7520de05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975358Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726288}
-
Patrick Monette authored
This change makes the dependency that the worker host has on its process host explicit. This has been true since the introduction of the SharedWorkerService::Observer interface. It also allows the removal of a few "if (RenderProcessHost::FromID())" checks and makes the lifetime of the worker host easier to reason about. Bug: 1035555 Change-Id: I53a6f5f5a5deade1feaed558dabcb379bb0d88cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965870 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#726287}
-
Rachel Sugrono authored
The transferHostedFileFromTeamDriveToDownloads was failing in step by step mode. This is because the destination was not set correctly when calling transferBetweenVolumes. Fix that, use downloads. Bug: 1035220 Change-Id: Id39080d30486503b0fe08a543595b04df75bc3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974711 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#726286}
-
nancy authored
BUG=1011235 Change-Id: Ia3d37e3d6943640659dce7df121869222ebee07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975387Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726285}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bf6cd36. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." fadf6027 "[css-pseudo] Recalculate viewport units in ::marker" 044ad8ad "[OT-PW] Make it work with OOP-R" 9899425d "[css-layout-api] IntrinsicSizes Implementation" 7d838af7 "[scroll-to-text-fragment] Apply :target CSS pseudo-class to match." 358ffa26 "[webnfc] Dispatch error events when failed to read a nfc tag" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If969400f52e05bb8e82983c0a07c8e7b9e02504f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975231Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726284}
-
Rachel Sugrono authored
The transferFromDownloadsToTeamDrivemyDriveContent was failing in step by step mode. This is because it was getting the source files from the wrong place. Change the test helper transferBetweenVolumes to read from the correct source. Bug: 1035220 Change-Id: Iec1ad334ee41b48a1d248dbaeb25d378342b9d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972737 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Noel Gordon authored
Some of our icon assets have fill color very close to #ddd; that's the default background color and so these icon are hard to see on the test page as a result. Make the background color lighter than #ddd. Bug: 1002393 Change-Id: Ie46bb88b1bec3bc3539054fba362bf0e3905dc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974295Reviewed-by:
-
Greg Thompson authored
BUG=546640 R=kinuko@chromium.org Change-Id: I65a0a90892069e4b226a9ce5bcda7dc1142c5694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972149 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#726281}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e9e4421eff0c..c76ac8e325c7 git log e9e4421eff0c..c76ac8e325c7 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 0827bfec..358ffa26 (433 commits) 2019-12-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 751e78884a55..6423b7fc7ded (6 commits) 2019-12-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 21be09d8e699..4fd7fccd6db5 (4 commits) Created with: gclient setdep -r src/third_party/skia@c76ac8e325c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Icda0834c4c2261cf7712221e5b723e941837ba80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975356Reviewed-by:
-
Yuke Liao authored
This CL does two things: 1. Fix the test suites of linux-code-coverage to match that of "Linux Tests". 2. Cleans up unneeded fuzzer bits. Bug: 1016929 Change-Id: I5cc2d1d9b1e5b71443ce917377fedaaee122b770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974617Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#726279}
-
Kuo Jen Wei authored
Fix bug that the declaration of exported compatible type is mis-deduced as arbitrary inferred type in ES6 module. Bug: 141518780 Test: Pass closure compiler test and manually type mutation test. Change-Id: I4718f2f7018921732fc785193e252f6eea48d1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975374 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#726278}
-
Hirokazu Honda authored
Bug: 1034415 Test: IPTest on atlas Change-Id: Ibc72b6b949501cd7147e5b45d49e4d31782b8210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975382Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#726277}
-
Kunihiko Sakamoto authored
Tbr: yangguo@chromium.org Notry: True Bug: 1034030 Change-Id: I629f2a6d5f105b2292a5a46e31e280a261f66236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974305Reviewed-by:
-
Hirokazu Honda authored
Bug: 1011281 Test: IPTest on atlas Change-Id: Ibbca4c02a28cf04cbfd3fa38769205b4f749dc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975380Reviewed-by:
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers components/security_interstitials/ Fixed: 1007729 Change-Id: I731834460dd34a8b2f2087608b52a5ee27111776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974813Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#726274}
-
Navid Zolghadr authored
https://docs.google.com/document/d/1AJ1XCtiYbaw64KhPX_a_TiNDOqeYV-MO30I1C-8VzPk/edit#heading=h.p9sgjwxtsd3c Change-Id: Ic3a1ae8c3cc4a0f473c3309e2ef0de47db40bf6f Bug: 1030176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974727Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#726273}
-
Gavin Williams authored
-My original CL(https://crrev.com/c/1829766) was reverted due to the bug mentioned here http:crbug/1012102. -New changes made in http://crbug/1023394 made it safe to reapply my original CL -I am applying these changes in this new CL because there were issues with merge conflicts in the reverted CL. Fixed: 1007235 Change-Id: I22b6608396238367cb2a7dd520d877c4ea78d767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967806Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#726272}
-
Ken Rockot authored
If a SerialConnection consumer calls StartPolling() and then eventually SetPaused(true), they should reasonably be able to assume that the callback given to StartPolling() will no longer fire. This changes SerialConnection::SetPaused() to ensure that any pending timeout task is cancelled when pausing, satisfying the above assumption where it was not previously satisfied. This should fix a memory bug in ViscaWebcam which has been causing crashes on Chrome OS. Fixed: 1028819 Change-Id: I54c233fbc90fc2996d624548326ccda624fc9383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974732Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#726271}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9bba4a936e85..cf788596f480 git log 9bba4a936e85..cf788596f480 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 enga@chromium.org fuzzing: Factor WireServer set up code out of frontend fuzzer Created with: gclient setdep -r src/third_party/dawn@cf788596f480 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I6db2a75d45ccfa272292285d0c73acadb0b338d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975353Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/04858b5b5e1f..763d35f18f56 Created with: gclient setdep -r src-internal@763d35f18f56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic6f72995e833b0055cfa8025db9d2b4c3c3e40cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975351Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726269}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c880346ba5d1..e9e4421eff0c git log c880346ba5d1..e9e4421eff0c --date=short --first-parent --format='%ad %ae %s' 2019-12-19 reed@google.com temporarily expose postIDiv 2019-12-19 jiancai@google.com Fix clang warnings 2019-12-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-18 reed@google.com hide/remove obsolete/tricky SkMatrix methods Created with: gclient setdep -r src/third_party/skia@e9e4421eff0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1035559 Tbr: borenet@google.com Change-Id: Ib71784469c284538ca8444cabe297af55b0da0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975350Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ibf3beee17555dbed4a4e3baa64eb7c402a5d5cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973890Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#726267}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bd51b1d1e98f..4b40870fb128 git log bd51b1d1e98f..4b40870fb128 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@4b40870fb128 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I79661eb8f29adb687543b194b5a245b03fcdf9ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974709Reviewed-by:
-
Yuzu Saijo authored
This CL intends to fix crash happening in ServiceWorkerVersion:: RestoreControlleeFromBackForwardCacheMap. The crash hit the check !base::Contains(controllee_map_, client_uuid), so it seems that the client exists in controlle_map_ when it is supposed to be in bfcached_controllee_map_. This could happen when a controllee was not controlled by a version and started to be controlled in bfcache. This change adds code to make sure that UpdateController checks bfcache status of the client. Bug: 1021718, 1034141 Change-Id: I1e054cfb43b4ce0e6df33fbbf0e1ec239faf1803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959238 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
-
James Cook authored
This subpage only exists in OS settings under apps, so move it into //chrome/browser/resources/settings/chromeos/os_apps_page/ Browser settings still needs to use AndroidAppsBrowserProxy for the protocol handlers page. Fixed: 1034722 Change-Id: Ia67bbb61ac847f0124ee5170c5c0ec2facae0b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974532 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#726264}
-
Miyoung Shin authored
This CL converts crostini_upgrader::mojom::PageHandlerFactory mojom interface clients for chrome os in chrome to use BrowserInterfaceBroker. Bug: 936482, 1002647 Change-Id: I9ccea33e088a8496f548a464e20bf2a29cde9cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969128 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#726263}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5c3e409cc4f9..104d95744f44 git log 5c3e409cc4f9..104d95744f44 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 dberris@chromium.org Fix graph refinement logic 2019-12-19 fancl@chromium.org Scale sheriff-config Created with: gclient setdep -r src/third_party/catapult@104d95744f44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1034393,chromium:953181 Tbr: sadrul@google.com Change-Id: If4a26e883441d1e53a4823056eaa99f59cdd5c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974708Reviewed-by:
-
Dana Fried authored
Want to not have to specifically stuff icons into a custom view. Splitting controller and container means we can use a default container implementation where we've been using it before, but also allow us to un-nest page action icons in the avatar button toolbar view to improve the quality of slide-out animations (which will be addressed in a follow-up CL). Follow-ups: - Flatten nested view structure in avatar toolbar button - Switch default container to use animating layout Bug: 1023528 Change-Id: Ia7259b6065b139fcb35ac154b81c3456a48838bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974650 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#726261}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/20432bf38dfe..6423b7fc7ded git log 20432bf38dfe..6423b7fc7ded --date=short --first-parent --format='%ad %ae %s' 2019-12-19 timvp@google.com Return the correct location count for Matrices Created with: gclient setdep -r src/third_party/angle@6423b7fc7ded If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I7e3f367f18a423f88d65ae9e2a6598eb5502f529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975166Reviewed-by:
-
Chih-Yu Huang authored
The Chromium smart pointer guidelines [1] says "don't pass or return a smart pointer by reference". This CL remove "const scoped_refptr<T>&" at DecodeSurfaceHandler. [1] https://www.chromium.org/developers/smart-pointer-guidelines Bug: 1020668 Test: run vda_tests on kevin and octopus Change-Id: I7fb98618147a1f9bceb0203b41faaa9ba58fa38c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974717Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1f0469da. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." fadf6027 "[css-pseudo] Recalculate viewport units in ::marker" 044ad8ad "[OT-PW] Make it work with OOP-R" 9899425d "[css-layout-api] IntrinsicSizes Implementation" 7d838af7 "[scroll-to-text-fragment] Apply :target CSS pseudo-class to match." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia9dc843c29362a892544f509dc58636eb508fe7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975230Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ieb26af4ed83ef1a33e084f08746289fc0595f90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975057Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726257}
-
John Lee authored
https://i.imgur.com/B5vHorB.png Bug: 1035675 Change-Id: I4c337f27077f9b01a6a4c23afa315b35f4ea2dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966693Reviewed-by:
-
Dominic Battre authored
We have added input::-internal-input-suggested, textarea::-internal-input-suggested { font: -webkit-small-control !important; } to html.css to prevent that the scrollWidth/scrollHeight attributes of an input element disclose information about autofill content that is in suggest (preview) state. This CL mocks out the scrollWidth/scrollHeight values in preview state and may allow us to disable the font overriding again. Bug: 1035058 Change-Id: I36a4a3498c240e15c7d72de1746f9697bb875e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972849 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#726255}
-
Rafael Cintron authored
"sanboxing" should be spelled "sandboxing". Change-Id: Iaa82f4bae962456b072268028fd1a578591b7f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975298Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#726254}
-
