GitLab

Enabling on trunk in preparation for the 100% Stable rollout. 1% Stable
experiment has concluded with positive metrics consistent with the Beta
experiment.

Bug: 799085, 737787
Change-Id: I656f55dd100ca97973e417c11bbb494f4e3c4fa9
Reviewed-on: https://chromium-review.googlesource.com/1055929Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558438}

A path can belong to multiple components, so totals entry shows
incorrect value.

R=mmoroz@chromium.org,liaoyuke@chromium.org

Bug: 842760
Change-Id: Ibbae86ed31a9d330ed02a6e7a24a5211634b2fc5
Reviewed-on: https://chromium-review.googlesource.com/1058167Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558437}

After running an Audit, the cached device is set to `null`, so after opening
DeviceMode (DM), the current device does not change.  The Rotate toolbar
button’s enabled state is only updated on emulated Device changed, so it
doesn’t get properly updated.

This CL properly updates the Rotate icon on emulation Type changes
(e.g. None > Responsive), not Device changes.

Bug: 829305
Change-Id: Ieac2a7d76e7f711409b5d1c0ca5a3da17a9672f5
Reviewed-on: https://chromium-review.googlesource.com/1058037Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558436}

Looking through the code, is_track_encrypted_ appears to only be set, and
never read. Since it appears unnecessary, removing it.

BUG=
TEST=compiles

Change-Id: I29c78326b6004755e31104faf40ff8a0fc36ca8a
Reviewed-on: https://chromium-review.googlesource.com/1056391Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558435}

Update the text of the tab switch button to latest UI recommendation,
and also noticed we weren't using the resource constant.

Bug: 780835
Change-Id: I43e685d7fff4ee7c62812a1a6a22a2914cf9b359
Reviewed-on: https://chromium-review.googlesource.com/1057698Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558434}

https://pdfium.googlesource.com/pdfium.git/+log/22c24441a3a4..77c223be193b

$ git log 22c24441a..77c223be1 --date=short --no-merges --format='%ad %ae %s'
2018-05-14 dsinclair Use internal wcstof instead of system wcstod in formcalc lexer
2018-05-14 tsepez Add regression test for XFA crash under CPDF_LinkList::GetPageLinks().
2018-05-14 hnakashima Cleanup unused members of CFWL_MonthCalendar.
2018-05-14 hnakashima Remove dead code from CFWL_WidgetMgr.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:813646,chromium:840922


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I663f89d69fd2fe4be1c05357226fec22db967113
Reviewed-on: https://chromium-review.googlesource.com/1058032
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558433}

This CL adds the extension at the Blink layer and in authenticator.mojom
and includes typeconverters and layout tests.

This will be used by cloud-assisted BLE, a protocol used by
the WebAuthN API to communicate with certain BLE devices without
explicit pairing.

Also, note that this extension is in early stages of standardization
and still being presented to the working group, so names and such will
likely change in future versions.

This is a low-risk feature - its functionality will be behind a flag,
and if a request is made with either the registration or authentication
extensions and the feature is disabled, then the request will proceed
normally as if the extension was not used at all.

Bug: 840153
Change-Id: I554452d5702511f77f47666a2abf35bf5bd9d99e
Reviewed-on: https://chromium-review.googlesource.com/1046110
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558432}

Bug: 834103
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4825a67e3716cca47c09b1510180c61079445dbd
Reviewed-on: https://chromium-review.googlesource.com/1056931Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558431}

Perftest logging on fuchsia is broken. The changed file
manages locating and initializing a log file, specialized
for each platform. Previously, the file failed to
initialize a log file, because there was no fuchsia
specific clause in the Initialize() function, and the
default assumptions don't work on Fuchsia. The OS_ANDROID
clause also works for Fuchsia, so this change adds
it to that code path.

Bug: 841574
Change-Id: I83f0d424ce9acbb28f904c08d4660f7f7661fa3a
Reviewed-on: https://chromium-review.googlesource.com/1053229
Commit-Queue: Stephan Stross <stephanstross@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558430}

Bug: 836303
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iecad80fe56c5cd92721a5ae5408e0cef3da22d36
Reviewed-on: https://chromium-review.googlesource.com/1055807
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558429}

Move the code into the last caller.

Change-Id: I1bac0758a60279ee0a4debcc18cb618c30bd5d46
Reviewed-on: https://chromium-review.googlesource.com/1056319Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558428}

https://boringssl.googlesource.com/boringssl/+log/8e75ae488047c519f14f2c08b02a55bf7712fa1d..69271b5d4fed328eb61b86b013937ce22549fee5

BUG=none

Change-Id: I76cae0fa5c940e6abfe3e1efc846d0f4003898e8
Reviewed-on: https://chromium-review.googlesource.com/1057426
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558427}

Bug: 842793
Change-Id: Ie52b2702453a8607824fb800c3708d4398e55f91

TBR=rdevlin.cronin@chromium.org

Change-Id: Ie52b2702453a8607824fb800c3708d4398e55f91
Reviewed-on: https://chromium-review.googlesource.com/1058013
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558426}

Currently users are able to edit their printer's network configuration
in ways that would make the printer unusable. This change makes it so
that network printers cannot have their protocol changed to a
non-network protocol. Also, USB printers do not allow any changes to
their URI.

BUG=chromium:841053
R=skau@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I74b6e50a09f1b61b7b63cf52f789a5d63d0d980d
Reviewed-on: https://chromium-review.googlesource.com/1053212
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558425}

This change adds username and password fields to the SMB Share Dialog to
enable users to connect to shares that require authentication.

Bug: chromium:757625
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7c0f825e27eb6df7fab1641942f0da92af7c0be3
Reviewed-on: https://chromium-review.googlesource.com/978461
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558424}

Flag an error if not in whitelist. Skip over rejected commands.

I used a fake (InProcCommandBuffer) instead of a mock
because it was too difficult to inject (e.g. if you use a fake
GrContext, you have to use fake GrBackendTexture, etc).

Bug: 836928
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7e3a996fb17491b755f0423d205b385c437f7509
Reviewed-on: https://chromium-review.googlesource.com/1057891
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558423}

Also adds support for empty buffer to VTVDA, since this feature is
supported on Windows.

Bug: 522298
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I15fcbee034b4be6c56d04b283931a7c4ea6b82ab
Reviewed-on: https://chromium-review.googlesource.com/1056322
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558422}

Part of ongoing effort to enable ChromeVox in
chromecast.  This CL brings in the extension schema
from chrome and adds relevant api features.

PS 1 is base for copied files.  PS 2+ modifications
on top of copied files.  Duplicate code will be
removed later (b/837773).

Bug: 73383411
Test: None
Change-Id: Iabf5d5905ff2565e72e4ec38311ff35633766fe6
Reviewed-on: https://chromium-review.googlesource.com/1052496
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558421}

There are devices that have problem with the new implementation of
DropdownPopupWindow on Android M. At this point, it looks to be too
late to find a proper solution that we can merge back to 67. Therefore,
I change the condition so that all devices < N use the old
implementation of DropdownPopupWindow based on ListPopupWindow.

Bug: 838736
Change-Id: Idfe1c00f609e1a911e09381401eff344131e28d0
Reviewed-on: https://chromium-review.googlesource.com/1055477Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558420}

Ahem font is designed specifically for tests. There are serveral
copies checked in in chromium. Putting it in third_party/test_fonts
will allow to deploy it for layout tests on all platforms same way
as other fonts.

I will remove AHEM_____.TTF later in a separate CL(s).

Bug: 787020, 778467
Change-Id: Id4bf45792c591ac1f0ac5ef94f7a1b95cef3b6f1
Reviewed-on: https://chromium-review.googlesource.com/1055811
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558419}

Android API Context.getExternalFilesDirs may return a null File object
when the user unmount the SD card at some point. This CL handles the
null object cleanly so it won't trigger NullPointerException.

TBR=nyquist@chromium.org

Bug: 838419
Change-Id: I0efc8c793e45383d49038688b9af4076eeb54328
Reviewed-on: https://chromium-review.googlesource.com/1056287Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558418}

The anonymous block inside LayoutMenuList had its ComputedStyle modified
in place. Instead, clone it for modification if necessary.

Also, optimized a bit by not modifying the style when the active option
text is modified if the option style does not change.

Bug: 813068
Change-Id: I25e6aca96e795c7c822dd62f03c946be480f3020
Reviewed-on: https://chromium-review.googlesource.com/1057328Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558417}

Enough of these tests are flaky on this bot that we should just use a
wildcard suppression. This bot is not expected to pass WebGL 2.0
conformance.

Bug: 756537
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I824d00e5f05bc42b119baa8089ef2cb81f0675a1
Tbr: rjkroege@chromium.org
Tbr: zmo@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1054360Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558416}

The current BrokerClient is not signal-safe because of its use of base::Pickle
which uses new and delete, and also its use of std::vector, which is not
technically signal safe either. These are used in messaging IPCs with the
BrokerHost when a syscall is trapped, thus BrokerClient must be made signal
safe. This is discussed in https://crbug.com/255063.

This CL creates a new BrokerSimpleMessage class to handle simple IPC messaging
with strings and ints only. It uses fixed sized messages to simplify logic and
allow it to allocate all its memory on the stack. It creates send, receive, and
a synchronous send-and-receive method. It also adds a basic set of unit tests
to sanity check behavior.

Bug: 255063
Change-Id: I8077a515921b62969a1b8b173d903f2a118ed186
Reviewed-on: https://chromium-review.googlesource.com/553400
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558415}

Gtk increases the reference count of the cairo_pattern_t before returning it to
clients, so this CL adds the appropriate call to cairo_pattern_destroy().

R=thestig

Change-Id: I540c635e15d086aa515c0b1bc3953c1008df5607
Reviewed-on: https://chromium-review.googlesource.com/1058031Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558414}

The method being tested requires a non-unique origin, so make sure the
dummy html is actually loaded with a valid security origin.

Bug: 104300
Change-Id: I9b8728d1c16f788bee08fb1c0dff5637a17dc942
Reviewed-on: https://chromium-review.googlesource.com/1057830Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558413}

Change-Id: Ic62a16887fb7e1028d961f3ba752ce9ad2fbe37e
Reviewed-on: https://chromium-review.googlesource.com/1054696
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558412}

Based on the discussion at:
https://chromium-review.googlesource.com/c/chromium/src/+/1050935/5/content/browser/network_service_client.cc
This CL changes the |is_main_frame| variable name to |is_request_for_main_frame|
to make it more clear. The variable indicates if the request (associated
with a frame) is the request for the frame itself or a subresource.

Bug: 783990
Change-Id: I0369efc027c27cac3c19a1ce48a0fba7a67809a0
Reviewed-on: https://chromium-review.googlesource.com/1056292Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558411}

Updates the styling of the NTP fakebox for GM2. Modifies
GetConfigData to allow the NTP to show/hide these updates
depending on the kNtpUIMd flag.

Bug: 837784
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I40a76820fc4a5f976166b64b74e5c7d73668cce4
Reviewed-on: https://chromium-review.googlesource.com/1042281
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558410}

Previously this code compared the current (possibly new) value of
css-animation-playstate to the value of blink::Animation::Paused()
to determine if it should toggle the paused state. This is incorrect;
if blink::Animation::pause() is called directly from JS these values
diverge by spec[0]. We only need to toggle the pause state from
CalculateAnimationUpdate if css-animation-playstate itself has changed.

Note that this incorrect behavior did not actually manifest in release
builds because of a no-DCHECK-only optimization; if is_animation_style_change
is set, we skip the entire state-update step and just calculate interpolations.

[0]: https://drafts.csswg.org/css-animations-2/#animation-play-state

Bug: 838594
Change-Id: I23a9eb0d338171c5a125b54ec4e29b916aceb3b0
Reviewed-on: https://chromium-review.googlesource.com/1053759Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558409}

This CL includes several minor changes to components/crash/ in
preparation for enabling Crashpad on Android.

- Use std::string instead of char* in GetProductNameAndVersion.
- Set LD_LIBRARY_PATH when building handler args for component builds.
- Update Android handler executable to libcrashpad_handler.so.
- Don't set a url parameter on Android to avoid Crashpad attempting to
  upload reports, which it doesn't yet support.
- Initialize CrashHandlerHost on the first call to GetDeathSignalSocket
  because CrashHandlerHost may be created before it can post tasks to
  the IO thread.

Bug: crashpad:30
Change-Id: I80efa0cf87cb4081773eaa516b1d6eb90fb6f5e8
Reviewed-on: https://chromium-review.googlesource.com/1056320
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558408}

CC=perezju@chromium.org
BUG=842731
NOTRY=true
TBR=eyaich@chromium.org

Change-Id: Idbc0a87a843c3647e1ad15d13a5429dda6e9d0cf
Reviewed-on: https://chromium-review.googlesource.com/1058068Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558407}

chrome::FindBrowserWithWebContents returns nullptr when the webcontents
opened in a views::WebView

Change-Id: I6465bbd83efe7cef23568ab8026c5eb96990e769
Reviewed-on: https://chromium-review.googlesource.com/1056547Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558406}

Part of ongoing effort to enable ChromeVox in
chromecast.  This CL brings in the chrome.i18n api
from chrome.

PS 1 is base for copied files.  PS 2+ modifications
on top of copied files.  Duplicate code will be
removed later (b/837773).

Bug: b/73383411
Test: None
Change-Id: I571edb830ed09d4c3866bb14649b472c550acd04
Reviewed-on: https://chromium-review.googlesource.com/1057354Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558405}

Bug: 817377
Change-Id: I4d290113a6cb00dda74f0906294665862d40ddb1
Reviewed-on: https://chromium-review.googlesource.com/1057696Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558404}

Any time the WebContents is removed from the TabStripModel and then destroyed,
JavaScriptDialogTabHelper would fail to deregister itself as an observer of the
TabStripModel. This would cause use after free.

Change-Id: I162f5f7c65b0b2848a922130cefc31348eeecc6e
Bug: 842545
Reviewed-on: https://chromium-review.googlesource.com/1057873
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558403}

This reverts commit de77cb76.

Reason for revert: https://crbug.com/842408 should now be fixed.

Original change's description:
> Revert "Reland "win: Link with lld instead of link.exe by default""
> 
> This reverts commit a25e3672.
> 
> Reason for revert: broke Windows tests using ANGLE's GL back-end.
> Breaks the CQ for graphics-related tests, and ANGLE's CQ.
> 
> example builds:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/1063
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20dEQP%20Release%20%28NVIDIA%29/3528
> 
> Original change's description:
> > Reland "win: Link with lld instead of link.exe by default"
> > 
> > The nacl browser_test failures on Win7 that caused the last revert are fixed.
> > There's a known bug about this regressing binary size (crbug.com/838449),
> > but with in-progress patches binary size will soon be 200 kB smaller and
> > these should all be rolled in by branch point, so let's reland this to find
> > more unknown unknowns.
> > 
> > Original change's description:
> > > win: Link with lld instead of MSVC's link.exe by default
> > >
> > > lld is LLVM's linker. It produces PE/COFF and PDB files just like
> > > link.exe, but it's significantly faster and it can also handle LLVM's
> > > internal representation, which will enable us to do link-time
> > > optimization and control-flow integraty checks with Clang.
> > >
> > > While lld is much faster at linking, it doesn't support incremental
> > > links, meaning builds that only touch a few files and re-link a large
> > > executable may become slower.
> > >
> > > This is the first attempt at switching everything over, with the
> > > purpose of gathering data and finding unknown unknowns. It's likely
> > > temporary until something breaks.
> > >
> > > is_win_fastlink is implicitly ignored when using lld, as lld without
> > > fastlink is faster than link.exe with it.
> > >
> > > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's
> > > link.exe to make sure that configuration keeps working.
> > >
> > > Bug: 792131
> > 
> > Change-Id: I18aba7a66c54c87092a13745f0ca213171ec25db
> > Reviewed-on: https://chromium-review.googlesource.com/1054521
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Reid Kleckner <rnk@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#557987}
> 
> TBR=thakis@chromium.org,rnk@chromium.org
> 
> Change-Id: Ida516adc6708c59407b817c8425c14bd3153d5b8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/1056327
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#558055}

TBR=thakis@chromium.org,rnk@chromium.org,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ided62bd7fb25d17d7a318539f41c308fb738797e
Reviewed-on: https://chromium-review.googlesource.com/1057767Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558402}

Methods marked as constexpr could b evaluated at compile time, but this need not be true at all call sites.
This implies that all their arguments could also be constexpr, either explicitly or implicitly.
One of the restrictions is that they should contain at most one return statement.

In AXNode, the methods I marked constexpr could never have been evaluated at compile time.
In this particular case, I was under the mistaken belief that constexpr would force the methods to be inline. But even though constexpr implies inline, it also has the added implications described above.

Thanks to Robert Sesek for the advice on when to use constexpr.

TBR=dmazzoni@chromium.org, rsesek@chromium.org

Change-Id: I58a6abb816bb7ae89f346ddb5ffea4d7d46395e4
Reviewed-on: https://chromium-review.googlesource.com/1055734Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558401}

Bug: 842729
Change-Id: I66e634c272f445ea2eb482722251a68fca0579bb

TBR=eyaich@

Change-Id: I66e634c272f445ea2eb482722251a68fca0579bb
Reviewed-on: https://chromium-review.googlesource.com/1057832
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558400}

Also adds validation against incoming server data, preventing
enabled features which are not in the supported feature set.

Bug: 824568, 752273
Change-Id: I70de90f5b104a2559e1c4e6350abcc7c002934bb
Reviewed-on: https://chromium-review.googlesource.com/1053373
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558399}