- 06 Sep, 2017 40 commits
-
-
Xida Chen authored
This CL reverts a previous CL here: https://chromium-review.googlesource.com/c/chromium/src/+/591913 The previous CL caused a regression on Mac. GL renderer has difficulties dealing with RPDQs converted from SolidColorDrawQuads, this CL will make mask layer produce solid quads. We need to keep it reverted before we fix the gl renderer bug. NOTRY=true Bug: 760807 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I844d02886329acbbbebd98200f8d2f90681adb8a Reviewed-on: https://chromium-review.googlesource.com/653317 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Reviewed-by:
Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#500036}
-
Scott Violet authored
The backend already does this for us, so there is no need to generate an additional event. BUG=755244 TEST=covered by tests Change-Id: I3755b628d24d2dd974ce62705e094ac63a57bd22 Reviewed-on: https://chromium-review.googlesource.com/653201Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#500035}
-
Sylvain Defresne authored
Introduce a new tab helper FormSuggestionTabHelper that owns FormSuggestionController and forward access to the public API of FormSuggestionController and change all code to use the FormSuggestionTabHelper instead of accessing it via Tab. Bug: 760556 Change-Id: I3e54734f8feb814a633d38bdd2959b40366ec544 Reviewed-on: https://chromium-review.googlesource.com/647591 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
mahmadi (Moe) <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#500034}
-
Yuri Wiitala authored
Simplified creation of requests and sending of results to support the effort to move tab/desktop capture into the VIZ component. The high- level philosophy here is for clients to get exactly the result type they ask for, matched to their use case. For example, one-off snapshots need scaled SkBitmaps that are immediately ready for use, while layer animations only need a texture reference to assign to an animated layer. Furthermore, clients should not be burdened with having to deal with ALL of the possible separate storage/access or ownership semantics that are specific to whichever DirectRenderer happened to generate the results. Summary of changes: CopyOutputRequest: 1) Removed pre-C++11-style CreateXYZ() methods in favor of a simple ctor. 2) Removed SendXYZ() methods in favor of a single SendResult() method that works with the new polymorphic CopyOutputResults. 3) Replaced CreateEmptyRequest() with CreateStubForTesting(), since non-test code should never create empty requests. 4) Add ResultFormat enum to allow clients to request exactly what they should get, rather than be burdened with coding for all possible result formats. CopyOutputResult: Common accessor API, but each DirectRenderer impl that executes copy requests can use their own subclass impl(s) to manage their own special result storage/access and ownership semantics and provide auto-format conversions where it makes sense. Updated mojo IDL, struct traits, client code, and unit tests to match the API changes. Bug: 754872, 758057, 644851, 759310 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia309e261a92e05a475a35732ba6df3497366478d Reviewed-on: https://chromium-review.googlesource.com/637003Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
ccameron chromium <ccameron@chromium.org> Reviewed-by:
Alexandre Elias <aelias@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#500033}
-
erikchen authored
There was some Windows specific code for passing around pipes that is no longer necessary now that out of process heap profiling is layered on Mojo and services. Bug: Change-Id: Id69ef914ca70eb7abd89a054af8045f8e42f934b Reviewed-on: https://chromium-review.googlesource.com/653298Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#500032}
-
chrome://profilerBrett Wilson authored
This removes the WebUI frontend for the task profiler. The underlying infrastructure will be removed in a separate pass. This saves about 30KB binary size. BUG=739505 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9d871e028168104496a0ab7f68aa45e428cba278 Reviewed-on: https://chromium-review.googlesource.com/650947 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#500031}
-
David Tseng authored
Bug: 751264, 751263, 751259, 745865 Change-Id: Ia354c13d609e80d0f068040f9888fd278e30c417 Reviewed-on: https://chromium-review.googlesource.com/639322 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#500030}
-
Sammie Quon authored
If we click the pin radio button but do not select a pin, on re-entering the lock screen page we should not highlight the pin radio button. Test: manual Bug: 760932 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic5a0e00a22cb58fa523c477be4be271a8760bbce Reviewed-on: https://chromium-review.googlesource.com/646274 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#500029}
-
Megan Jablonski authored
Bug: 762091 Change-Id: Ie26464c103d8884d4d82dee0457a39fff52dc58f Reviewed-on: https://chromium-review.googlesource.com/650946Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#500028}
-
John Mellor authored
Marks pending requests stored in the Service Worker UserData DB with a special "bgfetch_pending_request_" key. Unlike the other keys stored for Background Fetch, all of which are prefixed with the registration_id, these keys are prefixed with the registration creation timestamp, which will allow efficiently querying the Service Worker DB for only the oldest (highest priority in FIFO order) pending requests (querying will be implemented in a subsequent patch). A protobuf file is also created, which will be used for serializing and deserializing the values stored to the Service Worker DB (whose UserData feature only accepts std::strings). Bug: 757760 Change-Id: I0b07343f4ad8365e9480540d5415f0eaf290b7c5 Reviewed-on: https://chromium-review.googlesource.com/649607 Commit-Queue: John Mellor <johnme@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#500027}
-
Jiawei Shao authored
BUG=chromium:680797, chromium:737002 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9be5bbc30d214014a4e5e8a75d17560e4129493b Reviewed-on: https://chromium-review.googlesource.com/651007 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#500026}
-
Sergey Ulanov authored
Enabled HTTPS* tests on Fuchsia, since they should pass now. Updated unittests for OCSP, AIA and CRL set, since these features are not implemented in CertVerifyProcBuiltin. Bug: 731302, 762380 Change-Id: I5e4d3affe9783c502330d8784eb866a78ddd755e Reviewed-on: https://chromium-review.googlesource.com/651606 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#500025}
-
DanCraft99 authored
TBR=Dirk Pranke <dpranke@chromium.org> Bug: none Change-Id: If3ca236785e54346ad4ae388193dcaa543b9d815 Reviewed-on: https://chromium-review.googlesource.com/649586Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#500024}
-
Koji Ishii authored
This patch fixes to apply spacing offsets using the run direction rather than the direction of ShapeResult. LayoutNG does not use CachingWordShaper that ShapeResult can have mixed-direction runs. It turned out that offsets are very rare. I'm thinking to take this out of glyph loop to run loop, but it's not ready yet. For now, the loop is optimized for when offset is zero. Bug: 636993 Change-Id: I3dd63da4a2a6a162dc3038c646f6b35380afc13a Reviewed-on: https://chromium-review.googlesource.com/637435Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#500023}
-
Sigurdur Asgeirsson authored
f16e4eb9ffbf Implement SleepNanoseconds() on Windows b953388b9553 Add SystemSnapshotLinux ad1b86535c6a Roll mini_chromium to 068fe690218f 20ed4146d377 Use StringPiece for key and value in SimpleStringDictionary interface Bug: 758724 Change-Id: I0ef3d1a95dd2b2475a11256891beca32ab593fc5 Reviewed-on: https://chromium-review.googlesource.com/652669 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#500022}
-
MinChen authored
related functions. Changes, 1. Remove all the app list related functions in Shell, except the getter. 2. Updated the logic of Show() in AppListPresenterImpl. If we have multiple displays, show the app list in the second display when the app list is already opened in the first display should close the app list in the first display. This is used to keep the behavior consistency with AppListPresenterDelegate::OnGestureEvent, which will dismiss the app list when there is one ET_GESTURE_TAP, ET_GESTURE_TWO_FINGER_TAP or ET_GESTURE_LONG_PRESS be triggered. Bug: 759909 Test: ash_unittests Change-Id: Ic4750802ebbbaea604de5fd3ffc3909cd1e7b956 Reviewed-on: https://chromium-review.googlesource.com/644724 Commit-Queue: min c <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#500021}
-
erikchen authored
Prior to this CL, the allocator values used placeholder values to make the UI work. This CL plumbs through the correct values, and adds some additional metadata that will be used by telemetry. Bug: Change-Id: Id0890c41f3309d19aef579289a9aa854984f0dee Reviewed-on: https://chromium-review.googlesource.com/651187 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#500020}
-
Fady Samuel authored
We were using the last size stored instead of the latest size provided to set the primary SurfaceInfo which was causing surfaces to get clipped when --enable-surface-synchronization is used. Bug: 651108 Change-Id: I55de6e0ebd14fbd1151c34762a3e7c9085d68c09 Reviewed-on: https://chromium-review.googlesource.com/653041Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#500019}
-
Tarun Bansal authored
Add downlink throughput estimate (in Kbps) obtained from the Network Quality Estimator (NQE) to the UKM reports. Bug: 725146 Change-Id: Id8acd185db5f3e746d408ce9b008377d7c338a8e Reviewed-on: https://chromium-review.googlesource.com/648947Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#500018}
-
erikchen authored
This CL adds some logic to iterate through all processes, and then request dumps for each process. Some of these processes won't be profiling [e.g. utility processes, including the profiling process], but that case is gracefully handled by the profiling process. The alternative would be to track all "profiled" processes as they are created, and destroyed. This is possible using the BrowserChildProcessObserver and NotificationObserver interfaces, but this adds yet another cache that holds redundant information. Bug: 758437 Change-Id: I886d3a6c622320fd8a1ec59f6958193a7a32ef3e Reviewed-on: https://chromium-review.googlesource.com/650687Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#500017}
-
Chandan Padhi authored
This is another CL in the series for removal of StreamDeviceInfo. Bug: 760493 Change-Id: Ic0396260b1b25d5e4b75ba77cc3b8159834ec42e Reviewed-on: https://chromium-review.googlesource.com/650278Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#500016}
-
Becky Zhou authored
Bug: 761769 Change-Id: I9c0ac2e94d3cbecda0e84b2e294bcf665307d052 Reviewed-on: https://chromium-review.googlesource.com/653438Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#500015}
-
Helen Li authored
Net.QuicServerInfo.DiskCacheWaitForDataReadyTime code is removed in crrev.com/431dd445. This CL mark the histogram as deprecated. Bug: 707953 Change-Id: I43ed5f2556dfaa8924a4d6049c15c50669933149 Reviewed-on: https://chromium-review.googlesource.com/652963Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#500014}
-
Zinovy Nis authored
When NumLock is on, SendKeyPress* sends VKEY_NUMPAD* instead of VKEY_UP/DOWN/HOME/END/... due to incorrect VKEY->ScanCode mapping. It affects many tests, for example SSLClientCertificateSelectorMultiTabTest.SelectSecond and CeficateSelectorTest.GetSelectedCert. Both tests fail with NumLock turned ON and pass with OFF. Bug: chromium:760597 Change-Id: I047fb536390b9a385373f4f5e9202f6287923fcd Reviewed-on: https://chromium-review.googlesource.com/636963Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Zijie He <zijiehe@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#500013}
-
Xi Han authored
In this CL, we change the layout of the following dialog to match Chrome's UX styles: 1. Choose-host-browser dialog 2. Install-host-browser dialog 3. Offline dialog. This dialog is implemented in Chrome, so we use android.support.v7.app library and reuse Chrome's code. See screenshots: https://drive.google.com/open?id=0B7zEF5GgyYmpdHRpVHNJS3JEMTA See discussion in the implementation review: https://docs.google.com/presentation/d/1kS3bcBdcjb2wnKZ3qNaG2nHmRYyXcdRwA20Wq1sIexM/edit?ts=59a499cc#slide=id.g23d45e8a02_0_6 Bug: 759582 Change-Id: Ic3da89a8acaac7f967eeff3d7a725a4f6dc80b51 Reviewed-on: https://chromium-review.googlesource.com/641941 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#500012}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/59258564..7245c9da Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ibca1dfde2df7c9b88d4a228e45ff865be6862437 Reviewed-on: https://chromium-review.googlesource.com/652961Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#500011}
-
Anita Woodruff authored
- Previously only content settings provided by the PrefProvider were counted when calculating the number of sites that would be affected by clearing site settings. - This change means we also count settings provided by the NotificationChannelsAndroidProvider, because these settings will also be cleared. Bug: 762515 Change-Id: Ibc4265f7553a4ee6d79375fc292d5382eaa8376d Reviewed-on: https://chromium-review.googlesource.com/652807 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#500010}
-
Evan Stade authored
Bug: 761910 Change-Id: I1182e7651e75115d906990357d772439f9a4057d Reviewed-on: https://chromium-review.googlesource.com/653497Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#500009}
-
Jun Cai authored
This CL updates //third_party/WebKit/LayoutTests/device_orientation/motion to use testharness.js instead of js-test.js. Bug: 758628 Change-Id: I44d476cee1126a0c810e3dc2e217e7156e4a74d1 Reviewed-on: https://chromium-review.googlesource.com/644312Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#500008}
-
Fredrik Hubinette authored
Also add tests which loads many videos. Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7a745e57b2ed43011f414f4806827cc23915fb11 Reviewed-on: https://chromium-review.googlesource.com/646966Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#500007}
-
kristipark authored
The live update list layout test was using dumpCacheTree() to output the current cache storage list. However, dumpCacheTree() refreshes cache storage before dumping, causing the test to pass even if live update fails. Switched to use dumpCacheTreeNoRefresh(), which dumps the current tree without refreshing. Bug: None Change-Id: Ie34d6261362c3ae5b1584fdf163a0ca559c75787 Reviewed-on: https://chromium-review.googlesource.com/639916 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#500006}
-
Nico Weber authored
psyco was used by gyp_chromium back in the gyp days. cygwin hasn't been used in a few years as part of the build (and devs who want to use it locally probably install it themselves already). No intended behavior change. Bug: 123026 Change-Id: Ia3fe83c2d98af406f01853d7402302f6e1512e63 Reviewed-on: https://chromium-review.googlesource.com/651490Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#500005}
-
Matthew Jones authored
Chrome Home without Modern enabled still depends on the shadow drawable being a transition drawable. Since this is an extension of the layer drawable, it can safely be used for both Chrome Modern and non-Modern. BUG=762409 Change-Id: I4a2c406475dd9adac5a03e4b65334ab143963a1d Reviewed-on: https://chromium-review.googlesource.com/653078Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#500004}
-
Erik Chen authored
The callback was being run synchronously from a method in AllocationTracker, and potentially would destroy the AllocationTracker. Instead, we dispatch the callback back onto the same task runner. Bug: Change-Id: I0e710d7986c96b8502f95a4252e89e95fafcbd88 Reviewed-on: https://chromium-review.googlesource.com/648088Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#500003}
-
Per authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/488ab79..3fa5b7b $ git log 488ab79..3fa5b7b --date=short --no-merges --format=%ad %ae %s 2017-09-06 sprang@webrtc.org Fix FrameConfigs used for VP8 with four temporal layers. 2017-09-06 nisse@webrtc.org Reland of Use RtxReceiveStream. (patchset #1 id:1 of https://codereview.webrtc.org/3010983002/ ) 2017-09-06 danilchap@webrtc.org Update thread annotiation macros in rtc_base to use RTC_ prefix 2017-09-06 asapersson@webrtc.org vp8_impl.cc: Rename postproc field trial string for arm. 2017-09-06 eladalon@webrtc.org Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread ( https://codereview.webrtc.org/3007473002/ ) 2017-09-06 brandtr@webrtc.org Add ability to instantiate VideoEncoderSoftwareFallback in VP tests. 2017-09-06 nisse@webrtc.org Convert windows TaskQueue implementation to pimpl convention. 2017-09-06 danilchap@webrtc.org Add thread annotation macros with RTC_ prefix. Update samples unittests to use RTC_ versions. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Bug: Change-Id: I9e4e427c594effab9132e437c1cb8ce25dc59668 Reviewed-on: https://chromium-review.googlesource.com/653097Reviewed-by:
Per Kjellander <perkj@google.com> Commit-Queue: Per Kjellander <perkj@google.com> Cr-Commit-Position: refs/heads/master@{#500002}
-
Lutz Justen authored
Nullptr exception for auth_delegate_. The logs indicate that the devices are NOT in Active Directory management mode, so the crashing code should never be executed. We conclude that it is most likely due to webview events that are raised without the URL being set. To test this assumption, this CL adds a guard that rejects webview events before the Active Directory authentication page is shown and after onAuthSucceeded or onAuthFailed is fired. This guarantees that events are only sent while auth_delegate_ is valid. Moreover, the CL adds logs to verify the assumption that ActiveDirectoryAuthPage::setUrls is never called. In case the crashes still occur, the error_message from the onAuthFailed message is logged in order to track down the root cause. BUG=chromium:756144 TEST=Tested on AD-managed device Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie1f1cdc520b40c66aaae021f1758b96ed875c45b Reviewed-on: https://chromium-review.googlesource.com/620660Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#500001}
-
sczs authored
Removes all Tab dependencies on displaying the SadTab View. This is done by creating a SadTabLegacyCoordinator that encapsulates the SadTabView presentation. This coordinator is owned and created by BrowserViewController. Bug: Change-Id: Ic263f26af1ea81a293c05f0944d97e996ff7a6b2 Reviewed-on: https://chromium-review.googlesource.com/651756 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#500000}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5fccf9d8017a..38702ab43b28 $ git log 5fccf9d80..38702ab43 --date=short --no-merges --format='%ad %ae %s' 2017-09-05 caryclark possible fix for pathops timeout Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I00801c621cd4192f59c27d6741ea9b062a4c82b2 Reviewed-on: https://chromium-review.googlesource.com/652826Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#499999}
-
W. James MacLean authored
This is a temporary diagnostic measure to determine if, and why, RenderWidgetHostViewChildFrame is sometimes destructed without Destroy() being called. Bug: 762511 Change-Id: If6b77ab85b6aeb35e784943d7437b05d75fa0168 Reviewed-on: https://chromium-review.googlesource.com/652351Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#499998}
-
erikchen authored
The HTTP cache was observed to exceed its expected bounds of 1 GB. This CL adds temporary instrumentation to assess the frequency and magnitude of this occurence. The instrumentation is only run for 0.1% of NetworkContexts. Bug: 711579 Change-Id: Idcfc9f9df1305c9414fe3be97ca0d93ce9353315 Reviewed-on: https://chromium-review.googlesource.com/644391 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#499997}
-