GitLab

R=ronghuawu@chromium.org
BUG=82385

Review URL: https://codereview.chromium.org/292063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273990 0039d316-1c4b-4281-b951-d872f2087c98

This workaround is not needed anymore. The WindowAndroid should now
outlive all WebContents. This was also not consistent since there
are still many other call sites in the code that assume WindowAndroid
is always valid (see ContentViewCoreImpl).

BUG=324341
TBR=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/303293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273989 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72369

Review URL: https://codereview.chromium.org/309663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273988 0039d316-1c4b-4281-b951-d872f2087c98

Move all of our unittests from ui_unittests to ozone_unittests.

BUG=none
TEST=ozone_unittests

Review URL: https://codereview.chromium.org/304633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273987 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow-up patch for r273755.

BUG=368495
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/304183008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273986 0039d316-1c4b-4281-b951-d872f2087c98

On Android, we'd like to know how much data downloaded when app
is in foreground and background.

The changes adds an API for application to notify protocol manager
about status changes.

BUG=376029

Review URL: https://codereview.chromium.org/303233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273985 0039d316-1c4b-4281-b951-d872f2087c98

Don't restart the browser between each tested page in
rasterize_and_record_micro. This improves stability and -- somewhat
surprisingly -- reduces noise in the results. As an added bonus the
rasterize_and_record_micro.key_silk_cases test completes in about 9 min
compared to an earlier 16 min.

To measure the impact of the change I ran 18 rasterize_and_record_micro
iterations for 19 pages in key_silk_cases on a Nexus 5 (strapped to a
water bottle for cooling) and logged the per-page record_time results
for each run. The results were:

With browser restarts (baseline):
- Average record time: 1.78 ms
- Average record time standard deviation: 0.0978

Without browser restarts (patch):
- Average record time: 1.63 ms
- Average record time standard deviation: 0.0379

BUG=355952

Review URL: https://codereview.chromium.org/306923007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273984 0039d316-1c4b-4281-b951-d872f2087c98

Previously no_new_prevs mode was used when starting CRD host from NM. This
prevents sudo from working properly. r273785 fixed similar problem for the
code that launched NM binaries within chrome.

BUG=378012
R=lambroslambrou@chromium.org

Review URL: https://codereview.chromium.org/302083007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273983 0039d316-1c4b-4281-b951-d872f2087c98

Refactors ExternalInstallUI to have determinate lifetimes.
This is likely the first of multiple patches targeting this area of code; the
next one will concentrate on pulling the related logic out of ExtensionService.

BUG=378042

Review URL: https://codereview.chromium.org/300853008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273982 0039d316-1c4b-4281-b951-d872f2087c98

This patch is a cleanup patch that uses the delayed unique notifier
to schedule smoothness takes priority mode expiration. This is done
instead of manually managing the expiration.

R=reveman

Review URL: https://codereview.chromium.org/307023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273981 0039d316-1c4b-4281-b951-d872f2087c98

WebRtcRtpDumpHandler implements RTP header dump creation. It's owned by WebRtcLoggingHandlerHost and receives RTP packet callbacks through P2PSocketHost.

WebRtcRtpDumpWriter is owned by WebRtcDumpHandler and writes the RTP header into a memory buffer. When the in-memory buffer is full, it compresses the data and writes it to the disk.

After the dumping is stopped, WebRtcLoggingHandlerHost calls ReleaseDump to get the completed dump as a .gz file and uploads it.


BUG=363459

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273745

Review URL: https://codereview.chromium.org/264793017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273980 0039d316-1c4b-4281-b951-d872f2087c98

Since these tests keep the entire CrOS part of Memory.FYI red,
disabling for memcheck.

BUG=379140
NOTRY=true
R=thestig@chromium.org
TBR=sque@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/305283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273979 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/308763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273978 0039d316-1c4b-4281-b951-d872f2087c98

implementation thereof for desktop platforms. It also provides a stub
Android implementation, to be fleshed out in subsequent patches.

BUG=350384
TEST=existing tests
TBR=pavely@chromium.org for updates to invalidation tests

Review URL: https://codereview.chromium.org/278493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273977 0039d316-1c4b-4281-b951-d872f2087c98

nacl_os_qualify.h is no longer #included.  The other directories don't
exist any more.

BUG=none
TEST=run checkdeps.py
R=teravest@chromium.org

Review URL: https://codereview.chromium.org/306123006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273976 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378462

Review URL: https://codereview.chromium.org/301353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273975 0039d316-1c4b-4281-b951-d872f2087c98

This moves additional tests to content_browsertests. I keep these migrations
relatively small so I don't have to debug much if something fails.

Additionally, this change adds test coverage for NaCl for MessageLoop testing,
and restores testing for MessageLoop_Post.

BUG=371873

Review URL: https://codereview.chromium.org/303313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137973,374151,377420

Review URL: https://codereview.chromium.org/308733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273973 0039d316-1c4b-4281-b951-d872f2087c98

Replace the old CWP collection scheme with a new scheme:
- Divide post-login time into four-hour intervals.
- Randomly select a time in each interval to collect a perf profile. The
  probability distribution should be even across that interval.
- Use the new SampledProfile protobuf to store the collected data.

Note that since this patch still collects only perf data, the module
perf_provider_chromeos is not renamed to reflect something more generic.
We would like to introduce other types of data collection in the future
but they may be in other modules, or we may create a new generic module
for data collection.

BUG=chromium:358778
TEST=The interval is too long to directly test. Shorten it to something
on the order of a minute and rebuild and deploy Chrome. Should be getting
some profile collections.
I added some logging to print the collected data size. It's around 12 kB,
and I get the same size data from running quipper manually:
quipper 2 `which perf` record -a -e cycles -c 1000003 > /usr/local/perf.proto
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/282093011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273971 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376420
TEST=Set taskbar to autohide, start a copy of Chrome that will open maximized, ensure you can move your mouse to the screen edge to show the taskbar

Review URL: https://codereview.chromium.org/302113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273970 0039d316-1c4b-4281-b951-d872f2087c98

Per our discussion, SB database update is only enabled on
WiFi network.

BUG=376016

Review URL: https://codereview.chromium.org/302603008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273969 0039d316-1c4b-4281-b951-d872f2087c98

It is not used anywhere.

R=rogerta@chromium.org
BUG=

Review URL: https://codereview.chromium.org/301323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273968 0039d316-1c4b-4281-b951-d872f2087c98

This silences the false positive update warning, and starts with parts of Window's SystemTrayDelegate as a template to build on.

BUG=none

Review URL: https://codereview.chromium.org/292123014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273967 0039d316-1c4b-4281-b951-d872f2087c98

Sets up a experiment that, when active, demotes all suggestions with
inline autocompletions so that a suggestion without one (or, more precisely,
a suggestion with an empty inline autocompletion) appears first / within
the omnibox.

BUG=

Review URL: https://codereview.chromium.org/303013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273966 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371150
TEST=no visible change to instant extended

Review URL: https://codereview.chromium.org/292123015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273965 0039d316-1c4b-4281-b951-d872f2087c98

SSE2 is now the baseline for X86 platforms.

BUG=378608
TEST=compiles

Review URL: https://codereview.chromium.org/308003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273964 0039d316-1c4b-4281-b951-d872f2087c98

The Blink roll will make the test fail so disable the test
temporarily. This was seen with the original author of the
test <srawlins@google.com> as they think it's an easy fix.

BUG=379339
TBR=mvanouwerkerk@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/308863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273963 0039d316-1c4b-4281-b951-d872f2087c98

I'm doing to ultimately remove ContextFactory::Set/GetInstance().

BUG=none
TEST=none
R=jbauman@chromium.org

Review URL: https://codereview.chromium.org/301233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273962 0039d316-1c4b-4281-b951-d872f2087c98

The overlay is now dismissed after the first non-empty paint or the page load, whichever comes first. Removed all listening for repaints (OnUpdateRect).

Also updated the code for overlay fadeout to avoid the need to repaint the overlay layer before the animation is started - we now fadeout the WindowSlider's layer if it was the one being shown when the fadeout was started.

BUG=NONE

Review URL: https://codereview.chromium.org/278173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273961 0039d316-1c4b-4281-b951-d872f2087c98

Main thing that needed work here was the unittest.

BUG=339726

Review URL: https://codereview.chromium.org/303263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273960 0039d316-1c4b-4281-b951-d872f2087c98

With the zoom refactor in flight: https://codereview.chromium.org/287093002/, zoom
plumbing for BrowserPlugin in the content layer is now entirely dead code. We need to revisit zoom in
the chrome layer for <webview> so that the embedder's zoom is propagated to the guests.

This will be done at a later time when we need to get <webview> in WebUI working again.

BUG=330264
TBR=jam@chromium.org for trivial browser_plugin_guest_delegate.h code deletion.

Review URL: https://codereview.chromium.org/303423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273959 0039d316-1c4b-4281-b951-d872f2087c98

BUG=309681
R=asvitkine@chromium.org, dtseng@chromium.org, kalman@chromium.org

Review URL: https://codereview.chromium.org/308003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273958 0039d316-1c4b-4281-b951-d872f2087c98

$('alertOverlay') is null so the call for classList failed.  Guard the
condition to see if the element exists.

BUG=379194

Review URL: https://codereview.chromium.org/301223009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273956 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/309623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273954 0039d316-1c4b-4281-b951-d872f2087c98

This is a minimal diff that refactors the key/value stash into a class.
The next step is to pull the class implementation out to a separate
implementation file and add a unittest.
Also normalizes the use of the anonymous namespace to exclude functions
that are DLL exports.

BUG=378916

Review URL: https://codereview.chromium.org/302033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273953 0039d316-1c4b-4281-b951-d872f2087c98

Device pixel ratio is used to scale test rect and sampling locations.
It can be non-integral on some devices. For example it is 1.325 on
Nexus 7. The scaled quantities - dimensions of screenshot and sampled
pixel locations - need to be converted to integers before they can
be used.

BUG=368495

Review URL: https://codereview.chromium.org/303113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377636
TEST=run the test 50 times and no flakiness observed

Review URL: https://codereview.chromium.org/306953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273950 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239879

Review URL: https://codereview.chromium.org/308713006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273949 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364821
NOTRY=true
R=thestig@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/306033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273945 0039d316-1c4b-4281-b951-d872f2087c98

Right now ubsan=1 doesn't work with Chromium-packaged Clang because of missing libraries.

BUG=174801
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/299403007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273944 0039d316-1c4b-4281-b951-d872f2087c98