- 04 Jun, 2020 40 commits
-
-
Omer Katz authored
Bug: 1079247 Change-Id: If021e8ff4ccf3f591794698396ef2bf636115ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231066 Commit-Queue: Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#775212}
-
Matthias Körber authored
Change-Id: Ie055b7b2a4c09122cc6bae6caa778a8b4677f4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230489Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#775211}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591214254-6aa4e5b3c8cad7acd58b53b8c7cc7024959b4c99.profdata to chrome-mac-master-1591286362-102873a0b212b7d3d19b6bf651c7d4720fb0d502.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I566d73607dc716fd9e85ace8e2b75134606da856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775210}
-
evliu authored
This CL adds a header that was missed in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2206918. Bug: 1091051 Change-Id: Ifa742b5197b4deba6873a0c90ac180478b91d9a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228061Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#775209}
-
Jonathan Backer authored
crbug.com/1061442 suggests that it is unwise to do a virtual context switch after the underlying context is lost. This CL prevents that. Bug: 1061442 Change-Id: I7143836d0591c2a7f0a291b66f60b4f46d84c5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231285Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#775208}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cabedcafaa77..0df92012a18e 2020-06-04 jmadill@chromium.org Rename Platform.h to PlatformMethods.h. 2020-06-04 nguyenmh@google.com Allow line formats to pass description body's line length check 2020-06-04 spang@chromium.org Re-enable ShouldClearOpaqueFdRGBA8 on Pixel2 Vulkan 2020-06-04 xiaoxuan.liu@arm.com Vulkan: Cleanup unused variable in submitFrame() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I70d277c0803c59555efdaca8956212483fa38fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231418Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/024d42fdd6bb..5a2a7b3096d0 2020-06-04 johnstiles@google.com Update GrClampFragmentProcessor to use a child FP. 2020-06-04 bungeman@google.com Regularize SkFontMgr for CoreText build. 2020-06-04 johnstiles@google.com Fix invalid code generation with @setData and 'in fragmentProcessor?'. 2020-06-04 herb@google.com Move addToAtlas to GrAtlasManager 2020-06-04 senorblanco@chromium.org Dawn: skip PromiseImageShutdownTest and TextureIdleProcTest. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I020be42684f35a4ed6a4f89d6f03c410fb088f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231024Reviewed-by:
-
Calder Kitagawa authored
This reverts commit 17ae1743. Reason for revert: MSAN failure https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878408074967908800/+/steps/components_unittests/0/logs/Deterministic_failure:PaintPreviewRecorderUtilsTest.TestSerializeAsSkPicture__status_CRASH/0 Original change's description: > [Paint Preview] Account for scroll offset in subframes > > Scroll position isn't accounted for in the clip rect for subframes. It > needs to be manually corrected via the tracker when serializing. > > Bug: 1090920 > Change-Id: I93e316016832132cbfdfec833249ed454c060b9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228577 > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org> > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775098} TBR=mahmoudi@chromium.org,ckitagawa@chromium.org Change-Id: I2b2e7f5ff847c95c0c329bea0a54dc11c3810310 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231262Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#775205}
-
gogerald authored
Screenshot: https://drive.google.com/file/d/11nP7UVbol-7HM50Pm0LBcP5Mlwt8qzRL/view?usp=sharing Bug: 1091041 Change-Id: I230f3e8be0fbb330dc23edc7782e61708ca74701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230766 Auto-Submit: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#775204}
-
Liquan (Max) Gu authored
This CL adds test coverage for the appearance of the Expandable Payment Handler UI and its user interaction. Changes: * Moved the original content of ExpandablePaymentHandlerTest.java into ExpandablePaymentHandlerCoordinatorTest.java (and change to small-test). * Added test cases in ExpandablePaymentHandlerTest.java. * Changed payment method from "/pay" to the "payment_method.json". This is because /pay was not pointing to a payment method manifest, so JIT installation was disabled. * merchant.html: given ids to the buttons so that the tests can simulate users' clicking on the buttons. Bug: 1042892, 1084705, 1084707, 1084708, 1084711, 1084721, 1068741 Change-Id: I4943932632cc446c75144bcdf7f9d9f9e06881be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227512Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#775203}
-
Ankit Kumar authored
This CL ensures that when focus is restored to PDF, we maintain the viewport and do not scroll even if the focused annotation is out of viewport. Bug: 1085614 Change-Id: Ifc4015b6d393dd1678d839a6636fbd4b335528ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224946Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#775202} -
Jonathan Ross authored
On Mac we are seeing FirstPaintAfterBackForwardCacheRestore flake. This disables the test on just Mac until the root cause can be addressed TBR=npm@chromium.org TEST=BackForwardCachePageLoadMetricsObserverBrowserTest.FirstPaintAfterBackForwardCacheRestore Bug: 1075936 Change-Id: Ia6ad11517e81edb9d3832468e8db4881eec7dd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231284Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#775201}
-
Swapnil authored
If the device is offline, we fail to download and install the extensions which are listed in ForceList policy. We only look in the cache if the manifest fetch was successful. If manifest fetch failed, then we report the failure. Here, we try to fetch the extension from cache in case we failed to fetch the manifest and try to install the extension. In case we received MANIFEST_FETCH_FAILED or MANIFEST_INVALID error, instead of reporting the failure, try fetching the extension from cache. For force installed extensions, In case of no internet connection: We don't retry fetching the manifest now, and try installing directly from the cache. If the extension is not present in the cache, we retry downloading with backoff delay. In other failures related to Manifest fetch like server shut down etc., we make retry attempts and then in case of failure try installing it from the cache. A new histogram is added: Extensions.ForceInstalledCacheStatus : It reports the cache status for force installed extensions whenever a CRX file is looked up in the cache. It reports the cache status irrespective of whether the extension failed to install or installed successfully. Bug: 1051870 Change-Id: Iab8d95a7ffbf144ae415686b6a80d501a19823e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054244 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#775200}
-
Sebastien Marchand authored
I forgot to remove the %m part in https://chromium-review.googlesource.com/c/chromium/src/+/2229010 Change-Id: Ica40d2f9787e400967155f55749cd2d5b789127c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231260 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#775199}
-
Devlin Cronin authored
Stop recording Extensions.UnpackFailureInstallSource and Extensions.UnpackSuccessInstallSource. Bug: 1072516 Change-Id: I47c3e62752187a228eeb09a4f0782b3ae075fd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229427 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#775198}
-
Dave Tapuska authored
With the future removal of the content::Widget mojom interface we need to ensure that the blink Widget/FrameWidget interfaces are correctly initialized for tests. BUG=1073560 Change-Id: Id960f8c450ff9485d36b81504a4d96da3f4f14b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230839Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#775197}
-
Kent Tamura authored
- If a ruby base box has only zero-width lines, we should not allow overhang. - If a ruby base box didn't provide baseline, the corresponding ruby text box should provide it. These behaviors are compatible with the legacy layout. This fixes five failing tests. Bug: 1069817 Change-Id: Ibe42f27cf2a60b07e39f6fb979f177e3d08cb6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230141Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#775196}
-
danakj authored
chrome.gpuBenchmarking.pointerActionSequence() has synchronization problems, as the hit testing is done against compositor submissions but the gpuBenchmarking methods do not cause or wait for compositing to occur. So tests must explicitly do this themselves to avoid flaky behaviour. The webaudio-autoplay-iframe-with-gesture.html test on its own works fine, somehow. But the compositing of the iframe fails to beat the gpuBenchmarking synthetic events if it runs after the document-user-activation-cross-origin-feature-policy-header.html test which also involves gpuBenchmarking synthetic events. This adds waits in the test's js code to make up for the gpuBenchmarking harness being flaky. R=yigu@chromium.org Bug: 872952, 1091299 Change-Id: I6c4cb1ffc51286584ef9c7079bfff8677da1e1a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230768 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775195}
-
David Black authored
These methods are unused and were missed during earlier clean up. Bug: b:157237955 Change-Id: Ia3f45af1f206cf817544705af4500ebcf77cf74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226916 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#775194}
-
Behnood Momenzadeh authored
This CL will add a flag to enable suggesting navigations based on lookalikes. Lookalikes are currently used to detect spoofs, but it could be utilized to suggest navigations to users who might have typos in their navigation URL. Bug: 1076154 Change-Id: I4daf8061a3b52db970588f8a16b7fa9d19e38628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228985Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Behnood Momenzadeh <behnoodm@google.com> Cr-Commit-Position: refs/heads/master@{#775193}
-
Charlene Yan authored
Move from BrowserTabStripController into TabStripModel so it can be used by both BrowserTabStripController and TabStripModelOrderController. Update TabStripModelOrderController::DetermineInsertionIndex to take into account collapsed groups. Also rename variable from tabstrip_ to model_ inside order controller. Bug: 1018230 Change-Id: I26cf677bde4c68b91909f8f4d6f2e564e15bca92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219018 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#775192}
-
Juanmi Huertas authored
Fixing comments inside webgl::getImageData about the CPU fallback and about the usage of CopyRenderingResultsFromDrawingBuffer regarding that method not failing because the resource was always expected to be accelerated (GPU). Leaving a bug open (to track the issue with removing the CPU fallback) as some investigation may be needed whether it really makes sense to have that CPU fallback. Bug: 1090962, 1035589 Change-Id: Id50a18511e7966a860f46fa7d2e40a57e3269dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229156 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Auto-Submit: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#775191}
-
Zach Trudo authored
StorageModule and EncryptionModule are needed in the reporting client interface. TestStorageModule and TestEncryptionModule are needed in the reporting client tests. Bug: chromium:1078512 Change-Id: Ic96ce4b9a85724f7dee20f4576e54383d6bc3330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228984 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
-
Piotr Bialecki authored
This is a mechanical change to rename the mojo type and additional misc changes requested as a followup for CL https://crrev.com/c/2203277. Changes: - s/XRReferenceSpaceCategory/XRReferenceSpaceType, along with renaming few variable names from "*category" to "*type" - changed mojo type from now-deprecated macro-style naming to constant-style naming - refactored few lines of code that compute reference space appropriate for anchor creation into XRSession::GetStationaryReferenceSpace(), used both in XRFrame and in XRHitTestResult for anchor creation - added `using` in xr_reference_space.cc to help with readability of a quite-long type to something shorter (`ReferenceSpaceType` instead of `device::mojom::blink::XRReferenceSpaceType`) - same directive could be introduced in other files but the occurrences of the offending type are not that common elsewhere - refactored `XRReferenceSpace::NativeFromMojo()` since 3 `case`s were identical or very similar There should be no functional change. Change-Id: I8e8efdc036f11347f8d9159fbaede44634c6eb78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229622Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#775189}
-
John Williams authored
When Cast mirroring, check the media source for streamingCaptureAudio and streamingTargetPlayoutDelayMillis query parameters, and reflect them on the mirroring session launch parameters sent to the mirroring service. Bug: 1087961, b/156948625 Change-Id: I8b9a6eefa1fbdfdef23aa5866eed30be2b6047b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219595 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#775188}
-
Jeroen Dhollander authored
One issue with working from home is that it is not possible to send voice commands to the Assistant while running ChromeOS on your destop Linux machine. To work around it, this CL contains a fake microphone input, and a script that can be used to send text-to-speech data to this fake microphone. To use this: - use gn arg enable_fake_assistant_microphone - run the script |chromeos/asssitant/send-voice.sh tell me a joke| - open the Asssistant and see the query coming in. You can run this script both before and after opening the Assistant. Change-Id: Iccf3ad4b98c2cb47930ba892afab04cf9233fb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219594Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/80ae9afc70f7..b1e9759c011a 2020-06-04 sigurds@chromium.org Add missing check for undefined If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If579906f525522b47641767e778a570c67b07654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231001Reviewed-by:
-
Devlin Cronin authored
ExtensionService::RecordPermissionMessagesHistogram() historically used some bespoke logging because it had custom names for the histograms - which weren't supported with histogram macros. With histogram functions, this is much easier, and we can avoid using the internal histogram logging mechanisms. Bug: None Change-Id: I9e35569138094b98e4dab32cfcad505735549666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231439Reviewed-by:
-
Nazih Almalki authored
Both Windows and Mac don't support early ack without the actual surface being activated. Bug: 1087865 Bug: 1088412 Change-Id: If890f698bc3b1a1161a85aad0784c1d252269f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230328 Commit-Queue: Nazih Almalki <nalmalki@google.com> Reviewed-by:
-
arthursonzogni authored
This test is flaky on Android Pie. TBR=hanxi@chromium.org, wychen@chromium.org Bug: 1091311 Change-Id: I0a64088ffd0274d0ba77326fc1cdd503e6a8c73b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231047 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#775183}
-
Daniel Winkler authored
Recent ChromeOS bluez-next uprev fixes a bug that clears a client's discovery filter between discovery sessions. Now that it is fixed, we must be sure the filter is refreshed to prevent lingering filters from affecting client discovery. BUG=b:157266509 TEST=ARC++ bluetooth tests that use LE filters Change-Id: I06cf494a49d6bcf83370fbcb0f1d365a50e27560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225278 Commit-Queue: Daniel Winkler <danielwinkler@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#775182}
-
Koji Ishii authored
Sometimes we may need to retrieve |NGLayoutResult| after its |WillBeDestroyed| is called. 1. |LayoutBox::WillBeDestroyed| marks its cached |NGLayoutResult| as |WillBeDestroyed|. 2. |LayoutObject::WillBeDestroyed| clears its children by |DestroyLeftoverChildren|. 3. One of its descendant calls |SetNeedsLayout|. 4. In determining the container chain to mark dirty, |GetCachedLayoutResult| is needed to know if |ObjectIsRelayoutBoundary|. There will be rooms to improve, such as: * |DestroyLeftoverChildren| after |WillBeDestroyed| of its subclasses look dangerous. |LayoutBlockFlow| calls |DestroyLeftoverChildren| probably to prevent this. * We can probalby stop marking objects that are |BeingDestroyed|, though knowing exactly where may not be easy. but these changes are likely risky. This patch simply allows retrieving |GetCachedLayoutResult| if |BeingDestroyed|. Bug: 1091188 Change-Id: I966e1c6e7844fed795eadeb775b520bbd239e56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230562 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#775181}
-
Chris Lu authored
This change leaves BannerVisibilityChanged unimplementated in InfobarBannerInteractionHandler. This will allow the PasswordInfobarBannerInteractionHandler implementation to be executed. This change also modifies GetInfobarDelegate to return the generic InfoBarDelegate since BannerDismissedByUser is a general implementation by all Infobars. Translate is not a ConfirmInfoBarDelegate. Change-Id: Id6bfa73a8d1ca274466bb8c14217135438c19e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229602Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#775180}
-
Katie D authored
The UX mock has a slightly different string, so this just adjusts the string. AX-Relnotes: Adjust STS background shading string. Bug: 1079424 Change-Id: Ic485e1a39dbcfb614c8f5159d419fe1fe811a97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231020 Auto-Submit: Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#775179}
-
Yi Gu authored
This test is flaky under a variety of test suites: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyYwsSBUZsYWtlIlhjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZmFzdC9zY3JvbGxpbmcvc2Nyb2xsYmFycy9tb3VzZS1hdXRvc2Nyb2xsaW5nLW9uLXNjcm9sbGJhci5odG1sDA TBR=arakeri@microsoft.com NOTRY=TRUE Bug: 1057060 Change-Id: Ib4fa290128f5b106c551bf756d0665d72117d112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230910Reviewed-by:
-
Xiyuan Xia authored
ui::ThroughputTracker provides a more accurate smoothness tracking than ash::FpsCounter. Re-wire the start/stop smoothness tracking api using that. Bug: 1062124 Change-Id: I7472593810e2dc2151059e16656041cb1a7a72d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226278Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#775177}
-
Haiyang Pan authored
Currently they have been disabled on Emulator on Pie. See https://crbug.com/1077316#c1 Bug: 1077316, 1022533 Change-Id: I0a9d917a650e27c477ef7f693010f2c8e1bd07f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229878 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775176}
-
James Cook authored
I renamed a test and didn't realize there was a filter file to update. TBR=rsorokin@chromium.org Bug: 1074436 Change-Id: I89f46e71c8422043af9f369fda238b436cae477f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231450Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#775175}
-
Jonah Ryan-Davis authored
We are still tracking these metrics. Bug: chromium:1088816 Bug: chromium:1088825 Bug: chromium:1089985 Bug: chromium:1089986 Change-Id: I1999ba730fa60299f213d00f8a1fc6c62c36643f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227882 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#775174}
-
Mila Green authored
Bug: 1090553 Change-Id: I7f64266160d1de8b321c8d2df863e6faed92f20a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225250 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#775173}
-
