- 12 Sep, 2019 9 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f7cf794890d4..7c8c67ec803c git log f7cf794890d4..7c8c67ec803c --date=short --no-merges --format='%ad %ae %s' 2019-09-11 bsalomon@google.com Blacklist InitialTextureClear on TecnoSpark3Pro Created with: gclient setdep -r src/third_party/skia@7c8c67ec803c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I33497b44a7ea0dc0fdd8098cdbce4a9a25642721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799426Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695845}
-
rbpotter authored
- Autogenerate Polymer 3 cr-action-menu and test - Autogenerate modulized focus_row.js, since cr-action-menu depends on it - Add cr-action-menu to demo page - Script changes, required to allow cr-action-menu to export its enum Bug: 965770 Change-Id: Ie453b1f5f9ebe385143768cac1609ae1ae2f9de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789759Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#695844}
-
Ryan Hansberry authored
Bring EasyUnlockServiceRegular above the 85% test coverage expectation. This CL also removes unnecessary methods which remained in EasyUnlockServiceRegular, correctly clears stored remote devices in prefs when Smart Lock is no longer enabled, and includes minor refactors necessary to make tests pass. Coverage before this CL: easy_unlock_service.cc: 14.72% (91/618) easy_unlock_service_regular.cc: 22.58% (98/434) Coverage as of this CL: easy_unlock_service.cc: 35.76% (221/618) easy_unlock_service_regular.cc: 91.96% (389/423) Report created with: $ python tools/code_coverage/coverage.py unit_tests \ -b out/coverage \ -o out/report \ -c 'out/coverage/unit_tests --gtest_filter=*EasyUnlockService*' \ -f chrome/browser/chromeos/login/easy_unlock/ Bug: 949209 Change-Id: I037776f197373ff94099d2f5fc38726d60165cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788552 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#695843}
-
Julie Jeongeun Kim authored
This CL converts SandboxSupportMacPtr and SandboxSupportMacRequest to new Mojo types. It uses PendingReceiver, ReceiverSet, and Remote instead of SandboxSupportMacRequest, BindingSet, and SandboxSupportMacPtr. Bug: 955171 Change-Id: I8d216a85939cba01c392bb821e189610d5e5b885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786708Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#695842}
-
Kenichi Ishibashi authored
This is a follow-up CL of crrev.com/c/1792028. The CL seemed to fix a crash but a better and proper fix is to delay adding WorkerThread to WorkerThreads() until the worker context is initialized. This way we can make sure WorkerScheduler is available for all workers in WorkerThreads(). To terminate initializing workers via TerminateAllWorkersForTesting() we need to keep initializing workers somewhere else. This CL adds a HashSet that keeps initializing workers. Bug: 1000077 Change-Id: I8410ebec0a8459a779105f6d65e2bde4f3b81f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792510 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#695841}
-
Scott Violet authored
webkit-box treats a min-size of auto as 0. This adds that logic to FlexLayoutAlgorithm. BUG=993813 TEST=fast/css/deprecated-flexbox-auto-min-size.html Change-Id: I80eb42616575891d4a99450f6d1fd515ba3c39a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799389Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#695840}
-
Xianzhu Wang authored
This reduces size of cc::Layer from 680 to 552 on LP64 systems. - Adjust order of fields to reduce gaps; - Remove snap_container_data. Change-Id: Id2fa92d5feae2cb819b25c400c8ed678a01558ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798987 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#695839}
-
Brandon Wylie authored
Bug: 1002011 Change-Id: Iafd7bfa4f6235575775dee44eeba9779bceda6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798983Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#695838}
-
Jon Mann authored
This was used by Messages v1 to activate a long living service worker. Now that Messages v2 is completely rolled out, this code path is no longer used. Bug: 869714 Change-Id: I0b0d1dc234a8aec5e3d941cabb196103339a9e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797084Reviewed-by:
-
- 11 Sep, 2019 31 commits
-
-
John Budorick authored
Bug: 922145 Change-Id: I39af4eb6d2290335fdec268d9c9e1e0f7af66f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795312Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#695836}
-
Danan S authored
This reverts commit 441c06d9. Reason for revert: Reland changes after disabling test for MSan builds. The root issue is a bug that causes a flaky initialization behavior in the <webview> element in MSan builds (https://crbug.com/1002560) Also, added a new unit test from tobyhuang@ that was dependent on the original reverted CL. Original change's description: > Revert "Automated tests for Add Supervision flow ChromeOS code" > > This reverts commit 9f7c76d0. > > Reason for revert: > AddSupervisionBrowserTest.ShowConfirmSignoutDialog > AddSupervisionBrowserTest.URLParameters > failing on Linux ChromiumOS MSan Tests, see > https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/15000 > > Original change's description: > > Automated tests for Add Supervision flow ChromeOS code > > > > This required modifying the classes under test, including > > AddSupervisionHandler, AddSupervisionUI, and ConfirmSignoutDialog > > to allow them to be tested. > > > > Bug:982543 > > > > Change-Id: I3bebada137fe57a63ca090c788fa5a0cb317d22b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771387 > > Commit-Queue: Danan S <danan@chromium.org> > > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#693320} > > TBR=michaelpg@chromium.org,danan@chromium.org > > Change-Id: Ibe6189ed52f32afb62cdfabbf890857e474de6ea > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 982543 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787417 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Auto-Submit: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693571} Change-Id: I4d2c19c229923a5bd1acb246f8e9d4d1b2ccb9af Bug: 982543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787613 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695835}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/device/geolocation. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=mcasas@chromium.org Bug: 891670 Change-Id: Ibfbac7fc26104f23536ba42e07f38232bfd668ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787203 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#695834}
-
Matt Menke authored
This method name is confusing, since HttpServerProperties::SupportsSpdy() is used to store whether a server supports SPDY/H2, but SupportsQuic() actually means a network where QUIC works (i.e., the ISP isn't breaking QUIC, or something similar). This difference in meaning was also not documented anywhere. This CL renames "SupportsQuic" to "LastLocalAddressWhenQuicWorked", adds documentation, and reworks the API slightly - its behavior around empty IPAddresses was a little weird, as was passing in an IPAddress() and a bool when clearing information for all IP addresses. This CL also renames QuicFactory::requires_confirmation_ to is_quic_known_to_work_on_current_network_ (which also requires inverting its value) and adds some documentation for it, as it was similarly confusing. Bug: 969890 Change-Id: Id51b082343ff31ecd36f1bedfab8342307da26ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790325 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#695833}
-
Justin Donnelly authored
Change-Id: I1c9d81ae9f1440710b1409e1e05b89a53852e32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799622Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#695832}
-
rajendrant authored
This reverts commit 2760b9dd. Reason for revert: Causing some regression in perf tests Original change's description: > Bypass proxy for preflight request > > Since the OPTIONS preflight request is generated within the network > service, it will not reach the URL loader throttles in renderer that > handle the proxy specific code. > > Preflight requests apply predominantly to POST requests for which proxy > will not be used. So it makes sense to bypass proxy for preflight > requests too. > > Bug: 985673 > Change-Id: Iafa0db4ac0dcb29d7b38870fb4ea345f60da2212 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764748 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694025} TBR=rajendrant@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 985673, 1001610 TBR: cduvall@chroimum.org Change-Id: I5905b849e14867b467e5fc0af6cbfd24cd10201a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799391 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#695831}
-
Kent Tamura authored
This CL implements new autofocus algorithm in [1]. - Enqueue an autofocus element on InsertedInto(), not AttachLayoutTree() - Handle queued elements after rAF callbacks - Do not handle queued elements if a document has non-empty fragment or already-focused element. * Changes to the existing tests Focus timing becomes slightly later. Some test are updated to use focus(), and some other tests wait for two animation frames. [1] https://html.spec.whatwg.org/C/#the-autofocus-attribute Bug: 382901, 985636 Change-Id: I07b94771a53ddcf600aa3101cc1df1eceaf59356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699391Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#695830}
-
Koji Ishii authored
This patch fixes the |float| variation of |Font::TabWidth| not to return -NaN by adding the same guard as its |LayoutUnit| variation. Bug: 1002999 Change-Id: I4fc1fdb233b4156a425c92d97f7f9444be527d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798070Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#695829}
-
Peter Kotwicz authored
This CL adds a new UMA metric WebApk.Navigation.InScope which is recorded on every WebAPK navigation. It records whether WebAPK navigations are within the WebAPK's scope. BUG=999648 Change-Id: I0d8fc678f396e8fd55c48aabd41b8878ee8fdcd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788304 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#695828}
-
Nick Diego Yamane authored
Get rid of native event (i.e: XEvent) usage when translating ui::KeyEvent into GdkEvent in GtkUi GdkKeyBindingsHandler and InputMethod context implementation. Native event usage outside platform code is undesired and blocks changes such as Aura/X11 => Ozone/X11 migration (e.g: PlatformEvent migration crbug.com/965991). It is worth noting that aura IME code has been slightly modified to set root window as Event::target() during the PRE_DISPATCH phase (for some reason InputMethodContext::DispatchKeyEvent() is called at this phase) so that IME context implementation is then able to retrieve the X11 Window id, needed by GdkEvent system. To be able to retrieve XEvent group field in gtkui code, an Event::Property has been added and for now is set only for non-ozone X11. Ozone/X11 will be addressed in a follow-up CL. Rationale: https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc/edit?usp=sharing Bug: 965991, 987939 Change-Id: I64929d6866c1dfcfddbfe75166a1bad139c2da8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789603 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#695827}
-
Khushal authored
R=kbr@chromium.org Bug: 998038 Change-Id: Ic31d28938ef205b36657fc7bd297fe8a63d08543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798052 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#695826}
-
Brian Sheedy authored
Makes test_env.py compatible with both Python 2 and 3. Also adds a very simple test to ensure that it remains compatible until some other test switches to Python 3. As a side effect of adding the test, also makes testing/scripts/common.py compatible with Python 3 since it's necessary for running isolated scripts. Bug: 898348 Change-Id: Ib58cf4c4f85df60a432764d7f744bc3fee09ae3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796525Reviewed-by:
-
Matt Menke authored
With the non-NetworkService path now removed, only the URLRequest::Delegate auth path is used. This CL leaves a supporting enum and callback in NetworkDelegate, which aren't used by NetworkDelegate, but are still used. I'll figure out where to move them in another CL. Bug: 934009 Change-Id: Icf5f8344ca0326c7ac0bbd72440ad602f65c3363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798886Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#695824}
-
Bo Liu authored
Copies ContentView from components and EventOffsetHandler from chrome. These together will call EventForwarder.setCurrentTouchEventOffsets at the right times to correctly offset user input under browser controls Change-Id: I29a418457c4daf2306e7ce13e8311a489b1ca958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796046Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695823}
-
Matt Falkenhagen authored
This is a short-term workaround to get a browser test passing when ServiceWorkerOnUI is enabled. When ServiceWorkerContextCore is destroyed (i.e., browser shut down or DeleteAndStartOver() is called), Mojo callbacks can be destroyed without being run, which causes Mojo to DCHECK. In the failing browser test (PendingAppManagerImplBrowserTest.InstallChromeURLFails) the callback for Register gets destroyed when ServiceWorkerJobCoordinator is destroyed and destroys the ServiceWorkerRegisterJob that owns the callback. This test failure happens for Register job on when ServiceWorkerOnUI is enabled, but it looks like this can happen for any Mojo callback that goes through ServiceWorkerContextCore regardless of that feature. Medium to longer term fixes are: - Make the ServiceWorkerProviderHosts destruct before ServiceWorkerJobCoordinator and other objects that can hold callbacks like ServiceWorkerStorage. The provider hosts hold the connections to the renderer, and dropping the connections allows the callbacks to be dropped without DCHECK. - However, that won't help the case of destruction due to DeleteAndStartOver, because currently the provider hosts and Mojo connections survive while the job coordinator and other objects are destroyed. We should drop Mojo connections on shutdown (see issue 877356). Bug: 1002776, 877356, 824858 Change-Id: I8d99e7c37eb51eda7ca2baf5f32be25e1c399b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795645Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695822}
-
Katie Dillon authored
This cl adds an experiment to the CompositorPriorityExperiments class that will set the compositior to kVeryHighPriority until it exhausts a budget. Once the budget runs out it will set the compositor back to kNormalPriority until the budget is replenished. Bug: 966177 Change-Id: I62d9b261501c99dbe62efa008cbdbc8acd902f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767956 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#695821}
-
Rahul Arakeri authored
When an autoscroll is in progress and the pointer moves out of arrow/ track bounds, the animation is expected to "pause" until the pointer moves back in the bounds. This CL implements that feature for the compositor threaded scrollbars. Bug: 967004 Change-Id: I85d0c1c343f39651055198688dcb056ceb587d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764526 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695820}
-
Charlene Yan authored
ExtensionsMenuButton was a HoverButton which did not implement the logic for adding elide. LabelButton has elide but needs additional padding to look like what was a HoverButton. Bug: 985382 Change-Id: I94ed473e0fadb234774fd26fa9109a9adab11e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788512 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#695819}
-
Kristi Park authored
Change-Id: I5fa43851d21942c51a8ff3a8b79bb6bd03cce287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797330Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#695818}
-
John Rummell authored
Now that Widevine is in a nested directory, check for it's existence as a directory (and not a file). Also update the permissions on the actual Widevine library to be ${SHLIB_PERMS}. Tested by building "installer" and then installing it. Widevine is installed and Shaka player works with Widevine. Bug: 1002648 Test: Installed Chrome and played Widevine content. Change-Id: I531c0f7da58b50d36bb4e72fdde11f05cfa9f5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799306Reviewed-by:Michael Moss <mmoss@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#695817}
-
Dan Beam authored
* DCHECK() about not calling mojo callbacks before they're destroyed This happens when the user types more quickly than we can respond * Holding backspace accidentally shows matches for last deleted char This happens because when input is emptied, the UI immediately hides the matches UI, but an asynchronous result from the autocomplete "backend" returns right after, which renders a new result. R=mahmadi@chromium.org Bug: 1001761, 1001762 Change-Id: Ic18dd8c63e79d4fe2d1563134920725dc19daf97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790434Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#695816}
-
Scott Violet authored
Making webkit-box use LayoutFlexibleBox means ShouldScaleColumnsForParent would return false, where as it previously wouldn't. Returning false means width:100% table-cells won't stretch. This patch makes ShouldScaleColumnsForParent() not return false for webkit-box, so that width:100% for table cells continues to stretch. BUG=993813 TEST=fast/block/block-size-integer-overflow.html Change-Id: I0236c45401a7d71e8f6be8f9cbe0237ddbd46f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798986Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Kevin Babbitt authored
This histogram will continue to be useful for stabilizing the Windows UI Automation implementation. Extend its expiry by six months. Also update the range of known values to include UIA_IsDialogPropertyId which was introduced in RS5. Bug: 988814 Change-Id: Ibee9d36facf637f65b61f2a92bd8e29f0cd9e749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785623Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695814}
-
Dave Tapuska authored
It is possible that the frame becomes detached from the document after dispatching the event. This is the only way the FrameScheduler could be null. I previously checked it in SetLifecycleState in change https://chromium.googlesource.com/chromium/src.git/+/42b61856cfd1b63bed1a1cae45cac6b7e41e9e0f and that seemed to decrease the number of crashes, but they still seem to exist. These additional checks should cover those situations. BUG=994442 Change-Id: I59ad0e4f4e047f4548c72ad103691a260290626e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798888 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#695813}
-
Kevin Babbitt authored
The default HWND provider for UI Automation will generate a runtime id for our fragment root, but relying on this behavior for the legacy window was breaking the Inspect tool's ability to expand the tree for web content. Removing the special case and generating a runtime id for the fragment root as for any other node fixes the issue. Bug: 928811 Change-Id: Id15d33cacbc97699e904e9bf53e1b39975cbf8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797096Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695812}
-
James Cook authored
The goal is to allow the use of ax_enums.mojom-forward.h in header files, reducing the amount of transitively-included code from the mojo headers. This change is purely mechanical - just fix the includes where various ax::mojom::Foo enum values are used. Bypassing other owners per mechanical change policy: https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes TBR=dmazzoni@chromium.org Bug: 1001715 Test: compiles Change-Id: I091294909e322e4b1d8817cce0115e21dde96ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798757 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
rbpotter authored
- Autogenerating Polymer 3 version of cr-lazy-render and test - Adding to the demo page - Removing legacy templatizer behavior from Polymer 3 exports, since it should not be used now that cr-lazy-render is updated to use Polymer.Templatize.templatize() instead (see https://crrev.com/c/1786248). Bug: 965770 Change-Id: I58b0cd8b19b6f668888aa48fc56c7ad9817efac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790641 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
Previously if we had a table-cell which was %-block-size based, replaced elements would resolve their percentages against this height during both the "measure" and "layout" phases. This was incorrect, instead during the measure phase we should only resolve a percentage against a "fixed" height table-cell, and indefinite for all other cases. Bug: 1001083 Change-Id: If4217a7545830d1279911753930bf821c2c023d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793942 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Tim Song authored
The updated tooltip will include "Do not disturb is {on/off}", making it more consistent with the other tooltip buttons. BUG=1002471 Change-Id: I2cb41dc89aa1bf133dd77640340cc0c140a8b96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795306Reviewed-by:Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#695808}
-
Gabriel Charette authored
Backport some tests in /chrome/renderer/media/cast_ipc_dispatcher_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/renderer/media/cast_ipc_dispatcher_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=miu@chromium.org Bug: 891670 Change-Id: Ie63b2a50f17930c348dd9b9ebb6f65ce0cc8963c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786843 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695807}
-
Kaan Alsan authored
Updated the bug links for the external/wpt/css/css-scroll-snap/scroll-target* tests. Bug: 10030555 Change-Id: Iaf735d7118c4c2e8ac6a934a4e35707c2144cf1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798209Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Kaan Alsan <alsan@google.com> Cr-Commit-Position: refs/heads/master@{#695806}
-
