GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245471 0039d316-1c4b-4281-b951-d872f2087c98

DesktopScreenX11Test.GetWindowAtScreenPoint in views_unittests is faling on "Linux Aura Tests" after this change.
http://build.chromium.org/p/chromium.linux/builders/Linux%20Aura%20Tests/builds/701

> Linux Aura: Added --use-system-title-bar flag.
> 
> This flag makes browser windows use the system window dressing and title
> bar, instead of the custom frame. This is a Linux Aura equivalent of the
> "Use System Title Bar and Border" preference in Linux GTK. (Eventually,
> this part will be controlled by the same preference, rather than this
> flag.)
> 
> With this flag, browser windows use the native system window decoration,
> with our custom close/minimize/maximize buttons removed, and the tab
> strip being condensed vertically with square corners (like the maximized
> tab strip).  Popup browser windows (including V1 apps and the Developer
> Tools window) drop the blue custom frame altogether in favour of the
> native frame.
> 
> BUG=317859
> TEST=With --use-system-title-bar, open a browser window. Both maximized
> and restored windows should have a system native title bar, and the tab
> strip should be compacted into a single row (as when maximized).
> TEST=With --use-system-title-bar, open a hosted app window. It should
> have a system native title bar, with no second blue title bar.
> 
> Review URL: https://codereview.chromium.org/111723012

TBR=mgiuca@chromium.org

Review URL: https://codereview.chromium.org/139303014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245470 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333600

Review URL: https://codereview.chromium.org/139543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245468 0039d316-1c4b-4281-b951-d872f2087c98

Avoid unneccessary copy of structures gfx::PointF
by passing them by const ref rather than value.

Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple parameters.

Pass by value creates unneccessary overhead which should be avoided.

BUG=159273

R=danakj, enne, piman

Review URL: https://codereview.chromium.org/139233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245467 0039d316-1c4b-4281-b951-d872f2087c98

It is allowed to send metadata and file contents at the same time with Drive API.

BUG=260539
TEST=unit_tests

Review URL: https://codereview.chromium.org/139153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245466 0039d316-1c4b-4281-b951-d872f2087c98

Made red outline match NSPopUpButton pixel for pixel.

R=rsesek@chromium.org
BUG=325492

Review URL: https://codereview.chromium.org/138943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245465 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334379

Review URL: https://codereview.chromium.org/138593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245464 0039d316-1c4b-4281-b951-d872f2087c98

Added some quick searches that are usually performed in
sync to find out which objects are not updated and have
pending updates not being done.

Currently it implements IS_UNSYNCED, IS_UNAPPLIED_UPDATE, both, and
IS_DEL.


BUG=154378

Review URL: https://codereview.chromium.org/138273009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245463 0039d316-1c4b-4281-b951-d872f2087c98

This patch converts methods getLeadPath, setLeadPath, getSelectedPaths and setSelectedPaths to *Entry/*Entries.

TEST=Tested manually. Partly browser tests.
BUG=320967

Review URL: https://codereview.chromium.org/138033007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245462 0039d316-1c4b-4281-b951-d872f2087c98

Without rebuilding, stale command states are used.
That may leave menu items incorrectly enabled/disabled.
Fixes a regression from http://crrev.com/244436

BUG=334604
TEST=Bug doesn't repro; omnibox and textfield context menu items are enabled or disabled as expected on each menu invocation.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/137893017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245461 0039d316-1c4b-4281-b951-d872f2087c98

This adds necessary BindTexImage/ReleaseTexImage calls to
ResourceProvider::TransferResource.

BUG=334747

Review URL: https://codereview.chromium.org/132873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245460 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements nacl_irt_clock on non-sfi mode,
which is simply proxying to the glibc implementation.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Tried to call a newly added function from plugin via AT_SYSINFO.

Review URL: https://codereview.chromium.org/139303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245459 0039d316-1c4b-4281-b951-d872f2087c98

Delete no-op branch in isolate after fix for https://code.google.com/p/swarming/issues/detail?id=63 .

BUG=321878
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/140383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245458 0039d316-1c4b-4281-b951-d872f2087c98

chrome.management.uninstall is changed as follows unless the extension is trying to
uninstall itself:
- The confirmation dialog is shown by default.
- A user gesture is required.

BUG=178319

Review URL: https://codereview.chromium.org/137793011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245457 0039d316-1c4b-4281-b951-d872f2087c98

This was caused by a recent regression after refactoring. The volume manager was not available in the background file operation manager.

In this CL, the above problem is resolved by moving calls to the volume manager to the foreground.

TEST=Tested manually. Partly browser tests.
BUG=333180

Review URL: https://codereview.chromium.org/137743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245456 0039d316-1c4b-4281-b951-d872f2087c98

Useful in case the network is unavailable.

BUG=333399

Review URL: https://codereview.chromium.org/137563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245455 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=git cl try

Review URL: https://codereview.chromium.org/137533009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=323097
TEST=added auto tests, and manually tested by samples apps for the API

Review URL: https://codereview.chromium.org/137343008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245453 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245452 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334716

Review URL: https://codereview.chromium.org/137063011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245451 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245450 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334126

Review URL: https://codereview.chromium.org/136343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245449 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165253:165259&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/141353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245448 0039d316-1c4b-4281-b951-d872f2087c98

We used to call GCMClient::Get() to get the single instance. This did not
work when we need to pass some initialization data from browser to it.
GCMClientFactory is introduced such that GCMClient instance can be
created, initialized and used in GCMProfileService::IOWorker.

BUG=284553
TEST=existing tests

Review URL: https://codereview.chromium.org/135903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245447 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331940, 334726
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/135843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245446 0039d316-1c4b-4281-b951-d872f2087c98

[2/2] Unifies LayerTreeHost::SetNeedsUpdateLayers and SetNeedsAnimate

They basically do the same thing except that SetNeedsAnimate makes the next
commit non-cancellable. However there is really no reason why SetNeedsAnimate
need to enforce a commit even if no tiles are updated and no layer properties
changed.

SetNeedsAnimate is thus merged into SetNeedsUpdateLayers. The proper use of
it is when there are potential layout/tile changes, we can use it to defer
calculation until the next frame. A commit will be scheduled but can be
cancelled if no updates are needed after calculation.

This part of the patch changes code behavior slightly.
SingleThreadProxy::SetNeedsUpdateLayers was originally implemented as
RenderWidget::ScheduleComposite but now it is RenderWidget::ScheduleAnimation.
ThreadProxy::SetNeedsAnimate was non-cancellable but is now cancellable.

[1/2] Cleanup RenderWidget::scheduleComposite/scheduleAnimation

scheduleComposite has been renamed to ScheduleComposite as it is no longer
a part of WebWidgetClient API.

scheduleAnimation has been renamed to ScheduleAnimation. The semantics is to
schedule a composite and also (potentially) animating WebWidget.

A new WebWidgetClient API scheduleUpdate has been added, to replace the old
scheduleAnimation. The semantics is to notify the embedder that something in
the WebWidget may change in 0 seconds. (i.e. it is allowed to be called
during a redraw, in such case another redraw will be scheduled after frame
delay.

This part of the patch should not change code behavior.

BUG=316929
R=danakj,jamesr,jochen

Review URL: https://codereview.chromium.org/133263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245445 0039d316-1c4b-4281-b951-d872f2087c98

The two simple functions here only have one caller each, so move them
closer to where they are used.

BUG=none

Review URL: https://codereview.chromium.org/132203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245444 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245443 0039d316-1c4b-4281-b951-d872f2087c98

This moves third_party/html_office to chrome/browser/resources/pdf. Currently
html_office is only used by the pdf component extension, it isn't third_party
code and it's more difficult to use the code from it's current location.
The repo is also still empty so this shouldn't result in a lot of dwarf files.

BUG=303491

Review URL: https://codereview.chromium.org/131643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245442 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes the fake Drive/root entry, which was a hack. Along the way, the labels got moved away from the fake entries.

TEST=Tested manually. Partly browser tests.
BUG=334512

Review URL: https://codereview.chromium.org/135753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245441 0039d316-1c4b-4281-b951-d872f2087c98

Add two benchmark variants of smoothness with key_silk_cases.
smoothness.disable_gpu_rasterization.key_silk_cases:
  run with GPU rasterization explicitly diabled (but use impl-side painting)
smoothness.enable_gpu_rasterization.key_silk_cases:
  run with GPU rasterization enabled (implies impl-side painting).

R=nduca@chromium.org
BUG=

Review URL: https://codereview.chromium.org/135223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245440 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin@chromium.org,isherman@chromium.org,thakis@chromium.org,jam@chromium.org

Review URL: https://codereview.chromium.org/130433008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245439 0039d316-1c4b-4281-b951-d872f2087c98

This quad type just carries a surface ID to be resolved later. A quad of this type will always be replaced by the quads it represents (if any) before being passed to a cc:DirectRenderer for drawing.

BUG=334090

Review URL: https://codereview.chromium.org/127373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245438 0039d316-1c4b-4281-b951-d872f2087c98

StunRequest requires the AsyncResolver object produced by the configured
SocketFactory to resolve the address of the STUN server before it can
send the STUN requests. ChromiumSocketFactory currently produces
DummyAsyncResolver, which doesn't do any resolving.

The fix is to provide Libjingle's talk_base::AsyncResolver.

BUG=333958

Review URL: https://codereview.chromium.org/141083007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245437 0039d316-1c4b-4281-b951-d872f2087c98

When chrome signin page is embedded in the avatar bubble, context menu should be disabled, because the only option 'inspect element' would open a debugger window, which then immediately disappears since the avatar bubble auto closes when it loses focus.

BUG=313272

Review URL: https://codereview.chromium.org/141083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245436 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334313
TEST=ash_unittests --gtest_filter=*RevertDockedDragRevertsAttachment*
TEST=Manual on Chromebook

Review URL: https://codereview.chromium.org/141053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245435 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=331544

Review URL: https://codereview.chromium.org/124533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245434 0039d316-1c4b-4281-b951-d872f2087c98

This flag makes browser windows use the system window dressing and title
bar, instead of the custom frame. This is a Linux Aura equivalent of the
"Use System Title Bar and Border" preference in Linux GTK. (Eventually,
this part will be controlled by the same preference, rather than this
flag.)

With this flag, browser windows use the native system window decoration,
with our custom close/minimize/maximize buttons removed, and the tab
strip being condensed vertically with square corners (like the maximized
tab strip).  Popup browser windows (including V1 apps and the Developer
Tools window) drop the blue custom frame altogether in favour of the
native frame.

BUG=317859
TEST=With --use-system-title-bar, open a browser window. Both maximized
and restored windows should have a system native title bar, and the tab
strip should be compacted into a single row (as when maximized).
TEST=With --use-system-title-bar, open a hosted app window. It should
have a system native title bar, with no second blue title bar.

Review URL: https://codereview.chromium.org/111723012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245433 0039d316-1c4b-4281-b951-d872f2087c98

[chromedriver] Add an error autoreporting feature that automatically raises errors from browser logs

BUG=chromedriver:543

Review URL: https://codereview.chromium.org/101203012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245432 0039d316-1c4b-4281-b951-d872f2087c98

Plan is to add a RGB565 readback and copy conversion for RGBA8 to RGB565 in GLHelper.

BUG=323150

Review URL: https://codereview.chromium.org/88033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245431 0039d316-1c4b-4281-b951-d872f2087c98