- 19 Sep, 2017 40 commits
-
-
Philip Jägenstedt authored
Reported by Simon Pieters. No-Try: true Change-Id: I466202c42da81f89083cc3479035b2cb1924e8af Reviewed-on: https://chromium-review.googlesource.com/672366Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#502829}
-
Iulia Harasim authored
This CL changes the personalized signin promo's description in Recent Tabs on both iOS and Android. Bug: 766312 Change-Id: I6197e39fdc874e74124ce282085429c8001db131 Reviewed-on: https://chromium-review.googlesource.com/671352Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Iulia Harasim <iuliah@google.com> Cr-Commit-Position: refs/heads/master@{#502828}
-
Kent Tamura authored
|basename| is a base of the name 'V8*Partial'. So it's an interface name, not a file basename. Bug: 760462 Change-Id: Ic04bc604aea37a33d8c78fa4cc505fe3f30b120e Reviewed-on: https://chromium-review.googlesource.com/672029Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#502827}
-
Vitalii Iarko authored
The color is encoded as @ColorInt with alpha channel equal to 255. In the JNI bridge the absence of color is encoded as 0, because we would not have a fully transparent color anyway. Bug: 754183 Change-Id: I236a1e4e0659a9e732ad437cdb295fe6056737f4 Reviewed-on: https://chromium-review.googlesource.com/671347 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#502826}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 435a341a. With Chromium commits locally applied on WPT: 2803f82c "Add web platform test for getUserMedia with feature policy applied" Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2048 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: Idffa132b324ab1b94398fd4d6a6f65e1b15f8b07 Reviewed-on: https://chromium-review.googlesource.com/672213 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502825}
-
Manuel Rego Casasnovas authored
As a follow-up of r501249, this patch does a small refactoring adding a new method LayoutGrid::ContentAlignment() that is from LayoutGrid and GridTrackSizingAlgorithm. Change-Id: I4c057ef2ef47decbe76d3dac2140ee8deb0e515f Reviewed-on: https://chromium-review.googlesource.com/663395Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#502824}
-
Xida Chen authored
This is a follow-up for the previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/667323 TBR=junov@chromium.org Bug: 725651 Change-Id: I438a4210e28ff85d051de5103f33e2b81197f2e4 Reviewed-on: https://chromium-review.googlesource.com/670924Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#502823}
-
Tatiana Gornak authored
This CL implements following logic: 1. "Generate a strong password..." fallback is shown 2. When user clicks on the fallback NO PASSWORD IS GENERATED. Instead the generation bubble is shown. 3. Only if the user clicks on the generation popup, then the password is generated and pre-saved. In this CL if user clicks out of the password field and then clicks back, the generation popup will appear again. No decision on what should appear was made yet. BUG=739343 Change-Id: Ib01bb2a24f5106b29afd1f0ce1efac2aa830a06e Reviewed-on: https://chromium-review.googlesource.com/594148 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#502822}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d6ef217affb3..08d6322ff7a5 $ git log d6ef217af..08d6322ff --date=short --no-merges --format='%ad %ae %s' 2017-09-19 perezju [Telemetry] Adjust wait after forcing Garbage Collection Created with: roll-dep src/third_party/catapult BUG=690042 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I4db179f81a4b18b210243ba918d4591edec7c042 Reviewed-on: https://chromium-review.googlesource.com/671219 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502821}
-
Stephen Martinis authored
This will be used by the one buildbot step effort for perf builders. This CL shouldn't have any effect when it lands. Bug: 758630 Change-Id: I2e8434a975be2908427e5c6fd0091a5f1490f5bf Reviewed-on: https://chromium-review.googlesource.com/629962 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#502820}
-
David Roger authored
When a reconcile is done, the first account is kept in memory. Then later, if the first account is missing (i.e. the user is not signed in, and the Gaia cookie is lost), the cached first account is reused if possible (i.e. if the token is still there). The main (only) practical use case for this behavior is when the user manually clears the Gaia cookies from the Chrome settings. When this happens, Dice will rebuild the Gaia cookie, and this CL ensures that the default Google account will be the same as before the cookie clear. Bug: 764303 Change-Id: I62f31527a4d5235362ad0d48c0fc6ab7b4d72571 Reviewed-on: https://chromium-review.googlesource.com/666621 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#502819}
-
Sahel Sharify authored
Bug: 684691 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5ebf3fcff043b01f02fdbabdaf171fa13e838392 Reviewed-on: https://chromium-review.googlesource.com/658277 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#502818}
-
Kent Tamura authored
Add "basename" parameter to template("generate_global_constructors"), and generate snake_case IDL files and C++ header files. This is a preparation of the Great Blink mv. At this momnet, we only have lists of global scope interface names in *.gn. After the great mv, it's difficult to produce generated IDL list and C++ header list from the interface names in *.gn. So we need to introduce additional snake_cased interface list. Bug: 578345 Change-Id: Ia7f861e43d9b622926adde0280e4297c71bcc750 Reviewed-on: https://chromium-review.googlesource.com/672225Reviewed-by: -
John Wu authored
//components/autofill/ios/browser to be shared. //ios/web_view would like to integrate autofill as a feature, and could benefit from sharing as much code as possible with //ios/chrome. Bug: Change-Id: I7126d69a59fe85265a934a1ddcbe915ca21e6f28 Reviewed-on: https://chromium-review.googlesource.com/658205 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#502816}
-
Lisa Suzuki authored
This CL's intention is to adjust to the change of WebIDL's specifications. This CL enables types to be annotated types in Typedef and NonAnyType. In order to check if ASTs are dumped correctly and if the code generator works correctly, I also added pattern match based tests and code generator's tests. Bug: 714866 Change-Id: I3f04365eca44a646a92796028479744d9bd4dce8 Reviewed-on: https://chromium-review.googlesource.com/668353 Commit-Queue: Lisa Suzuki <lisabelle@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Shubhie Panicker authored
This uses same mechanism as timer suspension, a finch flag will be added next. Bug: 653493 Change-Id: Ie0e90b03c402664114b9a7aeee6818bfb53a0cb6 Reviewed-on: https://chromium-review.googlesource.com/653493 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#502814}
-
Olivier Robin authored
Bug: 755620 Change-Id: Id22d2b9b986494328f7dcf93d06771118e44289c Reviewed-on: https://chromium-review.googlesource.com/671007Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#502813}
-
Daniel Bratell authored
Both PODFreeListArenaTest and PODArenaTest had local test classes naemd TestClass and those collided in jumbo build. This patch changes the colliding names to be more unique inside blink/platform. Bug: 745732 Change-Id: I8b31e62125c0e0eb84103d91f3e28dd9decd3f5f Reviewed-on: https://chromium-review.googlesource.com/671265Reviewed-by:
-
Daniel Bratell authored
Jumbo didn't like that there were two TestExtraData classes in platform/exported tests so this adds appropriate prefixes to them. Bug: 745732 Change-Id: I9286225bf37dd39342e28aec8ddcca3da6504063 Reviewed-on: https://chromium-review.googlesource.com/671270Reviewed-by:
-
Raymes Khoury authored
A real UserMediaClient needs to be used to make these tests pass so that the feature policy is checked correctly. BUG=689802 Change-Id: I769c080c1e6eccb1791e032ab5d456b491e3760d Reviewed-on: https://chromium-review.googlesource.com/654021 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Daniel Bratell authored
Supporting jumbo in blink/platform/loader saves about 2.5 CPU minutes of effort which is about 0.3% of the remaining build time. Not much but it's only a few added characters. Bug: 761475 Change-Id: I3ca17ff6fefb04c43dd9571aea5e749bfe86b81d Reviewed-on: https://chromium-review.googlesource.com/671231Reviewed-by:
-
Daniel Bratell authored
There are InsertionAndDeletionTest functions in both PODIntervalTreeTest and PODRedBlackTreeTest and in jumbo builds they collide. This patch renames one of them TreeInsertionAndDeletionTest. Bug: 745732 Change-Id: Ieba300f4532695060250cb70f88f53713158ccf1 Reviewed-on: https://chromium-review.googlesource.com/671228Reviewed-by:
-
Sylvain Defresne authored
The asset catalog compiler (actool) can generate a partial Info.plist file that needs to be merged with the application Info.plist at build time (this is needed to support application icon in Assets.car). Add a partial_info_plist property to create_bundle that can be passed to compile_xcassets tool and ensure that the file will be created even if no asset catalogs are compiled. Bug: 764286 Change-Id: I6810f7d3aad647cff5f2ba99c49ba2fdd3c972d7 Reviewed-on: https://chromium-review.googlesource.com/668936Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#502807}
-
Daniel Bratell authored
Several utility functions existed in both HeapTest.cpp and HeapCompactTest.cpp. This patch moves them to a shared file so that they don't collide in jumbo builds. Also, less duplicate code is better. Bug: 761475 Change-Id: Ia5a4bb0b205646564ccec7e87150283837028191 Reviewed-on: https://chromium-review.googlesource.com/671267Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 86828bb7. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2046 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=qyearsley@chromium.org No-Export: true Change-Id: Ice67596ba4bc5be140149f45349fd1512d8e19e1 Reviewed-on: https://chromium-review.googlesource.com/672209 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Boris Sazonov authored
This CL adds FakeProfileDataSource to FakeAccountManagerDelegate that can provide profile data for various tests. It also removes unused parameter from FakeAccountManagerDelegate signature. TBR=nyquist@chromium.org Bug: 746519 Change-Id: I0348ccd22fcd1a14d910fc9344583fd61789e5b6 Reviewed-on: https://chromium-review.googlesource.com/671043 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
When the display type changes for an element in the DOM tree, the WhitespaceAttacher would re-attach whitespace siblings appropriately when traversing the re-attached element. When a DOM node is removed from the tree, there will be no layout tree rebuild. Or, at least, the removed node will not be encountered by the traversal to trigger a re-attachment of any following whitespace nodes. In order to fix that, introduce a hash set which contains elements which had one of their layout tree children removed since the last layout tree update. In the next UpdateStyle mark these elements for layout tree rebuild and let the WhitespaceAttacher check if any of its whitespace children needs to be re-attached. Bug: 763291, 762833, 364817 Change-Id: I4d1b3df10d07f549abfea17df0184beca0623ef7 Reviewed-on: https://chromium-review.googlesource.com/661957 Commit-Queue: Rune Lillesveen <rune@opera.com> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#502803}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/490a2884..9c5a43d3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I2a4aa6ac5aca012189c7e3d7d322aacb54702950 Reviewed-on: https://chromium-review.googlesource.com/672140Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#502802}
-
Loo Rong Jie authored
Switch to use Win32 CONDITION_VARIABLE like the rest of Chromium. This greatly simplifies the implementation of ThreadCondition class for Windows with better performance. Change-Id: If4d007ddf4c8f115c0f5363dc234d220d2fe9ee8 Reviewed-on: https://chromium-review.googlesource.com/670200Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#502801}
-
Greg Thompson authored
This change also adds test coverage for kUserLogOff and kOtherClose handling. BUG=717091 Change-Id: I4ed650e766df6f39d26682c275c699b8a364a55f Reviewed-on: https://chromium-review.googlesource.com/667336 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#502800}
-
Fady Samuel authored
This is a generalization to the 669444 CL. If a fallback SurfaceDrawQuad is provided but the Surface is unavailable at aggregation time then put a SolidColorDrawQuad in its place. For release builds without DCHECK, use the default background color provided by the parent. For DCHECK builds, use Magneta to highlight that this is a bug. Bug: 766013 Change-Id: Ide73d60cd4f47b8e905f5011f67561811cf70aaa Reviewed-on: https://chromium-review.googlesource.com/671158Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#502799}
-
Tetsui Ohkubo authored
This CL adds new material design icon to mobile data notifications. This CL also adds title "Mobile Data" to the notification. The icon is effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG=726241 Change-Id: Ia71759dbbe44b1472721c784bb4e1c59b9a7df53 Reviewed-on: https://chromium-review.googlesource.com/666399 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#502798}
-
Peter E Conn authored
Now that Scroll to Load depends on whether the phone is in accessibility mode or not, its state can change as Chrome runs. Because of this we can no longer not initialize the footer when Scroll to Load is disabled. Bug: 765695 Change-Id: Ic4e37bd74b12790b50458f936a07521830d25ac6 Reviewed-on: https://chromium-review.googlesource.com/671049Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#502797}
-
Yuichiro Hanada authored
Bug: None Change-Id: I1574d037bf7af1a32c6f9f1123d7e6e318ea69f0 Reviewed-on: https://chromium-review.googlesource.com/671306Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#502796}
-
Rijubrata Bhaumik authored
Add and record UMA for R16_EXT and LUMINANCE_F16. We add the UMA for both these formats as it would be nice to get rid of one or the other eventually. Bug: 759456 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iaee25dff684312229ceb408dbfde76985e566629 Reviewed-on: https://chromium-review.googlesource.com/635463 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#502795}
-
Kent Tamura authored
In _create_basename_maps(), we should skip bindings/tests before updating header_pattern because we don't add ConditionalFeturesForCore.h to header_pattern. Bug: 578345 Change-Id: I20a2160aecf48c99356f3c513d17633c217e6215 Reviewed-on: https://chromium-review.googlesource.com/672185Reviewed-by:
-
Sahel Sharify authored
The added test will fail with wheel scroll latching enabled and without applying this cl. Bug: 763422 Test: SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest Change-Id: I67ad586211f9d740b4652ed40ec0d260bd2c4abe Reviewed-on: https://chromium-review.googlesource.com/658217Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#502793}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dcf4cac7..490a2884 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I41988552073ae27efdb44065b2511043569e5cc7 Reviewed-on: https://chromium-review.googlesource.com/672125Reviewed-by:
-
Ulan Degenbaev authored
This affects: - memory.long_running_idle_gmail_tbmv2 - memory.long_running_idle_gmail_background_tbmv2 Bug: chromium:730036 Change-Id: I5a6d0c1d103f52874dba2b9a663aed80835674e1 Reviewed-on: https://chromium-review.googlesource.com/670726Reviewed-by:
-
Jan Krcal authored
This CL expands error reporting for fetching favicons from the Google favicon server. This change helps to better understand high ratio of FAILURE_INVALID status in logs. Bug: 765575 Change-Id: Id8ce67bd9371facc31cb24176973b0a8576ef128 Reviewed-on: https://chromium-review.googlesource.com/667112Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#502790}
-
