- 15 Mar, 2018 40 commits
-
-
Andrey Kosyakov authored
BUG=812464,721408 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I39b237ba370dc65febbb52e8d31b1d01d4c35d10 Reviewed-on: https://chromium-review.googlesource.com/956685 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543475}
-
Rouslan Solomakhin authored
Before this patch, browser tests for PaymentRequest would print warnings about deprecation of: 1) Using an array for 'supportedMethods'. 2) Specifying card networks in 'supportedMethods'. This patch modernizes the browser test by: 1) Converting single-element 'supportedMethods' arrays into strings. 2) Splitting up multi-element 'supportedMethods' arrays into arrays of objects with a single string 'supportedMethods' value in each object. 3) Using 'basic-card' in 'supportedMethods'. 4) Specifying card networks in 'supportedNetworks'. After this patch, browser tests for PaymentRequest don't print warnings about deprecation. Bug: NONE Change-Id: I777f299ce32353fbf6a54fb4f839c3bfd19517a9 Reviewed-on: https://chromium-review.googlesource.com/962928 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#543474}
-
Donn Denman authored
Adds another histogram to use to validate that our logging to Ranker for ML using features and outcomes is complete and balanced. This new histogram logs that features are available to Ranker when two key UX events occur: 1) A tap gesture is recognized that we commit to processing, 2) Each show of the Bar (for outcomes). The resulting histogram should highly correlate with the existing histogram that tracks actual logging of features and outcomes to Ranker. BUG=802963 Change-Id: I43e6ba711fa8fb91ea1d484e7399ef07aa5aa6bd Reviewed-on: https://chromium-review.googlesource.com/959445Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#543473}
-
sczs authored
- Adds a subtitle label to table_view_text_header_footer_item - Sets this label as a timpestamp for RecentTabs sessions headers. Screenshot: https://drive.google.com/open?id=1yamLSxBoFXm0la14ZLVxsEqMMcbFu6BC Bug: 805698 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2318b02df397d603285034a642fd75c7efb20953 Reviewed-on: https://chromium-review.googlesource.com/963674 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#543472}
-
rbpotter authored
Use ScopedRestoreDefaultLocale and correct variable name style. Bug: 819806 Change-Id: I51436ceba079c411c051c602bbf9a1d90b3bfc32 Reviewed-on: https://chromium-review.googlesource.com/963749Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#543471}
-
Illia Martyniuk authored
Moving UI specific methods from UI Element to either Window, View or Widget. Once we create common UIElement for UI and Viz it'll be easier to follow changes since this refactor is done. Common UIElement will not know about the functions moved in this CL, so I think it's better to do this now. Bug: 775348 Change-Id: Ife9d9150ad9de704272c62dc16c177064f4eccdb Reviewed-on: https://chromium-review.googlesource.com/962356Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Illia Martyniuk <illiam@google.com> Cr-Commit-Position: refs/heads/master@{#543470}
-
Geoff Lang authored
TBR=iannucci@chromium.org NOTRY=true BUG=820190 Change-Id: I926d479b6c2051ba93842174d1dc468524f0e158 Reviewed-on: https://chromium-review.googlesource.com/964784Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#543469}
-
Dave Schuyler authored
This Cl updates the color of icons in invalidate (e.g. selection or theme changes). Bug: 821342 Change-Id: Icbd861b443ed9d0125121641f94e1ec6aeb1865c Reviewed-on: https://chromium-review.googlesource.com/962680 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#543468}
-
Caleb Rouleau authored
This reverts commit 5d5a062f. Reason for revert: added a failing test https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/32246 see issue 822386 bug: 822386 Original change's description: > Send GSB before switching to mainthread scrolling in smooth scroll path. > > This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling > path,if the compositor handles the GSB and during the scrolling we have to switch to main thread > since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original > GSB was handled on the compositor rather than being sent to the main thread. > > touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main > thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling > in this cl I've moved the test to a new virtual test suite that has default scroll animation > value. > > I have removed the test expectations since I have changed the test and this might fix the flake. > > subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to > a new test suite. > > Bug: 820979, 708499, 757165, 800840 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0 > Reviewed-on: https://chromium-review.googlesource.com/961264 > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543425} TBR=tdresser@chromium.org,sahel@chromium.org Change-Id: I3c5253d96d011c9723063effac91c969ee352305 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820979, 708499, 757165, 800840 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/963388Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#543467}
-
Ryan Landay authored
There's a sequence of steps (see crbug.com/820902) that can cause the Android tab switcher to enter a state where it's showing a margin for the incognito tab stack, even though the stack is empty and we normally wouldn't allow switching to it. This CL fixes a regression when performing this sequence of operations that allows switching back and forth to the empty tab stack. The regression was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/933061. This CL does not fix the margin issue, which would be more involved to debug. Bug: 820902 Change-Id: I7255f430637d7f13d2dd63ce42f2e147f6a51e9c Reviewed-on: https://chromium-review.googlesource.com/959569 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#543466}
-
Sean Kau authored
We're building urls to make printer attribute requests to printers directly to check for autoconf support and connectivity. Ensure that there is only one '/' between the authority and queue. Bug: 819280 Change-Id: I0be201f46b344b807e121326f9bbf1d86565de32 Reviewed-on: https://chromium-review.googlesource.com/960939 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#543465}
-
Dominik Röttsches authored
The existing logic was to exclude segmenter output that does not overlap with range start and range end (HarfBuzzShaper::Shape) and to restrict shaping to the character indexes of the queue items that contribute to the desired range. However, the latter restriction only worked if the case mapping for small caps did not chop up the queue items further, due to case change segmentation. Adding an early-out if the result of case mapping chopping produces queue items that fall outside the desired range. Thanks to kojii@ for the report and initial test case. Bug: 817271 Test: RangeShapeSmallCaps Change-Id: If8c0b00343e7b1c9a342305e5f44fa515ba3576c Reviewed-on: https://chromium-review.googlesource.com/964445Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#543464}
-
Eric Stevenson authored
It isn't necessary and reduces the number of methods in the main dex by ~100. Bug: 820361 Change-Id: Id08cdf771b255c8ad2de8be46c2dadd69270e029 Reviewed-on: https://chromium-review.googlesource.com/956966Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#543463}
-
Gabriel Charette authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/941264 Now that only BrowserThread::UI/IO remain: APIs used to prevent further abuse in other BrowserThreads during their deprecation are no longer needed :). R=fdoray@chromium.org Bug: 815225 Change-Id: Ifa952367cd2ba87d035c14f0428393644503ef18 Reviewed-on: https://chromium-review.googlesource.com/963361 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#543462}
-
Xi Cheng authored
This should fix the issue that notification activation is not working in some cases. Bug: 734095, 821793 Change-Id: If19f1c802b7da3b1cd0476c0a585138a2d2edcaa Reviewed-on: https://chromium-review.googlesource.com/963685Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#543461}
-
https://webrtc.googlesource.com/src.git/+log/a12b1d625cc9..853715c9a906 $ git log a12b1d625..853715c9a --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8b5d3c31201110a2a1c5cb0322b0f2f1c8fbb4a6 Reviewed-on: https://chromium-review.googlesource.com/964385Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543460}
-
Helen Li authored
This test is flaky on Mac. This CL disables it temporarily. Bug: 821224 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I909087ed5102631fdca68b45d9a0c4b6810410fc Reviewed-on: https://chromium-review.googlesource.com/964614Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#543459}
-
https://chromium.googlesource.com/catapult.git/+log/6c4a8ca2e9bc..1446cf3fe8a3 $ git log 6c4a8ca2e..1446cf3fe --date=short --no-merges --format='%ad %ae %s' 2018-03-12 tiborg [vr] Fix draw metrics in frameCycleDurationMetric 2018-03-13 perezju [Telemetry] Let Telemetry find the embedder APK for WebView Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I729e915f328d914579609e93cec723aa64c597a7 Reviewed-on: https://chromium-review.googlesource.com/963838 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543458}
-
Emily Hanley authored
Bug: 779634 Change-Id: Ifbc4d5736cef4ceda239b5a5efe31533a4a01e78 Reviewed-on: https://chromium-review.googlesource.com/963083Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#543457}
-
Dave Schuyler authored
This CL uses CanProcessEventsWithinSubtree to stop enter/exit events to text and image elements. Bug: 820892 Change-Id: Ice5adc61ba617db3119eea9a99d10255888aa840 Reviewed-on: https://chromium-review.googlesource.com/962665Reviewed-by:
-
Cathy Li authored
Bug: 812022 Change-Id: I8cb1c8e9566bf4fb92f67ef5b8c9e434467e647b Reviewed-on: https://chromium-review.googlesource.com/944620 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#543455}
-
wutao authored
This cl changes one string in Keyboard Shortcut Helper to make it more clear to the users. Bug: b/74186947 Test: manually tested. Change-Id: I4af4d7a99c9a279a775309e58584c06e63f7a136 Reviewed-on: https://chromium-review.googlesource.com/964586Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#543454}
-
Owen Min authored
Browser test for crrev.com/027059d8. Bug: 820649 Change-Id: I8f9cd3a53b702ce67b62fd6986b469c426ad1f84 Reviewed-on: https://chromium-review.googlesource.com/961541Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543453}
-
Tarun Bansal authored
Add an explicit DCHECK in the data reduction proxy (DRP) to ensure that we do not check for explicit bypasses in the responses. Bug: 760294 Change-Id: Ifd683efc79d484388f2446757e9025068c1d6fb8 Reviewed-on: https://chromium-review.googlesource.com/963100Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#543452}
-
Andrew Grieve authored
Allows for better inlining by ProGuard. TBR=agrieve # Simple rename Change-Id: If0b57507aeae938bdbe2adbd62e5d38c0d50ab4c Reviewed-on: https://chromium-review.googlesource.com/964383Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/0b0dcbc1cffa..41918387cc52 $ git log 0b0dcbc1c..41918387c --date=short --no-merges --format='%ad %ae %s' 2018-03-13 lucferron Vulkan: Additional texture formats support. RGB565, RGBA4444, RGBA5551 Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I0e12575bd41525577314faf73fd7f5e6b6974db3 Reviewed-on: https://chromium-review.googlesource.com/964602Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543450}
-
John Abd-El-Malek authored
There are two fixes: -ensure that intercepted navigations have the correct StoragePartition: this was currently not true because ResourceDownloader::InterceptNavigationResponse was using empty site url. The fix is to pass the right one in from DownloadManagerImpl::InterceptNavigationOnChecksComplete. This is similar to the fix in r528794 but instead of for new downloads, it's for intercepted downloads. -pass the (now correct) StoragePartition to BeginDownloadInternal, instead of it creating it from the render frame ID, as that doesn't work with storage partitions for web views. Bug: 769401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I65caeaefbf489ab5a2c955d8a7a8d0efb562d281 Reviewed-on: https://chromium-review.googlesource.com/957983Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#543449}
-
Anita Woodruff authored
- This test was frequently timing out the net_unittests on multiple platforms. TBR=juliatuttle@chromium.org Bug: 820950 Change-Id: I1e24c286824b678db290ad1116f463c314a045cd Reviewed-on: https://chromium-review.googlesource.com/964661Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#543448}
-
Fady Samuel authored
I stumbled upon the need for some cleanup in deadlines while investigating a surface sync bug. SurfaceDependencyDeadline::InheritFrom returned a bool that wasn't used anywhere anymore. This CL removes it. This CL also clarifies the InheritFrom contract. When deadline object A inherits from deadline object B, A gets B's deadline but does not get B's start time. This was already true but this CL adds direct test coverage of this. The other oddity is InheritFrom only supported deadline inheritance if the object already had a deadline set. This is how it's used by surface sync in practice but seems unnecessarily brittle. With a small change, the contract is fully specified and this special case is removed. Bug: 672962 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Icd6a078ef90298af578c7267ca38f5c0f3ab5d37 Reviewed-on: https://chromium-review.googlesource.com/964257 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#543447}
-
Miguel Casas authored
VaVDA passes a UMA callback of sorts to VaapiWrapper to mark error conditions (Media.VAVDA.DecoderFailure) but there's no baseline for the amount of times it succeeds: this CL adds it as Media.VAVDA.VaapiWrapperCreationSuccess. It also adds a Media.VaapiWrapper.VADisplayStateInitializeSuccess to track the success/fail of initialising the VADisplayState, which we suspect to fail at times in the field. It also adds a "Vaapi" prefix to some traces so that they can be visually related in chrome:tracing. Bug: 717265 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib841dca9626f2bed53a39b8bfd756d29c99b553e Reviewed-on: https://chromium-review.googlesource.com/962709Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#543446}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/703b4a85a21e..a325ad2db5de $ git log 703b4a85a..a325ad2db --date=short --no-merges --format='%ad %ae %s' 2018-03-14 misterg erging, cont 2018-03-13 misterg merging, merging 2018-03-13 misterg fixing, was removing too much 2018-03-13 misterg More merges, removing old dead code 2018-03-12 bauerb Allow macros inside of parametrized test names. 2018-03-12 misterg merges-port(1) 2018-03-07 misterg Merging, XML tests Created with: roll-dep src/third_party/googletest/src Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official Change-Id: I28944f5f6293d391c221dda2d67a8342de89062a Reviewed-on: https://chromium-review.googlesource.com/963706Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#543445}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ied9c3836a042a7278ba5833fc05d3df47ab38877 Reviewed-on: https://chromium-review.googlesource.com/963834 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#543444}
-
Robert Liao authored
The first kFocusPage config has been skipped since at least the initial public commit and appears to be an oversight. https://chromium.googlesource.com/chromium/src/+blame/09911bf300f1a419907a9412154760efd0b7abc3/chrome/browser/browser_focus_uitest.cc#186 BUG= Change-Id: If17bfc7594d57ea62e5508b8912abcd628d5a0bf Reviewed-on: https://chromium-review.googlesource.com/964608Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#543443}
-
https://pdfium.googlesource.com/pdfium.git/+log/40c223e4ed41..d1ffda2acaee $ git log 40c223e4e..d1ffda2ac --date=short --no-merges --format='%ad %ae %s' 2018-03-15 thestig Cleanup CStretchEngine. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7d16e2a8ed63b5fcb7295d8bcb35b68abe672218 Reviewed-on: https://chromium-review.googlesource.com/964388 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543442}
-
Shakti Sahu authored
This CL adds support for upload in the download driver, model, client and entries. The upload logic and state machine changes in the controller will be added in another CL. Bug: 812327 Change-Id: Ib3b60e2ad71740a28b0aa53a08cce9b046ab6e9e Reviewed-on: https://chromium-review.googlesource.com/919867 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL moves ReplacePlaceholders() to //content in preparation for using ReplacePlaceholders() in manifest_parser.cc Change-Id: Ia4fb6533bcc6f914e3e5499577edb2212583af8a Reviewed-on: https://chromium-review.googlesource.com/924550 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#543440}
-
Derek Cheng authored
- On channel error, erase the sink from |current_sinks_map|. crrev.com/541271 added a check in OpenChannel() to short circuit if a sink already exists on the map. In order for retry on error to kick in properly, we will need to erase the entry in OnError(). - In OnChannelOpenSucceeded, erase stale sink with the same IP. This is done to maintain the invariant of having at most 1 sink of a given ID in the map. Stale sink is defined as having the same sink ID but different IP endpoint than the current one. - In OnChannelOpenFailed, when erasing the sink from |current_sinks_map_|, also verify the sink ID. It is possible that a different sink now occcupies the IP endpoint that it is trying to erase. Change-Id: I12bfd5af5f664c4773e7587dc30c6709d2352021 Bug: 698940 Reviewed-on: https://chromium-review.googlesource.com/961555Reviewed-by:
Bin Zhao <zhaobin@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#543439}
-
Ryan Landay authored
I'm splitting most of StackLayout into a base class in https://chromium-review.googlesource.com/c/chromium/src/+/957875 to support building UI prototypes on top of the tab switcher UI. This CL cleans up the interface for child classes so that they don't have to manually manage the list of Stacks. Instead, they can call a setTabList() method with a list of TabLists, and StackLayoutBase will set up the Stacks accordingly. Bug: 648314 Change-Id: I627da998baaf9d74e3fa14da3cf392097a6e0944 Reviewed-on: https://chromium-review.googlesource.com/961442Reviewed-by:
-
Scott Violet authored
DisplayManager's constructor is called from WindowServer's constructor. This means DisplayManager shouldn't call to WindowServer, else we get use of unitialized values like this. BUG=822246 TEST=covered by tests Change-Id: I296911502021a135276a9db49b98927efea95618 Reviewed-on: https://chromium-review.googlesource.com/963831Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#543437}
-
David Bokan authored
Selection bounds are sent from Blink to CC as part of a commit cycle so that we can draw touch handles for it. Currently, the selection bounds are relative to the main graphics layer of a CompositedLayerMapping. In the case of a scroller, this will be its clip rect - rather than its scrolling contents layer. Unfortunately, this means that scrolling on the compositor isn't applied as part of the ToScreen transformation on the selection bounds so scrolling wont update the selection bounds location until another Blink commit. This went unnoticed until now because the root layer was not considered a scroller. The page would paint into a document-sized layer and the compositor would provide extra scrolling layers to handle frame scrolling. In this configuration, the ToScreen transformation from the root layer does include the scroll offset. Now that root layer scrolling has been turned on, frame scrolling works much the same as other scrollers. Thus, this shortcoming is seen on frame scrolling also. The solution in this CL is to move the selection bounds rect to be relative to the scrolling contents layer - if one exists. The ToScreen transformation done in CC will correctly compensate for any scroll offset applied in the compositor and touch selection handles stick to the selection as its scrolled. For the CC side, see ComputeViewportSelectionBound in layer_tree_impl.cc Bug: 812048 Change-Id: I219ac3209d334ac91e9c13ffaaa51cbc9db57886 Reviewed-on: https://chromium-review.googlesource.com/963006Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543436}
-
