- 27 Jun, 2018 40 commits
-
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e58bd8a02b9c..b3f5aed4332b git log e58bd8a02b9c..b3f5aed4332b --date=short --no-merges --format='%ad %ae %s' 2018-06-27 qingsi@google.com Remove the flag PORTALLOCATOR_ENABLE_ANY_ADDRESS_PORTS. 2018-06-27 qingsi@google.com Use the sparse histogram in RTC_HISTOGRAM_ENUMERATION_SPARSE. 2018-06-26 emircan@webrtc.org Add bit depth information to PlanarYuvBuffer 2018-06-26 steveanton@webrtc.org [Unified Plan] Avoid offering two senders with the same ID 2018-06-26 steveanton@webrtc.org [Unified Plan] Do not initialize recvonly transceivers with any send streams Created with: gclient setdep -r src/third_party/webrtc@b3f5aed4332b The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9f8c16944e0cd335ff5fee17bed1585c40897869 Reviewed-on: https://chromium-review.googlesource.com/1116259Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570716}
-
Olivier Robin authored
EGtests bundle don't have access to application groups. Create a test hook to prevent app group access. Bug: 855625 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3c773f92edfdaafb9207d69a51ba6fdee823868b Reviewed-on: https://chromium-review.googlesource.com/1113540Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570715}
-
Friedrich Horschig authored
If the provider registered itself but never provided items, the caching adapter would notify all observers that the last provided actions were null and force them into an undefined state which caused a crash. The proper way to handle this case, is to send an empty set to all observers (see tests for an intuitive use case). Bug: 855036 Change-Id: If3a0e9ee14ac3e24e163ebba092ab47f226e43b7 Reviewed-on: https://chromium-review.googlesource.com/1115220Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#570714}
-
Moe Ahmadi authored
This CL fixes a regression caused by crrev.com/c/1012979. Previously, AutofillAgent would scan the whole page on form activities due to the possiblity of Autofill having been enabled after page load. crrev.com/c/1012979 replaced that logic in favor of observing the Pref directly. This has a side effect where previously hidden fields can go unnoticed by AutofillManager. This CL fixes that regression by scanning the page when a field is focused. All fields receive focuse before their value is set by Autofill, therefore, AutofillManager can get notified of previously hidden fields. Bug: 855696 Change-Id: I175bf90e12d1ca356b746e6347943a295063c288 Reviewed-on: https://chromium-review.googlesource.com/1112493Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570713}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=xdai@google.com Change-Id: I2b3523eed96718ac318f72aaa086b9af6f51fc12 Reviewed-on: https://chromium-review.googlesource.com/1116599Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#570712}
-
Kent Tamura authored
Add a mock implementation of RunFileChooser(), with a testRunner function setFileChooserPaths(). Bug: 637639 Change-Id: Ic5536524b2a5381556605b79e1907429d985e245 Reviewed-on: https://chromium-review.googlesource.com/1114573Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#570711}
-
Marc Treib authored
This is an attempt to deflake the currently disabled SingleClientDirectorySyncTest.SingleClientDirectorySyncTest. The test was failing due to running into the 45s timeout in WaitForExistingTasksOnLoop. The theory is that that's because that function is based on WaitableEvent, and thus doesn't allow processing of events on the main thread while waiting. This CL changes it to spin a nested RunLoop instead. I could never reproduce the flakes locally, so I don't know if this helps at all. As such, this CL leaves the test disabled for now; I'll send a separate one to try re-enabling. Bug: 850980 Change-Id: I16823fe01574662586e578d5f601299c58004286 Reviewed-on: https://chromium-review.googlesource.com/1116549Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#570710}
-
Hajime Hoshi authored
EventQueue is necessary when queued events might be cancelled. This CL replaces unnecessary usages of EventQueue wherever possible for code simplicity. This CL also adds comments about task sources that should have been added at https://chromium-review.googlesource.com/c/chromium/src/+/1114672 Bug: 846618 Change-Id: I610e7163c36faea11f9abd9a7c4550acb5b6188c Reviewed-on: https://chromium-review.googlesource.com/1116516Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#570709}
-
Denis Kuznetsov authored
TBR=alemate@chromium.org Bug: 854101 Change-Id: I4792b0bef59a71d6628da8337043f00ca4b0e5b2 Reviewed-on: https://chromium-review.googlesource.com/1069268Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#570708}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ab7198c3a75..37b7e4714558 git log 4ab7198c3a75..37b7e4714558 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 0265e1ec1eb7..82af620e0559 (6 commits) Created with: gclient setdep -r src/third_party/skia@37b7e4714558 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ice55488c5f690833b8c1745060f136b6a7c0abd9 Reviewed-on: https://chromium-review.googlesource.com/1116559Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570707}
-
Ulan Degenbaev authored
This adds V8.GCFinalizeMC.Evacuate histogram that was not included in the previous CL by mistake: https://chromium-review.googlesource.com/c/chromium/src/+/1095156 Bug: chromium:850508 Change-Id: I309e6de32ae64cdd727480b014ad533920709512 Reviewed-on: https://chromium-review.googlesource.com/1105817Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#570706}
-
Daniel Bratell authored
There were three identical SharedBitmapIdToGpuMailboxPtr functions which converted from viz::SharedBitmapId to gpu::mojom::blink::MailboxPtr and those clashed in jumbo builds, This patch makes all code use the same shared copy in canvas_resource.cc Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic7980af0aa30d7cc90acac1d0846f626ad58671d Reviewed-on: https://chromium-review.googlesource.com/1104461Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#570705}
-
Mikel Astiz authored
These new owners are active members of the client-side team for sync. We exclude sync/protocol to be more cautious with changes that are visible over the wire, for backward-compatibility reasons. Bug: None Change-Id: Icd5ba4a300701bf993de238b04b3d14f00821bc0 Reviewed-on: https://chromium-review.googlesource.com/1116538Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570704}
-
Morten Stenshorne authored
TBR=kinuko@chromium.org Change-Id: I4038a30f19cc582469b16eb4f0625cd12a4ccf5a Reviewed-on: https://chromium-review.googlesource.com/1116543 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#570703}
-
Trent Apted authored
Bug: 850372 Test: GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5ce2e7e3adf1a3619d0cec18c9133f231c2749c0 Reviewed-on: https://chromium-review.googlesource.com/1114525Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#570702}
-
Daniel Bratell authored
This reverts commit 2c7a71c3. Reason for revert: Linux with chunk size 50 broke in v8 which we can't quickly fix, and Windows (chunk size 8) has a DWORD logging error that looks non-trivial. We need to fix those before landing this. Original change's description: > jumbo: stable assignment of inputs to chunks > > Adding or removing a file from a jumbo source set causes on average > half of the chunks to have their inputs reallocated. > Derive chunk boundaries from a combination of list position and path > content. This is so that when a file is added or removed, only the > boundaries with adjacent chunks typically move. > For a balance between maximum chunk size and stability of partitions: > * Partition uniformly into the required number of chunks. > * Pick a "center" from each chunk by minimum hash value. > * Pick the boundaries between centers by maximum hash value. > > Bug: 782863 > Change-Id: Ie71d82b132e8145b4ed3d1141f85886a12149d5a > Reviewed-on: https://chromium-review.googlesource.com/1102218 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Daniel Bratell <bratell@opera.com> > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570623} TBR=dpranke@chromium.org,bratell@opera.com,brucedawson@chromium.org,david.barr@samsung.com Change-Id: I8c81aca34ab2876aebea6b54e847cb24be3aa27f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 782863 Reviewed-on: https://chromium-review.googlesource.com/1116658Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#570701}
-
Rohit Rao authored
Creates separate text, detail, and switch cells for settings, as they will require leading icons and different fonts from the non-Settings variants. BUG=805213 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I465f9df05bc5cea20dbff8dfd21f2eacceb9057f Reviewed-on: https://chromium-review.googlesource.com/1114605Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#570700}
-
Thomas Tangl authored
Relanding crrev.com/c/1105772 after crbug.com/855797. Broken tests caused by calls to GetAccountsForDicePromos were fixed. When the user is signed out of Chrome and the profile icon has not been explicitly changed, AvatarToolbarButton now uses the account icon of the first sync promo account. Screenshots: https://drive.google.com/file/d/1a7kr12KtA11Wt7MQ9MLnSf-M3D9nlLdg/view?usp=sharing https://drive.google.com/file/d/1nKLnoD1sbcZOvwGQY3YtHVTUv32DQNFn/view?usp=sharing TBR=droger@chromium.org TBR=tapted@chromium.org TBR=bsep@chromium.org Bug: 853363, 855797 Change-Id: I830aedd32c30cb1c39fc24551dd225c81d62c097 Reviewed-on: https://chromium-review.googlesource.com/1112253 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#570699}
-
Greg Thompson authored
It flakes just about everywhere. BUG=850980 TBR=treib@chromium.org NOTRY=true Change-Id: I2f4ac0620028240cdd24c75c6d45666ef6edcadc Reviewed-on: https://chromium-review.googlesource.com/1116545 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL fixes MoveContentBelowHeader to have it take into account the bottom toolbar. This function now moves the content below the header but also add an inset for the bottom toolbar. Bug: 851129 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2b7c5e54e1597bf2779e028381b9d05910c021c7 Reviewed-on: https://chromium-review.googlesource.com/1111845Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#570697}
-
Alexander Hendrich authored
Added a policy to limit the user's choices for their input methods in a user session. The user can only select one of the provided input methods in the list. If the current user's input method is not allowed, the user's input method will be set to the hardware keyboard layout (if allowed) or the first valid entry in this list. Bug: 841301 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: If68d812fa8b9621c776acff4e218b0002d038081 Reviewed-on: https://chromium-review.googlesource.com/1086998 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570696}
-
Rune Lillesveen authored
There was a DCHECK making sure we did not cached matched properties when one of the applied properties was a non-inherited property with an explicit inherit value. For :visited properties, we do not set the flag for properties which are not allowed, but re-applying it to the cached ComputedStyle later would trigger a DCHECK even if the inherit value would not actually be applied. Applied changes to the DCHECK to handle that case. Also took the chance to Ribbonize valid :visited/:link properties as IsValidForVisitedLink(). Bug: 855849 Change-Id: I0addbd969cfd71e7f177ed5afbd5eac088800dee Reviewed-on: https://chromium-review.googlesource.com/1114977Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#570695}
-
Maxim Kolosovskiy authored
That CL (https://chromium-review.googlesource.com/c/chromium/src/+/1113443) introduced a crash if a saved password has only one character (it called base::RandGenerator(0)). The goal of VotesUploader::GeneratePasswordAttributesVote is to report the maximum observed password length for a site in a privacy preserving way. To achieve this, the true length, L, of the password is reported in in 20% of cases. In the remaining 80% of cases, a random value from the range [1, L-1] is reported. This is not well defined for L = 1, which caused the crash after https://crrev.com/c/1113443 landed. The fix, introduced in this CL, is to always report 1 if L = 1. This is still privacy preserving (if a client reports 1, the true length could have been anything) and does not violate the invariant that the maximal password length gets reported. Bug: 849243 Change-Id: I5bf5ec03746f4339c20f1c7c3447fad3ce7d2ee2 Reviewed-on: https://chromium-review.googlesource.com/1116541 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570694}
-
Oscar Johansson authored
When calling certain functions in GridLayout a resize parameter is passed, defining how much the layout should resize. Most often it is passed as 0 or 1. Sometimes 100 (which is assumed to be the same as 1) and sometimes 0.5. This commit defines the variable kFixedSize = 0.f in grid_layout.h and remove every local defintion of the variables. The magic constant are replaced by this variable. The replacements are: 0, 0.f and 0.0f becomes kFixedSize (0.f) This commit affects chrome/browser/ui. Bug: 854186 Change-Id: I287b1b38350a2dce2bd6e02cc871e82e0a5d89db Reviewed-on: https://chromium-review.googlesource.com/1106159Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#570693}
-
Greg Thompson authored
c/b/extensions/api/downloads/downloads_api.h indirectly includes the generated csd.pb.h file, so it needs an explicit dependency on the target that produces it. BUG=856920 TBR=jialiul@chromium.org Change-Id: I8a1821b05b92c71fa89bb706d6e9b21abf93bc93 Reviewed-on: https://chromium-review.googlesource.com/1116539 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I4bb96252d6cc857b8ac9a677b366ecf087278f39 Reviewed-on: https://chromium-review.googlesource.com/1116523 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570691}
-
Yoichi Osato authored
This patch adds LayoutNG bots for changes in core/editing directory because of deep dependency. Bug: 707656 Change-Id: Iafcf381f9fab5c8472917c3d7ca22d8c378ba2f7 Reviewed-on: https://chromium-review.googlesource.com/1116402Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#570690}
-
Jun Choi authored
Add serialization logic for GetAsserion response needed to implement virtual CTAP2 device. Bug: 829413 Change-Id: I144a48bd99be2fa09231d76718ecf97bb9ad75b4 Reviewed-on: https://chromium-review.googlesource.com/1114286 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#570689}
-
Alexander Hendrich authored
Apart from the OnConfigurationRemoved() method, all other methods from the NetworkConfigurationObserver are only used in tests and should be removed. Bug: None Change-Id: I6fb12c7437101f8f2755ddcafe1e8f70604764ea Reviewed-on: https://chromium-review.googlesource.com/1104343 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
Kim Paulhamus authored
Bug: 678885 Change-Id: If395f541fbf5da01531b8dd5c6a04cccca2832d6 Reviewed-on: https://chromium-review.googlesource.com/1108355 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#570687}
-
Xiaohan Wang authored
kMaxValue is checked by clang that it's actually the max value. Test: No functionality change Change-Id: I06cb97d0c7fc65e5b7a12dda69766e6fbd0d543f Reviewed-on: https://chromium-review.googlesource.com/1115727Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570686}
-
Matt Falkenhagen authored
Follow-up to r570238, https://crrev.com/e5bca9a7ce3d474 Bug: 855952 Change-Id: Id75e3e16a28fe53234d18b9ee04bb08c633d175a TBR: shimazu Reviewed-on: https://chromium-review.googlesource.com/1116416Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#570685}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c421ca1d6e41..4ab7198c3a75 git log c421ca1d6e41..4ab7198c3a75 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@4ab7198c3a75 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ie6b1a80189a54ed24f1116785fc0c1be8f640699 Reviewed-on: https://chromium-review.googlesource.com/1116478Reviewed-by:
-
Jun Choi authored
Serialization for MakeCredential response is required to implement virtual CTAP2 security key. Bug: 829413 Change-Id: I268c1f11f03e23a2d0713de3de0b53694a3fc31a Reviewed-on: https://chromium-review.googlesource.com/1111337 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens when building in Chrome OS for the variables kErrorInvalidX509Cert in: chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc This commit solves the issue by renaming the variables to something more file specific. It also renames other variables in the same namespace, so the naming is locally consistent. Bug: 850484 Change-Id: I67fc4d43785460ea5aa8fd1a08a2fd1985569117 Reviewed-on: https://chromium-review.googlesource.com/1114963Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#570682}
-
Renee Wright authored
Follow up from https://chromium-review.googlesource.com/c/chromium/src/+/1077912 Also adds Profile to the StorageHandler constructor Change-Id: Iae96445b592f9e4f537ff848fa1bc60dab8a750d Reviewed-on: https://chromium-review.googlesource.com/1111740 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
-
Oscar Johansson authored
In jumbo builds, on chrome os, the namespace redeclarations of media_perception in: chrome/browser/extensions/api/media_perception_private/media_perception_api_delegate_chromeos.cc extensions/browser/api/media_perception_private/media_perception_api_manager.cc extensions/browser/api/media_perception_private/media_perception_private_api.cc conflict with the declaration in: third_party/cros_system_api/dbus/service_constants.h This commit solves the issue by removing the redeclaration of media_perception and instead use the full name extensions::api::media_perception_private. Bug: 850484 Change-Id: I5a6363ca7e305d1bd7929555f60f9e1bd3322bfc Reviewed-on: https://chromium-review.googlesource.com/1114852Reviewed-by:
-
Joel Hockey authored
This fixes some console errors that were showing and catches up with recent changes. Bug: 813477 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I37c2a0f39a01727da5860b1df2c79ec293e1ffea Reviewed-on: https://chromium-review.googlesource.com/1116399 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#570679}
-
Morten Stenshorne authored
NG seems to support it just fine, but was prevented from doing so by two things: We forced legacy layout on the subtree. AND we unconditionally created (legacy) LayoutBlockFlow rather than LayoutNGBlockFlow. Use the factory to create the right object type. DETAILS does not establish a new formatting context, making it a rather lousy entry-point for legacy layout. This requires some rebaselining, due to cases of off by ~0.02px and also the fact that NG creates fewer and larger text runs. There are also fewer spaces than before in a couple of text dumps, apparently. This fixes one crasher, but also introduces two failures; one which is not related to DETAILS / MARKER, but rather how we deal with hit-testing inside a vertical-rl container. The other one is a paint/invalidation/ tests that behaves different from legacy now, because it has DETAILS / MARKER in it. fast/multicol/span/summary-split.html now fails again with NG block fragmentation. It recently started to pass, because of https://chromium-review.googlesource.com/c/chromium/src/+/1063891 , but that was just because the legacy DETAILS element forced the entire multicol container to be done with legacy. The actual problem here is that NG block fragmentation doesn't support column-span:all and never has. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I823b5cd2ce62240b820428302556ee6df64c8b22 Reviewed-on: https://chromium-review.googlesource.com/1114847Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#570678}
-
Trent Apted authored
Double-clicking a video in thumbnail mode will also "activate" it when it's loaded in the slide mode. That is, it will autoplay. Renames Gallery::onChangeToSlideMode_() to Gallery::onThumbnailActivated_() since it's not used for anything else. That passes a boolean |activate| arg to Gallery::changeCurrentMode_() which invokes {mode}activateConetent() once the load associated with the mode change is complete. Test: GalleryBrowserTest.ActivateVideoFromThumbnailMode Bug: 850372 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie93448d8c643e842e1f871514a3283706b587900 Reviewed-on: https://chromium-review.googlesource.com/1109595 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
