GitLab

In order to report Largest/LastImagePaint to UKM, this CL is to plumb
Largest/LastImagePaint to WebPerformance, but a follow-up CL has to be
done to pick up the metric results from the browser side.

Before this CL, the metrics report the result by dumping a trace event.
This CL adds a new way of reporting. When the metrics fire new results.
The results will be stored in the detector class. At the same time,
the detector will notify web performance of the new result so that
the web performance will pick up the metric results.

This CL also refactors the OnLargest/LastImagePaintDetected function in
ImagePaintTimingDetector for better readability.

Bug: 869924
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9b198b8bacac52e5dae66ea3ab9c2bedc56cfb8f
Reviewed-on: https://chromium-review.googlesource.com/c/1280844Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599976}

This effectively reverts
https://chromium-review.googlesource.com/c/chromium/src/+/614084
which added this hack.

This is no longer necessary as wheel listeners can now prevent the
double-tap to zoom gesture (see issue 802369) and the PDF viewer has
the necessary behaviour already (see testPreventNativeZoomFromWheel in
gesture_detector_test.js).

Bug: 676668, 802369
Change-Id: I4cb840d9f383c0f8aa4a47851d749de41004816b
Reviewed-on: https://chromium-review.googlesource.com/c/1281172Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599975}

A new version of Clang made the -Wshadow warning also apply to
enumerators, warning that the blink::WebSettings::V8CacheOptions
enumerators shadow the enumerators from blink::V8CacheOptions, e.g.

49344/58815] CXX obj/third_party/blink/renderer/core/core_generated/v8_code_cache.o
In file included from
../../third_party/blink/renderer/bindings/core/v8/v8_code_cache.cc:9:
../../third_party/blink/public/web/web_settings.h:66:5: warning: declaration
shadows a variable in namespace 'blink' [-Wshadow]
    kV8CacheOptionsDefault,
    ^
../../third_party/blink/renderer/bindings/core/v8/v8_cache_options.h:37:3:
note: previous declaration is here
  kV8CacheOptionsDefault,  // Use whatever the current default is.
  ^

Bug: 895475
Change-Id: I6de82855f3db4655c1bfaa4bb8d77fab1466188e
Reviewed-on: https://chromium-review.googlesource.com/c/1282445Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599974}

gpu_tests.context_lost_integration_test.ContextLostIntegrationTest.ContextLost_WebGLUnblockedAfterUserInitiatedReload in context_lost_tests
is flaky on Win10 Debug

TBR=kbr@chromium.org

Bug: 895765, 879423
Change-Id: Ic36400494df68f257329e040be2c72f1ad2ec3a6
Reviewed-on: https://chromium-review.googlesource.com/c/1283049
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599973}

TBR=fserb@chromium.org

Bug: 894673
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I81df01f11d97763281b0282288ba3c068071eff6
Reviewed-on: https://chromium-review.googlesource.com/c/1281240Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599972}

Bug: 878390
Change-Id: I9415f702715ec0332720829f2e385f3787d77ec7
Reviewed-on: https://chromium-review.googlesource.com/c/1261982Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599971}

The owners are kkhorimoto@ (original author), and gambard@
(reviewer).

Bug: 880672
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2d099c944b12e77c04106dc6de6de428824f1272
Reviewed-on: https://chromium-review.googlesource.com/c/1220720Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599970}

https://android.googlesource.com/platform/external/perfetto.git/+log/a81ac2dc02bf..5f1cbf4f7262


git log a81ac2dc02bf..5f1cbf4f7262 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 fmayer@google.com Merge "Fix Chrome build."
2018-10-16 lalitm@google.com trace_processor: fix build
2018-10-16 lalitm@google.com trace_processor: add sort and filter support to counter table
2018-10-16 lalitm@google.com trace_processor: add diff testing for trace processor
2018-10-15 treehugger-gerrit@google.com Merge "profiling: Allow to set sampling rate on command line."
2018-10-15 lalitm@google.com trace_processor: fix build for Google3
2018-10-15 fmayer@google.com Merge "profiling: Add instructions for heapprofd"
2018-10-15 fmayer@google.com Fix GCC build.
2018-10-15 lalitm@google.com trace_processor: fix missing noexcept breaking build in Google3
2018-10-15 lalitm@google.com Merge "perfetto: switch sys stats counter to use proto lite not pzero"
2018-10-12 primiano@google.com Fix chromium builb - Consumer API
2018-10-12 hjd@google.com Merge "perfetto-ui: Add vsync track"
2018-10-11 primiano@google.com Fix gcc build
2018-10-11 primiano@google.com Add public API for Perfetto consumer
2018-10-11 primiano@google.com Merge "Remove cycling dependency between ftrace_proto_gen and protos"
2018-10-11 primiano@google.com Merge "Rename libtraced_shared to libperfetto"
2018-10-11 hjd@google.com Merge changes I83a22f93,I9bd0ea85
2018-10-11 treehugger-gerrit@google.com Merge "Remove UnixSocketTest::SendIsAtomic."
2018-10-11 treehugger-gerrit@google.com Merge "Watchdog: disable fatal timers if Watchdog is not enabled"
2018-10-11 primiano@google.com ftrace: Add kmem trace events
2018-10-11 primiano@google.com Merge "Fix libfuzzer GN target on mac standalone builds"
2018-10-08 lalitm@google.com perfetto: add Android-only target for merged proto for use in Java


Created with:
  gclient setdep -r src/third_party/perfetto@5f1cbf4f7262

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:117596113,chromium:117604753,chromium:115601774,chromium:117460566,chromium:117295297
TBR=perfetto-bugs@google.com

Change-Id: Ia6bc6236bbf1ff860e14979b65ce5455595128f0
Reviewed-on: https://chromium-review.googlesource.com/c/1283232Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599969}

These were removed in
https://chromium-review.googlesource.com/c/chromium/src/+/1283150. Since the
test are flaky, they happened to pass in the latest WPT import (which also
updated them) despite some occasional failures in the Blink and CQ bots.
Readd them to TestExpectations to prevent them from flaking in the future.

TBR=foolip, robertma

No-Try: True
Change-Id: I9fa87e29900d5a84a8bef9493bc48cac930a77a9
Reviewed-on: https://chromium-review.googlesource.com/c/1283036Reviewed-by: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#599968}

I made a mistake in my earlier config CL: these tests are supposed
to be swarmed. There are no phones on the Android tester so it fails
when it tries to run locally.

Bug: 877018
Tbr: kbr@chromium.org
Change-Id: Id1cdef0c68ce3a50c9b7d2dec6bcd0d4c8f3e86b
Reviewed-on: https://chromium-review.googlesource.com/c/1282950Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599967}

Using wpt-import in Chromium c82467fd.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26300

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure
guidou@chromium.org:
  external/wpt/mediacapture-streams
meade@chromium.org:
  external/wpt/web-animations
mkwst@chromium.org:
  external/wpt/trusted-types

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I0574afa5e55c3f8e4fa8394d1adba1a82fb1b477
Reviewed-on: https://chromium-review.googlesource.com/c/1283150
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599966}

Appears you can't have filter files for non swarmed tests.

Bug: 877018
Tbr: kbr@chromium.org
Change-Id: If294ff3679889978fe27e7eced642b00f7102508
Reviewed-on: https://chromium-review.googlesource.com/c/1283289Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599965}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dcefe396..4edb5e25

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Binary-Size: autoroller
Change-Id: Ia5790cc18c21592bea054c2e41f4392cdcc5324a
Reviewed-on: https://chromium-review.googlesource.com/c/1282395Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599964}

The linked bug is a result of the fact that we send and handle browser
controls state updates on both the main and compositor threads. When a
non-animated hide is followed by a animated hide, we start an animation
on the compositor thread but immediately hide the top controls on the
main thread. When we commit the browser controls delta, the controls
hide but the animation continues to play so the next frame re-shows the
controls. Additional updates may stop the animation so we'd see the
controls in a half-way hidden state.

Currently, UpdateBrowserControlsState sends animated commands to be
handled by CC (since Blink doesn't know how to animate), but because of
https://crbug.com/754346, non-animated commands are sent to Blink. When
the browser process sends a series of interweaved commands to the render
this leads the the clamping bug discussed above.

This CL fixes this issue by making the compositor-side the real source-
of-truth and pushing the changes to Blink. Both CC and Blink must be
made aware of the browser controls constraints, since scrolls may be
handled by either. However, we now always inform CC first and let it
push the differences to Blink. This happens as part of
ApplyViewportChanges during a commit.

Reland Note: The original patch broke MSAN as it forgot to initialize
ScrollAndScaleSet::browser_controls_constraint_changed. This CL fixes
that issue.

TBR=enne@chromium.org,chrishtr@chromium.org,alexmos@chromium.org

Bug: 861618
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I77964a893a9e376ceb29a69c6bef8b699801ed82
Reviewed-on: https://chromium-review.googlesource.com/c/1283249Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599963}

Bug: 894261
Change-Id: I6d161b6e1c7b7cbfe039fc15747f71acb3042f70
Reviewed-on: https://chromium-review.googlesource.com/c/1281170Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#599962}

This change:
1) Has BridgedNativeWidgetHostImpl notify the owning Widget when it becomes
   minimized
2) Has session restore not activate minimized browser windows when selecting
   a restored tab
3) Has session restore not show a newly created browser window if it's
   minimized

restore save; without this change, the widget will not get saved as minimized.
window. On Mac, showing/activating a window implies de-minimizing it, so this
is required to avoid de-minimizing saved minimized windows, but I think it is
necessary on other platforms as well.

Test steps:
1) Start Chromium
2) Create a second browser window (cmd-n) and minimize it
3) In the first window, chrome://restart

Before this change, both browser windows appear after restart; after this
change, the first window appears and the second stays minimized.

Note that there is a graphical glitch when first restoring a window that is
minimized this way: the window paints as blank for a few frames while running
the deminiaturize animation.

Bug: 888218
Change-Id: I8ac121408336a7d6aeedd2b27cd2c9c9d20a18f2
Reviewed-on: https://chromium-review.googlesource.com/c/1268396Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599961}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/ui/views/frame.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

Bug: 874080
Change-Id: I6664a62f27ae599144ffcac09f43aaf48e1948d3
Reviewed-on: https://chromium-review.googlesource.com/c/1194328
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599960}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03c087e3eafe..2129101d5e9b


Created with:
  gclient setdep -r src-internal@2129101d5e9b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I98060f703178d72c816c660a306d19cf4c57230e
Reviewed-on: https://chromium-review.googlesource.com/c/1283230Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599959}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/eea449a1e82a..ab45d6915434


git log eea449a1e82a..ab45d6915434 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 greg@lunarg.com Fix ADCE liveness to include all enclosing control structures. (#1975)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@ab45d6915434

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ifbb6ced7ea2fdda2eac74d6b11f44dcac657d934
Reviewed-on: https://chromium-review.googlesource.com/c/1283233Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599958}

This is a reland of eb25f32f

The CL was reverted with
https://chromium-review.googlesource.com/c/chromium/src/+/1282949
but it looks like an infra problem instead

TBR=justincohen@chromium.org,jbudorick@chromium.org
Original change's description:
> [ios] Move xcode-clang builders to Xcode 10.
>
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
> Change-Id: Ie5bdc140b82f49151ca891b39f65112bf6210eac
> Reviewed-on: https://chromium-review.googlesource.com/c/1278332
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599804}

Change-Id: I335dff58404b7bab44a5eab3c5b0337b38a572e3
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/c/1283016
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599957}

This field is always true going forward.

Bug: 662944
Change-Id: I4dc3a3ac5aa5d7abf6d1a33b5f1a21f046881250
Reviewed-on: https://chromium-review.googlesource.com/c/1277867Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599956}

Before this CL, IDL parser didn't accept types with
extended atttributes as union members.
This CL makes it possible.

For example,
  ([TreatNullAs=EmptyString] DOMString or [Clamp] long)
was an error, but it became acceptable.


Bug: 894469
Change-Id: I2980256f5090f4465bef1b2a8665b0a9a9643b76
Reviewed-on: https://chromium-review.googlesource.com/c/1278614
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599955}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: I897e124f0320106f49bc9f7f99533d7cfd0b125b
Reviewed-on: https://chromium-review.googlesource.com/c/1282644Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#599954}

This also enables per-edge AA for tile quads in SkiaRenderer.

Bug: skia:8444
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Iaa14e6bd74128b838a5fcfac86789777d1936a7f
Reviewed-on: https://chromium-review.googlesource.com/c/1266902Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#599953}

This is a reland of 8aeb9cc9

Original change's description:
> [TaskScheduler]: Add section to faq: when to annotate with ScopedBlockingCall.
> 
> Developpers are often wondering whether or not ScopedBlockingCall is redundant.
> 
> Change-Id: Ic7936ef805f43f7fc02d0ad3020c31d8364b099d
> Reviewed-on: https://chromium-review.googlesource.com/c/1271878
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599626}

Change-Id: I0850821994e3b4a1b0c3bb238725bc28867d18f5
Reviewed-on: https://chromium-review.googlesource.com/c/1280281
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599952}

It's the basic version, that asks for payment and shipping details.
(billing address cannot be saved yet.)

Bug: 806868
Change-Id: Ic2f55e659f8254b3088dd99d8b388446fcb0cf7d
Reviewed-on: https://chromium-review.googlesource.com/c/1280767
Commit-Queue: Lukasz Suder <lsuder@google.com>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599951}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/079a94f7aec0..70bac6b6f68d


git log 079a94f7aec0..70bac6b6f68d --date=short --no-merges --format='%ad %ae %s'
2018-10-16 ahassani@chromium.org paygen: catch and ignore GSNoSuchKey exception when looking for payloads


Created with:
  gclient setdep -r src/third_party/chromite@70bac6b6f68d

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib0640877c41bffcfca312f49bf825d6bb467004b
Reviewed-on: https://chromium-review.googlesource.com/c/1282352Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599950}

Change-Id: Iafcde04a7a212025204a64da2b089939b19d200e
Reviewed-on: https://chromium-review.googlesource.com/c/1282067
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599949}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c98f7a176af9..03c087e3eafe


Created with:
  gclient setdep -r src-internal@03c087e3eafe

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I1174563ffcad092adee020c02ae2701dc513ff01
Reviewed-on: https://chromium-review.googlesource.com/c/1283169Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599948}

This should make the chromium.webrtc waterfall work like the old
test config in recipes. It incorporates some fixes made in the
recipe code and creates composite test suites for the chromium.webrtc
bots.

Bug: 877018
Change-Id: I11b91c4e9516844086978b5a63b816576197585b
Reviewed-on: https://chromium-review.googlesource.com/c/1280669Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599947}

Disable BottomToTopExpanded and BottomToTopCollapsed

TBR: marq, kkhorimoto
Bug: 880672
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: If4c71557240e8589b52d6fe53491d661a5ff3a26
Reviewed-on: https://chromium-review.googlesource.com/c/1283029Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599946}

This is a reland of 48c7a842

Original change's description:
> [sync::test] Add two client integration test for custom passphrase
> 
> Add a Sync integration test which exercises custom passphrase flows in
> an end-to-end manner with two clients. The test ensures that two clients
> can sync data properly in the presence of custom passphrase-based
> encryption and different key derivation methods.
> 
> Refactor SetScryptFeatureState() from the single-client test to a scoped
> feature toggler that resides in encryption_helper, because the
> functionality now needs to also be used from the two-client test.
> 
> Bug: 894148
> Change-Id: Ia211b221f89a99092d3b19690ecae6bb4fa77d02
> Reviewed-on: https://chromium-review.googlesource.com/c/1277648
> Commit-Queue: David Davidović <davidovic@google.com>
> Reviewed-by: vitaliii <vitaliii@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599929}

Bug: 894148
Change-Id: I425db59e1427f2c3ebf1cb9cd8b2ee440fd31ce1
Reviewed-on: https://chromium-review.googlesource.com/c/1283012Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: David Davidović <davidovic@google.com>
Cr-Commit-Position: refs/heads/master@{#599945}

https://webrtc.googlesource.com/src.git/+log/f0e926fbdd8f..1927dfafabc0


git log f0e926fbdd8f..1927dfafabc0 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 magjed@webrtc.org Add tool for aligning color space of video files


Created with:
  gclient setdep -r src/third_party/webrtc@1927dfafabc0

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic041226cf06b7150fb4a320b72202eed70b8cc08
Reviewed-on: https://chromium-review.googlesource.com/c/1282333Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599944}

This CL moves the existing SettingsDetailItem to Legacy and creates a
new SettingsDetailItem which is now a subclass of the TableViewItem.
The new SettingsDetailItem now support Dynamic Type.

Bug: 894791
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia001bf2bdd59bb71a81d228ebf7f905f5600eebf
Reviewed-on: https://chromium-review.googlesource.com/c/1251625Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599943}

A recent albatross build is showing that this DCHECK is firing. Splitting apart
the DCHECK will allow diagnosing which condition is failing.

BUG=895520

Change-Id: I4dcb6a819b308ab407666c81b90536b8fcfef7cb
Reviewed-on: https://chromium-review.googlesource.com/c/1282728Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599942}

Also fix a couple of comments and make sure all icons are the
same height. We might want to enlarge them all in a future CL,
but they should at least match.

Bug: 860467
Change-Id: I78eb219771a94aa41d7eb312f072ebde8cc65d56
Reviewed-on: https://chromium-review.googlesource.com/c/1280768Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599941}

If a commit succeeds, but the response does not come back fast enough
then the |bookmark_tracker_| might assume that it was never committed.
The server will track the client that sent up the original commit and
return this in a get updates response.

This CL makes sure that the processor detects this case and updates
the persisted server id accordingly.

Bug: 516866
Change-Id: Ida0e66345b3f55b6ac8b595ddb5c676024698706
Reviewed-on: https://chromium-review.googlesource.com/c/1280434
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599940}

This feature was launched in M67.

Bug: 788621
Change-Id: I59aaf51c5b129d7c01d90076c779a0a747c81d28
Reviewed-on: https://chromium-review.googlesource.com/c/1282483Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599939}

This feature was launched in M65.

Bug: 788619
Change-Id: Ia6f9794301f05b91fbd3edc5bbeddfe24944eadd
Reviewed-on: https://chromium-review.googlesource.com/c/1282684Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599938}

When DCHECKs are enabled, this test crashes the test runner (but not when
content_shell is run manually) and blocks WPT imports. When DCHECKs are
disabled, the runner treats it as a pixel test and produces wrong results.

TBR=foolip, robertma

Bug: 895777
Change-Id: Ia0cb5bcbfb56a67e10bfd93a01ab6995fb02d328
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/1283130Reviewed-by: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#599937}