GitLab

On M+, web developers can provide the icon for notifications to use in the
status tray via the Notification.badge property
(https://notifications.spec.whatwg.org/#dom-notification-badge)

This CL sets the icon to be used by notifications originating from a WebAPK
- When the Notification.badge property is not set
- On Pre M Android OSes

BUG=604204

Review-Url: https://codereview.chromium.org/2362423002
Cr-Commit-Position: refs/heads/master@{#421227}

This API is unused, cleaning up offline page model.

BUG=622763
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2331423004
Cr-Commit-Position: refs/heads/master@{#421226}

BUG=650548
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2372233002
Cr-Commit-Position: refs/heads/master@{#421225}

There are two main fixes:
-use GetWebContentsGetter instead of the RPH/RFH IDs since the latter don't exist for browser side navigation
-switching TabSpecificContentSettings to use the new navigation callbacks. This is needed because with PlzNavigate, the old didstartprovisionalload callback (from the new renderer) would run after the cookie request (from the browser), and so we would wipe out the settings map. Using the new callbacks preserves the order of these callbacks with PlzNavigate.

This fixes the following browser tests with PlzNavigate:
ContentSettingsTest.RedirectCrossOrigin
ContentSettingsTest.RedirectLoopCookies

BUG=504347

Review-Url: https://codereview.chromium.org/2374443003
Cr-Commit-Position: refs/heads/master@{#421224}

* The scroll position is stored as extra data on the NavigationEntry.
* The main use case handled is when the user clicks on a suggested
article and then back to view more suggestions. Maintaining scroll position helps maintain context and flow here.
* It is the RecyclerView Adapter position that is stored and restored, so if the device is rotated in the meantime, scroll restore will still present the same content as long as the underlying data has not changed.
* Because the underlying data is subject to change a few times per day, the scroll position is not persisted. It would be confusing the restore to an old position that now shows different content.

BUG=606356
TBR=clamy,bauerb,tedchoc
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6
Cr-Commit-Position: refs/heads/master@{#420075}

patch from issue 2327083002 at patchset 160001 (http://crrev.com/2327083002#ps160001)

Committed: https://crrev.com/2c78ced6c8ce46eec8c9f7100b14b3414b7cbc07
Review-Url: https://codereview.chromium.org/2365313002
Cr-Original-Commit-Position: refs/heads/master@{#420896}
Cr-Commit-Position: refs/heads/master@{#421223}

onPagefinished generates a synthetic onNewPicture callback if a picture
listener is registered. We probably shouldn't change that behaviour,
even though it was introduced to fix a different CTS test flake, because
applications may well be relying upon it. Given that, it should at least
respect the documented behaviour that the picture instance it passes
should be null on JB MR2 and above.

BUG=650641

Review-Url: https://codereview.chromium.org/2376673002
Cr-Commit-Position: refs/heads/master@{#421222}

This allows Backend pointers to point to derived classes.

BUG=648701

Review-Url: https://codereview.chromium.org/2365283003
Cr-Commit-Position: refs/heads/master@{#421221}

Signin Error Dialog:
Part of the desktop user menu revamp project is to migrate signin error
surfacing from user menu's tutorial card to a tab modal dialog, and thus
completing the flow of signin modal -> sync confirmation modal dialog or signin
error modal dialog.

Particularly, this CL adds the code for appropriately triggering the dialog.
DO NOT LAND until after the first two CLs land (
https://codereview.chromium.org/2274013002/,
https://codereview.chromium.org/2275883003/).

Design doc:
https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.9vm5owqqt3w1

BUG=630523
BUG=615893

Review-Url: https://codereview.chromium.org/2348423002
Cr-Commit-Position: refs/heads/master@{#421220}

This CL introduces FormDataBytesConsumer which will replace
FetchFormDataConsumerHandle.

BUG=610195

Review-Url: https://codereview.chromium.org/2342023002
Cr-Commit-Position: refs/heads/master@{#421219}

TEST=build chromium

Review-Url: https://codereview.chromium.org/2369933003
Cr-Commit-Position: refs/heads/master@{#421218}

Review-Url: https://codereview.chromium.org/2371083002
Cr-Commit-Position: refs/heads/master@{#421217}

This CL merges CrossSiteResourceHandler and NavigationResourceThrottle.
It also removes the CrossSiteResourceRequest in favor of using
NavigationHandle. This allows WebContentsObserver::ReadyToCommit
navigation to be called in the non-PlzNavigate architecture.

A detailed description of the change can be found at https://docs.google.com/a/chromium.org/document/d/1Ze5_RNvUQV4ltWvFU5MY3L_TRIAux88iLadQIPHTMqk/edit?usp=sharing.

BUG=621856
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2321543002
Cr-Commit-Position: refs/heads/master@{#421216}

https://chromium.googlesource.com/skia.git/+log/75d6ffbc74b6..7bfc08b9fb42

$ git log 75d6ffbc7..7bfc08b9f --date=short --no-merges --format='%ad %ae %s'
2016-09-27 mtklein Focus -Wno-over-aligned to just 32-bit x86 Android. (2)

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=fmalita@google.com

Review-Url: https://codereview.chromium.org/2375643002
Cr-Commit-Position: refs/heads/master@{#421215}

This has been enabled behind an experimental web platform feature so that
we can test it on a few different devices before we activate it in the
wild. Likewise putting this as an experimental feature doesn't require
and Intent to Ship just yet. I would like to ship this at the same time
we ship touch action pan directions.

BUG=626086

Review-Url: https://codereview.chromium.org/2126323002
Cr-Commit-Position: refs/heads/master@{#421214}

No functional change, just updating comments and moving a block around.

BUG=645078

Review-Url: https://codereview.chromium.org/2320873004
Cr-Commit-Position: refs/heads/master@{#421213}

This make chromedriver works with android emulator in pure IPv6 env.

BUG=chromedriver:1515

Review-Url: https://codereview.chromium.org/2349423003
Cr-Commit-Position: refs/heads/master@{#421212}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6c8709c0cc9d..b9d66e1fc00f

$ git log 6c8709c0c..b9d66e1fc --date=short --no-merges --format='%ad %ae %s'
2016-09-27 petrcermak [tracing] Overhaul tr-ui-b-table focus handling

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2372113003
Cr-Commit-Position: refs/heads/master@{#421211}

NO_DEPENDENCY_CHECKS=true

Review-Url: https://codereview.chromium.org/2371113002
Cr-Commit-Position: refs/heads/master@{#421210}

BUG=none

Review-Url: https://codereview.chromium.org/2371163002
Cr-Commit-Position: refs/heads/master@{#421209}

BUG=632008

Review-Url: https://codereview.chromium.org/2367723002
Cr-Commit-Position: refs/heads/master@{#421208}

Flag was added in http://crrev.com/433623002/ but does not
appear to be in use any longer (and appears to have only
been used for Clank-specific purposes).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2370793004
Cr-Commit-Position: refs/heads/master@{#421207}

PLMObserver::FlushMetricsOnAppEnterBackground gets invoked when the metrics
subsystem is flushing metrics as part of the app entering the background.

Observers that buffer metrics information and flush it in the OnComplete
callback may want to implement this method, in order to avoid losing data
due to the application being killed after being backgrounded.

BUG=608360

Review-Url: https://codereview.chromium.org/2371883002
Cr-Commit-Position: refs/heads/master@{#421206}

On some combination of devices and version of OS (currently 64-bit iPad
running iOS 10), sysctlbyname("vm.pagesize", ...) fails. This cause the
wrapper ProcessMemoryDump::GetSystemPageSize to call base::GetPageSize,
which is incorrect when used for mincore() on iOS.

Instead use vm_kernel_page_size as recommended by Apple Staff on Apple
developer forums: https://forums.developer.apple.com/thread/47532.

BUG=542671

Review-Url: https://codereview.chromium.org/2365333002
Cr-Commit-Position: refs/heads/master@{#421205}

The file was renamed in CL https://codereview.chromium.org/2209443003.

Review-Url: https://codereview.chromium.org/2370213002
Cr-Commit-Position: refs/heads/master@{#421204}

A longstanding trap in global_keyboard_shortcuts_mac: if a binding has a
character specified instead of a keycode, the option modifier in the command is
ignored, which makes sense, since option might be involved in typing the
character in the first place. However, it does mean that bindings should never
specify opt == true, which is exactly what I did in CL 2369453003. This CL adds
a DCHECK to ensure nobody else trips over this.

BUG=650528

Review-Url: https://codereview.chromium.org/2373543003
Cr-Commit-Position: refs/heads/master@{#421203}

This is a follow up CL for CL (https://codereview.chromium.org/2301263004).
The InstallSource is passed into the constructor of
AppBannerInfoBarDelegationAndroid, so we can call Accept() instead of
AcceptWebApk() when installing a WebAPK from add-to-homescreen menu.

BUG=626510

Review-Url: https://codereview.chromium.org/2375503003
Cr-Commit-Position: refs/heads/master@{#421202}

Add struct-traits for gpu::SurfaceHandle, and use that to provide mojom API
for creating/destroying gpu memory buffer. This allows removing the direct
dependency of gpu code from ws code (which is a pre-requisite for the gpu
process split).

BUG=637923
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2360203003
Cr-Commit-Position: refs/heads/master@{#421201}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c47acc29..a13f63c6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2376683002
Cr-Commit-Position: refs/heads/master@{#421200}

Its contents were moved to the browsing_data/ component in
https://codereview.chromium.org/2238453002, but the directory itself
and the DEPS file in it were accidentally left behind.

BUG=635873

Review-Url: https://codereview.chromium.org/2372223002
Cr-Commit-Position: refs/heads/master@{#421199}

Setting the default behavior to anti-aliasing 2D canvas clips.
Adding run-time flag "--disable-2d-canvas-clip-aa".

BUG=424291

Review-Url: https://codereview.chromium.org/2359843003
Cr-Commit-Position: refs/heads/master@{#421198}

This CL removes a condition on whether a site settings row is 'actionable'.

BUG=650557
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2359403002
Cr-Commit-Position: refs/heads/master@{#421197}

If the root of a WindowTree associated with the window manager was
removed and the associated WindowTree destroyed, then Display
would still have a reference to the WindowManagerState resulting in a
possible crash.

WindowServer::DestroyTree() had code to handle this case, but it
looked up the Display using the roots of the WindowTree, so that once
the roots were removed the Display couldn't be found. Fix is to move
logic to ~WindowManagerState.

BUG=none
TEST=covered by test
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2365243003
Cr-Commit-Position: refs/heads/master@{#421196}

https://chromium.googlesource.com/skia.git/+log/a99b66d95b4d..75d6ffbc74b6

$ git log a99b66d95..75d6ffbc7 --date=short --no-merges --format='%ad %ae %s'
2016-09-27 reed Revert "Focus -Wno-over-aligned to just 32-bit x86 Android."

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=fmalita@google.com

Review-Url: https://codereview.chromium.org/2372213002
Cr-Commit-Position: refs/heads/master@{#421195}

BUG=622400

Review-Url: https://codereview.chromium.org/2367843002
Cr-Commit-Position: refs/heads/master@{#421194}

This CL removes tests that are no longer failing from the PlzNavigate
content_browsertests filter.

BUG=475027
TBR=nasko@chromium.org

Review-Url: https://codereview.chromium.org/2375623002
Cr-Commit-Position: refs/heads/master@{#421193}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b7b68b4c0396453d775c7fb924d45bbfdff6f349 Updating perf recipe for disabled chartjson data. (eyaich@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:647714

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2373793002
Cr-Commit-Position: refs/heads/master@{#421192}

Reverted in
https://codereview.chromium.org/2349253002

Reason for revert:
Tests are failing on Mac ASAN builder. See details here:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20(1)

BUG=633136

Review-Url: https://codereview.chromium.org/2353333002
Cr-Commit-Position: refs/heads/master@{#421191}

With this CL, a FileDescriptorWatcher is instantiated on every
base::Thread that runs a MessageLoopForIO. This allows
FileDescriptorWatcher::WatchReadable/WatchWritable to be used
on these threads.

BUG=645114

Review-Url: https://codereview.chromium.org/2372583002
Cr-Commit-Position: refs/heads/master@{#421190}

When the payment request is updated using updateWith,
the PaymentDetails can contain a message in the error field
that will be displayed to the user.

https://w3c.github.io/browser-payment-api/#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/pull/257

BUG=648240

Review-Url: https://codereview.chromium.org/2355463002
Cr-Commit-Position: refs/heads/master@{#421189}

This function was doing the wrong thing on Mac, so it has been removed and
the default implementation simply inlined into LabelButton.

BUG=649367

Review-Url: https://codereview.chromium.org/2358913006
Cr-Commit-Position: refs/heads/master@{#421188}