- 04 May, 2017 12 commits
-
-
romax authored
Adding support for "removed on cache reset" pages to the query interface. Also Adding a new interface on OfflinePageModel to delete pages matching a specific query. BUG=716142 Review-Url: https://codereview.chromium.org/2858803002 Cr-Commit-Position: refs/heads/master@{#469219}
-
ckrasic authored
There are no flags to be updated deprecate FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate in disabled state. It achieved results that were in general comparable to "measuring aggregation" approach, but it had worse rtx rate, and worse QoE, and did not actually seem to be better in other regards. Merge internal change: 154601526 https://codereview.chromium.org/2859913003/ fix packet conservation to remove packets from recovery window when they are lost. Protected by FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation2. This causes a dramatic reduction in losses compared to the previous patch. The transfer time is approximately the same. Merge internal change: 154590929 https://codereview.chromium.org/2857243002/ Fix typo in comments. Merge internal change: 154539040 https://codereview.chromium.org/2854823004/ QUIC - refactor stream creation. Guarded by --quic_reloadable_flag_quic_refactor_stream_creation. This CL is in preparation for HTTP stream pairs changes. A prototype of the entire HTTP stream pairs work is in progress. This CL is one subset of that (2nd in the series). [ HTTP stream pairs builds upon this, by having new QuicSpdySession overrides that implicitly create headers streams, and abstracting stream accounting as needed. ] Add a new factory like method QuicSession::CreateStream(), that unconditionally creates a new stream. It's virtual so subclasses of QuicSession can create streams that are appropriately specialized from QuicStream. There are new versions of Create*DynamicStream() called MaybeCreate*DynamicStream(), and ShouldCreate*DynamicStream() called ShouldCreate*DynamicStream2(). Separating this out means that fewer overrides of Create*DynamicStream() and ShouldCreate*DynamicStream() will necessary, because many of those were actually only needed to specialize the steam types. Those will go away when FLAGS_quic_reloadable_flag_quic_refactor_stream_creation is deprecated. Merge internal changes: 154351257, 154373998. https://codereview.chromium.org/2861673004/ QUIC - stream id refactor for tests. // AKA - http stream pairs bikeshed #1. This CL is in preparation for HTTP stream pairs changes. A prototype of the entire HTTP stream pairs work is in progress. This CL is one subset of that. Rework QUIC tests so that they do not hard code the assumption that all headers are on stream 3. Also, prepare to calculate stream ids according to whether stream pairs are enabled, i.e. whether they increment by 2 or 4. Merge internal change: 150949425 https://codereview.chromium.org/2854833005/ R=rch@chromium.org BUG= Review-Url: https://codereview.chromium.org/2862563003 Cr-Commit-Position: refs/heads/master@{#469218}
-
Sunny Sachanandani authored
If the get buffer is destroyed say in SetAggressivelyFreeResources, the next OrderingBarrier call after recreating the get buffer will see the old value for last_barrier_put_offset_. CommandBufferProxyImpl uses this to set the put_offset_changed parameter for OrderingBarrier. If the new put_offset_ matches last_barrier_put_offset_ exactly the OrderingBarrier becomes a nop. That can cause contexts to run out of order causing all sorts of rendering glitches. R=jbauman BUG=715997 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie1e511e22a3e2f3b0e71ea872bbd690925725be9 Reviewed-on: https://chromium-review.googlesource.com/495369Reviewed-by:
John Bauman <jbauman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#469217}
-
rdevlin.cronin authored
The chrome://extensions page uses different urls for a few things, primarily to highlight a given extension or to display the extension's options. In the MD version, we have separate pages for these, which makes these more like navigations. Add basic page and history manipulation to the chrome://extensions page. Navigating to a subpage updates the location and pushes a new state to the history stack, so that clicking back will return you to the previous page. Dialogs are contained within a page, and do not push a new history state. Examples: - Navigating from the main view to the details view updates the location, and 'back' would return to the main view. - Opening the options dialog from the details view does not push new state (since otherwise 'back' would just close the dialog). Add tests for the same. BUG=529395 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2811993004 Cr-Commit-Position: refs/heads/master@{#469216}
-
stevenjb authored
In this CL: * Always show IP config section for remembered or connected networks. * Fix editing IP config when switching from automatic to static. BUG=717262 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2856023002 Cr-Commit-Position: refs/heads/master@{#469215}
-
khorimoto authored
BUG=672263 Review-Url: https://codereview.chromium.org/2861583002 Cr-Commit-Position: refs/heads/master@{#469214}
-
davidben authored
The NaCl build (used by //remoting) doesn't actually process certificates, so we can switch them easily. (They configure SSLClientSocket to allow only a single certificate and run some other authenticator over the channel.) Sadly, this doesn't buy the binary size wins yet. It looks like this is because they pull in WebRTC. But it means that once this and the Android switch sticks, we can tidy up USE_OPENSSL_CERTS. BUG=671420 Review-Url: https://codereview.chromium.org/2861813002 Cr-Commit-Position: refs/heads/master@{#469213}
-
emircan authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/86a6787..075011d $ git log 86a6787..075011d --date=short --no-merges --format=%ad %ae %s 2017-05-03 ehmaldonado@webrtc.org Revert of Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ (patchset #2 id:60001 of https://codereview.webrtc.org/2851563003/ ) 2017-05-03 glaznev@webrtc.org Initial implementation of Android audio playback error handling. 2017-05-03 mbonadei@webrtc.org fixing braces around initialization of subobject 2017-05-03 deadbeef@webrtc.org Fixing DCHECK in turnport.cc that was broken by refactoring. 2017-05-03 henrika@webrtc.org Resolves race between Channel::ProcessAndEncodeAudio() and Channel::StopSend() 2017-05-03 magjed@webrtc.org Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ 2017-05-03 peah@webrtc.org Reland of Added ARM Neon SIMD optimizations for AEC3 (patchset #1 id:1 of https://codereview.webrtc.org/2856113003/ ) 2017-05-03 mbonadei@webrtc.org Revert of Extract iOS SDK helpers to separate target. (patchset #1 id:1 of https://codereview.webrtc.org/2852323003/ ) 2017-05-03 peah@webrtc.org Revert of Added ARM Neon SIMD optimizations for AEC3 (patchset #2 id:970001 of https://codereview.webrtc.org/2834073005/ ) 2017-05-03 peah@webrtc.org Added ARM Neon optimizations for AEC3 2017-05-03 mbonadei@webrtc.org Reland of Extract iOS SDK helpers to separate target. (patchset #1 id:1 of https://codereview.webrtc.org/2853273002/ ) 2017-05-03 peah@webrtc.org Corrected the behavior in AEC3 during buffer overruns and underruns 2017-05-03 kjellander@webrtc.org Remove config.h from //webrtc:webrtc target. 2017-05-03 mbonadei@webrtc.org Adding virtualsocketserver to rtc_base sources 2017-05-03 brandtr@webrtc.org Reland of Don't reinit encoder when rotation changes. (patchset #1 id:1 of https://codereview.webrtc.org/2861633003/ ) 2017-05-03 brandtr@webrtc.org Revert of Don't reinit encoder when rotation changes. (patchset #3 id:40001 of https://codereview.webrtc.org/2853463004/ ) 2017-05-03 sakal@webrtc.org Address tkchin's comments on RTCCameraVideoCapturer. 2017-05-03 brandtr@webrtc.org Don't reinit encoder when rotation changes. 2017-05-03 brandtr@webrtc.org Don't re-randomize picture_id/tl0_pic_idx when re-initializing internal encoders. 2017-05-03 bpostelnicu@mozilla.com Make sure the resulted operation is calculated on float basis. 2017-05-03 sakal@webrtc.org Fix lint issues on Android. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2855303002 Cr-Commit-Position: refs/heads/master@{#469212}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ab244f045a07..6d4b65e9dad9 $ git log ab244f045..6d4b65e9d --date=short --no-merges --format='%ad %ae %s' 2017-05-03 bsalomon Revert "Revert "Add a new non-AA rect op that does not inherit from GrLegacyMeshDrawOp."" 2017-05-03 mtklein treat SkPMColor as sRGB in SkPM4f::FromPMColor() 2017-05-03 bsalomon Revert "Add a new non-AA rect op that does not inherit from GrLegacyMeshDrawOp." 2017-05-03 bsalomon Add a new non-AA rect op that does not inherit from GrLegacyMeshDrawOp. 2017-05-03 mtklein fix G3 opt android_arm build? 2017-05-03 mtklein disable test_diagonal on 565 2017-05-03 fmalita Validate SkSpecialSurface raster info 2017-04-05 halcanary headers: fix 2017-05-03 fmalita Add a GM to exercise some complex gradient constructs Created with: roll-dep src/third_party/skia BUG=716311 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I0ef3efa6313f3f0815315cf662a0c94729c34b58 Reviewed-on: https://chromium-review.googlesource.com/494969Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#469211}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5c834a1ca845..0d00147b4f72 $ git log 5c834a1ca..0d00147b4 --date=short --no-merges --format='%ad %ae %s' 2017-05-03 dtu [pinpoint] Make handlers consistent. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I4e11ce037a3018a7efd8e915de5d0f248dbab419 Reviewed-on: https://chromium-review.googlesource.com/495387 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#469210}
-
kainino authored
This is a minimal fix for issues with getUniformBlockIndex and getTransformFeedbackVarying. Also removes unused Shader::GetMappedName. This corrects the behavior of GetOriginalNameFromHashedName. Previously, uniform block names were unmapped using "name_map", but name_map was not restored upon load. Now, instead of name_map, the five info maps (attrib, uniform, varying, interface block, output variable) are queried serially in GetOriginalNameFromHashedName. Unused code around name_map will be removed in a subsequent CL. BUG=716018 TEST=https://github.com/KhronosGroup/WebGL/pull/2388 TEST=https://github.com/KhronosGroup/WebGL/pull/2389 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2857083002 Cr-Commit-Position: refs/heads/master@{#469209}
-
qinmin authored
Accessing content URI can throw more exceptions than expected. This CL catch all possible exceptions so we don't crash. BUG=706299 Review-Url: https://codereview.chromium.org/2861583008 Cr-Commit-Position: refs/heads/master@{#469208}
-
- 03 May, 2017 28 commits
-
-
pkl authored
This is the first step of deprecating Native App Launcher. This puts the functionality behind an experimental flag experimental_flags::IsNativeAppLauncherEnabled(). There will be lots of dead code and unused classes/methods left after this step and they will be removed after experiment is removed. Default for experiment is Native App Launcher *disabled*. BUG=711511 TEST=Tools > Settings > Google Apps should not be there. Visits to Maps or YouTube sites will not show infobar. Tapping on Maps or YouTube links may still launch Maps and YouTube app because of Universal Links. Review-Url: https://codereview.chromium.org/2860573003 Cr-Commit-Position: refs/heads/master@{#469207}
-
caseq authored
Revert of DevTools: support resolving a UILocation to multiple raw script locations (patchset #3 id:60001 of https://codereview.chromium.org/2857453002/ ) Reason for revert: We decided that we don't need that. Original issue's description: > DevTools: support resolving a UILocation to multiple raw script locations > > This turns uiLocationToRawLocation into uiLocationToRawLocations and makes it return an array > > BUG=717694 > > Review-Url: https://codereview.chromium.org/2857453002 > Cr-Commit-Position: refs/heads/master@{#468825} > Committed: https://chromium.googlesource.com/chromium/src/+/421b9c4b9736e52c903123994d977b4ed406cf72 TBR=dgozman@chromium.org,lushnikov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=717694 Review-Url: https://codereview.chromium.org/2859073002 Cr-Commit-Position: refs/heads/master@{#469206}
-
Tommy Nyquist authored
Previously we have used the pre-release code names for checking whether the current platform Chrome runs on is Android O. This CL updates this to instead check against the Build.VERSION.SDK_INT when running on release builds of the OS. This CL also updates the the check for whether Chrome is currently targeting Android O, which now also uses the Build.VERSION.SDK_INT for release builds, but still checks against CUR_DEVELOPMENT for pre-releases for Android O. BUG=685808 Change-Id: I7f17fd5bc8f6489586435818b224b080c391295c Reviewed-on: https://chromium-review.googlesource.com/495266 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa Wellington <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#469205}
-
dtrainor authored
In order to better understand Chrome usage, add metrics that help us figure out if Chrome is the default browser on the system or not. BUG=704223 Review-Url: https://codereview.chromium.org/2843693002 Cr-Commit-Position: refs/heads/master@{#469204}
-
glebl authored
NGLayoutInputNode::ShowNodeTree will be used for debugging or demonstration purposes(ex. show how the changes in LayoutObject tree will look like in LayoutNG) BUG=636993 Review-Url: https://codereview.chromium.org/2854993002 Cr-Commit-Position: refs/heads/master@{#469203}
-
jamescook authored
The crash occurs because chrome --mash doesn't have a chromeos::UIProxyConfigService. For classic ash this is usually created by chrome browser during startup. This object is using in ash to display a "your connection may be monitored" warning when using a network proxy. It has dependencies on the user profile pref service and the local state prefs, so we can't create one for mash yet. As a temporary measure, add a check for mash and skip the warning. This can be fixed properly when the mojo prefs service supports local state. Also add tests for TrayNetwork. This requires making it optional to initialize chromeos::NetworkHandler and DBusThreadManager in mash_unittests. BUG=717645,718072 TEST=ash_unittests, also chrome --mash doesn't crash when opening system tray networking menu Review-Url: https://codereview.chromium.org/2861773003 Cr-Commit-Position: refs/heads/master@{#469202}
-
Simeon Anfinrud authored
The CastContentWindowAndroid object would only get destroyed after the WebContents, but the Java handler for the former's destructor requires WebContents to still be around. Destroy the window_ in CastWebView before resetting the web_contents_. BUG=Internal b/37791255 TEST=Cast Play Movies to Android TV, tear down app, no crash. Change-Id: I496b19fdd97734bb00cfa3663c5d5a3f95a16d5d Reviewed-on: https://chromium-review.googlesource.com/494098Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#469201}
-
kbr authored
BUG=718183, 718194 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2858123002 Cr-Commit-Position: refs/heads/master@{#469200}
-
johnchen authored
Occasionally ChromeDriver may fail to delete temporary directories while exiting, causing wasted disk space. This change adds retry logic while cleaning up these directories. BUG=chromedriver:644 Review-Url: https://codereview.chromium.org/2853953002 Cr-Commit-Position: refs/heads/master@{#469199}
-
dgozman authored
BUG=491778 Review-Url: https://codereview.chromium.org/2854303004 Cr-Commit-Position: refs/heads/master@{#469198}
-
jsaul authored
BUG=718150 Review-Url: https://codereview.chromium.org/2861823002 Cr-Commit-Position: refs/heads/master@{#469197}
-
tommycli authored
Adds a bunch of missing nullchecks. Not sure why crash frequency has increased recently. Perhaps changes in RenderFrameObserver lifecycle: https://codereview.chromium.org/2034153002 BUG=717886 Review-Url: https://codereview.chromium.org/2860783002 Cr-Commit-Position: refs/heads/master@{#469196}
-
tommycli authored
BUG=690901 Review-Url: https://codereview.chromium.org/2862703002 Cr-Commit-Position: refs/heads/master@{#469195}
-
adithyas authored
This CL removes the following files from bindings/core/v8 and updates all include sites to use their platform/bindings version: - ToV8.h - TraceWrapperMember.h - TraceWrapperV8Reference.h - ScriptWrappableVisitorVerifier.h - SharedPersistent.h - StringResource.h - ScriptWrappableVisitor.h BUG=682322 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2856653003 Cr-Commit-Position: refs/heads/master@{#469194}
-
qinmin authored
If a StreamReader is found that it can no longer write any data, we should clear its callback. Otherwise, the StreamReader can still report an error and interrupt the download. BUG=717719 If the data has already been written Review-Url: https://codereview.chromium.org/2861443005 Cr-Commit-Position: refs/heads/master@{#469193}
-
fdoray authored
WorkerPool is being deprecated in favor of TaskScheduler. BUG=659191 Review-Url: https://codereview.chromium.org/2855543003 Cr-Commit-Position: refs/heads/master@{#469192}
-
mikecase authored
Want to move resources.zip files out of gen/ directory since they won't get packaged by several of the Builder bots. We will need these resources.zip files for JUnit tests. BUG=693573 Review-Url: https://codereview.chromium.org/2862603002 Cr-Commit-Position: refs/heads/master@{#469191}
-
lgarron authored
This CL does the following: - Move strings into page_info_strings.grdp - Organize the strings into sections with comment headings, based on the order and role they have in the UI. - Remove old "chrome/grit/generated_resources.h" includes in C++ files where possible. - Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES (crbug.com/716296) - Remove dead strings and their associated code (crbug.com/709701) - Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* (crbug.com/716305) - Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY BUG=663975, 709701, 716296, 716296, 716305 TBR=meacer@chromium.org, asanka@chromium.org, kkhorimoto@chromium.org Review-Url: https://codereview.chromium.org/2849713003 Cr-Commit-Position: refs/heads/master@{#469190}
-
smcgruer authored
This was an oversight when I originally implemented kCompositingInputsUpdate; the early-exit from UpdateLifecyclePhasesInternal meant that some necessary logic was being skipped accidentally. BUG=716150 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2844993004 Cr-Commit-Position: refs/heads/master@{#469189}
-
mostynb authored
This is required for GCC builds with is_official_build=true. BUG=464797 Review-Url: https://codereview.chromium.org/2858723002 Cr-Commit-Position: refs/heads/master@{#469188}
-
dvallet authored
BUG= Review-Url: https://codereview.chromium.org/2854973004 Cr-Commit-Position: refs/heads/master@{#469187}
-
tedchoc authored
Revert "Revert of Fix omnibox suggestions being overdrawn with the nav bar. (patchset #1 id:1 of https://codereview.chromium.org/2849283002/ )" This reverts commit 50e675c5. findViewById(android.R.id.content) can return null if called early enough. BUG=669150 Review-Url: https://codereview.chromium.org/2856943002 Cr-Commit-Position: refs/heads/master@{#469186}
-
kbr authored
Revert of Add more strict DCHECKs around context state. (patchset #1 id:1 of https://codereview.chromium.org/2852353003/ ) Reason for revert: Breaks an optimization needed on some Android devices for performance. Original issue's description: > Add more strict DCHECKs around context state. > > Upon processing commands in the GLES2Decoder, assert that the context > is current. > > Make virtual contexts' definition of "current" more strict. This > required moving a DCHECK inside the base GLContext class. > > These aren't needed, but were useful during recent debugging to > confirm that the bug wasn't in these areas. > > BUG=694359 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2852353003 > Cr-Commit-Position: refs/heads/master@{#469115} > Committed: https://chromium.googlesource.com/chromium/src/+/a21cb49e77bf727d692bbe8dd8eda85a9d089e93 TBR=jbauman@chromium.org,zmo@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=694359 Review-Url: https://codereview.chromium.org/2859963002 Cr-Commit-Position: refs/heads/master@{#469185}
-
jaydasika authored
https://codereview.chromium.org/2838033002/ unintentionally removed layers with singular transform and copy requests from the list of layers that draw. This CL fixes that. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2856043002 Cr-Commit-Position: refs/heads/master@{#469184}
-
chrishtr authored
Since all actual semantic clips are represented by the clip tree, this code was only necessary to check for cases when a surface exceeded the maximum texture size. Since the rendering would already be broken in such cases, it seems ok to not count that as a clip, which is correct w.r.t. the semantics of the web page, even if it disagrees with the apparent rendering. Note: the relevant code was added in https://codereview.chromium.org/1551333003. BUG=718149 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2858053003 Cr-Commit-Position: refs/heads/master@{#469183}
-
rdevlin.cronin authored
The declarativeContent API exposes constructors that initialize certain types. These constructors (sometimes) take arguments that need to be validated against the schema. Add native support for this validation by allowing native hooks to modify the API binding's object template, and using this to expose the constructor methods rather than relying on the JS custom bindings. Add additional declarativeContent-related tests and unittests for hooks modifying the API binding template. BUG=653596 Review-Url: https://codereview.chromium.org/2853023002 Cr-Commit-Position: refs/heads/master@{#469182}
-
avi authored
JavaScriptDialogClosed walks up a list of frames. It shouldn’t be deleting frames and then calling functions on them. BUG=717410 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2858743003 Cr-Commit-Position: refs/heads/master@{#469181}
-
fdoray authored
Use a constexpr constructor that accepts traits in any order instead of the builder pattern to construct TaskTraits in net. BUG=713683 R=gab@chromium.org TBR=jri@chromium.org Review-Url: https://codereview.chromium.org/2854243003 Cr-Commit-Position: refs/heads/master@{#469180}
-