GitLab

It looks like the error that the windows dom_perf tests are hitting could be
caused by improperly closing the socket, which this might fix.

error: [Errno 10053] An established connection was aborted by the software in your host machine

BUG=335624

Review URL: https://codereview.chromium.org/259623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266074 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365235

Review URL: https://codereview.chromium.org/257463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266073 0039d316-1c4b-4281-b951-d872f2087c98

This seems to have broken views_unittest (label_unittest) on ChromiumOS

> Automatically call OnNativeThemeChanged when a widget is added to a hierarchy
> with a widget.
> 
> Split off from https://codereview.chromium.org/245863002/
> 
> BUG=347832 (tangentially)
> 
> Review URL: https://codereview.chromium.org/248073005

TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/256683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366504

Review URL: https://codereview.chromium.org/255513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266070 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366750

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266069 0039d316-1c4b-4281-b951-d872f2087c98

Test must be disabled because the time range values will change
and binary files don't land well through CQ :(

BUG=366750
TEST=none
TBR=acolwell
NOTRY=true

Review URL: https://codereview.chromium.org/252633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266067 0039d316-1c4b-4281-b951-d872f2087c98

This CL exists as an effort to actually land
https://codereview.chromium.org/225513005/.

This applies a small fix to the hid_service_win.cc module.

BUG=359560
TBR=rpaquay
TBR=jracle@logitech.com

Review URL: https://codereview.chromium.org/256673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266066 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/253343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266060 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330735

Review URL: https://codereview.chromium.org/246633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266059 0039d316-1c4b-4281-b951-d872f2087c98

Remove the WCHAR_T_IS_UNSIGNED definition since it is not really useful. Replace its use with a static_cast.

BUG=354405
NOTRY=true

Review URL: https://codereview.chromium.org/248843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266058 0039d316-1c4b-4281-b951-d872f2087c98

There are no changes in implementation in this CL. This is in preparation
for making IPC::Channel support filters on the Channel's thread.

BUG=364241
TBR=cpu@chromium.org,nduca@chromium.org

cpu: OWNERS for win8
nduca: OWNERS for components/tracing

Review URL: https://codereview.chromium.org/245443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266057 0039d316-1c4b-4281-b951-d872f2087c98

R=yzshen@chromium.org
BUG=366768

Review URL: https://codereview.chromium.org/256503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266056 0039d316-1c4b-4281-b951-d872f2087c98

This will both improve cycle time and reduce log spam. See:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/20012/steps/telemetry_perf_unittests/logs/stdio

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/257493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266054 0039d316-1c4b-4281-b951-d872f2087c98

The NULL check seems to be accidentally compiled out, so work around that by dereferencing the same datatype through a volatile pointer.

BUG=361936

Review URL: https://codereview.chromium.org/255403008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266053 0039d316-1c4b-4281-b951-d872f2087c98

This broke the chromiumos builds.

> Send commands from webcamPrivate API to the webcam via V4L2 ioctls
> 
> BUG=346492
> 
> Review URL: https://codereview.chromium.org/234843006

TBR=zork@chromium.org

Review URL: https://codereview.chromium.org/256583007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266052 0039d316-1c4b-4281-b951-d872f2087c98

BUG=358728
TEST=Manual
NOTRY=True

Review URL: https://codereview.chromium.org/246353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266051 0039d316-1c4b-4281-b951-d872f2087c98

This moves a MACOSX-specific IME workaround outside the trusted plugin as part
of the effort to refactor all that code to components/nacl.

BUG=239656

Review URL: https://codereview.chromium.org/250063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266050 0039d316-1c4b-4281-b951-d872f2087c98

Depending on a group is like depending on that group's dependants. This wasn't working for forwarding dependent configs.

BUG=366814
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/255603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266049 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357670

Review URL: https://codereview.chromium.org/241863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266048 0039d316-1c4b-4281-b951-d872f2087c98

TODOs:
1. update native theme when user changes setting
2. fix various bugs like tooltip text color, bubble button color
3. decide if we should ever use aura theme for menus and tooltips

BUG=347832

Review URL: https://codereview.chromium.org/243633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266047 0039d316-1c4b-4281-b951-d872f2087c98

This also makes us consistently use GetWebContents() (instead of
delegate_->GetWebContents()) and, if it's to be stored in a variable, names the
variable |web_contents| (which is what the majority of uses already did).

BUG=362645
TEST=none

Review URL: https://codereview.chromium.org/254393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266046 0039d316-1c4b-4281-b951-d872f2087c98

Device id is ref string, not relative path.

BUG=366575

Review URL: https://codereview.chromium.org/258623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266043 0039d316-1c4b-4281-b951-d872f2087c98

with a widget.

Split off from https://codereview.chromium.org/245863002/

BUG=347832 (tangentially)

Review URL: https://codereview.chromium.org/248073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266042 0039d316-1c4b-4281-b951-d872f2087c98

Reland Remove remaining window states where window is shown with opacity 0. https://codereview.chromium.org/237963019/

BUG=351553

Review URL: https://codereview.chromium.org/258533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266041 0039d316-1c4b-4281-b951-d872f2087c98

This is now straightforward using the underlying DataView representation
used by the Mojo JS bindings, given its support for these types.

Review URL: https://codereview.chromium.org/247013008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266040 0039d316-1c4b-4281-b951-d872f2087c98

It OOMs on some android devices now and no one has the cycles to debug.

BUG=357326
NOTRY=True

Review URL: https://codereview.chromium.org/234813010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266039 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266038 0039d316-1c4b-4281-b951-d872f2087c98

r152: Patch City.h to fix compile errors in Chromium
--> This will allow proper inclusion of City.h where CityHash functions are 
    used in Chromium.

BUG=353157

Review URL: https://codereview.chromium.org/247013007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266037 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=172472:172520&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/259473006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333413

Review URL: https://codereview.chromium.org/250163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266034 0039d316-1c4b-4281-b951-d872f2087c98

This is same as crbug.com/366905, but causing failure due to the lack of symbols.
This suppression is too wide and should be reverted as soon as the symbol issue is solved.

BUG=366905
TBR=zhaoqin@chromium.org, bruening@chromium.org

Review URL: https://codereview.chromium.org/250753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266033 0039d316-1c4b-4281-b951-d872f2087c98

The perf dashboard can only display one unit (e.g. ms, bit/s, etc) per
graph, so this patch splits the metrics into reasonable buckets. I
deliberately didn't name them like the old buckets in order to reduce
confusion (e.g. audio_send, video_recv, and so on).

Also it turns out I had mixed up video_recv and video_send, so this
patch corrects that.

Another benefit is that we won't see huge values (bytes_received) with
small values (num_firs_recv), which makes the graphs easier to read.

R=kjellander@chromium.org,xians@chromium.org
BUG=357525

Review URL: https://codereview.chromium.org/252513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266031 0039d316-1c4b-4281-b951-d872f2087c98

BUG=363948

Review URL: https://codereview.chromium.org/252383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266030 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True

Review URL: https://codereview.chromium.org/249713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266029 0039d316-1c4b-4281-b951-d872f2087c98

clang says:

..\..\chrome\browser\ui\views\frame\minimize_button_metrics_win.cc(24,59) :
warning(clang): use of logical '||' with constant operand
[-Wconstant-logical-operand]
      (titlebar_info.rgstate[2] & (STATE_SYSTEM_INVISIBLE ||
                                                          ^
..\..\chrome\browser\ui\views\frame\minimize_button_metrics_win.cc(24,59) :
note(clang): use '|' for a bitwise operation
      (titlebar_info.rgstate[2] & (STATE_SYSTEM_INVISIBLE ||
                                                          ^~
                                                          |
1 warning generated.

BUG=82385
R=sky@chromium.org

Review URL: https://codereview.chromium.org/254583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266028 0039d316-1c4b-4281-b951-d872f2087c98

R=jzern@chromium.org, urvang@google.com

Review URL: https://codereview.chromium.org/259623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266027 0039d316-1c4b-4281-b951-d872f2087c98

* Add const, static and/or private in some places.
* Integrate ProcessCustomWallpaper() into SetCustomWallpaper() to avoid PostTask() and deep copy of wallpaper in case it is not persistent.
* Replace UserImage by gfx::ImageSkia in some places to simplify code and to avoid useless temporary objects.
* Remove unused DAILY User::WallpaperType.
* Remove unused GetOriginalWallpaperPathForUser().
* Replace SetLastSelectedUser() by direct member access.
* Add initialization of WallpaperInfo.date that was missing in one case.
* Rename all ImageSkia method parameters to "image" and all UserImage method parameters to "user_image" for consistency.
* Rename ResizeWallpaper() to ResizeImage().
* Improve some comments.

BUG=none

Review URL: https://codereview.chromium.org/221873005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266026 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found while doing
https://codereview.chromium.org/243343002 and we discovered that android
was building wifi_test target.

It was building this target because it does:

$ ninja -C out/Debug -j50

And that builds all the targets generated by gyp.

Since the target was not excluded from android platform, a target was
created there and thus the above command would build it.

This patch fixes this problem, by only including it where it is actually
supported.

BUG=None
TEST=green trybots
R=mef@chromium.org,thestig@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/259543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266025 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/250103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266024 0039d316-1c4b-4281-b951-d872f2087c98

- for Windows and Linux
- open device with read access when read/write fails

BUG=364438

R=rockot@chromium.org

Review URL: https://codereview.chromium.org/240263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266022 0039d316-1c4b-4281-b951-d872f2087c98