GitLab

This is not really part of the JSON standard but a common practice and is
harmless in most of the cases so we can enable it for JSON policy files.

BUG=101141
TEST=none


Review URL: http://codereview.chromium.org/8423079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110503 0039d316-1c4b-4281-b951-d872f2087c98

This picks up a single change: http://src.chromium.org/viewvc/chrome?view=rev&revision=110423

BUG=101600
TEST=none


Review URL: http://codereview.chromium.org/8587020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110502 0039d316-1c4b-4281-b951-d872f2087c98

In the File Manager list view icons are moved to the name column. Checkbox column made unsortable.

+bugfixes.

BUG=chromium-os:20156
TEST=None


Review URL: http://codereview.chromium.org/8585027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110501 0039d316-1c4b-4281-b951-d872f2087c98

Replace SetContentSetting method of the content_settings::Provider interface with GetWebsiteSetting.

This is part of a series of cleanup CLs to make all content settings Providers and the HostContentSetting map use only |Values| instead of |ContentSettings|. The HostContentSettingsMap should only contain conveniences methods that take |ContentSetting| parameters.

BUG=102637
TEST=HostContentSettingsMapTest*,
     PrefProviderTest*,
     PolicyProviderTest*,
     DefaultProviderTest*,
     ExtensionProviderTest*

Review URL: http://codereview.chromium.org/8539004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110500 0039d316-1c4b-4281-b951-d872f2087c98

Bug=None
Test=None


Review URL: http://codereview.chromium.org/8351052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110499 0039d316-1c4b-4281-b951-d872f2087c98

Fixed the problem that sort didn't work correctly when some rows are "N/A". 

BUG=none 
TEST=manually


Review URL: http://codereview.chromium.org/8486014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110498 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8590007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110497 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org

Review URL: http://codereview.chromium.org/8584001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110496 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8590004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110495 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102804
TEST=Manual


Review URL: http://codereview.chromium.org/8586023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110494 0039d316-1c4b-4281-b951-d872f2087c98

Ran with --gtest_repeat=500 and unable to get it to fail.

BUG=70960


Review URL: http://codereview.chromium.org/8581001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110493 0039d316-1c4b-4281-b951-d872f2087c98

This is preparation for implementation Mozc suggest window fix.

TEST=emerge chromeos-chrome and run unit_tests
BUG=None


Review URL: http://codereview.chromium.org/8573035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110492 0039d316-1c4b-4281-b951-d872f2087c98

Some users fall off the update train. We don't want to build up a non-trival
population of people who have pins that we might want to change.

BUG=103283
TEST=Check that https://pinningtest.appspot.com fails in official builds.

http://codereview.chromium.org/8467031/

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110491 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r110456.

These tests have been failing on the Mac10.6 Sync builder since this was landed:
ManyClientBookmarksSyncTest.Sanity
ManyClientPasswordsSyncTest.Sanity
ManyClientPreferencesSyncTest.Sanity

BUG=
TEST=

Review URL: http://codereview.chromium.org/8590030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110490 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8589024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110489 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104582

Review URL: http://codereview.chromium.org/8588031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110488 0039d316-1c4b-4281-b951-d872f2087c98

This patch is 3rd part of 3 splitted patches made from http://codereview.chromium.org/8386031

BUG=chromium-os:16556
TEST=build success


Review URL: http://codereview.chromium.org/8499009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110486 0039d316-1c4b-4281-b951-d872f2087c98

- marked most callbacks as optional;
- merged PanelWithSidebars into ElementsPanel;
- more specific description for most of the callbacks;
- misc puntuation fixes;^H.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8538005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110485 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110482 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110480 0039d316-1c4b-4281-b951-d872f2087c98

TBR=danno

Review URL: http://codereview.chromium.org/8591016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110479 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE

Follow up on:
Review URL: http://codereview.chromium.org/8465022

Then reverted by:
http://codereview.chromium.org/8571008/


Review URL: http://codereview.chromium.org/8468010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110476 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104496
TEST=Opening a Panel in debug mode with Youtube frame embedded right after launching chromium.


Review URL: http://codereview.chromium.org/8581004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110475 0039d316-1c4b-4281-b951-d872f2087c98

BUG=80308


Review URL: http://codereview.chromium.org/8585005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=emerge chromeos-chrome passed.


Review URL: http://codereview.chromium.org/8585022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110471 0039d316-1c4b-4281-b951-d872f2087c98

The in-browser crash tests used to be flaky, but this was fixed some
time ago.  More recently, the inbrowser_crash_in_syscall test got
broken by a change that caused the Breakpad handler to get run twice
per crash, but this has now been fixed too.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2173
TEST=nacl_integration

Review URL: http://codereview.chromium.org/8573023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110470 0039d316-1c4b-4281-b951-d872f2087c98

This patch is 2nd part of 3 splitted patches made from http://codereview.chromium.org/8386031


BUG=chromium-os:16556
TEST=Confirm that removable disk is correctly mounted


Review URL: http://codereview.chromium.org/8497007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110469 0039d316-1c4b-4281-b951-d872f2087c98

SearchEngineManagerWebUITest.testOpenSearchEngineManager fails when run on a ChromeOS VM for the first time, all subsequent runs pass. Marking it as flaky.

See crosbug.com/22673


BUG=chromium-os:22673
TEST=Confirmed that the test doesn't cause a fail on ChromeOS VM's.


Review URL: http://codereview.chromium.org/8495025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110468 0039d316-1c4b-4281-b951-d872f2087c98

This is part 1 of the UpdateLibrary to UpdateEngineClient migration.
The new files are added but not used from Chrome yet.

The new code is based on update_library.cc and chromeos_update_engine.cc,
and the new code will replace the them.

For code review, please refer to the files below:

http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/cros/update_library.h?view=markup
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/cros/update_library.cc?view=markup
http://git.chromium.org/gitweb/?p=chromiumos/platform/cros.git;a=blob;f=chromeos_update_engine.h;hb=HEAD
http://git.chromium.org/gitweb/?p=chromiumos/platform/cros.git;a=blob;f=chromeos_update_engine.cc;hb=HEAD

BUG=chromium-os:16564
TEST=chrome and tests build.

Review URL: http://codereview.chromium.org/8572020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110467 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100879
TEST=Visually confirm that when entering fullscreen, the exit bubble has a drop shadow.


Review URL: http://codereview.chromium.org/8565034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110465 0039d316-1c4b-4281-b951-d872f2087c98

Background: when first opening about:profiler, the browser sends data for each process as it becomes available. The UI responds to this by redrawing all the data. If there are a lot of processes then this can cause many conecutive repaints which slows things down. To avoid this, we now bulk together redraws on a 500ms timer (just for loading, not any user-initiated action).

BUG=100992
Review URL: http://codereview.chromium.org/8585023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110464 0039d316-1c4b-4281-b951-d872f2087c98

The new field trial (SUGGEST) is almost the same as HIDDEN, except that the
Instant suggested text is allowed to be autocompleted into the omnibox. Since
the hidden tab contains results for the full query, it's more likely to be
relevant when the user presses <Enter>. From the user perspective, the omnibox
autocompletion is similar to how it behaves for past searches.

BUG=none
TEST=With --instant-field-trial=suggest, type into the omnibox, and observe
that it gets inline autocompleted, even though there's no Instant preview.


Review URL: http://codereview.chromium.org/8588003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103688
TEST=manual


Review URL: http://codereview.chromium.org/8571024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110462 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103997
TEST=Changing focus using tab should only navigate to visible elements.


Review URL: http://codereview.chromium.org/8573016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110461 0039d316-1c4b-4281-b951-d872f2087c98

Initially, this object was owned by views hierarchy, but this is not the case since
http://src.chromium.org/viewvc/chrome?view=rev&revision=42404.

The leak didn't manifest itself until http://src.chromium.org/viewvc/chrome?view=rev&revision=110041

TEST=none
BUG=104029


Review URL: http://codereview.chromium.org/8585011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110460 0039d316-1c4b-4281-b951-d872f2087c98

R=asargent@chromium.org


Review URL: http://codereview.chromium.org/8568037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110459 0039d316-1c4b-4281-b951-d872f2087c98

The CNS allows files to be served under constrained network conditions
per the design doc listed in the bug report.

Uses CherryPy to handle HTTP processing. See ./cns.py --help, to run:

./cns.py [--port <port>] [--port-range <port-range>]

Requests can then be made to:

http://<server ip>:<port>/ServeConstrained?f=<file>&latency=...&bandwidth=...&loss=...

The server will allocate a port from the preconfigured range and setup
constraints on that port. Subsequent requests for the same constraints
from the same source ip will result in the constrained port being
reused.

BUG=104242
TEST=Ran locally. Ran unittests.


Review URL: http://codereview.chromium.org/8528049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110458 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8468026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110457 0039d316-1c4b-4281-b951-d872f2087c98

Version is in format <Browser Name> <Version> (<OS>) <Channel/Modifier info>

BUG=97158
TEST=verify version info is in about:sync


Review URL: http://codereview.chromium.org/8587017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110456 0039d316-1c4b-4281-b951-d872f2087c98

use-gl=desktop mode got broken in r109111. GL proc addresses were not being found because ::GetProcAddress does not work with stock opengl32.dll. The stock dll just exposes GL 1.1 interface. wglGetProcAddress needs to be used to get >GL 1.1 interface, which in turn requires a GL current context.
This patch simply reverts a portion of r109111.
BUG=103765

Review URL: http://codereview.chromium.org/8588009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110455 0039d316-1c4b-4281-b951-d872f2087c98