GitLab

This adds a new simpler method to ResourceProvider called
CopyToResource and uses that instead. This removes TextureUploader
from the path of most impl-side painting code.
R=enne
BUG=454575

Review URL: https://codereview.chromium.org/938893002

Cr-Commit-Position: refs/heads/master@{#316978}

This makes SHMEM implementation of discardable memory preferred
over EMULATED implementation. This effectively makes SHMEM the
implementation used by default on Linux, CrOS and Windows.

SHMEM implementation of discardable memory gives the browser
process control over the total amount of discardable memory used
and allows us to enforce a global limit of 512MB across all
renderers.

BUG=429415,429416

Review URL: https://codereview.chromium.org/793443003

Cr-Commit-Position: refs/heads/master@{#316977}

BUG=459688

Review URL: https://codereview.chromium.org/940723002

Cr-Commit-Position: refs/heads/master@{#316976}

BUG=430054
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/936123002

Cr-Commit-Position: refs/heads/master@{#316975}

Discover the Zygote's PID properly when using the namespace sandbox.

BUG=459724

Review URL: https://codereview.chromium.org/940603003

Cr-Commit-Position: refs/heads/master@{#316974}

Non-android bots will not have credentials to download SDK packages from Google
Storage buckets. Thus, if a bot does not have credentials, the hook should print
a warning and continue.

BUG=459681

Review URL: https://codereview.chromium.org/940633003

Cr-Commit-Position: refs/heads/master@{#316973}

BUG=459642

Review URL: https://codereview.chromium.org/933343002

Cr-Commit-Position: refs/heads/master@{#316972}

Revert of Reland #4: Ensure WebView notifies desktop automation on creation,  (patchset #1 id:1 of https://codereview.chromium.org/940763002/)

Reason for revert:
Still flakes on bots.

Original issue's description:
> Reland #4: Ensure WebView notifies desktop automation on creation, destruction, and change
>
> Previous attempts:
> https://codereview.chromium.org/880063002
> https://codereview.chromium.org/895623003/
> https://codereview.chromium.org/890013006/
> https://codereview.chromium.org/907973004/
>
> This latest attempt removes the logic that reloads ChromeVox at the beginning of a test.
>
> Locally, under extremely heavy load, tests progressively ran slowe. The same copy of a test ran 1 second slower than a previous copy. Ultimately, this led to a timeout.
>
> With the above change, this no longer occurs and hopefully fixes the flakeyness.
>
> Change is located in chromevox_e2e_test_base.js.
>
> TBR=dmazzoni@chromium.org
>
> Committed: https://crrev.com/47cb3b3798d325f3083565a05a2dcdaee117c296
> Cr-Commit-Position: refs/heads/master@{#316950}

TBR=dmazzoni@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/939853003

Cr-Commit-Position: refs/heads/master@{#316971}

BUG=408152

Review URL: https://codereview.chromium.org/932293002

Cr-Commit-Position: refs/heads/master@{#316970}

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org

Review URL: https://codereview.chromium.org/936183002

Cr-Commit-Position: refs/heads/master@{#316969}

There's a bug in AppKit that causes Chrome to crash when users attempt to save
or open a file. The code path that causes the crash is only hit by applications
linked against OSX 10.7 SDK (or earlier). This CL registers a default value for
the preference NSViewKeepLayersAround, which prevents this code path from being
hit. The functional implications of changing the preference
NSViewKeepLayersAround are minimal.

BUG=428977

Review URL: https://codereview.chromium.org/941453002

Cr-Commit-Position: refs/heads/master@{#316968}

Review URL: https://codereview.chromium.org/924803003

Cr-Commit-Position: refs/heads/master@{#316967}

TBR=cpu
BUG=458571

Review URL: https://codereview.chromium.org/930243007

Cr-Commit-Position: refs/heads/master@{#316966}

This change makes tools/perf/page_sets/tough_animation_cases/resources/perftesthelper.js
consistent with the Chromium Javascript style guide:
 - Fixed indentation
 - Added missing semicolon
 - Renamed file to be underscore separated

Review URL: https://codereview.chromium.org/927583005

Cr-Commit-Position: refs/heads/master@{#316965}

This change ensures that if a QUIC proxy is unreachable,
then it is marked as bad. Allows chrome to retry the
request with the next proxy instead of showing
ERR_QUIC_PROTOCOL to user.

BUG=459426

Review URL: https://codereview.chromium.org/936243002

Cr-Commit-Position: refs/heads/master@{#316964}

BUG=458687, 403800

Review URL: https://codereview.chromium.org/929483004

Cr-Commit-Position: refs/heads/master@{#316963}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/830d38e..37a8479

TBR=yhirano@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/939843002

Cr-Commit-Position: refs/heads/master@{#316962}

BUG=426953
TEST=See bug for repro steps.

Review URL: https://codereview.chromium.org/913223009

Cr-Commit-Position: refs/heads/master@{#316961}

Also deletes a bunch of comments that no longer apply and need to
be rewritten.

BUG=457413

Review URL: https://codereview.chromium.org/932263002

Cr-Commit-Position: refs/heads/master@{#316960}

This is the first step in removing the flag entirely.

BUG=457462

Review URL: https://codereview.chromium.org/931233004

Cr-Commit-Position: refs/heads/master@{#316959}

Moves creation of conversion_settings and bitmap_settings needed by
PWGRasterConverter::Start to a place usable by code for handling
extension printers. This will enable extension printer handler to reuse
the code when converting pdf documents to PWG raster data.

BUG=408772
TEST=existing tests

Review URL: https://codereview.chromium.org/935673004

Cr-Commit-Position: refs/heads/master@{#316958}

The PDF viewer has 2 plugins associated with it. These are grouped correctly for Google Chrome but not for Chromium. This groups these plugins correctly for Chromium by updating the plugin metadata.

BUG=459113

Review URL: https://codereview.chromium.org/931063002

Cr-Commit-Position: refs/heads/master@{#316957}

SharedPreference.edit() creates a new editor.
So calling this method twice creates 2 different editors.
And the apply() call from the 2nd editor has no effect on the first editor.

BUG=459403

Review URL: https://codereview.chromium.org/930303003

Cr-Commit-Position: refs/heads/master@{#316956}

Property trees don't calculate lcd text settings on the main thread, so
to move to them, these calculations need to move to the compositor
thread.

There's nothing tied to the main thread, other than only changing lcd
text during a commit.  This restriction avoids the pitfall of tile
versions (i.e. changing out content in place with different settings) by
only changing content and invalidating during a commit, which already
waits for rasterization to occur before displaying that content.

That restriction is satisfied by only updating lcd text on picture
layers during an update on the sync tree on new frame numbers.

Review URL: https://codereview.chromium.org/913203006

Cr-Commit-Position: refs/heads/master@{#316955}

- Usually, logical first segment should appear in the first line
  when multi-lined. This is the reported bug as crbug.com/458219
  Therefore, TextRunHarfBuzz should be added to the line breaker
  in the logical order.
- The segment order in a line is assumed as visual order,
  therefore it needs to be sorted.
- Modified the test expectations which support this behavior.
- Added new test cases to verify where exactly the segment is
  drawn.

BUG=458219
R=msw@chromium.org, ckocagil@chromium.org
TEST=gfx_unittests

Review URL: https://codereview.chromium.org/924773002

Cr-Commit-Position: refs/heads/master@{#316954}

This means the grey text under the title, which usually explains what
type the result is (e.g., "Google Search" or "Chrome Web Store").

BUG=450644

Review URL: https://codereview.chromium.org/935523002

Cr-Commit-Position: refs/heads/master@{#316953}

Clipboard is single-threaded, so Stop() is not useful there.

Review URL: https://codereview.chromium.org/930403002

Cr-Commit-Position: refs/heads/master@{#316952}

BUG=458379

Review URL: https://codereview.chromium.org/925733002

Cr-Commit-Position: refs/heads/master@{#316951}

Previous attempts:
https://codereview.chromium.org/880063002
https://codereview.chromium.org/895623003/
https://codereview.chromium.org/890013006/
https://codereview.chromium.org/907973004/

This latest attempt removes the logic that reloads ChromeVox at the beginning of a test.

Locally, under extremely heavy load, tests progressively ran slowe. The same copy of a test ran 1 second slower than a previous copy. Ultimately, this led to a timeout.

With the above change, this no longer occurs and hopefully fixes the flakeyness.

Change is located in chromevox_e2e_test_base.js.

TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/940763002

Cr-Commit-Position: refs/heads/master@{#316950}

By defaulting Threaded GPU Rasterization to ON I inadvertently
disabled using more than 1 raster thread for Software rasterization
everywhere.

Fixing so IsThreadedGpuRasterizationEnabled() is only on if Gpu
rasterization is enabled or forced, so this will currently only be
on for Android.

We'll need a better way to support multiple raster worker threads
to turn on GPU rasterization on desktops, or to support multiple render
threads on Android.

BUG=454500
BUG=459760

Review URL: https://codereview.chromium.org/941443002

Cr-Commit-Position: refs/heads/master@{#316949}

Example: for "chrome-extension://extensionid/page.html",

Currently, the src would be set as: "chrome-extension://extensionid/page.html".

With the change, the src would be set as: "page.html".

BUG=459680

Review URL: https://codereview.chromium.org/936223002

Cr-Commit-Position: refs/heads/master@{#316948}

The new assets have correct colour contrast and more closely match the
Material Design spec. Affects both the classic and experimental
launcher.

The following assets were replaced:

- Microphone (hotword enabled and disabled states).
- Back button.
- Download progress bar.

BUG=457979,456953
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/931483004

Cr-Commit-Position: refs/heads/master@{#316947}

New chrome os devices are going to make more frequent use of the dark
resume state - a hybrid power state where several hardware devices are
left off to save power.  One of these is the display.  Unfortunately
this creates issues with chrome, which believes that the display is on
and attempts to render things to the screen.  These calls fail in the
kernel and trigger a logical memory leak in the error handling code in
the GPU process.

In order to make this interaction more robust, have chrome stop sending
rendering requests at suspend time and restart them at resume time.
There are a few things to watch out for here.  If the user has requested
that the screen be locked at suspend time then rendering cannot be
stopped until the screen locker is visible.  Otherwise the contents of
the user's screen will be visible at resume time, which is a security
issue.  Additionally, the suspend must be delayed until any pending
requests have been handled by the GPU process to prevent a race where
the system suspends before all requests have been processed and they end
up being processed when the system later enters dark resume, triggering
the memory leak mentioned in the previous paragraph.

BUG=chrome-os-partner:35699

Review URL: https://codereview.chromium.org/910393002

Cr-Commit-Position: refs/heads/master@{#316946}

Address comments of RCH

BUG=none

Review URL: https://codereview.chromium.org/934383002

Cr-Commit-Position: refs/heads/master@{#316945}

This is temporary until we can determine a permanent solution.
This cannot be implemented at a lower level because the lower levels do not know
which version of EME is being used.

BUG=394926

Review URL: https://codereview.chromium.org/936653004

Cr-Commit-Position: refs/heads/master@{#316944}

This will be used to track session history items for subframes.
For now, each NavigationEntry owns a single one for its main frame.

BUG=236848
TEST=No behavior change.

Review URL: https://codereview.chromium.org/931333004

Cr-Commit-Position: refs/heads/master@{#316943}

The new accent color matches the rest of the app.

BUG=459699

Review URL: https://codereview.chromium.org/941513002

Cr-Commit-Position: refs/heads/master@{#316942}

BUG=439497

Review URL: https://codereview.chromium.org/938743002

Cr-Commit-Position: refs/heads/master@{#316941}

This eliminates one use of TextureUploader via
ResourceProvider::SetPixels.  The PICTURE_PILE_MODE is renamed to
OOM_MODE which more accurately describes what it is, and OOM tiles are
displayed in red again instead of gray (something that changed with
impl-side-painting).

R=enne
BUG=454575

Review URL: https://codereview.chromium.org/941433002

Cr-Commit-Position: refs/heads/master@{#316940}

Avoid possibly long blocking times in the Windows SetupDi function
calls made to enumerate devices by offloading to the FILE thread.
Now that we can be sure that a stray request to the device won't
block the UI additional calls to get the device's product and serial
number strings can be made.

BUG=457899

Review URL: https://codereview.chromium.org/936603003

Cr-Commit-Position: refs/heads/master@{#316939}