- 24 Oct, 2014 4 commits
-
-
kundaji authored
When we activate data reduction proxy, a request is made to the prober URL. If this request is made before ProfileManager::DoFinalInitForServices() completes, it causes a crash because HostContentSettingsMap is not yet initialized. BUG=424260 Review URL: https://codereview.chromium.org/665703002 Cr-Commit-Position: refs/heads/master@{#300995}
-
aruslan authored
BUG=426437 Review URL: https://codereview.chromium.org/673903002 Cr-Commit-Position: refs/heads/master@{#300994}
-
cpu authored
Right now we are checking Vista in a Win8 file. Crazy. BUG=426573 Review URL: https://codereview.chromium.org/671273003 Cr-Commit-Position: refs/heads/master@{#300993}
-
xhwang authored
This is a preparation to move KeySystems to media, which is needed to support Encrypted Media Extensions (EME) without relying on content. BUG=422730 Review URL: https://codereview.chromium.org/665343002 Cr-Commit-Position: refs/heads/master@{#300992}
-
- 23 Oct, 2014 36 commits
-
-
boliu authored
By making the limit unrealistically high. BUG=426548 Review URL: https://codereview.chromium.org/660383004 Cr-Commit-Position: refs/heads/master@{#300991}
-
newt authored
Changes to these files are always UI-related and should be reviewed by someone familiar with Chrome Android UI. Review URL: https://codereview.chromium.org/647043007 Cr-Commit-Position: refs/heads/master@{#300990}
-
horo authored
https://codereview.chromium.org/643773004 broke LayoutTest fetch-mixed-content.html. While executing LayoutTest, ignore_certificate_errors is set in LayoutTestBrowserContext. So every cert errors are ignored in HttpStreamFactoryImpl::Job::HandleCertificateError. At this case we should also ignore the cert errors in ServiceWorkerWriteToCacheJob. BUG=426047,425396 Review URL: https://codereview.chromium.org/664343005 Cr-Commit-Position: refs/heads/master@{#300989}
-
zmo authored
BUG=421709,421695,415694 TEST=gpu bots NOTRY=true TBR=bajones@chromium.org Review URL: https://codereview.chromium.org/667253003 Cr-Commit-Position: refs/heads/master@{#300988}
-
dmazzoni authored
This will be followed with a Clank change to use this class everywhere we're using ClickableSpans. BUG=390226,418989 Review URL: https://codereview.chromium.org/657893005 Cr-Commit-Position: refs/heads/master@{#300987}
-
scottmg authored
R=sky@chromium.org BUG=143619 Review URL: https://codereview.chromium.org/672673005 Cr-Commit-Position: refs/heads/master@{#300986}
-
timvolodine authored
BUG=347507 Review URL: https://codereview.chromium.org/661413003 Cr-Commit-Position: refs/heads/master@{#300985}
-
joaodasilva authored
Extensions may import resources from other extensions. Extensions that export resources to other extensions are known as shared_modules. Chrome is currently applying the blacklist to all kinds of extensions; this means that whitelisting (or force-installing) an extension that requires shared_modules will fail unless the modules are whitelisted too. This CL bypasses the policy blacklist checks for shared_modules. Also fixed a bug in the CrxInstaller, which prevented extensions loaded via external providers (such as policy) from getting their dependencies installed. BUG=424377 Review URL: https://codereview.chromium.org/666223005 Cr-Commit-Position: refs/heads/master@{#300984}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/47eedcc..14e4d39 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=mtklein@google.com Review URL: https://codereview.chromium.org/675013002 Cr-Commit-Position: refs/heads/master@{#300983}
-
navabi authored
A device with a critically low battery gets listed as a bad device. The device status check only fails if all devices are bad. Otherwise, it will continue with the good devices. BUG=423709 Review URL: https://codereview.chromium.org/651843007 Cr-Commit-Position: refs/heads/master@{#300982}
-
vmpstr authored
This patch is part 2 of a fix to return pending now tiles before active eventually tiles. We already do this at a pair level. This patch ensures that we also do it across pairs. That is, given two pairs of layers, if the highest priority tile on one is an active eventually tile and the highest priority tile on the other is a pending now tile, then prefer the pending now tile (this is just for smoothness). This ensures that we activate if we're prepainting too far. BUG=426287 R=reveman Review URL: https://codereview.chromium.org/675663002 Cr-Commit-Position: refs/heads/master@{#300981}
-
paulmeyer authored
********** This is an initial working reimplementation of webview attributes that will allow for many improvements to how webview handles attributes (and with much less code repetition!) in future CLs. In this CL: - Created a new web_view_attributes.js file to contain the implementation of webview attributes. - Reimplemented all webview attributes as objects that share common properties through inheritance, and can be operated on more consistently (this is important for automating the handling of attributes in later CLs). - Constants are now used for attribute names consistently throughout webview. Review URL: https://codereview.chromium.org/663483004 Cr-Commit-Position: refs/heads/master@{#300980}
-
asvitkine authored
Adds a CHECK to the production code since our memory bots don't like a crash on a null deref, even in a death test. BUG=123063 Review URL: https://codereview.chromium.org/678493002 Cr-Commit-Position: refs/heads/master@{#300979}
-
oshima authored
BUG=None Review URL: https://codereview.chromium.org/653563004 Cr-Commit-Position: refs/heads/master@{#300978}
-
amistry authored
BUG=397019 Review URL: https://codereview.chromium.org/671113002 Cr-Commit-Position: refs/heads/master@{#300977}
-
davidu authored
Previously the UI chooses the highest pixel rate mode when multiple modes exists for the same screen resolution. If there exist a higher pixel clock mode that's the same as the monitor's preferred mode, then HDMI is first plugged in it will choose the preferred mode, but when you later switch away to a different resolution and then switch back, you will get the higher pixel clock version. This patch changes FindDisplayModeMatchingSize() to choose the preferred mode instead of the one with highest pixel clock. BUG=chrome-os-partner:29514 TEST=Using the EDID of DELL U2410, there are two 1920x1200 modes 1920x1200 (0x1d2) 154.0MHz -HSync +VSync *current +preferred h: width 1920 start 1968 end 2000 total 2080 skew 0 clock 74.0KHz v: height 1200 start 1203 end 1209 total 1235 clock 60.0Hz 1920x1200 (0x1d3) 193.2MHz -HSync -VSync h: width 1920 start 2049 end 2256 total 2593 skew 0 clock 74.5KHz v: height 1200 start 1202 end 1205 total 1242 clock 60.0Hz plug HDMI in, and obseve that it uses mode 0x1d2. switch to 720p mode, then switch back to 1920x1200 observe that it does not use mode 0x1d3. Review URL: https://codereview.chromium.org/606913002 Cr-Commit-Position: refs/heads/master@{#300976}
-
watk authored
In Android SDK 21, adb shell started escaping quotes in its arguments. This change removes the literal quotes around the URLs in intents sent by The adb_run_*_shell scripts. BUG=426544 Review URL: https://codereview.chromium.org/662683006 Cr-Commit-Position: refs/heads/master@{#300975}
-
qyearsley authored
First try was https://codereview.chromium.org/676893002/; I forgot to add an import statement. BUG=426564 Review URL: https://codereview.chromium.org/668343006 Cr-Commit-Position: refs/heads/master@{#300974}
-
peter authored
It's odd to have a directory specifically for this, since the other directories in //content/shell/ refer to the process they're in. BUG= Review URL: https://codereview.chromium.org/653573003 Cr-Commit-Position: refs/heads/master@{#300973}
-
rtenneti authored
StartupTimeBombAlarm. Added a TODO to enable StartupTimeBomb for Android. Reverting the following two CL's manaually: https://codereview.chromium.org/269763002 https://codereview.chromium.org/273963002 R=jar@chromium.org BUG=366699 Review URL: https://codereview.chromium.org/672973002 Cr-Commit-Position: refs/heads/master@{#300972}
-
sebmarchand authored
We don't produce them anymore. TBR=chrisha@chromium.org BUG= Review URL: https://codereview.chromium.org/662543009 Cr-Commit-Position: refs/heads/master@{#300971}
-
navabi authored
BUG=406848 Review URL: https://codereview.chromium.org/673863002 Cr-Commit-Position: refs/heads/master@{#300970}
-
cjhopman authored
This adds pretty straightforward conversion of the relocation package gyp targets. The android_apk template is updated to use pack_arm_relocations.py instead of copy_ex.py for copying native libraries into the directory used to build the apk. This script will copy the files when relocation packing is disabled and otherwise will do the relocation packing (just like it does in gyp). BUG=359249 Review URL: https://codereview.chromium.org/650933003 Cr-Commit-Position: refs/heads/master@{#300969}
-
noms authored
This includes - actually drawing the button correctly in Metro/Win 8 CrOS/immersive mode - fixing chrome://settings to display the multiple users box in these cases Screenshots (including rtl and non-english characters YAY): https://drive.google.com/open?id=0B1B1Up4p2NRMWmdhcklhUUtQVU0&authuser=1 BUG=422434 TEST=Start Chrome with --enable-new-avatar-menu. From the hot-dog menu, relaunch Chrome in immersive mode. Everything should look like it does in normal mode (avatar button on the right, tabs don't overlap it, users are listed and can be edited in chrome://settings) Review URL: https://codereview.chromium.org/668773002 Cr-Commit-Position: refs/heads/master@{#300968}
-
gcasto authored
BUG=363324 TBR=groby@chromium.org Review URL: https://codereview.chromium.org/657633004 Cr-Commit-Position: refs/heads/master@{#300967}
-
sebmarchand authored
BUG= Review URL: https://codereview.chromium.org/666143004 Cr-Commit-Position: refs/heads/master@{#300966}
-
rlp authored
Checking for audio devices right away is causing performance regressions on Mac. This CL delays checking until needed, but does not include the availability of an audio capture device in the error reporting until after it's known the check has been completed. Otherwise, the settings page immediately displays an error upon opening. In general, this should not be a problem as typically the audio device check will have completed by the time the user goes to the settings page. There is a rare use case, where the user installs Chrome and immediately goes to settings and in that case, we won't be able to accurately report if there is an audio device preventing the user from starting hotwording. However, by the time they reload, the error should be present which should be sufficient. BUG=385514,413104 Review URL: https://codereview.chromium.org/654613004 Cr-Commit-Position: refs/heads/master@{#300965}
-
yzshen authored
Revert of Rename BrowserActionView to ToolbarActionView (patchset #1 id:40001 of https://codereview.chromium.org/673503002/) Reason for revert: Failed ComponentToolbarActionsBrowserTest.ComponentToolbarActionsShowUpAndRespondToClicks on Linux ChromiumOS Tests (dbg)(1) and Linux Tests (dbg)(1)(32). [23680:23680:1023/150443:FATAL:browser_actions_container.cc(1021)] Check failed: model_->toolbar_items().size() == toolbar_action_views_.size() (0 vs. 1) Original issue's description: > Rename BrowserActionView to ToolbarActionView > BrowserActionViews now represent significantly more than > just Browser Actions. Rename it to ToolbarActionView. > > BUG=426448 > > Committed: https://crrev.com/fdc6f645c57aa0a054166743d1614ddaf32ab4c0 > Cr-Commit-Position: refs/heads/master@{#300944} TBR=sky@chromium.org,rdevlin.cronin@chromium.org NOTREECHECKS=true NOTRY=true BUG=426448 Review URL: https://codereview.chromium.org/675893002 Cr-Commit-Position: refs/heads/master@{#300964}
-
pkotwicz authored
BUG=None TEST=None R=wittman Review URL: https://codereview.chromium.org/673003002 Cr-Commit-Position: refs/heads/master@{#300963}
-
wtc authored
R=dalecurtis@chromium.org BUG=none Review URL: https://codereview.chromium.org/672793002 Cr-Commit-Position: refs/heads/master@{#300962}
-
guohui authored
The purpose is to avoid the white flash before the web content is loaded. This CL only handles the view implementation, mac implementation will be handled in the next cl. BUG=368225 Committed: https://crrev.com/fe517ffc1a9550ff4557b5718b01b103bd134616 Cr-Commit-Position: refs/heads/master@{#299594} Review URL: https://codereview.chromium.org/637083002 Cr-Commit-Position: refs/heads/master@{#300961}
-
mek authored
Add a new GeofencingService class for the few global tasks GeofencingManager used to do. BUG=383125 Review URL: https://codereview.chromium.org/645763003 Cr-Commit-Position: refs/heads/master@{#300960}
-
magjed authored
BUG=359587 Review URL: https://codereview.chromium.org/604743005 Cr-Commit-Position: refs/heads/master@{#300959}
-
thestig authored
BUG=424746 Review URL: https://codereview.chromium.org/673663004 Cr-Commit-Position: refs/heads/master@{#300958}
-
jochen authored
v8 extensions are slowing down context creation and we're trying to get rid of them. BUG=334679 R=ernstm@chromium.org,nduca@chromium.org Review URL: https://codereview.chromium.org/647433003 Cr-Commit-Position: refs/heads/master@{#300957}
-
benwells authored
This uses the manifest as defined in https://w3c.github.io/manifest/. BUG=425837 Review URL: https://codereview.chromium.org/667053007 Cr-Commit-Position: refs/heads/master@{#300956}
-