- 26 Feb, 2018 28 commits
-
-
Zhuoyu Qian authored
Editor::DeleteWithDirection() is only called in EditorCommand.cpp. Move it to make |Editor| class simpler for improving code health. BUG=672405 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I54d47bf44f6baa73bac2c54f767331f56f500352 Reviewed-on: https://chromium-review.googlesource.com/934382 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539081}
-
Paul Irish authored
Change-Id: I12afb94b6e5b920e08b3d5bf6a0a5897e54af41c Bug: 815367 Reviewed-on: https://chromium-review.googlesource.com/935838Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#539080}
-
Giovanni Ortuño Urquidi authored
Before, when we got a navigation for an in-scope URL we would cancel the navigation, and start a new navigation in a new app window. This resulted in the new app window losing its 'window.opener' and the window that initiated the navigation losing its reference to the new window. Now, for initial navigations, we move the WebContents to a new app window and continue the navigation as usual. This results in new windows with `window.opener` keeping their openers. Bug: 804881 Change-Id: Id0a32824cf7f9d57a9e32239e2e11ce952e91487 Reviewed-on: https://chromium-review.googlesource.com/923902 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#539079}
-
Zhuoyu Qian authored
Editor::TidyUpHTMLStructure() is moved to EditingCommandsUtilities in crrev.com/c/908388 miss removing the declaration in Editor.h, remove it. Bug: 672405 Signed-off-by:
-
Zhuoyu Qian authored
Editor::PasteAsFragment() is called by PasteWithPasteboard() in EditorCommand.cpp. Move it to make |Editor| class simpler for improving code health. BUG=672405 Signed-off-by:
-
Megumi Hattori authored
According the mock (http://shortn/_WV9xAY7nir), the text "Placeholder" in the text field and the paper airplane icon in the notification reply should be transparent white. After inputting text, they should be opaque white. However, they were transparent black. After inputting text, they were opaque black. This CL fixes the color of them. BUG=815134 TEST=manual Change-Id: I68d5ef9373c1cc537e05aa6785c724a55b95b137 Reviewed-on: https://chromium-review.googlesource.com/934482Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Commit-Position: refs/heads/master@{#539076}
-
Kent Tamura authored
They caused parsing errors because strings produced by them were not escaped. This CL fixes 27 failures in WPT. Bug: 351767 Change-Id: I6ac10572cf63b0e8cdc6cd357631257a6a470be6 Reviewed-on: https://chromium-review.googlesource.com/936983Reviewed-by:
-
Christopher Lam authored
This CL adds extension actions to the Hosted App window frame and menu by: - decoupling the BrowserActionsContainer from ToolbarView via a Delegate - adding a BrowserActionsContainer to the HostedAppButtonContainer with a custom ToolbarActionsBar which only displays only the popped out action Bug: 762401 Change-Id: I24c607d3111bc48e75e26c880cbd91d59d69b7e6 Reviewed-on: https://chromium-review.googlesource.com/897383 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#539074}
-
tzik authored
This CL replaces all usage of legacy base::Bind and base::Callback in //storage/browser/quota. Change-Id: I03916561d22dd888bf5356a66bc74683af9a3799 Reviewed-on: https://chromium-review.googlesource.com/930103 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#539073}
-
Koji Ishii authored
Following bot results are included. 3923 3927 3933 3934 3942 3937 5 lines were removed and 17 lines were deflaked by consecutive results since 3881. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id240d57e9809ce44e6298dadb63e86b9edad9114 Reviewed-on: https://chromium-review.googlesource.com/934463 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#539072}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 780785, 786332 Change-Id: Ic9801a4896dd4d9a70f9b9fa4f5b26dc474db224 Reviewed-on: https://chromium-review.googlesource.com/930524Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#539071}
-
Gevorg Voskanyan authored
R=rockot@chromium.org Change-Id: I37bb122815288605e5df28ba9090eff02de8c864 Reviewed-on: https://chromium-review.googlesource.com/887023Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#539070}
-
Takuto Ikuta authored
Bug: 815363 Change-Id: I2e46eac205c902914332c1f11423350273b77ba0 Reviewed-on: https://chromium-review.googlesource.com/936724Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#539069}
-
https://chromium.googlesource.com/angle/angle.git/+log/3c43b4d1e6d0..81aa15f10682 $ git log 3c43b4d1e..81aa15f10 --date=short --no-merges --format='%ad %ae %s' 2018-02-22 jgilbert Test `EGL_OPENGL_ES3_BIT_KHR` against `rendererType`, not `conformant`. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I096d90ce39169ba5888f04f1d83b8c8d71a88c66 Reviewed-on: https://chromium-review.googlesource.com/936901Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539068}
-
Megumi Hattori authored
Previously, only web notifications have the inline settings and can be blocked depending the settings. This CL also applies this feature to Chrome extension notifications. This CL adds the inline settings on the Chrome extension notification and enables users to choose whether to block the notification or not. Due to this implementation, a gear icon for the inline settings is also added on the notification. BUG=810622 Change-Id: I6197167d2c587cd40a1e92b81a5bba5d3057820f Reviewed-on: https://chromium-review.googlesource.com/923877 Commit-Queue: Megumi Hattori <megumihattori@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#539067}
-
Timothy Loh authored
Seems to have been flaking for the past several days. TBR=kojii Bug: 816026 Change-Id: I335b2c4d49a172a7ae092e8163adf2f6c9cd5f2d Reviewed-on: https://chromium-review.googlesource.com/936984Reviewed-by:
-
David Tseng authored
This change is largely motivated by TalkBack utils. The problem It seems as though Android's accessibility tree is not in-order (rendered from left to right, top to bottom) when walking the tree in pre order. As a result, app drawers appear at the end of the navigation linearization. Bug: 813721 Test: navigate linearly through Play Store. Verify navigation button/app text/search text field get seen first, then the app contents Change-Id: I489b18708b8fb3a03a9d6e0cf0d42c830c9ac21f Reviewed-on: https://chromium-review.googlesource.com/928047Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#539065}
-
Xiaocheng Hu authored
LayoutInline::LinesBoundingBox() adds the child fragment's offset twice when calculate the child's rect. This patch fixes it. We also have some NG baselines with incorrect rects of inline elements in the layout tree dump due to the bug. This patch correct the baselines. Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Icddd3e20c99ef876c0deed4ec95aac10765f52fe Reviewed-on: https://chromium-review.googlesource.com/935830Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/b8b6253df6e6..a58cd1ba9fe8 $ git log b8b6253df..a58cd1ba9 --date=short --no-merges --format='%ad %ae %s' 2018-02-26 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 3c43b4d1e..81aa15f10 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I66a74bdafd4256a4d377f60e1c8c98958a6e74b0 Reviewed-on: https://chromium-review.googlesource.com/936788 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539063}
-
Zhuoyu Qian authored
StylePropertyMapOnly.size should be unsigned: https://github.com/w3c/css-houdini-drafts/commit/2da28139b2f817e241fc55a35f8c4b2825835308 Bug: 815040 Signed-off-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#539062}
-
Yoshiki Iguchi authored
This reverts commit 81609a0e. Reason for revert: Break some functionality (see comments in the original CL) Original change's description: > Do not set SYSTEM_PRIORITY to system notifications > > System notifications generated using CreateSystemNotification has > SYSTEM_PRIORITY. So we don't need to set SYSTEM_PRIORITY manually. > > This CL is a clean-up and doesn't change any behavior. > > Test: None > Bug: None > Change-Id: I8be104f87b756b5226f9034c9a31c67015978621 > Reviewed-on: https://chromium-review.googlesource.com/906172 > Reviewed-by: Mitsuru Oshima (In Tokyo) <oshima@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536651} TBR=yoshiki@chromium.org,oshima@chromium.org,estade@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I562ef9b2f6e2c51bd713fb9ee1154b9cc43c1cbd Reviewed-on: https://chromium-review.googlesource.com/936981Reviewed-by:
-
Xianzhu Wang authored
Output one Save/ClipRect sequence for each series of rectangular clips instead of output the sequence for each clip. This along with other optimizations will fix SPv175 regression of raster time, picture memory, etc. Bug: 814227 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8596213ce3356b9d9c9b003c64a4bed5773aea50 Reviewed-on: https://chromium-review.googlesource.com/936683 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539060}
-
Kent Tamura authored
This CL might help polyfills though we don't support MathML 2.0. This fixes 2,117 test failures in WPT. Bug: 816320 Change-Id: I93a563ae013d0c97717500130f26605e5d2ba2d3 Reviewed-on: https://chromium-review.googlesource.com/936861Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#539059}
-
Chris Harrelson authored
Otherwise a clip-path or mask will incorrectly apply to the squashed layers. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1b22732f2d4cb47bcd0d0869c5c901bd9141a639 Reviewed-on: https://chromium-review.googlesource.com/935822 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539058}
-
Xianzhu Wang authored
Previously we output three clip operations in SPv175 for <div style="overflow: hidden; border-radius: 5px; width: 100px; height: 100px">...</div> which is one more than SPv1. By omitting OverflowClip, now we output the same clip operations in SPv175 and Spv1. Bug: 814227 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8839d3af5180b017e20681c54ad94316632c08ab Reviewed-on: https://chromium-review.googlesource.com/934923Reviewed-by:
-
Jia authored
In this cl 1. Timestamps for mouse, key, last activity, last user activity will not be reset when an idle event is generated. Only timestamps used to measure recent time active will be reset. 2. When SuspendDone is received, if sleep_duration is longer than idle delay, we regard it as an idle event, hence we reset recent-time-active-related timestamps. Change-Id: Ife2ad702ce64edd28f842014a5745124a9c30a31 Bug: 784232 Reviewed-on: https://chromium-review.googlesource.com/936504 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#539056}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d34b9924..6198dc41 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2031b25139d614a0364206b45f9500880d2fe2eb Reviewed-on: https://chromium-review.googlesource.com/936666Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#539055}
-
Dominick Ng authored
This is intended to help developers who see the console messages during testing of sites. BUG=808896 Change-Id: I4353bb6417c8b3b97d307c1f9afd4ad23b447549 Reviewed-on: https://chromium-review.googlesource.com/930608Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#539054}
-
- 25 Feb, 2018 12 commits
-
-
CrystalFaith authored
File paths not working to download. Updated location of image and linked to sample. Bug: 806073 Change-Id: Id1e9b1794ad54dfe748ed8cc5da862fe6271a030 Reviewed-on: https://chromium-review.googlesource.com/935499Reviewed-by:
Meggin Kearney <mkearney@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#539053}
-
Gabriel Charette authored
After just doing a full pass of this code for issue 810464, I think leaving these CHECKs behind will help a future reader as well as enforce required calling semantics. R=fdoray@chromium.org Bug: 810464 Change-Id: I48bd2c3c0308be3b856ef518ed41382497ca5cf8 Reviewed-on: https://chromium-review.googlesource.com/934081 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#539052}
-
Dave Tapuska authored
This change restructures some chrome IPC code into a subclasses. On the renderer side the Chrome IPC is moved into the SynchronousCompositorProxyChromeIPC subclass and the base class is generalized to use callbacks that Mojo can use directly. On the browser side an impl of the mojo SynchronousCompositor interface is made to send Chrome IPC to the renderer. There are two Hosts for the Synchronous Compositor. The control host which is hosted by the SynchronousCompositorBrowserFilter on the IO thread and the host which is hosted on the browser ui thread. All mojo channels are associated channels with the widget_input_handler so input is handled in order. BUG=722928 Change-Id: I517ab8b391433fa6b5e4b4fe2f9440dcfed29c05 Reviewed-on: https://chromium-review.googlesource.com/830928 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539051}
-
Rohit Rao authored
These tests use OCMClassMock() to mock out an NSDate class method. The OCMock documentation states that behavior is undefined if multiple objects try to mock the same class simultaneously. The documentation also states that the mock object must be deallocated in order to restore the original method implementations. I suspect that the autorelease pool is never being drained and therefore the mock object stays alive past the end of these tests. This is calling subsequent tests to fail, because NSDate no longer returns the correct date. Inheriting from PlatformTest wraps each test in an autorelease pool, which appears to be enough to get the tests passing again. BUG=815189 TEST=TextToSpeechListenerTest.ValidAudioDataTest passes on the bots. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0d8383b0d1f476ff2ab9840fff384f7b4aeb2dc3 Reviewed-on: https://chromium-review.googlesource.com/936222Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#539050}
-
https://skia.googlesource.com/skia.git/+log/3fd84fa4bff1..b8b6253df6e6 $ git log 3fd84fa4b..b8b6253df --date=short --no-merges --format='%ad %ae %s' 2018-02-23 liyuqian Add threaded backend sink to DM. Fix a scheduler bug. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I6b71ce567d732d34b7d9edd74899c94092740b96 Reviewed-on: https://chromium-review.googlesource.com/936458Reviewed-by:
-
Mohamad Ahmadi authored
Fixes the bug where changes to existing autofill profiles and credit cards or adding new ones get reflected in PersonalDataManager when user is in incognito mode. Also refactors the details of adding/updating autofill profiles and credit cards into the paymentrequest.mm instead of the coordinators. Updates the unit tests accordingly. Bug: 814130 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2cc72032648d162304211fe3de6612bc23848350 Reviewed-on: https://chromium-review.googlesource.com/931625 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#539048}
-
https://pdfium.googlesource.com/pdfium.git/+log/26820b474343..1dbea185e709 $ git log 26820b474..1dbea185e --date=short --no-merges --format='%ad %ae %s' 2018-02-25 rharrison Add expectations for static XFA tests Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia74f756c94d7e7f3de4fe5afbd390440326963dd Reviewed-on: https://chromium-review.googlesource.com/936457 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539047}
-
tzik authored
The previous implementation of it checks if T::AddRef is available, but it seems to fail on gcc on scoped_refptr, as it has private static AddRef and Release. This adjust the check to refer methods of T explicitly to avoid touching the static member functions. Change-Id: I7fde97a533df3b4a4b7ddbb0a8f7201c3744bd46 Reviewed-on: https://chromium-review.googlesource.com/933670Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/58a48f4f..d34b9924 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I508595b69ce0b071daeda92556922b9ec47a01f0 Reviewed-on: https://chromium-review.googlesource.com/936587Reviewed-by:
-
Christos Froussios authored
pulling out setting the password list and allowing to use a base::MockCallback<WriteCallback> in SetWriteForTesting directly to reduce noise in the PasswordManagerExporter test code. Bug: 789561 Change-Id: Ib703b8a720e38f75d57519b9f96f926e93e9a561 Reviewed-on: https://chromium-review.googlesource.com/924422 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539044}
-
https://skia.googlesource.com/skia.git/+log/88fdee9bde97..3fd84fa4bff1 $ git log 88fdee9bd..3fd84fa4b --date=short --no-merges --format='%ad %ae %s' 2018-02-23 liyuqian Set empty drawFn when init-once returns early 2018-02-23 liyuqian Copy the bitmap in SkThreadedBMPDevice::drawDevice Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I1776a8c76ed2ecf042b1dcafdc3c34b390600f58 Reviewed-on: https://chromium-review.googlesource.com/936456 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Daniel Erat authored
Bug: none Change-Id: Ib3f5225cbe9283c96646ca47d6640bfc07c28713 Reviewed-on: https://chromium-review.googlesource.com/936686 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#539042}
-
