GitLab

The goal of this CL is to eliminate the dependence of
GoogleURLTracker(MapEntry) on NavigationController. To accomplish this goal,
GoogleURLTrackerNavigationHelper is turned into a conceptually per-tab
interface. GoogleURLTracker::OnNavigationPending() now takes in the
GoogleURLTrackerNavigationHelper with which the navigation is associated rather
than the associated NavigationController; GoogleURLTracker performs per-tab
actions by calling the navigation helper associated with the tab.

A followup CL will turn GoogleURLTrackerNavigationHelper(Impl) into the
GoogleURLTrackerDriver interface and ContentURLTrackerDriver implementation.

BUG=373230

Review URL: https://codereview.chromium.org/283413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50298
TEST=as in bug.

Review URL: https://codereview.chromium.org/290733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272093 0039d316-1c4b-4281-b951-d872f2087c98

See UX changes in this video:
https://drive.google.com/a/google.com/file/d/0BzdR97pL_sHWaW5aM0EzS2JYbU0/edit?usp=sharing

Video of clicking icon and doing re-auth:
https://docs.google.com/a/google.com/file/d/0BzdR97pL_sHWQ0NMYWdJekFRVHc/edit

BUG=311235,374771

Review URL: https://codereview.chromium.org/240453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272092 0039d316-1c4b-4281-b951-d872f2087c98

We were checking if 'prodaccess' is in the path when trying to decide
if 'gsutil' supported prodaccess; when we called this as part of
the find_dependencies script, this meant that we wouldn't include gsutil
because prodaccess wasn't on the bot.

We really only want the path check to happen when we're handling an
authorization failure, in order to determine what message to show the
user.

This CL fixes this issue.

R=nduca@chromium.org, dtu@chromium.org
BUG=369350

Review URL: https://codereview.chromium.org/291293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272091 0039d316-1c4b-4281-b951-d872f2087c98

Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile.

Relanding patch: ShutdownStartupCycle failed in build [49353], this patch was speculatively reverted in r269383 [49355], but ShutdownStartupCycle failed again in [49362] after the revert had landed.

[49353] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49353
[49355] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49355
[49362] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49362

BUG=368684, 374683
TEST=Manual testing as described on http://crbug.com/368684#c1 and http://crbug.com/374683#c7

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269343

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270890

Review URL: https://codereview.chromium.org/266343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272090 0039d316-1c4b-4281-b951-d872f2087c98

It was reverted in r270600 because it broke compilation:
lib/libgfx.so:error: undefined reference to 'XCreateRegion'
lib/libgfx.so:error: undefined reference to 'XUnionRectWithRegion'
lib/libgfx.so:error: undefined reference to 'XPolygonRegion'

Original description:
This requires to major changes:

1- It requires the introduction of GfxTestSuite to allow us to
initialize the ResourceBundle which is required for some of these tests
to pass.
2- It requires to split gfx_unittests target out of gfx.gyp, into
gfx_tests.gyp. This is necessary because otherwise a circular dependency
between ui_base.gyp and gfx.gyp would arise.

The circular dependency is the form of:
gfx.gyp -> ui_base.gyp -> gfx.gyp

And is created because gfx_unittests now requires ResourceBundle to link
which is in ui_base target.

BUG=331829
TEST=ui_unittests,gfx_unittests
R=sadrul@chromium.org, danakj@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/291753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272088 0039d316-1c4b-4281-b951-d872f2087c98

preferencesPrivate was only available on the dev channel. This CL
moves the whitelist entries to a stable channel entry.

BUG=312900,319444,371562,375938

Review URL: https://codereview.chromium.org/293053009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272087 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/296133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272086 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/294033006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/298623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272084 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374207
TEST=none
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/287193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272083 0039d316-1c4b-4281-b951-d872f2087c98

+ fixed some lint complaints in renamed files.

BUG=375740
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/292663009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272082 0039d316-1c4b-4281-b951-d872f2087c98

By adding upload.py to the archive, we can submit patches to telemetry
without requiring a full depot_tools checkout. This helps ensure that
the standalone zip really is sufficient for telemetry development.

R=nduca@chromium.org, dtu@chromium.org
BUG=373104

Review URL: https://codereview.chromium.org/281383005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272081 0039d316-1c4b-4281-b951-d872f2087c98

In order to remove unused png files inside the chromium source code, I've first wrote a simple python script to narrow my research.

With http://pastebin.com/ZEz4TgzD, I'm doing three things:
- Restricting my search to folders I'm familiar with.
- Listing all strings that end with ".png"
- Grabbing only PNG files that haven't been created in 2014

Then, because I know there might some cases that are not covered, I've looked into *all of them* to make sure they were not used for real anymore.

Review URL: https://codereview.chromium.org/296443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272080 0039d316-1c4b-4281-b951-d872f2087c98

The dashboard no longer needs this hack and in fact it is breaking our ability
to bisect in some cases.

BUG=371159

Review URL: https://codereview.chromium.org/291153008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272079 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of https://codereview.chromium.org/270883003/, which was reverted because it missed to update one of the callers to CreateRenderViewForRenderManager. Patchset 1 is the equivalent to the previous commit.

BUG=357747

Review URL: https://codereview.chromium.org/299703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272078 0039d316-1c4b-4281-b951-d872f2087c98

Some tiles that are required for activation might never be initialized
because we move them into EVENTUALLY_BIN before making adjustments
based on the memory policy. This is because EVENTUALLY_BIN will map
to NEVER_BIN when ALLOW_PREPAINT_ONLY or ALLOW_ABSOLUTE_MINIMUM is the
current memory policy.

This is fixed by moving low-res tiles into EVENTUALLY_BIN after
making adjustments based on current memory policy.

BUG=375801
TEST=cc_unittests --gtest_filter=TileManagerTests/TileManagerTest.EnoughMemoryPendingLowResAllowAbsoluteMinimum/*

Review URL: https://codereview.chromium.org/291093008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272077 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/295933007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272076 0039d316-1c4b-4281-b951-d872f2087c98

Now that crbug.com/374143 is fixed we should be able to run these tests again.

BUG=355952
TBR=tonyg@chromium.org

Review URL: https://codereview.chromium.org/294973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272075 0039d316-1c4b-4281-b951-d872f2087c98

Connect() has ended up acquiring all of the ConnectionToHost's
configuration settings as parameters, making calling code harder to read
especially as more new parameters are added.

Review URL: https://codereview.chromium.org/279273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272074 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/293433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272073 0039d316-1c4b-4281-b951-d872f2087c98

Remove Notifications Associated with an Extension When the Extension is Unchecked from the Message Center Settings

Added an observer relationship between MessageCenterImpl and
MessageCenterSettingsController so that the notification removal would occur
when a user unchecked an extension from the settings view.

BUG=304364

Review URL: https://codereview.chromium.org/288033014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272072 0039d316-1c4b-4281-b951-d872f2087c98

diretory.

BUG=375804

Review URL: https://codereview.chromium.org/296113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272071 0039d316-1c4b-4281-b951-d872f2087c98

Currently DeferredInitialize assumes OutputSurface never has
delegated_rendering capability. With this change, remove this
assumption by always first creating SoftwareRenderer for
OutputSurface with deferred_gl_initialization. Then create
either DelegatingRenderer or GLRenderer depending on
delegated_rendering capability in DeferredInitialize.

With support for DelegatingRenderer and DeferredInititalize,
have to ensure that all GL resources are returned to child
before ReleasGL is called, because ContextProvider is going
away after ReleaseGL. Add a DCHECK for this in
ResourceProvider::CleanUpGLIfNeeded.

New path covered by LayerTreeHostTestDeferredInitialize.

BUG=344087

Review URL: https://codereview.chromium.org/286953008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272070 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346399
TEST=none

Review URL: https://codereview.chromium.org/296053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367239

Review URL: https://codereview.chromium.org/292723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272068 0039d316-1c4b-4281-b951-d872f2087c98

UntypedHandle, as it is, makes chaining messages impossible. A received message is expected to contain UntypedHandle which cannot be generated from a Handle.
This CL allows any handle to be transformed into an UntypedHandle.

Review URL: https://codereview.chromium.org/291103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272067 0039d316-1c4b-4281-b951-d872f2087c98

This allows trybots to verify that mcs_probe compiles, without actually attempting to run it.

BUG=364257

Review URL: https://codereview.chromium.org/294963005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272066 0039d316-1c4b-4281-b951-d872f2087c98

Move FaviconImageCallback, FaviconResultsCallback and FaviconRawCallback
to favicon_base, those types are shared between favicon and history
components (methods are declared in FaviconService, but it delegates the
work to HistoryService) and only uses types from base:: and
favicon_base:: namespaces.

Also BookmarkClient::FaviconImageCallback is a copy of
FaviconService::FaviconImageCallback, replace it with favicon_base::
version.

BUG=372321
TBR=thakis for //chrome outside of //chrome/browser/history,
//chrome/browser/favicon

Review URL: https://codereview.chromium.org/291643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370240
TBR=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/293083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272064 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272058 0039d316-1c4b-4281-b951-d872f2087c98

This is a recommit of
[ https://src.chromium.org/viewvc/chrome?view=rev&revision=271798 ], fixing IWYU.

BUG=374296
TEST=compiles
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/294123006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272057 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372368
TEST=browser_test

Review URL: https://codereview.chromium.org/275913004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272056 0039d316-1c4b-4281-b951-d872f2087c98

New avatar menu: Don't allow supervised users to edit their profile name. This brings the new menu in line with the user list in about:settings.

Mac implementation to follow.

BUG=360559

Review URL: https://codereview.chromium.org/294593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272055 0039d316-1c4b-4281-b951-d872f2087c98

Currently when users forget to include their TypeConverter specializations, they get errors about various methods not defined in TypeConverter<x, y>. By removing the definition of the general template, users will get errors about incomplete type TypeConverter<x, y> used.

TEST=None
BUG=None

Review URL: https://codereview.chromium.org/294473010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272054 0039d316-1c4b-4281-b951-d872f2087c98

This is initial patch for proxy unittests.
New testing stubs are added to LayerTreeTest.

R=brianderson@chromium.org, danakj@chomium.org
BUG=356832
TEST=*ProxyTest*

Review URL: https://codereview.chromium.org/242783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272051 0039d316-1c4b-4281-b951-d872f2087c98

This is useful for testing. VP9 is already enabled at the client.

BUG=260879

Review URL: https://codereview.chromium.org/286213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272050 0039d316-1c4b-4281-b951-d872f2087c98

This change gets potential Answers to the Java side of things, enabling
rendering in the Omnibox

BUG=370192

Review URL: https://codereview.chromium.org/292073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272049 0039d316-1c4b-4281-b951-d872f2087c98

This flaky test can be removed because it 
doesn't force any draw operation and it returns 
regardless of scheduler state.


R=danakj@chromium.org
BUG=373371
TEST=covered by existing test

Review URL: https://codereview.chromium.org/290853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272048 0039d316-1c4b-4281-b951-d872f2087c98

The command line switch enable-usermedia-screen-capturing will still work.

BUG=347641

Review URL: https://codereview.chromium.org/270353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272046 0039d316-1c4b-4281-b951-d872f2087c98