- 03 Oct, 2018 40 commits
-
-
Sam McNally authored
This is a reland of 0780e76b. The tests in folder_shortcuts.js are flaky with DriveFS, so continue to not run them as before. Original change's description: > Run more FilesApp tests with DriveFS enabled. > > Run with DriveFS enabled: > - Drive-related context_menu.js tests. > - Drive-related metadata.js tests. > - folder_shortcuts.js tests. > - fileDisplayDrive in tablet mode with DriveFS enabled. > > In order to make those tests pass: > - Pass capabilities metadata to FakeDriveFs in SetMetadata() and return > it in GetMetadata(). > - Populate croppedThumbnailUrl so metadata cache doesn't retry fetching > metadata, trying to get a value for it. > - Remove two unused and incomplete tests in context_menu.js. > - Only perform early-init for the downloads volume for the "user" > profile. > > Bug: 891197 > Change-Id: I8ddcbd75b74258b6988ad5c70c4e70c707d18f70 > Reviewed-on: https://chromium-review.googlesource.com/c/1255086 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596048} Bug: 891197 Tbr: noel@chromium.org Change-Id: Ib85e05c0d940f5a748ef5207b3ff4c3d4e0e7df6 Reviewed-on: https://chromium-review.googlesource.com/c/1257474Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596181}
-
Harald Alvestrand authored
Moved the scheduling of subsequent tones from the webrtc layer to the blink layer. Revised the tests to remove the chance to sneak in extra tonechange events when overriding a remaining tone buffer. Also change "approximate timing" to "at least this long". Bug: chromium:816475 Change-Id: Id91011600b61f43152c8fb896d72433ccb871c61 Reviewed-on: https://chromium-review.googlesource.com/c/1236337 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#596180}
-
Daniel Bratell authored
According to the coding style guide a sub-namespace should not have the same name as a common top level namespace. That still happens with many "features" namespaces which causes problems whenever the compiler knows about the root ::features namespace. This patch removes the namespace completely and lets the constants live in the safe_browsing namespace directly, making the code a little shorter. Another option would have been to rename the namespace from ::safe_browsing::features to ::safe_browsing_features like was recently done to some other features namespaces, for instance app_list_features. Change-Id: I3655cca7fb56b45a03118a80a957599bd5f316b3 Reviewed-on: https://chromium-review.googlesource.com/c/1251604 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#596179}
-
Fergal Daly authored
Add addvice for base::Bind* Currently we are told not to use something, but it's not always clear what we should use instead. This allows adding advice for the correct alternative to the forbidden identifies. Change-Id: Iaadab609452d2413fdd39a31c80e3924467c42d3 Reviewed-on: https://chromium-review.googlesource.com/c/1253526Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#596178}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/531ee1a13814..1f6d20f5c09f Created with: gclient setdep -r src-internal@1f6d20f5c09f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1b8bf33cb48418d1f328e7fe5857f6f18134c3bd Reviewed-on: https://chromium-review.googlesource.com/c/1258865Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596177}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2cbceb0be548..82dac3df06b9 git log 2cbceb0be548..82dac3df06b9 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 lalitm@google.com Merge "trace_processor: optimize filtering for sched slice and generify" 2018-10-03 fmayer@google.com Re-enable {a|l}san 2018-10-03 primiano@google.com Merge "UI: set ALLOW_MEMORY_GROWTH=1" 2018-10-03 hjd@google.com Merge "perfetto-ui: Fix font bug with ChromeSlices" 2018-10-03 hjd@google.com Merge "perfetto-ui: Add dynamic CPU track" Created with: gclient setdep -r src/third_party/perfetto@82dac3df06b9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I309c2caf3d251f920fa48bc1506c57f0b84d7718 Reviewed-on: https://chromium-review.googlesource.com/c/1258421Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596176}
-
Leszek Swirski authored
Measure the impact of the current trial by seeing what regressed, and disable while waiting for Bug:874080 to be resolved, since there are currently some loading regressions. Bug: 715309 Bug: 885053 Bug: 886668 Change-Id: I4497e11373ffa92d3e5f5844fa9fbe73fef6bf4b Reviewed-on: https://chromium-review.googlesource.com/c/1255946Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#596175}
-
Maksim Sisov authored
Relying on OzoneDrmMojo feature is not a very good idea, because it is mostly intended to be used with the Ozone/Drm platform, which can use both the legacy IPC and mojo for communication. It happened once that the Ozone/Wayland platform regressed due to misunderstandings why that feature flag was used with ifdefs. In Ozone/Wayland, the mojo IPC is a requirement to be able to run the browser in a multi-process mode(there is a separate GPU process). Thus, use PlatformProperties to know if the platform requires mojo communication before the gpu is started. At the moment, only Ozone/Wayland platform requires mojo communication in addition to the Ozone/Drm platform, which can use both legacy IPC and mojo and uses OzoneDrmMojo feature instead. Bug: 578890 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1f0fccb19ec2fc69a50320b55014979556739c2c Reviewed-on: https://chromium-review.googlesource.com/c/1254209 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#596174}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/086cac5c439c..23eba224241c git log 086cac5c439c..23eba224241c --date=short --no-merges --format='%ad %ae %s' 2018-10-03 asapersson@webrtc.org Add support for RtpEncodingParameters num_temporal_layers. Created with: gclient setdep -r src/third_party/webrtc@23eba224241c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I05e54c3bb49127605c383e3f78b515d15f64c04f Reviewed-on: https://chromium-review.googlesource.com/c/1258864Reviewed-by:
-
Findit authored
This reverts commit 0780e76b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 596048 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDc4MGU3NmIwMzg4MmQ5MmVjOGI5YjczNDIyNzgzMzA5YzZjZWM1Nww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29332 Sample Failed Step: viz_browser_tests Sample Flaky Test: FolderShortcuts/FilesAppBrowserTest.Test/traverseFolderShortcuts_DriveFs Original change's description: > Run more FilesApp tests with DriveFS enabled. > > Run with DriveFS enabled: > - Drive-related context_menu.js tests. > - Drive-related metadata.js tests. > - folder_shortcuts.js tests. > - fileDisplayDrive in tablet mode with DriveFS enabled. > > In order to make those tests pass: > - Pass capabilities metadata to FakeDriveFs in SetMetadata() and return > it in GetMetadata(). > - Populate croppedThumbnailUrl so metadata cache doesn't retry fetching > metadata, trying to get a value for it. > - Remove two unused and incomplete tests in context_menu.js. > - Only perform early-init for the downloads volume for the "user" > profile. > > Bug: 891197 > Change-Id: I8ddcbd75b74258b6988ad5c70c4e70c707d18f70 > Reviewed-on: https://chromium-review.googlesource.com/c/1255086 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596048} Change-Id: I918211f80347a93388965b5278c2e3b55d4bfca5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891197, 891641 Reviewed-on: https://chromium-review.googlesource.com/c/1258616 Cr-Commit-Position: refs/heads/master@{#596172}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b969b6f368a..531ee1a13814 Created with: gclient setdep -r src-internal@531ee1a13814 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I255c96cdb45da204876fc32de0dc06603b5ef01a Reviewed-on: https://chromium-review.googlesource.com/c/1258862Reviewed-by:
-
Guido Urdaneta authored
The default input device reported by Pulse Audio is not really a default device, but a fallback device. Actual expected default behavior in Pulse Audio is achieved by not specifying a device to use and letting Pulse Audio select it. In this case Pulse first tries to use the device specified by the PULSE_SOURCE environment variable and, if that fails, tries to use the fallback device. There is no API to fetch what device Pulse will actually use by default. A consequence of this is that the groupId reported by the default input device will not correspond to the group ID of the actual device that will be used. This is not ideal, but it is better than the alternative. The groupId constrainable property still works fine with nondefault devices. Bug: 890010 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3473df314f0a36f56094c4986bf8fc9b38265fad Reviewed-on: https://chromium-review.googlesource.com/c/1256832Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#596170}
-
Olivier Robin authored
Sets are never cleared in VariationsHttpHeaderProvider. This means that if VariationsHttpHeaderProvider id initialized in a test with a GoogleVariationID, the trial will be added to variation_ids_set_ and never be removed even by ResetForTesting. This make all tests relying on not having X-Client-Header after this fail. E.g. on iOS, TranslateScriptTest.CheckScriptParameters fails if it runs after PaymentClientTest. Bug: None Change-Id: I3287f3df846ab1b0f56e42980146b07a3707f7d4 Reviewed-on: https://chromium-review.googlesource.com/c/1256803 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#596169}
-
Daniel Bratell authored
It was linked into some jumbo build experiments where it triggered link errors. If you include an object file, for instance options_menu_model.o, in an archive, for instance libtranslate.a, and nothing references that object file, then the linker won't care if options_menu_model.o is referencing all kinds of undefined symbols. It's a feature or quirk depending on who you asks. With jumbo compilation this options_menu_model.o would be combined with 7+ other .o files into translate_jumbo_1.o and since the .o file is no longer completely unused, the linker will get upset about the dangling references. So something that used to be "just" dead code compilation with dangling references becomes a linking error when compiling with jumbo. Change-Id: Id15f7e15804efe2fdf959c4db7fdade061477102 Reviewed-on: https://chromium-review.googlesource.com/c/1256685 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#596168}
-
Yutaka Hirano authored
With OOR-CORS, CORS logic is moved out of blink. This is problematic for the memory cache in blink, because the relationship between caching and CORS is different from what is specced. Ignore headers added by blink-initiated revalidation. Bug: 870173 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I64346ee908cd4b3ab5b6cd8442dfaa8f8d7a2368 Reviewed-on: https://chromium-review.googlesource.com/c/1244998 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
The client is getting OnStartLoadingResponseBody before OnResponseReceived. See if ThrottlingURLLoader is buggy. Bug: 882661 Change-Id: I3de4e907d502c8140c1a0736468868775c43d691 Reviewed-on: https://chromium-review.googlesource.com/c/1256382Reviewed-by:
-
Hajime Hoshi authored
The default task runner should be avoided if possible. Bug: 870606 Change-Id: Id4a3a5cc11d7a101b9f80fc339142f43ad41e9c3 Reviewed-on: https://chromium-review.googlesource.com/c/1256473Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596165}
-
Yuta Kitamura authored
Now, (almost) nobody uses blink::WebThread in non-Blink code. This CL removes unused #include of web_thread.h in those files. Note that two files related to testing were still using WebThread indirectly. They call Platform()->MainThread()->GetTaskRunner() to obtain a task runner. These calls were replaced with scheduler:: GetSingleThreadTaskRunnerForTesting(). Bug: 826203 Change-Id: I954eb67e99f76bd992f0bcdd73498cfdccba0726 Reviewed-on: https://chromium-review.googlesource.com/c/1255747 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#596164}
-
Takashi Toyoshima authored
Now that the dynamic instantiation mode is the only mode that MidiService and MidiManager support, we can ensure that any MidiManager instance will be constructed and destructed on the same IO thread. This will allow us to remove complicated shutdown system that relies on Shutdown() and Finalize(). Now destructor should just work. Bug: 672793 Change-Id: I50cc843dd997f9de68492c13d7d845810020dcb9 Reviewed-on: https://chromium-review.googlesource.com/c/1249421 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#596163}
-
Stephane Zermatten authored
This change is a quick and dirty way of making sure that scripts that expect a specific element on the page will get triggered, by checking for 20 seconds after a page load or after a script has finished. This is just enough to unblock further manual tests while we work on a proper solution. Bug: 806868 Change-Id: I218ba905a2eef586463c6335435e97cdca1657d0 Reviewed-on: https://chromium-review.googlesource.com/c/1256691Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#596162}
-
Javier Ernesto Flores Robles authored
Adds options to invert the direction of the animation and the position of the table view when presenting. Supporting presenting table views in the leading edge is required for the manual fallback UI: go/leftpresentation Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I1e8466bc90fe29fd77bb71fed1639bcbac14eb02 Reviewed-on: https://chromium-review.googlesource.com/c/1255242 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#596161}
-
Tetsui Ohkubo authored
This CL adds rounded corners and separator lines to notifications in UnifiedMessageListView. UnifiedMessageListView will replace MessageListView. It's behind a flag: --enable-features=NewMessageListView Design doc: go/chrome-popup-refactoring TEST=UnifiedMessageListViewTest BUG=769219 Change-Id: I9616b8d3e6505046448742e3f8936188e23e0129 Reviewed-on: https://chromium-review.googlesource.com/c/1258783 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#596160}
-
Nico Weber authored
ToTAndroidOfficial is green after https://chromium-review.googlesource.com/1257202 so chances are this is fixed in the recent clang roll. Bug: 887272,889062 Change-Id: Iea7a64507cea2cc0410f851af68a5f9fc008b5ae Reviewed-on: https://chromium-review.googlesource.com/c/1258287 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#596159}
-
Morten Stenshorne authored
We got borders and padding right, because we honor min-inline-size, but the space taken up by any scrollbar wasn't included there, because scrollbars are allowed to intrude into padding and border area to prevent the content box size from becoming negative (but this intrusion should be prevented for min/max size calculation, also when size containment is applied). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iebeb3b5e358ba620d24b072543400dfe94fea5a0 Reviewed-on: https://chromium-review.googlesource.com/c/1256924Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#596158}
-
Egor Pasko authored
The tool was useful for benchmarking page loads optimized with prefetch predictor database. The code depends on the customtabs_benchmark. The latter got updated a few times without updating the caller, leading to this code being slightly rotten. We do not plan to benchmark resource prefetch predictor in the near future. Removing to reduce maintenance costs. Bug: 699080 Change-Id: Ic6d28015b0cabdf7e4b243633fd6ea967df77a1e Reviewed-on: https://chromium-review.googlesource.com/c/1256792Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#596157}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8775060263d6..cfc9679f85fe git log 8775060263d6..cfc9679f85fe --date=short --no-merges --format='%ad %ae %s' 2018-10-03 hidehiko@chromium.org Remove stale cheets_release template. Created with: gclient setdep -r src/third_party/chromite@cfc9679f85fe The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8e3e8fdd2f7e5fcc3c75e34cd124950ed4c267b3 Reviewed-on: https://chromium-review.googlesource.com/c/1258420Reviewed-by:
-
Maksim Sisov authored
This CL adds a new functionality to the existing WaylandOutputManager and WaylandScreen classes. Now, it is possible to remove and change primary displays on hot plugs and removes. To test that functionality, a new test has also been added. The logic that assigns output ids has also been changed. Now, we are using numeric names that a Wayland compositor announces during Global and GlobalRemove calls. That is, each global object is assigned an unique numeric name, which can be freely used as an id. Bug: 890276, 875161 Change-Id: I775bdd40a946c9f0c5dde89eba6e36c4615e1f21 Reviewed-on: https://chromium-review.googlesource.com/c/1254146 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Olivier Robin authored
Without frame messaging, messages can be receive after the frame is deleted. The current code DCHECKs because the frameID is empty in that case. Change-Id: I008803da50f166bfefe29159addaac2a69f15ec1 Reviewed-on: https://chromium-review.googlesource.com/c/1256804 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596154}
-
Tetsui Ohkubo authored
This CL implements auto collapsing / expanding of notifications in UnifiedMessageListView. UnifiedMessageListView will replace MessageListView. It's behind a flag: --enable-features=NewMessageListView Design doc: go/chrome-popup-refactoring TEST=UnifiedMessageListViewTest.CollapseOlderNotifications BUG=769219 Change-Id: Iff52b748c8a4faf9560586d049621b92baec68dc Reviewed-on: https://chromium-review.googlesource.com/c/1258668Reviewed-by:
-
Mathias Carlen authored
Before this patch, the expectation was that a precondition domain match meant a host match. The server has different rules and therefore nothing is matching. There were also precondition DCHECK failures due to empty element exists selectors. This patch changes the domain match behavior to a scheme and host match, ignoring port and trailing slash. It also filters empty elements_exist selectors. After this patch, the expectations around domain matches are again in line with the established rules on the server. Element exists matches are now guaranteed to not be empty. Note: There is still the question of an empty selector within an elements_exist. R=rouslan@chromium.org, szermatt@chromium.org Bug: 806868 Change-Id: I28b09a0b260ecefd60e21852cfdcd12150893ead Reviewed-on: https://chromium-review.googlesource.com/c/1249091 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#596152}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfd8fd1ee3a9..4b969b6f368a Created with: gclient setdep -r src-internal@4b969b6f368a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iaa56deb7d43b48cce43153ab61d00070b2d4cfc7 Reviewed-on: https://chromium-review.googlesource.com/c/1258418Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6a1afc01be80..2cbceb0be548 git log 6a1afc01be80..2cbceb0be548 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 hjd@google.com Merge "trace_processor_shell: Persist cmdline history" Created with: gclient setdep -r src/third_party/perfetto@2cbceb0be548 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I11f59aaaa7f322df7e807f01120d134dd2bb4877 Reviewed-on: https://chromium-review.googlesource.com/c/1258419Reviewed-by:
-
François Beaufort authored
https://github.com/WICG/shape-detection-api/pull/52 Change-Id: I9b61e86278c3344d74423443405c7f7dbda8c9ab Reviewed-on: https://chromium-review.googlesource.com/c/1257924Reviewed-by:
-
Alexander Dunaev authored
The session restore logic looked at the command line of the main browser process, which resulted in session loss if the browser is first launched as incognito and then another window is opened with some normal profile. This change introduces passing the command line of the new process to the session restore point so it decides whether to restore the session according to settings and command line both relevant to the profile that is to be loaded. R=sky@chromium.org Change-Id: I69de884b4d270da4d4cc358fe225255b3d4cb3b5 Reviewed-on: https://chromium-review.googlesource.com/c/1245368 Commit-Queue: Alexander Dunaev <voodoo@yandex-team.ru> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#596148}
-
Maksim Sisov authored
There is a new class called WmMoveResizeHandler in ui/platform_window/dir now. This class can be set as a property value to the PlatformWindow, which is derived from the PropertyHandler now. That is, whenever a platform, which implements a platform window supports interactive move/resize events, it can implement a WmMoveResizeHandler and call SetWmMoveResizeHandler to set the handler. DesktopWindowTreeHostPlatform creates a WindowEventFilter now, which is a pre target handler for double click and window interaction events (move,resize). It also gets a handler from the PlatformWindow and sets it to the WindowEventFilter. The handler can be null, which will mean the non-client events won't be handled. When an event comes, it is tested against possible hittest values and whether it's a left click event. If the test is positive, the last mouse pointer location is taken and DispatchHostWindowDragMovement is called. The DispatchHostWindowDragMovement call passes the hittest and the pointer location values to a set |handler_| if it exists, which has its own platform specific implementation to request a server to start move/resize interactions. For example, in case of Wayland, xdg_surface_move or xdg_surface_resize methods are used. In case of X11, _NET_WM_MOVERESIZE message atom along with the last mouse pointer location are sent, and an x11 server grabs a pointer and starts move/resizing operation on a window. The events are also marked as non-client to ensure mouse handlers are not stuck in a "mouse pressed mode" until release events are sent. Normally, when platforms starts interactive move/resize, release events are never sent by compositors, which results in the above mentioned problem. Bug: 854564 TEST: XdgVersionV5Test/WaylandWindowTest.DispatchWindowMove/0, XdgVersionV5Test/WaylandWindowTest.DispatchWindowResize/0, XdgVersionV6Test/WaylandWindowTest.DispatchWindowMove/0, XdgVersionV6Test/WaylandWindowTest.DispatchWindowResize/0. Change-Id: I30f9fc50d9ab50c4cb7c6e76a0a8723015e3c777 Reviewed-on: https://chromium-review.googlesource.com/c/1078248 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Takashi Sakamoto authored
BUG=888904 Change-Id: I2b5af4b25e190a564d9374c94b6f6d43be84da58 Reviewed-on: https://chromium-review.googlesource.com/c/1248245Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#596146}
-
Alexey Baskakov authored
TBR=tkent@chromium.org Bug: 891575 Change-Id: I03fc86727d16ac81bfde2a15afb5f45085f1ffa6 Reviewed-on: https://chromium-review.googlesource.com/c/1258665 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#596145}
-
Maksim Sisov authored
This patch makes use of the PlatformScreen and ScreenOzone implementation. At this point, only basic functionality is added. Multi-display and other features will be added in a follow-up CL. How display fetching mechanism works: During the WaylandConnection::Initialize process, a Wayland compositor announces available global objects including a wl_output, which corresponds to one physical display. However, at this step, the WaylandScreen is not created, but the interface must be bound. Otherwise, we won't get properties of a wl_output aka physical display until something is changed on the display. That is, when a wl_output is announced, the WaylandConnection calls to a WaylandOutputManager, which creates a WaylandOutput wrapper class, and binds to the announced interface. As soon as the interface is bound, the Wayland compositor starts to send properties of the corresponding display through a wl_output_listener interface. After this, the WaylandOutput starts to receive property events, which are always stored and sent to a Delegate through a WaylandOutput::Delegate::OnOutputHandleMetrics, which WaylandOutputManager implements. The WaylandOutputManager then forwards those calls to the WaylandScreen (derived from the PlatformScreen), which it has a non-owned pointer to. Talking again about the WaylandScreen, once it is created, WaylandOutputManager has to manually tell the WaylandScreen about the existing WaylandOutputs and share their ids. The WaylandScreen starts to maintain a DisplayList based on those ids. Then, the manager calls the WaylandOutput::TriggerDelegateNotification() method, which triggers property update notifications of the existing WaylandOutputs. Once the browser is running, and the WaylandScreen exists, there is no need to manually trigger the updates. Instead, the WaylandOutputs immediately send the updates on each property change as described above. In the follow up cls, I will add more functionality and implement not implemented methods. Bug: 875161 Change-Id: I8d533149641bd5ee1970cd36c3c8601d5a81b7db Reviewed-on: https://chromium-review.googlesource.com/c/1236268 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Jinho Bang authored
This patch is initiated from this comment[1]. After this patch, the following small bugs are also fixed. - The PaymentResponse.details should always return same object. - If no details, should return empty object instead of undefined. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1226774/6/third_party/blink/renderer/modules/payments/payment_method_change_event.h#42 Bug: none Change-Id: Ib784013fbdedd42d30eb820a82d51ec4d08550f4 Reviewed-on: https://chromium-review.googlesource.com/c/1253862 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
There are some failures when validating URLLoaderClient method parameters, and one suspect is null data pipe. There are some callsites passing data pipes created with mojo::DataPipe without null checks. There are DCHECK in DataPipe constructors, but we suspect the assumption fails in the wild, so turn them to CHECK. Bug: 890468 Change-Id: I222af288ac17a439ac2cfbc4b1bd41c12cd4fb70 Reviewed-on: https://chromium-review.googlesource.com/c/1258686Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#596142}
-
