GitLab

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165145:165201&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/138033008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245233 0039d316-1c4b-4281-b951-d872f2087c98

Note that this temporarily adds some content:: notion in webkit/ (mostly for friend'ing / forward decls)

This also includes some refactoring in some test code (namely obfuscated_file_util_unittest.cc) to work around
cross-namespace friend'ing.

BUG=265769
TEST=build
TBR=mmenke

Review URL: https://codereview.chromium.org/137923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245232 0039d316-1c4b-4281-b951-d872f2087c98

XRaiseWindow does not reliably set the focus. GTK code is doing the same
thing, see gdk/x11/gdkwindow-x11.c.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244779

Review URL: https://codereview.chromium.org/137533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245231 0039d316-1c4b-4281-b951-d872f2087c98

BUG=223464

Review URL: https://codereview.chromium.org/137463006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245230 0039d316-1c4b-4281-b951-d872f2087c98

This will allow use to ignore profiles unused for a certain length of time (likely 28 days) when calculating statistics on number of profiles, number of signed-in profiles, etc.

BUG=295817

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244760

Review URL: https://codereview.chromium.org/134863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245229 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245228 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca

Review URL: https://codereview.chromium.org/132883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245227 0039d316-1c4b-4281-b951-d872f2087c98

There is no point in this typedef now that MessagePumpDispatcher is
its own class.

BUG=none
TEST=none
R=ben@chromium.org, darin@chromium.org

Review URL: https://codereview.chromium.org/139593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245226 0039d316-1c4b-4281-b951-d872f2087c98

BUG=324046

Review URL: https://codereview.chromium.org/136693007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245225 0039d316-1c4b-4281-b951-d872f2087c98

PageActionNotSupported: Synthetic swipe not supported for this browser

TBR=rtenneti@chromium.org,dominikg@chromium.org
NOTRY=True
BUG=

Review URL: https://codereview.chromium.org/135313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245224 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/139083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245223 0039d316-1c4b-4281-b951-d872f2087c98

Currently we assume audio output is either mono or stereo. This is wrong if the output channel is larger than 2.
This CL fixes the issue by mapping the number of channels to their corresponding AudioFormat constants.

BUG=312818

Review URL: https://codereview.chromium.org/138973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245222 0039d316-1c4b-4281-b951-d872f2087c98

There was still one data member accessed after the object got 
destroyed. 

BUG=329734

Review URL: https://codereview.chromium.org/138973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245221 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org, wjia@chromium.org
TBR=jam

Review URL: https://codereview.chromium.org/132903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245220 0039d316-1c4b-4281-b951-d872f2087c98

Disable the touch ack timeout on pages that have a width=device-width or
narrow viewport (indicative of the page being mobile-optimized or responsive).
Previously, this was disabled only on mobile sites with a fixed page scale.

BUG=260732,313741

Review URL: https://codereview.chromium.org/138893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245219 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245217 0039d316-1c4b-4281-b951-d872f2087c98

It seems to have cuased bug 335108 and XP Tests 1 interactive_ui_tests BookmarkBarViewTest18.BookmarkBarViewTest18_SiblingMenu
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/29747

> aura: Destroy the compositor before destroying the backing window.
> 
> This was causing linux_aura single-process browser tests to crash since
> they don't set up a default X error handler. When the compositor is
> shutting down it does a finish and this might try to swap to the X
> window.
> 
> Also change the windows shutdown ordering to match.
> 
> R=ben, enne
> BUG=270918
> 
> Review URL: https://codereview.chromium.org/132473007

TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/137893014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245215 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Make sure Chrome_elf.dll imports are correct and that it the first import of chrome.exe (https://codereview.chromium.org/109483003/)

Reason for revert:
Tests failing on Win x64 bots.

Original issue's description:
> 1. Make sure chrome_elf.dll imports nothing besides kernel32, advapi32, and some msvc libs (DEBUG builds)
> 2. Add gyp action and test to ensure chrome_elf.dll is always the first entry in chrome.exe's import table.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242834
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243048
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245197

TBR=robertshield@chromium.org,siggi@chromium.org,csharp@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/132613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245214 0039d316-1c4b-4281-b951-d872f2087c98

Added following metrics:
 * CrosFirstRun.DialogShown
 * CrosFirstRun.FurthestStep
 * CrosFirstRun.TimeSpent
 * CrosFirstRun.TimeSpentOnStepAppList
 * CrosFirstRun.TimeSpentOnStepHelp
 * CrosFirstRun.TimeSpentOnStepTray
 * CrosFirstRun.TutorialCompletion
 * CrosFirstRun.TutorialLaunched

BUG=269291

Review URL: https://codereview.chromium.org/131023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245212 0039d316-1c4b-4281-b951-d872f2087c98

trace-viewer side CL is here: https://codereview.appspot.com/52710047

Currently the monitoring mode doesn't work correctly when we reload about:tracing. This is because reloaded about:tracing fails in extracting the current monitoring status (See my comment in patch set 2).

This CL implements TracingController::GetMonitoringStatus so that trace-viewer/src/about_tracing/profiling_view.js can get the current monitoring status when loading the profiling view.

TEST=content_browsertests::EnableCaptureAndDisableMonitoring
R=nduca@chromium.org

Review URL: https://codereview.chromium.org/139313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245211 0039d316-1c4b-4281-b951-d872f2087c98

BUG=181136, 331337

Review URL: https://codereview.chromium.org/131913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245210 0039d316-1c4b-4281-b951-d872f2087c98

- always use "native" prefix for native calls.
- parametrize javap and cpp

BUG=

Review URL: https://codereview.chromium.org/136773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245209 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245208 0039d316-1c4b-4281-b951-d872f2087c98

The goal of the list is to store mappings between usernames, serial numbers and delegates.
Patch includes:
* implementation of the user list
* tests for the user list

BUG=284553

Review URL: https://codereview.chromium.org/135303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245207 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/135003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245206 0039d316-1c4b-4281-b951-d872f2087c98

This CL cleaned up the capturer a bit by moving the initialize() method to private and do NOT allow re-initializing the capturer when a new getUserMedia is called.
Instead, it creates a new capturer for each getUserMedia.

BUG=333285
TEST=content_unittests

Review URL: https://codereview.chromium.org/133903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245205 0039d316-1c4b-4281-b951-d872f2087c98

Eliminate separate boolean tracking socket writeability in
QuicConnection; query the writer instead. This CL tries to minimize
behavior changes, so no actual bugfixes. Connection will now check
writer's status instead of its local flag, so it will refuse to
write sooner.

Merge internal change: 59603011
https://codereview.chromium.org/138843003/


Change QUIC's SendAlgorithmInterface to have a separate UpdateRtt
method instead of passing it in with every acked packet.

This fixes a bug where the RTT was not being updated when
retransmitted packets were acked and one where a very large RTT could
be used when packets are acked before being sent.

Merge internal change: 59572874
https://codereview.chromium.org/138843003/

Break out of the loop in QuicSession::OnCanWrite if the QuicConnection
is congestion control blocked.  This fixes a weird form of starvation
among same-priority streams caused by streams often ending up in the
same order in the WriteBlockedList before and after
QuicSession::OnCanWrite.

Stop iterating through QUIC write blocked streams if the connection is
congestion-control blocked to avoid starvation of same-priority
streams.  Not flag protected.

Merge internal change: 59513911
https://codereview.chromium.org/139103002/


Fix a bug where the packet was put into unacked packets when it was
serialized and acked before being sent.

This was only ever seen on Chrome with very short RTTs.

Merge internal change: 59408566
https://codereview.chromium.org/133683010/


WriteBlockedList for QUIC that prioritizes Crypto and Headers streams
over data streams. Not flag protected.

Merge internal change: 59400238
https://codereview.chromium.org/137893008/


Create an interface for explicit notification of Dispatcher about
blocked writers; port TimeWaitListManager to the new interface.

Merge internal change: 59396227
https://codereview.chromium.org/138503006/


Remove WritePacket() from internal server's QuicDispatcher;
Integrating internal changes to clean up QuicDispatcher.

Merge internal change: 59346874
https://codereview.chromium.org/131743007/


Reset QUIC's retransmission counters whenever a new packet is acked
which updates the RTT estimate.

Previously the counters were only done when the left edge was acked,
which could cause excessive backoff when the connection was making
progress.

Merge internal change: 59292726
https://codereview.chromium.org/138273004/


Implement QuicPacketWriterWrapper. This lets us replace or embellish
the low-level writer without disturbing connections that keep a
pointer to the top level.

Merge internal change: 59287995
https://codereview.chromium.org/138273004/


Use basictypes.h consistenly in QUIC code instead of macros.h and/or
integral_types.h

Simply refactoring includes. Sync'ed with internal source code
for include of basictypes.h.

Merge internal change: 59287325
https://codereview.chromium.org/136853005/


Use the right priority when marking QUIC streams write blocked via
QuicFdWrapper::SetReady.  Not flag protected.

Used NULL instead of nullptr.

Fixed QuicReliableClientStreamTests to pass. Activated the
QuicReliableClientStream in the QuicSession so that session's
MarkWriteBlocked knows about the stream.

Merge internal change: 59263642
https://codereview.chromium.org/136523005/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/131743009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245204 0039d316-1c4b-4281-b951-d872f2087c98

This is a short term fix for a crash due to gfx::Screen access after ash shutdown, to be merged to 33.

Better fix is https://codereview.chromium.org/138003007/ but it's too large, risky to merge.

BUG=334585
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/130483009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245203 0039d316-1c4b-4281-b951-d872f2087c98

This CL is the equivalent of CL 136573002 for enrollment: It ensures that
when a user authenticates via SAML during enrollment, that user's e-mail
address is used to enroll the device.

BUG=332132
TEST=Manual

Review URL: https://codereview.chromium.org/130303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245202 0039d316-1c4b-4281-b951-d872f2087c98

Align ashmem region sizes to page size after ashmem creation failed.                                                                                                                                                                                                                                                           

When ashmem creation failed the new size (twice smaller) used to retry wasn't
page-aligned.

This also moves the page alignment function to the allocator's anonymous
namespace since it's now an implementation detail (since the allocator is
always used).

BUG=331832

Review URL: https://codereview.chromium.org/136723005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245201 0039d316-1c4b-4281-b951-d872f2087c98

A 'click' event can't be handle an activation by keyboard.

BUG=329166
TEST=manually tested

Review URL: https://codereview.chromium.org/128023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245200 0039d316-1c4b-4281-b951-d872f2087c98

Currently -[AppController applicationDidFinishLaunching:] and
-[AppController windowLayeringDidChange:] can trigger a synchronous load
of the last used _browser_ profile, even when no browsers are being
opened, and that profile is not required. This causes delays when the
app launcher or app shims are launched for a profile that doesn't match
the last used browser profile, because both profiles must be loaded and
initialized.

This change moves ChromeBrowserMain's GetStartupProfilePath() from an
anonymous namespace to startup_browser_creator.h so that AppController
can share the logic that determines the profile loaded when the browser
process starts up.

The shim process is tweaked slightly to ensure it passes
`--show-app-list` for the app launcher shim, similar to the Windows app
launcher. This allows a newly created browser process to determine that
the first thing it will be doing is showing a launcher.

BUG=178260, 262848

Review URL: https://codereview.chromium.org/127343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245199 0039d316-1c4b-4281-b951-d872f2087c98

Firefox 21 changed the directory layout within Firefox.app.
Some libs and content were moved from Firefox.app/Content/MacOS to
Firefox.app/Content/MacOS/browser, and this new location was
read as app_path_ by the importer. However, libnss3.dylib is still
in Firefox.app/Content/MacOS.

Changing utils to set app_path_ based on compatibility.ini's
LastPlatformDir (which always has Firefox.app/Content/MacOS)
instead of LastAppDir (which was changed to
Firefox.app/Content/MacOS/browser).

'searchplugins' subdir was moved into the new 'browser' subdir
so search engine importing code has to be adjusted.

Enabling Firefox importer browser tests on Mac. They didn't
work because they attempted to use Windows nss libraries. 
They should have been using Mac-specific libraries which are 
already available for Mac unit tests.

BUG=321112, 48007

Review URL: https://codereview.chromium.org/117123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245198 0039d316-1c4b-4281-b951-d872f2087c98

1. Make sure chrome_elf.dll imports nothing besides kernel32, advapi32, and some msvc libs (DEBUG builds)
2. Add gyp action and test to ensure chrome_elf.dll is always the first entry in chrome.exe's import table.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242834

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243048

Review URL: https://codereview.chromium.org/109483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245197 0039d316-1c4b-4281-b951-d872f2087c98

> Add the UI compositor to the Mac build
> 
> Move the bulk of the files in content/browser/aura to
> content/browser/compositor, since they're not aura-specific.
> 
> Build all of those files in the Mac build, and add ui/compositor
> to the dependencies of the Mac build. These files will soon only
> be excluded from the Android build.
> 
> BUG=314190
> 
> Review URL: https://codereview.chromium.org/137893007

TBR=ccameron@chromium.org
BUG=335083

Review URL: https://codereview.chromium.org/137853019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245195 0039d316-1c4b-4281-b951-d872f2087c98

This broke the wtf_unittests when compiling with gcc:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/16904

TBR=cevans@chromium.org, thestig@chromium.org
BUG=

Review URL: https://codereview.chromium.org/139153005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245194 0039d316-1c4b-4281-b951-d872f2087c98

Seems to be causing lots of layout test failures on Win7

> Don't set the scroll styles (WS_VSCROLL and WS_HSCROLL) for WS_POPUP windows.
> 
> This causes issues with select boxes on Windows 7 where hovering at the end of the window returns the scroll WM_NCHITTEST
> codes. Works fine on Windows 8. In any case we don't want the scrolling styles set on windows other than the main Chrome window
> which is the only window which should be receive mousewheel messages.
> 
> I moved the scroll style setting code from the HWNDMessageHandler::OnCreate function to HWNDMessageHandler::Init function as that
> would prevent the initial WM_SIZE message from hiding the scrollbar. The other change is to hide the scrollbars and readd the
> scroll styles if we are sizing the window, when the sizing completes. Basically when we receive the WM_EXITSIZEMOVE message.
> For normal sizing operations we continue to do this in WM_SIZE as before.
> 
> From testing on my thinkpad with Win7, desktop with Win7 and Win8 this works well.
> 
> BUG=334454,334541
> R=sky@chromium.org, sky
> 
> Review URL: https://codereview.chromium.org/137403008

TBR=ananta@chromium.org

Review URL: https://codereview.chromium.org/137443018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245191 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245188 0039d316-1c4b-4281-b951-d872f2087c98

Causing 'check_license' failure on 'Linux' builder
http://build.chromium.org/p/chromium/builders/Linux/builds/46649

> Add libwebm in third_party.
> 
> libwebm will be used by chromoting client to generate WebM stream for
> MediaSource API.
> 
> BUG=321825
> 
> Review URL: https://codereview.chromium.org/134643003

TBR=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/139993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245187 0039d316-1c4b-4281-b951-d872f2087c98

This flag flip accidentally shows the UI in Windows
but it should not.

> Flag-flip of app-list-voice-search. Now it's on by default.
> 
> BUG=333914
> R=xiyuan@chromium.org
> TEST=manually
> 
> Review URL: https://codereview.chromium.org/139293007

TBR=mukai@chromium.org

Review URL: https://codereview.chromium.org/139293012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245184 0039d316-1c4b-4281-b951-d872f2087c98