- 12 Nov, 2019 40 commits
-
-
Kazuki Takise authored
We want to control the visibility of a window in overview mode from the Android side. The actual scenario we have so far is: We want to hide the Netflix home (non-video) window if the video is in PIP mode because selecting the Netflix home window in the alt-tab cycler kills PIP, which is a bit confusing and may not be the user's intention. See b/129367828 for more details. BUG=b:143789289 TEST=PIP'd Netflix and confirmed the netflix home window is not listed in the alt-tab cycler. Change-Id: Iee4aac66c54646972a030cf3a00a138cf5762896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905302 Auto-Submit: Kazuki Takise <takise@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#714411}
-
Olivier Robin authored
These files include test code that triggers presubmit warning. As these files will never be compiled in the prod application, exclude them from these tests. Change-Id: I00f58dd9a3510617485ba655009307a8d6c95dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906209Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714410}
-
Kuo Jen Wei authored
ResolutionEventBroker was designed for aggregating a set of resolution related callbacks passing to all deep nested resolution related components. After several refactor works, all resolution related function will be moved into ConstraintsPreferrer and this broker is no longer needed. Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: I92f0b22b4d645155862f506347752d48e8b63714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883470 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#714409}
-
Takuto Ikuta authored
This reverts commit e5f79808. Reason for revert: crbug.com/1023761 Original change's description: > Reland: chrome_repack_locales: compress .pak files on Chrome OS > > Chromite changes to deploy locales/*.pak.gz files has landed. > > NOTE: This CL depends on the following chromite change (which copies > .gz locale files to the Chrome OS image): > https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1903536 > > Original CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1883292/ > > Original reviewer: > TBR=agrieve@chromium.org > For trivial change to resource_bundle.cc: > TBR=sky@chromium.org > > Bug: 1017864 > Change-Id: I384f1c2d0a2771e9121723ce8d10519f1ac1af9e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906944 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714328} TBR=stevenjb@chromium.org,sky@chromium.org,agrieve@chromium.org Change-Id: Icbf01b3424729ed7502994c08e026a42e41e9f32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017864, 1023761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911349Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#714408}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fb88ee1e..29cbe0b3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I81ade7232ae40878cf2552d16abe6999038aa61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911243Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714407}
-
Morten Stenshorne authored
Simplifies the code. Follow-up to CL:1903193 Change-Id: If5e068a96de44aa938fd3ab83496f1ca757d2dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908538Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#714406}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/503d196f2b70..9da287fd0264 git log 503d196f2b70..9da287fd0264 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 timvp@google.com Output Swiftshader version to logcat Created with: gclient setdep -r src/third_party/swiftshader@9da287fd0264 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/142828252 Change-Id: I29cd11ba8ab6ebd81bfdf12f9633b71a72048e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911142Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714405}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iddd6b433567b76e263357551287095c05bd07215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911662Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS orderfile from 80-3943.1-1572866479-benchmark-80.0.3954.0-r1 to 80-3943.1-1572866479-benchmark-80.0.3961.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I4342179d871c3bb2278c1eff54ceacdc828bf8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910781Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2d0a87cb7e91..faf13a0c3fdc Created with: gclient setdep -r src-internal@faf13a0c3fdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1018879,chromium:None,chromium:None,chromium:1023055 Change-Id: I37001a1fa1a9bd69b4c038fc1f3a929f4d1b6914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911284Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714402}
-
Ionel Popescu authored
Since in the time picker each column has the list of cells doubled we can start with each column scrolled to the middle in order to allow scrolling up. The new behavior is validated by time-picker-appearance-wheel.html and other existing tests. Bug: 1021343 Change-Id: I65b04f3f1fec79c2efc75f54a7798726c6ab1200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907522 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#714401}
-
John Abd-El-Malek authored
Change-Id: I61b804afe6c19ed399095d68aa6a6d76da71d945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908926 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#714400}
-
Ian Kilpatrick authored
"NeedsHackForTextControlWithFontFamily" behaviour was removed: https://chromium-review.googlesource.com/c/chromium/src/+/1019405/ And TextBlockLogical{Width,Height} was simply dead. :) This shouldn't change any behaviour. \o/ Change-Id: Ia267e88593cea94606b6f286058a4be887c01bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909267 Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#714399}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/52f8e51c..fb88ee1e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I88c7ef274a3b773e444f7fe5c8237dc2fbc4316e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911240Reviewed-by:
-
Ken Rockot authored
This eliminates redundancy in LocalStorageContextMojo ands hides some implementation details that were being unnecessarily exposed to e.g. DOMStorageContextWrapper. This is part of the preparation to move the implementation into the Storage Service. Bug: 1000959 Change-Id: Ie94ff8a3948a02561aac67dcbea024d70c4a434e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900918 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#714397}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2c237069. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 15c6f4fb "Add Web Platform Tests for the Split Cache" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dtapuska@chromium.org: external/wpt/uievents foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy jsbell@chromium.org: external/wpt/resources mcasas@chromium.org: external/wpt/mediacapture-record mkwst@chromium.org: external/wpt/mixed-content external/wpt/upgrade-insecure-requests nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events rego@igalia.com: external/wpt/css/css-grid skobes@chromium.org: external/wpt/css/css-scroll-anchoring NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I4b58bae1435a1f27fd19e60813dd0ac3da504120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911241Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714396}
-
Carlos Caballero authored
Allocators must return memory that is aligned at least as strictly as std::max_align_t. So make sure we do not ask for more, otherwise we risk getting misaligned memory in heap allocations. For more context, see discussion in https://crrev.com/c/1648176/18/base/task/promise/dependent_list.h#61 Change-Id: I91d69844e9a83899f3a9453f0e060a9779b40028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810960Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#714395}
-
Ian Kilpatrick authored
The first-tier OOF-cache attempts to skip all the OOF sizing and positioning work required, as the other cache simply compares the constraint spaces which can be (relatively) expensive to determine. This first-tier cache works by comparing the available-size given to the OOF-positioned descendant. If equal we can skip the OOF-positioned sizing and positioning steps. This mostly worked, however had an issue where the containing-block may have added/removed a borders/scrollbars, but the available-size given remained the same. This resulted in an incorrectly positioned OOF-positioned node. This fix disallows the first-tier cache when borders/scrollbars are present. This is sufficiently rare that this cache still has a relatively high hit-rate and is still relative cheap to calculate. Bug: 1013866 Change-Id: I71d41d2c4b47bcff6412f395db2deabf2f6f3a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891768 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#714394}
-
Keishi Hattori authored
This reverts commit 3ee16746. Reason for revert: HeapTests are failing crbug.com/1023716 Original change's description: > [Fuchsia] Stop enabling shadow-call-stack explicitly > > shadow-call-stack is enabled by default on Fuchsia now, so we no longer > need to enable it explicitly. > > Bug: 821951 > Change-Id: I221bc557bf93dfd5bf7c1659f7f8dfc32129c6b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898631 > Commit-Queue: Wez <wez@chromium.org> > Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714312} TBR=wez@chromium.org,sergeyu@chromium.org Change-Id: I7e8467363407c8ce1738ae83f31e7c543d3e9144 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911066Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714393}
-
Evan Stade authored
Bug: none Change-Id: I2fddbc42b7a42e4c312c30dbd533fe92a6fb7d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910876Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#714392}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I9d4cd05623b53d3499e002de2e51ca9bb88afc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911640Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714391}
-
Manu Cornet authored
This is used (and will be used more) to give observers updates about the home launcher position (within the animation / drag) and not just updates about what the expected target position is, so the new name is a little more informative. It's hard to predict what the "target" position is anyway, since during a drag the user can easily go back and forth. This is a pure rename (plus some comment updates) and has no expected user-visible impact. Change-Id: I8eb8d039e3cc33a43a4fa9760dcb332e15a83e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910768Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714390}
-
Ken Rockot authored
This doesn't need to exist anymore; it wraps two separate sequences (one "primary" and one for "commit") yet DOM storage implementation now only uses one of them. It's effectively a thin wrapper around a SequencedTaskRunner which provides no additional functionality. Bug: 1000959 Change-Id: I178a9ee254232cc73b0b89e1ed2c588b23266ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900538 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Finnur Thorarinsson authored
This will control whether we show contact images in the UI. Later, it will also control whether we pass these images down to the web page. Bug: 1020564, 860467 Change-Id: Idbed174e9d53a1bee591eb50864cd8a571f71b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905986Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#714388}
-
Keishi Hattori authored
This reverts commit 031922a6. Reason for revert: RemoteCopyBrowserTest.ImageUrl is failing crbug.com/1023709 Original change's description: > Add image support to Remote Copy. > > Bug: 1018138, 1018132, 1020582 > Change-Id: I50d131ec34ccee3bf5b76167178eac4728b51bea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903203 > Reviewed-by: Richard Knoll <knollr@chromium.org> > Reviewed-by: Darwin Huang <huangdarwin@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714193} TBR=mvanouwerkerk@chromium.org,mastiz@chromium.org,mkwst@chromium.org,huangdarwin@chromium.org,knollr@chromium.org Change-Id: Ia5f3ffae72f8812b7caf0c678bc17a65e92c89a9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018138, 1018132, 1020582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911063Reviewed-by:
-
W. James MacLean authored
When an inner WebContents is fullscreen, and has focus, pressing <esc> causes the keyboard event to be handled by that webcontents. But it should instead be handled by the outermost WebContents so that it can get to the appropriate delegate. Bug: 1013640 Change-Id: I4ff81bea8cd9fa43259dde39b3bc479f6fd06f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896771Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=gbiv@chromium.org Change-Id: I2d4565a1bc8c9a7d8f72812f1ae2905347fd7404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910751Reviewed-by:
-
Manu Cornet authored
Also rename "animation state" to "transition state" since this also represents drag state. Bug: 1012760 Change-Id: Ic890be82ddd4cb713759c07985cc7e4b1210b029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910761Reviewed-by:
-
Ryan Sturm authored
Add PreconnectOnDidFinishNavigation entry to field trial testing config. The 3 second arm is chosen as it is the most likely to launch. Bug: 1016553 Change-Id: I84250e6d4ef55edc988de2edf2a2c873dd61d22f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900470Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#714383}
-
Tommy Steimel authored
This CL allows the user to click and drag a media notification out of a MediaDialogView and into an always-on-top overlay. This allows the user to continue to control media without having to go back to the dialog. This feature is put behind a disabled-by-default flag. Bug: 1022452 Change-Id: Ifd4b837c5b2407c886a9b16403d15f710e38db0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904158 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#714382}
-
Nick Burris authored
Adds more web platform tests for scroll to text: - Combination of non-text directive and text directive - Scroll second text directive into view if first doesn't match - Matching shadow DOM - Don't scroll to hidden text - Text that requires a horizontal scroll into view - Also fixed non-ASCII test case (and changed to Japanese example) Change-Id: Id7e21a185897267dc565b19adc7bfdfb5fe70974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903624 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714381}
-
sczs authored
Creates and configuresthe necessary items to populate the SaveCard Modal and adds placeholder methods for their actions. Screenshot: https://drive.google.com/open?id=1VOFTyTGYyOAXp_dI0ZEkiAg6SP-rv8bd Bug: 1014652 Change-Id: I231b19781a5f7142a2c4096f995450aace2f833b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907210Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#714380}
-
Michael Spang authored
Many data members are not const but can be, especially pointers. Make them so. Change-Id: I82a1e3ab26507eaa88e239847eff84b24f7198b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876984Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714379}
-
Makoto Shimazu authored
Clients restricted by COEP header should not get opaque responses. Service workers need to respect a COEP value for the client which dispatches a FetchEvent, otherwise the client can fetch opaque responses through a service worker. This CL is to propagate the COEP header to the service worker. Each service worker has connections to the clients, and this CL tries to bundle the Mojo endpoint for subresource fetch events on the service worker side with its COEP header. In a following CL, I'm going to add code to respect the value before responding to the clients. Bug: 999049 Change-Id: Ic92bde114c361e53ddef0951ec0d7224c525e624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895253 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#714378}
-
Livvie Lin authored
Bug: 1008219 Change-Id: If02a36539fe61e71d1434528ec5af31d3914439b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889116 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#714377}
-
Morten Stenshorne authored
And enable fragment painting for multicol containers. Rules are to be painted "just above the border of the multicol container" [1]. At the same time, "the rules need to scroll along with the columns" [1]. Hence, we'll paint it as the first item in the foreground phase, so that we get scroll offsets applied. [1] https://drafts.csswg.org/css-multicol/#column-gaps-and-rules By enabling fragment painting for multicol containers, we break one outline test. The fix is easy, but I'd rather deal with that in a follow-up. Bug: 829028 Change-Id: Ie5e4ac267967f185a588bfc36f1902a2b1659413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899784 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
John Budorick authored
Bug: 1023475 Change-Id: I7df21c024c5459d8fc615e5d33ade559dd16e70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910863 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#714375}
-
James Cook authored
This fixes a regression introduced by the split settings project. The window frame menu for settings, when multiple users are logged in, is not supposed to show the "Teleport" menu item. This broke because the WebUI URL for the Settings window content changed. Fix by using SettingsWindowManager to detect if a Browser* is the settings window, which is the canonical way of doing it. Bug: 1023043 Test: added to browser_tests Change-Id: Ib79bcfd6c6206773d12377640f476d3b76652182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910760Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#714374}
-
Simon Que authored
This is currently set to use the RBE backend via the recipe config. Specify it in the builder config instead. Bug: 1022800 Change-Id: I27955c8012682847987c65daec9d2de64898369c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906460 Auto-Submit: Simon Que <sque@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
-
Noel Gordon authored
Add files20 (20px files-ng) <iron-icon> set. Add external-link icon, and eject icon, as initial members. Bug: 992819 Change-Id: I12f9e228f404bc68cfa8d998feae249a6bfe40cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906459Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#714372}
-
