- 08 Apr, 2019 40 commits
-
-
Nina Satragno authored
This CL replaces the UI for the webauthn authentication attestation permission prompt with a new sheet on the authentication dialog. Bug: 850955 Change-Id: I83f39f470e308474a4a67744dd0675eaef18e188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547344 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#648664}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ce224208..eec47f93 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaa71ee74037019eaf489be26012ea1da51cafbcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557012Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648663}
-
Huanzhong Huang authored
Changes the code so that when the new-clear-browsing-data-ui flag is on, the path through Settings that used to present a CBD CollectionView will instead present a CBD TableView. Change-Id: I75f6742099fc62a6c6553cbefef65cb351de87df Bug: 935350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554497Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#648662}
-
Nikita Podguzov authored
Change policies values from {"secure", "unsecure"} to {"pin", "no_pin"} not to confuse users with "*secure" values. Bug: 848942 Change-Id: I08f8a54fecbff2ea4521b478d34c7e6bef4c62f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554493 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#648661}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/65611b197df1..3c8363e80d5f Created with: gclient setdep -r src-internal@3c8363e80d5f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I92f4276a1c4f06cf4556f8ba32ca7e252ee36252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557880Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648660}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/439ae2de32db..cb0a4cdcabe1 git log 439ae2de32db..cb0a4cdcabe1 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 fmayer@google.com Merge "Check return value of fnctl when sealing fds." 2019-04-08 rsavitski@google.com Merge "no_destructor_unittest: assert flag setting instead of death tests" 2019-04-08 lalitm@google.com Merge "trace_processor: replace vector<string> with StringPool in storage" Created with: gclient setdep -r src/third_party/perfetto@cb0a4cdcabe1 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I3973884e56a3bd63d1cb2cd22788d5f2ae723ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557881Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648659}
-
Becca Hughes authored
Add a Media.Notification.Source histogram that records the source of the media session when a media notification is shown. BUG=949303 Change-Id: I36880667d1911845187d192bb46afa2c4c4dcc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552239 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#648658}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/webaudio, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I0556290c2f89e7210aecc9644490344145b3a4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556661Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#648657}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/webdatabase, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ic675c3325b66468b4686f69e0f950cc8d99034b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556964Reviewed-by:
-
Rayan Kanso authored
Changes: - Previously we were only exposing whether the event succeeded or failed. Now we also include whether it timed out, was rejected, or aborted. - Add an event for when a sync is re-registered. - Restore UMA logging and add a test for it. Bug: 940450 Change-Id: I2f920b0b5adcf4374e9cfb4f3edd57658cd83021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549085 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#648655}
-
Amr Aboelkher authored
Bug: 949184 Change-Id: I8a101256662676ac7bcc1c9ddc9e9c5fb0ace8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556838 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#648654}
-
Denis Kuznetsov authored
Bug: 950471 Change-Id: Ic3ae509848884bb8349543fda157edbb35c70cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556801 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
Edwin Joe authored
Do not allocate a new Local Surface ID if the RWHI is hidden when it receives DidUpdateVisualProperties from the RW. Currently, when the RWHI receive a DidUpdateVisualProperties from the RenderWidget, it always allocate a new Local Surface ID no matter what its visibility state is if it currently do not have a valid Local Surface Id Allocation. This causes us to allocate a new local surface id even though we do not need it, and we will not send this to the Renderer until we are visible, which is when we switch back to this tab. When we switch back, we will use the previously allocated local surface id (which could possibly be allocated a long time ago, depending on how long it takes before switching back to the tab) and send it to the Renderer. Since the Viz.DisplayCompositor.SurfaceEmbeddingTime metric tracks the delta between allocation time and Surface::OnWillBeDrawn, this means that we are uploading inflated surface embedding time metric. Bug: 936858 Change-Id: Ibd42f687b66d623eaf265fa5ab6e959cf492c125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541580Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Edwin Joe <ejoe@google.com> Cr-Commit-Position: refs/heads/master@{#648652}
-
Huanzhong Huang authored
- Previously in Clear Browsing Data, a selection of a cell is immediately followed by a deselection along with UI update (checkmark in accessory view). - With the new CBD UI being introduced, the selection state of cells becomes relevant and should be handled and maintained. Detail outline: - Reconfigure instead of reload a cell upon browsing data counter finish counting, as a reload clears a cell's selection state. - Cell pre-selection according to browser state, whenever |viewWillAppear:| is invoked. - Have separate |tableView:didSelect...| and |tableView:didDeselect...| implementations. - Should introduce no effect when new-clear-browsing-data-ui is disabled. Bug: 935346 Change-Id: I6b224e5d6ac05f5a3506668f8d6a68d3353fc897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551779 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
-
PKH authored
[Android Refactor] Rename WebApkSharedPreferences#SHARED_PREF_REQUEST_HOST_BROWSER_RELAUNCH_TIMESTAMP This CL renames WebApkSharedPreferences#SHARED_PREF_REQUEST_HOST_BROWSER_RELAUNCH_TIMESTAMP to WebApkSharedPreferences#PREF_REQUEST_HOST_BROWSER_RELAUNCH_TIMESTAMP in order to be more consistent with the other constants in WebApkSharedPreferences BUG=None Change-Id: Ic909032eefa2198c3ce7ef618c68feb5beaa302f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556448Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#648650}
-
Michael Thiessen authored
Exposes the native NQE observer to java. Bug: 948233 Change-Id: I78d44cd65a57f019e7cd2b3cbc0308514d1ee29a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553643Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#648649}
-
W. James MacLean authored
This CL implements pinch-zoom re-raster throttling for OOPIFs by making OOPIF compositors aware of when the main-frame is active in a pinch zoom gesture. It achieves this by receiving |is_pinch_gesture_active| via the FrameVisualProperties sent to the FrameConnectorDelegate and appending it to the VisualProperties synced from the browser process to subframes. Then is is plumbed into the compositor along the same route as |external_page_scale_factor|. An existing test for propagation of PageScaleFactor to subframes has been enhanced to verify the value propagates from mainframe to subframe, and from subframe to sub-subframe. Another test verifies the flag makes it into the compositor when VisualProperties are synced to the RenderWidget. TBR=danakj@chromium.org TBR=alexmos@chromium.org TBR=kenrb@chromium.org Bug: 924336 Change-Id: I3eeec35077291aef945791ce49743b90b55d0247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557879Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#648648}
-
Rohit Rao authored
shell_earl_grey.h is converted to be C++ functions in the "shell_test_util" namespace. shell_earl_grey_app_interface.h is introduced to contain the ObjC functions that will eventually make up the EG2 cross-process API. BUG=922813 Change-Id: Ifb419383e9c1dc2e69327914d00cd749318ff889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554053 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#648647}
-
Rayan Kanso authored
The button is disabled if there are no events, and saves all events to a file when clicked (JSON format). Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c13 Bug: 942174 Change-Id: I2c2d3600814f19050083275f52acbe40e23b0e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552854 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#648646}
-
Marc Treib authored
It's an (OAuth2) access token, so let's call it what it is. Bug: 933799 Change-Id: Ie7439bdf707991df913cf56a502f0d92143c4679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556798 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#648645}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3bb94905928d..edab510dfad8 git log 3bb94905928d..edab510dfad8 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 swiftshader.regress@gmail.com Regres: Update test lists @ 4ba1911b Created with: gclient setdep -r src/third_party/swiftshader@edab510dfad8 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ib9c30ded3e665842a4132b079436d25dc695aca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557877Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/731eaa372a59..d3c9245454ed git log 731eaa372a59..d3c9245454ed --date=short --no-merges --format='%ad %ae %s' 2019-04-08 ethannicholas@google.com Revert "Revert "Reland "GPU support for SkMixers""" Created with: gclient setdep -r src/third_party/skia@d3c9245454ed The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ie6d0f0a616192e5cb753d60b68744b881384fa6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557874Reviewed-by:
-
Mikel Astiz authored
Passwords have a few particularities when it comes to reading from the sync Directory, as reflected in the TODO now removed. This patch adds integration tests to exercise the migrator, which seems to work just fine. Bug: 949038 Change-Id: I058964587fd94873c0f86836d262adb18a2761d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557021 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#648642}
-
Henrique Ferreiro authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in third_party/blink/renderer/platform/, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbx> Bug: 939691 Change-Id: I3ae44fd631206e018f4d3daf13c6849aed8a756d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556836Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/094a55279558..439ae2de32db git log 094a55279558..439ae2de32db --date=short --no-merges --format='%ad %ae %s' 2019-04-08 hjd@google.com Merge "perfetto-ui: Show slice wakeup info" 2019-04-08 rsavitski@google.com heapprofd_client: avoid destruction re-entrancy issues, and global destructor Created with: gclient setdep -r src/third_party/perfetto@439ae2de32db The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:129749217 TBR=perfetto-bugs@google.com Change-Id: I486093b941dac478ce25d5ff43019366a0e1453e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557878Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/40c6e1550294..65611b197df1 Created with: gclient setdep -r src-internal@65611b197df1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: Idfb5c236e6b1e519783d9535518c2e03ecf893a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557876Reviewed-by:
-
Marc Treib authored
It was used to record field trials as Sync user events, but this feature was abandoned a while ago. Bug: 934762, 934333 Change-Id: I1606d5052bda03b1db64a2c084f05fe21c5cc9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557020Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#648638}
-
Marc Treib authored
The engine itself knows whether it's initialized. This CL adds a public IsInitialized() methods which exposes that, so ProfileSyncService doesn't have to track it externally. Bug: 934239 Change-Id: Icab966baee60cc8913ff58639b2825df35fc2cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556841Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/067afa275dcb..6abc006f6760 git log 067afa275dcb..6abc006f6760 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 raul@tambre.ee Convert print statements to Python 3 style Created with: gclient setdep -r src/native_client@6abc006f6760 The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:941669 TBR=mseaborn@chromium.org Change-Id: I6c698f556ae9c5eaade53b2d9ae6df899bf886ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557875Reviewed-by:
-
Ehsan Karamad authored
FramePolicy (almost always) contains to the combination of a FrameOwner's sandbox flags as well as parsed FeaturePolicy. This is a mechanical change to use FramePolicy instead of the pair of sandbox and parsed policies when possible. In summary: * GetSandboxFlagS() and ContainerPolicy() are removed from FrameOwner. * GetFramePolicy() is added to FrameOWner. * All the public and internal blink API relying on the pair of (WebSandboxFlags, ParsedFeaturePolicy) from a FrameOwner now take a FramePolicy argument. This change would make merging Sandbox and FeaturePolicy easier down the road (FeaturePolicyForSandbox). TBR=jochen@chromium.org Bug: 812381 Change-Id: I4c6f330e13e187cd8c43841955df924a7332ba46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556512Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
-
Lucas Tenório authored
The current conversion first transforms the id into a string then to a hex representation of that string. This is the wrong result since what we really want is the string representation of the id as a hex number. As a bonus I'm adding proper tests to cover this feature. Bug: 927809 Change-Id: I54b902e55e4437595857548bbb6c3775685c8528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554948Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#648634}
-
Askar Aitzhan authored
before: When managed user logs in to unenrolled device there were no managed icon in the bottom left corner near the "time" after: When managed user logs in there is an icon Bug: 940429 Change-Id: Id72cea2d7008443f53c5bbcefb1d6bac507472c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549129Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Cr-Commit-Position: refs/heads/master@{#648633}
-
Samuel Huang authored
This reverts commit b8de8c26. Reason for revert: Relanding: Looks like the problem is caused by another CL. Original change's description: > Revert "Clear inapplicable disable reasons for component extensions" > > This reverts commit 07619eb1. > > Reason for revert: Speculative revert for "Linux Chromium OS ASan LSan Tests (1)" failures in unit_tests related to extensions. > > Original change's description: > > Clear inapplicable disable reasons for component extensions > > > > This change ensures that all component extensions are allowed to be activated despite having some inapplicable disable reasons set. > > > > In particular, this fixes any specific observed on-device instances where ChromeVox or tts had a disable reason of blocked by policy which prevented it from being activated. > > > > Bug: 946839,947305 > > Test: manually. With a device enterprise enrolled, push down kiosk apps to the device from an admin console. Ensure that ChromeVox still works on all screens. > > Change-Id: I2cedafeb16d4420702188f1516825ce1bad52802 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553017 > > Commit-Queue: David Tseng <dtseng@chromium.org> > > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#648464} > > TBR=dtseng@chromium.org,rdevlin.cronin@chromium.org,devlin@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 946839, 947305 > Change-Id: Icf19fe7e45c41ed559a732703844c0874c6cfdd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557734 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648573} TBR=huangs@chromium.org,dtseng@chromium.org,rdevlin.cronin@chromium.org,devlin@chromium.org Change-Id: I92b60a51aaf4883e8fcc953645b343860bb61f1e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 946839, 947305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557011Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#648632}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I01bc173f2a4db6f5ffa744aedb8441667f759b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556656Reviewed-by:
-
Elly Fong-Jones authored
This change: 1) Removes the AffiliationBasedMatching flag 2) Removes the backing AffiliationBasedMatching feature 3) Removes support in PasswordStore for disabling password propagation to web credentials 4) Removes test coverage for (3) Bug: None Change-Id: Ied45e67ffb11893c9aa7e27c2d2625c595156b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546528 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#648630}
-
Jan Krcal authored
This CL makes sure that we do not abuse the UMA_HISTOGRAM_CUSTOM_TIMES macro by specifying max value above 24 days (which in milliseconds is around INT_MAX). Recording higher time values has to be treated differently. Bug: 949034 Change-Id: I016379bd5270e3120a21464d072b29117a71c03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549072 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#648629}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e3b2feb3..ce224208 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I47780209d164b21993bbd65e25caf0ead1ada212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557542Reviewed-by:
-
Mikel Astiz authored
Our ongoing rollouts (USS migrations) have noticeable impact on this metric and we'd like to keep it around for some more time. Bug: 928514 Change-Id: I8ed093e48c6e15c4e6ea7e5a6d2adc7102c6fc7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556783 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Marc Treib authored
It's an (OAuth2) access token, so let's call it what it is. Bug: 933799 Change-Id: I02ce9c9885e95d1ea8a854c919d6ac6d75def420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556839 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/008246e0ae51..094a55279558 git log 008246e0ae51..094a55279558 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 lalitm@google.com Merge "trace_processor: introduce API for computing metrics on trace processor" Created with: gclient setdep -r src/third_party/perfetto@094a55279558 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8c735e2f23cb263f8920a61dfe8b6eeb2d0e5e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556585Reviewed-by:
-
