- 20 Jun, 2018 40 commits
-
-
Quan Nguyen authored
Bug: 837501 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia55c5e302d70c1a65409fd7268ae135e0ee7c5ca Reviewed-on: https://chromium-review.googlesource.com/1102904 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#569043}
-
David Bokan authored
A local root OOPIF has its own lifecycle but doesn't have its own visual viewport layers so we'd crash when trying to process them. Only try to process viewport layers for blink-gen-property-trees when we're in the main frame. TEST=Open chrome with --enable-blink-gen-property-trees and open any site with an out of process iframe. Pass if renderer doesn't crash. Bug: 854221 Change-Id: I423c90e5cbc7aa20be8541e8e7d89158233f774c Reviewed-on: https://chromium-review.googlesource.com/1106668Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569042}
-
Victor Costan authored
MSAN/ASAN correctly identified a user-after-free in ClipboardMacTest::CreateImage(). Specifically, when using CGDataProviderCreateWithData(), the caller is responsible for keeping the data buffer referenced by the CGDataProvider alive as long as necessary. ClipboardMacTest::CreateImage() incorrectly assumes that the buffer does not need to be kept alive after an the CGDataProvider is used to create an NSImage. This CL implements a CGDataProviderReleaseDataCallback and passes it to CGDataProviderReleaseDataCallback(), so the data buffer is only freed after the CGDataProvider stops using it. This fixes the use-after-free. Bug: 818167 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_chromium_asan_rel_ng Change-Id: Iafdc7a4b2448fd2d31bcd6f3078af69b8062c06b Reviewed-on: https://chromium-review.googlesource.com/1108550 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Mathieu Perreault authored
If was considered redundant by UX designer and writer. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_valid_PermanentError --test-launcher-intera Change-Id: I3630fabdc7cabec92106d75ed907faa1b72a64b1 Reviewed-on: https://chromium-review.googlesource.com/1107778Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#569040}
-
Maks Orlovich authored
Previous version (https://chromium-review.googlesource.com/c/chromium/src/+/1060254) had to be reverted since it did not handle running off UI thread, which pre-change version did. The reland is permitted by https://chromium-review.googlesource.com/c/chromium/src/+/1108137 which removes the off-thread usage, and is identical except for: 1) Some additional sequence checking 2) Port of the one new client that showed up during lifetime of this CL 3) Test filter update. (See patchset 1 for straight re-apply) Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9a039409fe8069df7d03242eb0eb579f4c11dc4b Reviewed-on: https://chromium-review.googlesource.com/1098035 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#569039}
-
Marijn Kruisselbrink authored
This makes sure the DownloadContentTest.DownloadAttributeBlobURL test works with mojo blob URLs enabled even when network service isn't enabled. We want to ship Mojo Blob URLs before network service is ready to ship, so need to support this in the downloads code as well. This simply switches DownloadManagerImpl to use the network service code path whenever a blob_url_loader_factory is passed in. Bug: 800901 Change-Id: Ib2668a1a7b9544e29e796eb40ac8680265c7e82b Reviewed-on: https://chromium-review.googlesource.com/1105477Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
-
Bin Wu authored
allow more inlining. Not flag protected. Merge internal cl: 201354423 R=rch@chromium.org Change-Id: I312d75438afadb385df223efd8bf7eec55296b52 Reviewed-on: https://chromium-review.googlesource.com/1108372 Commit-Queue: Bin Wu <wub@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569037}
-
Amirhossein Simjour authored
Bug: 854181 Change-Id: Id2418b88928fcd998e67bed8f011f2dcbb4cc8f5 Reviewed-on: https://chromium-review.googlesource.com/1106293Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#569036}
-
Evan Stade authored
Implemented by Chrome, the majority is only used from within //chrome/, and only from one callsite each. Thus the implementations can be inlined. The one remaining method in the interface is only used for ash tests. Resolving that and removing the interface altogether is TODO. Bug: 826374 Change-Id: Ib808ae70f3cf87be688b05c3cec15f35e4e121b5 Reviewed-on: https://chromium-review.googlesource.com/1107128 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#569035}
-
Shimi Zhang authored
Wrongly used "^" and "|" in two tests, so the selection direction is not matching the old tests. This CL fixed these misuse. Bug: 847192 Change-Id: I036c3a00eacb9ff4a7d8244ec40b3899aa68feb3 Reviewed-on: https://chromium-review.googlesource.com/1108742Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#569034}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/beb2d9813c71..db6af36979b6 git log beb2d9813c71..db6af36979b6 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 aleloi@webrtc.org Add RNN-VAD to AGC2. 2018-06-20 yvesg@webrtc.org Add format check to `git cl presubmit` Created with: gclient setdep -r src/third_party/webrtc@db6af36979b6 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifb7a0dc76ead7c9687a3fb8f9dcd38c35570ba8d Reviewed-on: https://chromium-review.googlesource.com/1108637Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569033}
-
David Black authored
There as been confusion regarding the term "bubble". As such, this CL: - Renames AssistantBubbleController to AssistantUiController. - Renames AssistantBubbleModel to AssistantUiModel. - Renames AssistantBubbleModelObserver to AssistantUiModelObserver. - Renames AssistantBubbleView to AssistantContainerView. Bug: b:80542452 Change-Id: I7a9797da83d9bc3a53718aef5e76933fa43c1f3f Reviewed-on: https://chromium-review.googlesource.com/1105134 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Ryan Tseng authored
Bug: 840631 TBR: tandrii Change-Id: Ie3794a3c74b9643a10596d106ffc12c31f7e599f Reviewed-on: https://chromium-review.googlesource.com/1108552 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#569031}
-
Patrick Monette authored
The feature is currently active at 10% on stable and it's time to make it the default. Bug: 717696 Change-Id: I7b6c3e162c6d475408b201a6c1417c89762f6b32 Reviewed-on: https://chromium-review.googlesource.com/1106484Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#569030}
-
Raphael Kubo da Costa authored
Commit fc5fe708 ("FrameSinkVideoCapture clean-up: Remove unused APIs, style fixes") added the noexcept marker to FrameSinkVideoCapture's ConsumptionState inner class. This breaks the GCC build due to the fact that its members' types do not have noexcept themselves: ../../content/browser/media/capture/frame_sink_video_capture_device.cc: At global scope: ../../content/browser/media/capture/frame_sink_video_capture_device.cc:372:1: error: function ‘content::FrameSinkVideoCaptureDevice::ConsumptionState::ConsumptionState(content::FrameSinkVideoCaptureDevice::ConsumptionState&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’ FrameSinkVideoCaptureDevice::ConsumptionState::ConsumptionState( clang is fine because we pass -fno-exceptions and it disables the same error there, while GCC continues to raise it (bug 843143 and its corresponding CL have a longer discussion on this issue). In this case, mark CursorRendererUndoer as well as mojo's ubiquitous InterfacePtr with noexcept to fix the build. Bug: 754872, 819294, 843143 Change-Id: I78714fda26d21e0979aed4fe26d543463dff9631 Reviewed-on: https://chromium-review.googlesource.com/1107918Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#569029}
-
Majid Valipour authored
Paging scroll operations should take scroll-padding into account [1]. So we use the snapport rect to calculate the page step instead of the visible rect. Other minor change: - VisibleScrollSnapportRect now takes into account scrollbar inclusion. This was needed since in at least one paging operation we needed to include scrollbars. [1] https://drafts.csswg.org/css-scroll-snap/#scroll-padding Bug: 842165 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3112a94a984b438bc66fc2664b8288ec95a1d725 Reviewed-on: https://chromium-review.googlesource.com/1105520Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#569028}
-
Matt Menke authored
It flakily reaches a point of execution where extensions try to do a host resolution using the RequestContext, which isn't set up when the network service is enabled. TBR=jam@chromium.org Bug: 854762 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5883a5620b953ca40fd582d39b96ea29f4f988e9 Reviewed-on: https://chromium-review.googlesource.com/1108737Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569027}
-
Khushal authored
GpuImageDecodeCache supports decoding directly to the desired scale, if supported by the image decoder, but the functionality was commented out in PaintImage. Enable it. Follow up changes should add the use of this API to the software cache. R=ericrk@chromium.org Bug: 558070,773799 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iea69e200b9b0bc1b1c60231c7c15cef5c6a2f674 Reviewed-on: https://chromium-review.googlesource.com/1102025 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569026}
-
Olivier Robin authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I437b8139b4c25e350e81d92cacc9575cac4763cf Reviewed-on: https://chromium-review.googlesource.com/1104173Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569025}
-
Eugene But authored
No major issues were found during manual testing. Safe to ship in M69. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I753c20d6525547958140d6407e8bd71d4f8ef0f7 Reviewed-on: https://chromium-review.googlesource.com/1086111Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#569024}
-
Ben Wagner authored
Skia is moving the include/ports/SkFontMgr.h file to include/core/SkFontMgr.h as part of a general clean up. The old header still exists as a forwarding header, but users need to be updated to use the new header location so that the forwarding header can be removed. TBR=sky@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7c644f1acc3826714e0cf1a29be44fe4669f259d Reviewed-on: https://chromium-review.googlesource.com/1108084 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#569023}
-
Fabio Tirelo authored
Bug: 847980 Change-Id: I3000a303d016d68dc86a21211399bc24c204a8a0 Reviewed-on: https://chromium-review.googlesource.com/1080689 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
-
Scott Violet authored
This makes the utility process create AshService for --OopAsh. AshService will get the logic to create Shell for OopAsh. BUG=854336 TEST=none Change-Id: I266cd93b848fa6e3a8d95de2a0c3410aa6ac8d38 Reviewed-on: https://chromium-review.googlesource.com/1108507Reviewed-by:
-
Zhongyi Shi authored
This test verifies that QuicStreamFactory broadcasts connection migration signal to all the sessions and multiple sessions migrate to new network afterwards. Bug: 818259, 843299 Change-Id: I9ade5015b9eb992bf83d23132c5aa0bfeb3563a6 Reviewed-on: https://chromium-review.googlesource.com/1108516 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
Tarun Bansal authored
Add few DCHECKs, and update enum values. Change-Id: Idb9a6ea39ed5a4799a3e9a24703b6d485914ccd8 Bug: 854666 Reviewed-on: https://chromium-review.googlesource.com/1105188 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#569019}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e5c614fbaf79..a58d69e90b91 git log e5c614fbaf79..a58d69e90b91 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 fjhenigman@chromium.org Revert "GLES1: Point rasterization (partial implementation)" Created with: gclient setdep -r src/third_party/angle@a58d69e90b91 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If70df816dffc37b638ca16707848327442c55220 Reviewed-on: https://chromium-review.googlesource.com/1108301Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569018}
-
Boris Sazonov authored
This CL contains first chunk of changes to adapt Settings for UnifiedConsent. It adds "Account" section and "Sync and Google services" entry to the main settings screen. It also changes the summary text of SignInPreference. All changes in this CL are gated by UNIFIED_CONSENT feature flag. "Sync and Google services" preferences will be populated by subsequent CLs. Bug: 814728 Change-Id: I7662459ef98277e556c1754700d250c8d406e6a8 Reviewed-on: https://chromium-review.googlesource.com/1108214Reviewed-by:
-
Kevin Schoedel authored
Test: manual; unit test TBD Bug: b/73383411 Change-Id: I5b5a65ad85695bcd4d126081f3ce472215e33996 Reviewed-on: https://chromium-review.googlesource.com/1102893Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#569016}
-
Sebastien Marchand authored
Change-Id: Ia760f35e73729b513f8b149b196aef803a7d93bd Reviewed-on: https://chromium-review.googlesource.com/1107303Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#569015}
-
Maria Khomenko authored
We see users turning this on for themselves mistakenly assuming it's a performance optimization. Bug: 854686 Change-Id: Ib3450527509c90711cda952746045c99c6f9738d Reviewed-on: https://chromium-review.googlesource.com/1108441 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#569014}
-
Bret Sepulveda authored
The top chrome height increases when Refresh is enabled, so the insets into the browser window to click on the web content were incorrect. Bug: 846410, 853990 Change-Id: I2f274632ca752d583a8fd0ac21721039c3cc8c1b Reviewed-on: https://chromium-review.googlesource.com/1107272 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#569013}
-
Tomasz Śniatowski authored
As a side effect of the tracing cleanups in https://crrev.com/c/1015647, setting a custom startup trace file via --trace-startup-file stopped working on Android. Fix by not hardcoding the call to generate a path, so the switch is checked first. Bug: 828993 Change-Id: Ifcfd0dc2ea41b09af0c409ba5d406eda5d920b8b Reviewed-on: https://chromium-review.googlesource.com/1097326Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Add passing of GAIA ID from the login screen JS code to the C++ handler, in addition to passing the user e-mail. This will allow to build AccountId instance for the user in question in a more reliable way. This CL should bring no change of behavior - logic for the passwordless ("challenge-response") logins is yet to be implemented. BUG=chromium:826417 TEST=existing tests (no change of behavior is introduced) Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I64a29ba845543644626fb972129c0b6376c3de2b Reviewed-on: https://chromium-review.googlesource.com/1107059Reviewed-by: -
Bret Sepulveda authored
There is a DCHECK that triggers in cc::Layer when running the test. This patch disables the tests temporarily so the feature can be turned on by default. We will follow up before launch. Bug: 853990 Change-Id: I6033d49b11ab341079152ca876d198fc7cdfd84a Reviewed-on: https://chromium-review.googlesource.com/1105503 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Francois Doray authored
When a PENDING_DISCARD TabLifecycleUnit is focused, its state is transitioned to PENDING_FREEZE, to indicate that the renderer is processing a freeze request, but that no discard should happen when it's done. With this CL, we also stop the freeze timer to ensure that FinishDiscard() isn't called when the renderer tells the browser that the freeze request has been processed. Bug: 854720 Change-Id: Iea98644ea1e9b056eb05bbf5ae6da870c324064c Reviewed-on: https://chromium-review.googlesource.com/1108376Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#569009}
-
Scott Little authored
This CL makes Blink record histograms to measure how often LazyLoad decides to immediately load a cross-origin iframe instead of deferring it, or if the iframe is deferred, how often that iframe is later loaded or seen by the user. This will help with tuning the distance-from-viewport threshold for determining how far down the page a lazy loaded frame should start loading. Since different distance-from-viewport thresholds will be used for different effective connection types, separate counts for these histograms are recorded for different effective connection types. Bug: 854040 Change-Id: Ied135413bb16770aeb22a304c312b8cc01df88b4 Reviewed-on: https://chromium-review.googlesource.com/1105606Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#569008}
-
David Grogan authored
This reverts commit e2cac39f. Reason for revert: https://crbug.com/854785 (CrSettingsSiteEntryTest.All failing on chromium.mac/Mac10.13 Tests (dbg)) TypeError: this.$.menu.getIfExists is not a function at HTMLElement.getOverflowMenu_ (chrome://settings/site_settings/site_entry.js:115:65) at Context.<anonymous> (file:///b/s/w/ir/chrome/test/data/webui/settings/site_entry_tests.js:136:25) ", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48) Original change's description: > Settings: Content settings can now be reset for a group of origins in All Sites. > > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow > menu allows the entire list of origins to have all their content settings reset > in one go. This will be preceded with a confirmation dialog. > > Manual test - With #enable-site-settings turned on, change a content setting via > Page Info > Site settings on both https://permission.site and > http://permission.site. Navigate to chrome://settings/content/all and see that > both sites are listed under 'permission.site'. Verify there is an overflow menu > on this entry and that inside the overflow menu, there is a 'Reset permissions' > option. Clicking this should bring up a reset permission dialog and confirming > the dialog should remove this entry from All Sites. > > Bug: 835712, 717468 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 > Reviewed-on: https://chromium-review.googlesource.com/1098577 > Commit-Queue: Patti <patricialor@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568742} TBR=dschuyler@chromium.org,patricialor@chromium.org Change-Id: I227ad85a38a66a6f571dab6aabfdfb5211580280 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835712, 717468, 854785 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1108777Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569007}
-
Patrick Monette authored
Also keep track of the status of the ModuleListFilter initialization, which will be used later to display the state of the third-party blocking subsystem to the user. Bug: 847544 Change-Id: I354253ec05012f50fa4418ef1c69113844c3c2ac Reviewed-on: https://chromium-review.googlesource.com/1097626 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#569006}
-
Daniele Castagna authored
Change-Id: I4c6ddc1466ff8736272591cf05236f3bb939b6fc Reviewed-on: https://chromium-review.googlesource.com/1108521Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#569005}
-
Matt Menke authored
This will cause histogram will be collected both when the network service is enabled, and when it's not. Also update LayeredNetworkDelegate::OnCompletedInternal to pass in the net_error. Bug: 853211 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8294b26b9cbe031cdb54adf7fc752c6717605b95 Reviewed-on: https://chromium-review.googlesource.com/1108083Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569004}
-
