GitLab

This property is unused and unnecessary.

BUG=648498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2555373006
Cr-Commit-Position: refs/heads/master@{#437587}

In particular, check the cases of async URLRequest::Read successes.

Also add ResourceHandler re-entrancy checks to TestResourceHandler,
which the current API is designed to avoid.

Review-Url: https://codereview.chromium.org/2552463002
Cr-Commit-Position: refs/heads/master@{#437586}

BUG=669668
TEST=ScrollbarAnimationControllerThinningTest.DontFadeAfterReleasedNear,
ScrollbarAnimationControllerThinningTest.FadeAfterReleasedFar,
ScrollbarAnimationControllerThinningTest.MoveNearAndDontFadeOut,
ScrollbarAnimationControllerThinningTest.MoveOverAndDontFadeOut
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2552813002
Cr-Commit-Position: refs/heads/master@{#437585}

This change has the browser controls depend on the window viewport
rather than the visible viewport when drawing. This allows for the
math to be consistent across layouts that use the controls and
fixes the toolbar swipe layout.

To facilitate this, the SceneOverlay interface was updated to
include the window and visible viewports when updating their
respective SceneLayers.

BUG=652892

Review-Url: https://codereview.chromium.org/2542883004
Cr-Commit-Position: refs/heads/master@{#437584}

BUG=none
TBR=ben@ for content/renderer

Review-Url: https://codereview.chromium.org/2559343003
Cr-Commit-Position: refs/heads/master@{#437583}

BUG=672602

Review-Url: https://codereview.chromium.org/2567473003
Cr-Commit-Position: refs/heads/master@{#437582}

The workaround in that class to watch DidStartNavigationToPendingEntry is only for the non-PlzNavigate case, since with PlzNavigate all navigations happen in the browser.

This fixes
PredictorBrowserTest.RendererInitiatedNavigationPreconnect
with PlzNavigate.

BUG=504347

Review-Url: https://codereview.chromium.org/2559203003
Cr-Commit-Position: refs/heads/master@{#437581}

Revert of Cleanup sign checking in safe math code (patchset #1 id:1 of https://codereview.chromium.org/2564493003/ )

Reason for revert:
This change was not a performance improvement.

Original issue's description:
> Cleanup sign checking in safe math code
>
> Signed comparison is less code and matches the optimal compiler
> heuristics better than masking.
>
> TBR=scottmg
> NOTRY=true
>
> Committed: https://crrev.com/99bfa52d9dea53984ae4da5ee44eff0002928453
> Cr-Commit-Position: refs/heads/master@{#437342}

TBR=scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2563003003
Cr-Commit-Position: refs/heads/master@{#437580}

Revert of Remove bad comment in HasSignBit (patchset #1 id:1 of https://codereview.chromium.org/2562643005/ )

Reason for revert:
The original change was not actually a performance improvement.

Original issue's description:
> Remove bad comment in HasSignBit
>
> Remove a bad comment left behind from crrev.com/437342
> TBR=scottmg
> R=scottmg
> NOTRY=true
>
> Committed: https://crrev.com/6b15c686879f6747935a517f74f579f7ae46d797
> Cr-Commit-Position: refs/heads/master@{#437416}

TBR=scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2559183004
Cr-Commit-Position: refs/heads/master@{#437579}

The fullscreen manager can be null in cases where a different
activity is showing. This CL adds a check to make sure it is there
before using it.

BUG=672730, 670459

Review-Url: https://codereview.chromium.org/2557403004
Cr-Commit-Position: refs/heads/master@{#437578}

This was causing different versions of Java JVM other than user's
default.

BUG=669999

Review-Url: https://codereview.chromium.org/2558183002
Cr-Commit-Position: refs/heads/master@{#437577}

This will allow us to get server-side suggestions on the local NTP.

BUG=514752
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2532103002
Cr-Commit-Position: refs/heads/master@{#437576}

Moves include of ojbc_property_releaser to the implementation file to
allow this to be included from ARC code.
Also moves ivars to the implementation file, per style guide.

BUG=672510
TEST=None

Review-Url: https://codereview.chromium.org/2561133002
Cr-Commit-Position: refs/heads/master@{#437575}

BUG=613123

Review-Url: https://codereview.chromium.org/2554403004
Cr-Commit-Position: refs/heads/master@{#437574}

After this CL Physical Web suggestions on the NTP can be dismissed.
The list is stored in prefs. It is pruned on fetches and when URL is
lost.

BUG=667766

Review-Url: https://codereview.chromium.org/2560783002
Cr-Commit-Position: refs/heads/master@{#437573}

Revert of Change ExecLinkWrapper to not buffer all tool output (patchset #2 id:20001 of https://codereview.chromium.org/2558153002/ )

Reason for revert:
Reverting under suspicion for crbug.com/672841.

Original issue's description:
> Change ExecLinkWrapper to not buffer all tool output
>
> /verbose linking of chrome.dll creates over one GB of output. This
> causes ExecLinkWrapper to consume over two GB of memory which leads to
> an OOM failure in the 32-bit depot_tools python, and the loss of all
> of the valuable output. This change modifies ExecLinkWrapper to
> process the output one line at a time, thus avoiding the OOM.
>
> I've tested that this handles the 1.1 GB of output which the previous
> version of this function failed on and I've visually confirmed that the
> output looks the same - no extraneous blank lines, for instance, when
> displaying warnings, errors, or 1.9 million lines of verbose output.
>
> I also verified that the script stays idle when waiting for output -
> blocking on .readline().
>
> BUG=672182
>
> Committed: https://crrev.com/5d0d1b0bf01acb3ebe3a5ef27ebf2f3180ab1d1d
> Cr-Commit-Position: refs/heads/master@{#437126}

TBR=brucedawson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=672182

Review-Url: https://codereview.chromium.org/2564893002
Cr-Commit-Position: refs/heads/master@{#437572}

Moves the focus to the expiration year field when the expiration month
field gets filled with a second character and move the focus to the
cvc input field when the expiration year field gets filled with a
second character.

Also adds more detailed error messages for invalid expiration month and
year.

BUG=671762

Review-Url: https://codereview.chromium.org/2557873002
Cr-Commit-Position: refs/heads/master@{#437571}

Revert of Mark virtual/android/media/mediadocument/media-document-with-download-button.html as flaky (patchset #1 id:1 of https://codereview.chromium.org/2560033003/ )

Reason for revert:
The issue had just been fixed by https://codereview.chromium.org/2555373005 before this marking.

Original issue's description:
> Mark virtual/android/media/mediadocument/media-document-with-download-button.html as flaky
>
> BUG=672696, 672371
> NOTRY=true
> TBR=asargent@chromium.org, grt@chromium.org, vasilii@chromium.org
>
> Committed: https://crrev.com/f26da5af712a45c4ee62d79e6da2530a591ce987
> Cr-Commit-Position: refs/heads/master@{#437466}

TBR=asargent@chromium.org,grt@chromium.org,vasilii@chromium.org,yhirano@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672696, 672371

Review-Url: https://codereview.chromium.org/2564623005
Cr-Commit-Position: refs/heads/master@{#437570}

- Follow up to http://crrev.com/2549443003
- Move RequestAnimationFrameCallback and AnimationComplete class
  definitions to .cpp file
- Prefix enums with k
- Change direction() and behavior() to getDirection() and getBehavior()
  respectively
- Use case insensitive match for direction and behavior
- Remove trueSpeed()
- Use String::numberToStringECMAScript to convert double to String instead of using String::format which is locale sensitive

BUG=669656

Review-Url: https://codereview.chromium.org/2554403002
Cr-Commit-Position: refs/heads/master@{#437569}

For example if we have "http://example.com/" and "http://example.com",
then their paths should match.

BUG=647588

Review-Url: https://codereview.chromium.org/2550093005
Cr-Commit-Position: refs/heads/master@{#437568}

BUG=672676

Review-Url: https://codereview.chromium.org/2557743008
Cr-Commit-Position: refs/heads/master@{#437567}

https://skia.googlesource.com/skia.git/+log/a129dfef2aaa..4993b95f532f

$ git log a129dfef2..4993b95f5 --date=short --no-merges --format='%ad %ae %s'
2016-12-08 scroggo Do not create SkGifCodec if true size is not known
2016-12-09 robertphillips Revert "Revert "Add antialiasing to SkDropShadowImageFilter's shadow draw""
2016-12-09 reed Revert[2] "remove SK_SUPPORT_LEGACY_CLIP_REGIONOPS"
2016-12-09 mtklein Roll GN

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2555103008
Cr-Commit-Position: refs/heads/master@{#437566}

Review-Url: https://codereview.chromium.org/2562883002
Cr-Commit-Position: refs/heads/master@{#437565}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/666ab2c..f23e926

$ git log 666ab2c..f23e926 --date=short --no-merges --format=%ad %ae %s
2016-12-09 pbos@webrtc.org Remove extra uses of basictypes.h.
2016-12-09 brandtr@webrtc.org Only store sequence numbers for media stream in FlexFEC end-to-end test.
2016-12-09 kthelgason@webrtc.org Disable failing perf test on Android.
2016-12-09 minyue@webrtc.org Modify JavaToStdString to allow ISO-8859-1 encoded strings.
2016-12-09 terelius@webrtc.org Implement Theil-Sen's method for fitting a line to noisy data (used in bandwidth estimation).
2016-12-09 hbos@webrtc.org RTCInboundRTPStreamStats.packetsLost set by RTCStatsCollector.
2016-12-09 hbos@webrtc.org RTCIceCandidatePairStats.requestsReceived defined by RTCStatsCollector.
2016-12-09 kthelgason@webrtc.org Reland of Bump up scaling limit for MediaCodec. (patchset #1 id:1 of https://codereview.webrtc.org/2562963002/ )
2016-12-09 peah@webrtc.org During AEC development, it is handy to be able to simulate different orders of the ProcessStream and ProcessReverseStream API calls.
2016-12-09 peah@webrtc.org When recreating a call based on an aecdump recording the nearend used is the one stored in the aecdump.
2016-12-09 asapersson@webrtc.org Revert of Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabl… (patchset #1 id:40001 of https://codereview.webrtc.org/2532053002/ )
2016-12-09 kthelgason@webrtc.org Revert of Bump up scaling limit for MediaCodec. (patchset #3 id:40001 of https://codereview.webrtc.org/2566533002/ )
2016-12-09 kthelgason@webrtc.org Bump up scaling limit for MediaCodec.
2016-12-08 stefan@webrtc.org Fix issue with deprecated CongestionController interface not working.
2016-12-08 zijiehe@chromium.org Enable screen capturer tests for Linux / DirectX capturer / magnifier capturer
2016-12-08 ehmaldonado@webrtc.org Refactor webrtc/modules/video_{capture,coding} for GN check
2016-12-08 brandtr@webrtc.org Rename RtpStreamReceiver::IsFecEnabled to RtpStreamReceiver::IsUlpfecEnabled.
2016-12-08 asapersson@webrtc.org Do not update OnReceivedRtcpReceiverReport if report block list is empty (and rtt zero).
2016-12-08 kthelgason@webrtc.org Reland of Add ability to scale to arbitrary factors (patchset #1 id:1 of https://codereview.webrtc.org/2557323002/ )
2016-12-08 nisse@webrtc.org Delete deprecated CongestionController constructor and packet_router method.
2016-12-08 kjellander@webrtc.org Re-enable disabled VideoProcessorIntegrationTest tests
2016-12-08 brandtr@webrtc.org Add FlexFEC settings toggle in Android AppRTCMobile.
2016-12-08 nisse@webrtc.org Simplify an always true condition.
2016-12-08 sakal@webrtc.org Fix error in VideoFileRenderer_nativeI420Scale.
2016-12-08 brandtr@webrtc.org Generalize FlexfecReceiveStream::Config.
2016-12-08 brandtr@webrtc.org Clean up FlexfecReceiveStream ctor signatures.
2016-12-08 ehmaldonado@webrtc.org Refactor webrtc/modules/audio_processing for GN check
2016-12-08 johan@webrtc.org Decode h264 fmtp sprop-parameter-sets to binary.
2016-12-08 aleloi@webrtc.org Injectable output rate calculater for AudioMixer.
2016-12-08 asapersson@webrtc.org Remove unused arguments and variable in MediaOptimization.
2016-12-08 kthelgason@webrtc.org Revert of Add ability to scale to arbitrary factors (patchset #7 id:120001 of https://codereview.webrtc.org/2555483005/ )
2016-12-08 kthelgason@webrtc.org Add ability to scale to arbitrary factors
2016-12-08 hta@webrtc.org Refactoring: Declare cricket::Codec constructors protected.
2016-12-08 magjed@webrtc.org Android classreferenceholder.h: Reorder function declaration keywords
2016-12-07 zijiehe@chromium.org Log BitBlt failure
2016-12-07 zhihuang@webrtc.org Create the Java Wrapper of RtpReceiverObserverInterface.
2016-12-07 kjellander@webrtc.org Refactor webrtc/{api,audio} and modules/audio_coding for GN check
2016-12-07 ossu@webrtc.org Moved call.h and most of api/call/* into call/
2016-12-07 ehmaldonado@webrtc.org Clean up redundant include of ../webrtc_overrides
2016-12-07 minyue@webrtc.org Adding OnReceivedOverhead to AudioEncoder.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2567643002
Cr-Commit-Position: refs/heads/master@{#437564}

between warning label and Discard button on download shelf.

Note, this bug has been there for more than 3 years. The string
change in crrev.com/2443343002 exposed this issue. The reason this bug
was only reproducible on Win is because Win's font is narrower than
other OSs' (a.k.a label with the same text on Win yields a smaller width)

BUG=668472

Review-Url: https://codereview.chromium.org/2556573002
Cr-Commit-Position: refs/heads/master@{#437563}

https://pdfium.googlesource.com/pdfium.git/+log/1babeeed9c25..6814f49aa839

$ git log 1babeeed9..6814f49aa --date=short --no-merges --format='%ad %ae %s'
2016-12-09 caryclark update to latest skia api

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2563063002
Cr-Commit-Position: refs/heads/master@{#437562}

BUG=672477

Review-Url: https://codereview.chromium.org/2556253006
Cr-Commit-Position: refs/heads/master@{#437561}

Using update-w3c-deps in Chromium 5fe2c203.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7823

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2564853002
Cr-Commit-Position: refs/heads/master@{#437560}

BUG=

Review-Url: https://codereview.chromium.org/2558083004
Cr-Commit-Position: refs/heads/master@{#437559}

As falken's comment, this cl is splitted from https://codereview.chromium.org/2516353002.

https://codereview.chromium.org/2516353002/diff/140001/content/browser/cache_storage/cache_storage_cache.cc#newcode1407

BUG=658249

Review-Url: https://codereview.chromium.org/2561203003
Cr-Commit-Position: refs/heads/master@{#437558}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/167cbe51..ce8eb03c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2565763003
Cr-Commit-Position: refs/heads/master@{#437557}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/animation/.
There are too many references to change them all at once, so this CL is
part 2 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2562773002
Cr-Commit-Position: refs/heads/master@{#437556}

https://codereview.chromium.org/2516353002/ introduces URL list of Response.
Response.redirected returns true when the size of the list is larger than 1.

BUG=658249

Review-Url: https://codereview.chromium.org/2524703002
Cr-Commit-Position: refs/heads/master@{#437555}

BUG=618305
R=haraken@chromium.org, jochen@chromium.org, yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2439013002 .
Cr-Commit-Position: refs/heads/master@{#437554}

Several tests are flaking on Android swarming bots as they rely on the
system time being correct. Disabling them until we can remove the
dependency on the system clock.

BUG=672294,672843
TBR=asargent@chromium.org

Review-Url: https://codereview.chromium.org/2564873002
Cr-Commit-Position: refs/heads/master@{#437553}

This function will check pins against user policies. Currently the checking logic is in javascript code, but we want to move it to C++.

BUG=612271
TEST=unit_tests --gtest_filter="QuickUnlockPrivateUnitTest.*"

Review-Url: https://codereview.chromium.org/2374303002
Cr-Commit-Position: refs/heads/master@{#437552}

The generation of PkgInfo is disabled for the moment (as come target
downstream already pack a PkgInfo file and enabling the target would
cause a non-deterministic build) and can be enabled by an undocumented
parameter write_pkg_info.

Update build/config/mac/write_pkg_info.py to support loading plist
in any format, not only xml1.

BUG=672516

Review-Url: https://codereview.chromium.org/2559323005
Cr-Commit-Position: refs/heads/master@{#437551}

This cl introduces a SensorDeviceManager for Linux and ChromeOS platforms.

Manager:
1) PlatformSensorProviderLinux owns a SensorDeviceManager that uses
DeviceMonitorLinux to enumerate iio devices and get removed/add udev
events. Once device is enumerated, added or removed, it is identified
and all the necessary information is put to SensorInfoLinux structure
and passed to the provider. If there is no such a device, it is added
to cache. In case of removal, manager checks if there was such a device
and updates it's cache accordingly + notifies the provider about a
removed device, which update own cache.
2) Requests: when a request for a sensor comes, it can be processed
immediately or asynchronously once service is up and running.

Reader:
1) There will be two strategies for a reader. At the moment
only polling read is supported.
2) The reader doesn't search for sensor files any more, those are passed
to it in SensorInfoLinux structure.

Unittests:
1) In order to make it possible to test the whole path, I've made
SensorDeviceManager's methods virtual, which allowed me to
mock and override them.
2) Unittests implement own udev methods that just read values from
files. If read is successful, the manager adds this type of sensor
associated with the files that have been read to it's cache and notifies
the provider.

BUG=606766

Review-Url: https://codereview.chromium.org/2533793002
Cr-Commit-Position: refs/heads/master@{#437550}

R=ajuma
BUG=672077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2555283002
Cr-Commit-Position: refs/heads/master@{#437549}

This should greatly mitigate a current bug in the BattOr firmware where
sending the command to start tracing causes the BattOr to reset. In this
case, we now retry the full initialization sequence. Because the error
we're hitting is a timeout, and we allow 4 seconds for a command to
be executed before timing out, this means that initialization will
retry after 4 seconds and then make 20 attempts to initialize the BattOr
100 milliseconds apart from each other, making the whole sequence take
something like 6 additional seconds. We can retry this full sequence
up to 5 times. When added to the five or so seconds that the BattOr
already takes to initialize, this means that this full sequence might
take up to 11 * 5 = 55 seconds before deciding that the BattOr can't
be initialized. In practice, I suspect that almost all initializations
will succeed on either their first or second attempts.

BUG=672631

Review-Url: https://codereview.chromium.org/2563033002
Cr-Commit-Position: refs/heads/master@{#437548}