- 27 Aug, 2019 40 commits
-
-
David Black authored
Per feedback from UX, the proactive suggestions window animation should be 350ms in duration with a cubic bezier tween. Bug: b:139199754 Change-Id: I9d5cc06cd441c9cedbe60066a364d09c7b005a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773840Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#690938}
-
Peter Boström authored
Prevents activating the grouping border stroke when a user hovers the main item. This is currently either extensions' puzzle icon or the avatar icon, neither of which need to communicate which group of icons they belong to. Bug: chromium:993105 Change-Id: Iedcb82865517504efb452f00680fe50833a8b9b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773726 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#690937}
-
Sophie Yang authored
Removed duplicate variable menuOriginNode that likely appeared after a merge. Bug: 982004 Change-Id: I857049cda8387b9e5d40189d1ed9afec49156e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773213Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Sophie Yang <sophyang@google.com> Cr-Commit-Position: refs/heads/master@{#690936}
-
Becca Hughes authored
Add rounded artwork corners as per spec. There is a screenshot of the implementation in the bug. BUG=998314 Change-Id: I8e92628693c64618628d05b064a5a46027fbeee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772380 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#690935}
-
Avi Drissman authored
There have been no scrollbar buttons since 10.7. The code handling them on the renderer side is long-gone; remove the code from the browser side. Do mild other cleanup while we're here. BUG=997934 Change-Id: Ia217b4de1b0451e3aff738a0e4c3f1db7526b6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773162 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#690934}
-
Jinsuk Kim authored
Adjusts the offset of the bottom sheet so that it appears as expected when the omnibox control is not on screen. This CL fixes the issue by overriding BottomSheetContent.onHideScroll so the browser controls won't have an effect on NavigationSHeet. Bug: 996535 Change-Id: I32d5a1a15d5a7275ce0fdba1a86e7dd82a570086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767283Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#690933}
-
Kent Tamura authored
This CL reduces pre-processed size of foo.mojom(-blink)-forward.h including interfaces or structs significantly. For example, file_chooser.mojom-blink-forward.h: 1.66MB => 0.004MB * mojo/public/cpp/bindings/*_forward.h New files. They contain some forward declarations for mojo/public/cpp/bindings/. * mojo/public/tools/bindings/generators/cpp_templates/module-forward.h.tmpl Include only *_forward.h and native_struct.mojom-forward.h. native_struct.mojom-forward.h is necessary for [native] structs. * ipc/message_view.{h,cc} Move TakeHandles() implementation to message_view.cc in order to avoid instantiation of mojo::StructPtr<> in the header. * Other files Add #includes or forward declarations which were included indirectly from mojo headers. Change-Id: I08ac30fc40cb7af4ce248e8e9b5b1ff4fb55ed68 Bug: 862064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768608Reviewed-by:Ken Rockot <rockot@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#690932}
-
Ahmed Fakhry authored
Rounding the corners of the desk mini_views' contents was apprently forgotten. This CL adds it. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=998235#c3 TBR=sammiequon@chromium.org BUG=998235 TEST=Manually Change-Id: Ia7a43201dcaeb635fe9182071f7befb4406cca35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773871Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#690931}
-
Ben Pastene authored
This'll add a click-able "clang" link to build.chromium.org that'll take you to ci.chromium.org/p/chromium/g/chromium.clang. Change-Id: Ic66d522f1d3392ecd66e17f92c5275569b0ec744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773839 Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#690930}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: I0946a7776862e67d81929e91dcf84dbdf1768172 Bug: 242216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773018Reviewed-by:
-
Sophie Chang authored
This implementation consults the OptimizationGuideKeyedService to make decisions for whether an optimization type can be applied for a navigation. The code path introduced here will only be used if the OptimizationGuideKeyedService feature flag is enabled. Although the internal decision made by the OptimizationGuideKeyedService incorporates the max ECT trigger for the hint, the ultimate decision for when to apply based on ECT is still made by Previews code. (i.e. even if the OGKS says LitePageRedirect can be applied when the ECT is 3G, LPR will still only apply on 2G and below in this current state) This also includes browser test changes that ensure that Previews logic is still maintained in both the original code path and the new one backed by the OptimizationGuideKeyedService introduced in this CL. Bug: 969558 Change-Id: I65d4678e0a200950bbb749461252e200f8b44d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771134Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#690928}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ce0eecb10b14..aea4bca2621b git log ce0eecb10b14..aea4bca2621b --date=short --no-merges --format='%ad %ae %s' 2019-08-27 thestig@chromium.org Prevent another integer overflow in AGG. 2019-08-27 thestig@chromium.org Roll build/ 315a0c669..e7232efeb (1 commit) 2019-08-27 thestig@chromium.org Remove a memset() in CFDE_TextEditEngine::RebuildPieces(). 2019-08-27 thestig@chromium.org Reformat listbox_form.in to be more consistent with other .in files. 2019-08-27 thestig@chromium.org Redo a UBSAN fix in AGG. 2019-08-26 thestig@chromium.org Roll third_party/freetype/src/ 7d1d3b9a0..9adc3b35f (1 commit) 2019-08-26 thestig@chromium.org Roll third_party/freetype/src/ 12af46b64..7d1d3b9a0 (3 commits) Created with: gclient setdep -r src/third_party/pdfium@aea4bca2621b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:997021 Change-Id: Ieff2f4f2754be5d200e739a456c5d4f91668c8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769689Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690927}
-
Dana Fried authored
In a number of cases we want to delay an action until after an animation completes, e.g. showing a bubble that will be anchored to a view that will be moving or appearing as part of the animation. Prerequisite for a number of things we want to do with the new extensions area and identity chip. Change-Id: Ifa2ca7d0b993cc545b786ab472d5a5f42b23ce60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773721 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
-
Sophie Chang authored
The refactor of the hints manager unittest and metrics recording is not strictly required but done in the below CL: https://chromium-review.googlesource.com/c/chromium/src/+/1762982 This is mostly to reduce the amount of merge conflicts I will get Bug: 969558 Change-Id: I49d7afc1a977bc2111dedc48fdd5cf5e3c022184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772476 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
-
Jun Cai authored
If the soft input keyboard is open and focused on the OTP/code field when the SMS arrives, the keyboard is dismissed. Bug: 997025 Change-Id: Ibadd3febb4696ccfd600971538926ed667ce1bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768995Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#690924}
-
Karen Qian authored
Added comment and set linux-rel as 100% experimental in the new config group. Bug: 922150 Change-Id: I67e85580e8a43567d2189ee1cbaf578769065b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769693 Commit-Queue: Karen Qian <karenqian@google.com> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#690923}
-
Christopher Cameron authored
The next steps here will be to allow the AppShimHost to be owned either by the ProfileState (non-multi-profile-mode) or the AppState (multi- profile mode). Bug: 982024 Change-Id: Idbc2de4927895800a79e6300a6dbf24fc3ff652e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771945Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#690922}
-
James Cook authored
The test failures were caused by a real bug. For the set-time-dialog element, the keys of the prevValues_ object are HTML element IDs ("dateInput" and "timeInput"), not "date" and "time". I broke this when I changed the element IDs during the Material Design conversion of this dialog in March 2019. The failures were flaky because we didn't have an explicit test for reverting the input elements to their previous values. The occasional failures we say were due to element blur() events during test teardown that apparently depend on timing. Fix the bug and add an explicit test for reverting values. Bug: 996000 Test: browser_tests Change-Id: Ic0a286858e0563d32351da06536c881e541b1273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773541 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by: -
Brian Sheedy authored
Adds a temporary sleep to testConsentPersistsLowerLevel and testConsentPersistsSameLevel to see if it fixes failures on P. TBR=alcooper@chromium.org Bug: 998307 Change-Id: I56183327330ad2c027c5c01afecd3e53e6c7c102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773898Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#690920}
-
Jinsuk Kim authored
Makes the "Close [Chrome]" text blue when it appears on the last page navigation. Bug: 979498 Change-Id: I89f63e56b32ac4c6c3e157b5cbcab858081716b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768804Reviewed-by:
-
Andrew Xu authored
In this CL, ScrollArrowView inherits the ShelfButton. It improves the code readability and also makes Shelf code coherent: in current code base all of buttons in Shelf are ShelfButtons. Bug: 973481 Change-Id: I73aab558948b4ef32f79fa6e4ce243e9eba269a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772293Reviewed-by:
-
Evan Stade authored
In these files, it was being used to clear notification registrations to fix http://crbug.com/125276 In NetworkStateInformer, it was doing nothing except removing its own registration. In SignInScreenController, the referenced UI object is owned, and therefore can't have been freed, so the precaution was no longer necessary. In ExistingUserController, we can replace with a check to IsSessionStarted before handling NOTIFICATION_AUTH_SUPPLIED. I don't understand why this code lives in ExistingUserController to begin with, and there's a TODO/bug to rework the bodge, but this should preserve behavior. Bug: 268984 Change-Id: I219b69997e4873ed60695442a757bd8d549dc00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771614 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Peter Kasting authored
See bug comments 16/17 or comments in the code for description. The algorithm here is O(n) in at most two passes over the input string, not counting the StripJavascripSchemas() call. Bug: 764512 Change-Id: I12123b40fc6c91f10d927fd34b368aa16c0310c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766890 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#690916}
-
Angel Alvarez authored
Adds logic to compute the contents digest of generated MHTML files, when requested via the generation input parameters. A new MHTML generation method is added to WebContents, but it will be merged into the existing one in a follow up CL. Also updates tests to verify the correctness of the digest computation. This is based off a change by mtlieuu@: https://crrev.com/c/1552118 Bug: 915966 Change-Id: I816940a307018255f31d1aea0a66a729cbec77ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754125 Commit-Queue: Angel Alvarez <angelii@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#690915}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/14a9be448e01..886698bc3fdd git log 14a9be448e01..886698bc3fdd --date=short --no-merges --format='%ad %ae %s' 2019-08-27 jmadill@chromium.org Vulkan: Style cleanups to TextureVk. 2019-08-27 jmadill@chromium.org Vulkan: Remove command buffer param from initImage. Created with: gclient setdep -r src/third_party/angle@886698bc3fdd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: I3d5c608e3a5bbac740483225ee2ad181d6e3836e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772330Reviewed-by:
-
Torne (Richard Coles) authored
Anywhere we call getSharedPreferences might be a disk write as the directory for prefs is created if it doesn't already exist; move the existing StrictModeContext in AwGeolocationPermissions up to the caller to also cover where the SharedPreferences object is retrieved, and add another missing one when the browser context is created. Bug: 994321 Change-Id: I2e18e156d378910751ee2a530d72180eab012696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773781Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#690913}
-
Steven Bennetts authored
"Start activate" in the internet settings UI simply opens a new dialog with the activation UI. This should not be part of the network config API. Bug: 853953 Change-Id: Ia4c72df1aad547991ab775ebf4c158827382da8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769633 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690912}
-
Mike Frysinger authored
The required behavior of argparse subparsers changed in Python 3. Add some code that works in Python 2 & Python 3 to retain the old behavior. Bug: 983071 Test: `./pak_util.py` doesn't crash under Python 3 Change-Id: I6820c65e365da662633a2eb4386e4077fedd3174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771983Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#690911}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/59099ed6ee31..217195ca2ce8 git log 59099ed6ee31..217195ca2ce8 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@217195ca2ce8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Icd61b738e1b1177962845b34429456f3e27145ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773716Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/db16ee85fb52..c9fdf2610a1d git log db16ee85fb52..c9fdf2610a1d --date=short --no-merges --format='%ad %ae %s' 2019-08-27 crouleau@chromium.org [Telemetry, typ] Add Rakib as OWNER. 2019-08-27 crouleau@chromium.org [tracing] Replace crouleau@ with perezju@ for owning TBMv2 and tracing tooling. Created with: gclient setdep -r src/third_party/catapult@c9fdf2610a1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:973936,chromium:997370 Change-Id: I122be6d5ed9c3f1b8aaecf7dc729cedd81343303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773329Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/51ed66b5cadd..cde5dea64717 git log 51ed66b5cadd..cde5dea64717 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 pprabhu@chromium.org cbuildbot: Do not set quota_account for moblab requests Created with: gclient setdep -r src/third_party/chromite@cde5dea64717 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic26516ff882b37dbb12145c36896519ec1ec5180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773328Reviewed-by:
-
David Black authored
Entry animation: Translate up from offscreen. Exit animation: Fade out. See bug for demo. Bug: b:139199754 Change-Id: Ib32f3bf0eaf19577cd1da2e9e28285a4d96bec53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769841Reviewed-by:
-
gogerald authored
Screenshot before: https://drive.google.com/file/d/12NZSwfUUEGC9dXSIEoSUB3mlMmjDmwtE/view?usp=sharing after: https://drive.google.com/file/d/1oHZ21pwrplRsKy8mzX0jDBKkmOaDPka8/view?usp=sharing Bug: 982018 Change-Id: Ib2cffd89fd1a8fc319e65e2cf70e32442fd9b072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769355 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690906}
-
Eric Willigers authored
Tests for scroll-padding-inline-start, scroll-padding-block-start, scroll-padding-inline-end, scroll-padding-block-end now appear together. Tests for scroll-margin-block-start, scroll-margin-inline-start, scroll-margin-block-end, scroll-margin-inline-end now appear together. Added tests that calc(auto) is rejected. Change-Id: I06759db50dd21e2654df494255a4e41233cdcae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771486 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#690905}
-
Haines Sy authored
Add a basic FakeComponentContext implementation of ConnectToAgentService to be used for Unit Testing. Bug: b/139953375 Change-Id: I68fa278c5fb287eda691ab30ca21fa6381b93717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770955 Commit-Queue: Haines Sy <hainesy@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#690904}
-
Bettina authored
Bug: 996380 Change-Id: I57e49cad315fb038ef4b9dfb71293f49f64c749f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769728 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#690903}
-
Scott Violet authored
Plumbs through the Profile/BrowserController and the start of NavigationController as discussed. The pattern is classes in weblayer/public/java/org/chromium/weblayer trivially calls through to classes in weblayer/browser/android/java/org/chromium/weblayer_private/ . Eventually the calls will be over AIDL. I also introduced a WebLayer java class for one time initialization. This isn't perfect, but a good start. BUG=none TEST=none Change-Id: Ie14cdb3d8a63624fb23c37dbc6187f100b5f20ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772443Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#690902}
-
Lei Zhang authored
Change it to return base::Optional<PP_PrivateAccessibilityTextRunInfo>, instead of returning the individual elements of PP_PrivateAccessibilityTextRunInfo as out parameters. Update the caller of GetTextRunInfo() to std::move() the text run into the vector that holds all the text runs, and simplify calculations for char indices in the caller. Change-Id: I719119935ea201f5aed7d1d41e706831a1696c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769220 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#690901}
-
Chris Mumford authored
r472276 renamed two targets: 1) android_webview_apk ==> webview_instrumentation_apk. 2) android_webview_test_apk ==> webview_instrumentation_test_apk. However, there were two local targets which should have been renamed for consistency, but were not: 1) android_webview_apk_assets ==> webview_instrumentation_apk_assets. 2) android_webview_apk_resources ==> webview_instrumentation_apk_resources. Bug: 701938 Change-Id: I09b7f8109472e5ad0c9c2b5639dbb3e4e656cf74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772691Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#690900}
-
Rakina Zata Amni authored
Move the tests and change them to use the rendersubtree attribute. Note that the SVG test fails because the rendersubtree attribute is only defined on HTML elements. Bug: 991095 Change-Id: I4515d4db3786d7bcd1863e7b5407d88dbbf3c016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773017Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#690899}
-
