GitLab

Bug: 897502
Change-Id: If4e9c315c5742be40764e9a13f0d002acb96a43e
Reviewed-on: https://chromium-review.googlesource.com/c/1305821
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603696}

This way, if a client is too slow we'll inject the next event. I have no
doubt we will need more sophisticated things, but this is a start to ensure
we don't get entirely wedged.

BUG=none
TEST=covered by test

Change-Id: If4c233431be3239476227fc0271a5bc18cfff479
Reviewed-on: https://chromium-review.googlesource.com/c/1303353
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603695}

This reverts commit 86259392.

Reason for revert: Breaks webview https://crbug.com/899656

Original change's description:
> [Android] Remove most resource names in resources.arsc
>
> resource names are stored in the resources.arsc file to allow for
> getIdentifier with the string name of the resource to work. This cl
> obfuscates all of those resources to one name (and thus stored only
> once) for all resources that are not accessed via getIdentifier.
>
> This improves binary size by about 200KB.
>
> Bug: 894208
>
> Change-Id: I28c440c22b90cd045f53017073fdb88c7410d530
> Reviewed-on: https://chromium-review.googlesource.com/c/1265897
> Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603229}

TBR=torne@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,mheikal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Binary-Size: This is a revert. A reland is coming soon (TM).
Bug: 894208
Change-Id: I29e9dc851fcd45e4ad657d055ac2db0514a9563d
Reviewed-on: https://chromium-review.googlesource.com/c/1305693
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603694}

This reverts commit 03b56190.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 603619 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDNiNTYxOTBmZjU1Yjg3NmRjMWI0YTEzOTg5MzAxNTQyNDBhMzE3MAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/44916

Sample Failed Step: network_service_interactive_ui_tests

Sample Flaky Test: NativeWindowOcclusionTrackerTest.SimpleOcclusion

Original change's description:
> Native window occlusion tracking for windows.
> 
> This implements native window occlusion tracking on windows, under flag/experiment control. It uses WinEvent event hooks and EnumWindows to track and calculate occlusion.
> 
> It is not yet hooked up to the code that treats occluded windows differently.
> 
> Bug: 813093
> Change-Id: Ic9b473b8cad38e7b1653566f28917164bc92e21c
> Reviewed-on: https://chromium-review.googlesource.com/c/1140752
> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603619}

Change-Id: Ib25fedcac09b39cda2b5df277febc3cfd12d6eba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 813093, 900025
Reviewed-on: https://chromium-review.googlesource.com/c/1306841
Cr-Commit-Position: refs/heads/master@{#603693}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: I3a5ba338aea36aa40c1d727862996b6706560097
Reviewed-on: https://chromium-review.googlesource.com/c/1303321
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603692}

This reverts commit 9d157bc0.

Reason for revert: New behavior is not good, see bug/thread.

Original change's description:
> Update VolumeController behavior for hardware keys
> 
> Changing behavior as requested, and updating tests:
> 1) The mute button should toggle mute (rename mojo function).
> 2) Volume up/down buttons should adjust up/down normally when muted.
> 3) Volume up/down buttons should also un-mute (if above default mute level).
> 4) Volume down will still mute if the level is below the default mute level.
> 
> Bug: 895550, 895552
> Change-Id: I353ab3124bb0375f109b96841cce6df3c9839388
> Reviewed-on: https://chromium-review.googlesource.com/c/1289990
> Commit-Queue: Michael Wasserman <msw@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601191}

TBR=msw@chromium.org,tsepez@chromium.org,afakhry@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 895550, 895552
Change-Id: I6f4000a832bd0230f4da6a21e40b17b13b3823d2
Reviewed-on: https://chromium-review.googlesource.com/c/1306407Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603691}

This CL checks CENC-v3 instead of CENC-v1. See Bug for more details.

Bug: 899984
Test: Tested manually.
Change-Id: I860ebae0657f76af91e7346524fdbb8b16f42f89
Reviewed-on: https://chromium-review.googlesource.com/c/1306635Reviewed-by: Rintaro Kuroiwa <rkuroiwa@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603690}

This reverts commit 60b53b5d.

Reason for revert: Bot is drained, can re-add to CQ. 

Original change's description:
> Remove win10_chromium_x64_rel_ng from the CQ
> 
> This bot is totally broken at the moment. Remove it so it doesn't block
> CQ.
> 
> TBR=jbudorick
> NOTRY=true
> 
> Bug: 899908
> Change-Id: Ie6eca4c1bf8a67821e5a6570a59255fc6a87f54d
> Reviewed-on: https://chromium-review.googlesource.com/c/1306396
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603611}

TBR=martiniss@chromium.org,jbudorick@chromium.org

Change-Id: I55af5ee2c7d1255f10de817a4f9a548793989a21
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 899908
Reviewed-on: https://chromium-review.googlesource.com/c/1306659Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603689}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bb933756..c3ca4c14

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I809e567e51fdcd9fca2489b355f8eeb8f358f1be
Reviewed-on: https://chromium-review.googlesource.com/c/1306340Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603688}

-Make REVERSE/FORWARD buttons have the same behavior as LEFT/RIGHT buttons.
-The internal part is in eureka-internal/187704

BUG=internal b/71719665

Test=cast movie from Google Play Movie and press the button on the remote.

Change-Id: If9ff5132851df7ac00e81fd5fcca73725b3c0307
Reviewed-on: https://chromium-review.googlesource.com/c/1150804
Commit-Queue: Ziyang Cheng <ziyangch@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603687}

Change-Id: I232f7daffacf8f6d49286336860e4251676a5afb
Reviewed-on: https://chromium-review.googlesource.com/c/1306176Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603686}

https://webrtc.googlesource.com/src.git/+log/a0677d14c17f..c640a936d166


git log a0677d14c17f..c640a936d166 --date=short --no-merges --format='%ad %ae %s'
2018-10-29 titovartem@webrtc.org Fix import of chromium into webrtc.


Created with:
  gclient setdep -r src/third_party/webrtc@c640a936d166

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:NONE
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7fc39910d1e21a75a902a2e802d1bf2143f8e045
Reviewed-on: https://chromium-review.googlesource.com/c/1306217Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603685}

Add a custom view to use when showing a media
notification. At the moment this will just show
and hide the control buttons on hover.

BUG=897836

Change-Id: Ie6335b3fbff55e1f9d588cfbe3e95678fb0b8e1a
Reviewed-on: https://chromium-review.googlesource.com/c/1297246
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603684}

RenderProcessHost::FilterURL performs some security checks whether the
URL coming from the renderer process is a valid one. In some cases it
rewrites the URL to about:blank to avoid committing URL that is not
valid for the renderer process.

This CL adds a #blocked reference fragment to the URL, so it is easier
to spot when this logic has taken effect and distinguish it from regular
navigations to about:blank URLs.

Bug: 866549, 899788
Change-Id: I35052fdec361e18fb081bcae4a19b3bf697d46a7
Reviewed-on: https://chromium-review.googlesource.com/c/1300395Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603683}

https://pdfium.googlesource.com/pdfium.git/+log/ea08d171755b..69066ab61e2f


git log ea08d171755b..69066ab61e2f --date=short --no-merges --format='%ad %ae %s'
2018-10-29 thestig@chromium.org Do bilinear interpolation for "huge" images.


Created with:
  gclient setdep -r src/third_party/pdfium@69066ab61e2f

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:898443
TBR=dsinclair@chromium.org

Change-Id: I34c4086a0d9b8099d765464b4967ec4832da293f
Reviewed-on: https://chromium-review.googlesource.com/c/1306214Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603682}

Bug: various
Change-Id: I794e714d9aaa0c119aa339008379a9c796507d64
Reviewed-on: https://chromium-review.googlesource.com/c/1305881Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603681}

Classes outside of //net should use
Network Quality Tracker instead of
Network Quality Estimator (NQE).

Change-Id: Iaf9d940c862f322f14eacb20391354e5cc7cb9cd
Bug: 878844
Reviewed-on: https://chromium-review.googlesource.com/c/1305203Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603680}

Drag & drop worked with an external mouse but failed on touchpad
devices, specifically Eve and Nocturne.

Touchpads generate ET_SCROLL_FLING_CANCEL events at the start of
a drag. This change has the AutoclickDragEventRewriter ignore
those events, which fixes behavior on the touchpads of nocturne
and eve.

Also resolves a TODO to ensure that drag & drops are completed
rather than leaving the UI in an odd state by not including the
mouse released event.

Finally, logs UMA only once per drag-and-drop.

Bug: 894907
Change-Id: I79cc178e701894881618514a0e3aa585721a2c41
Reviewed-on: https://chromium-review.googlesource.com/c/1306295Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603679}

This changes the type in the .pdl file to binary.
Wire representation remains as is, but now the protocol
layer handles the encoding / decoding into base64,
and we use protocol::Binary instead of std::string.

Relevant prereqs:
Supporting binary in .pdl files:
https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1285695
Rolled into Chromium / v8.

Add protocol::content::Binary to protocol_string{.h,.cc}.
https://chromium-review.googlesource.com/c/chromium/src/+/1280555

Bug: chromium:891377
Change-Id: Ifc38332ce49c12bb1082ee165de04caa18a7f1ae
Reviewed-on: https://chromium-review.googlesource.com/c/1303558Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603678}

These tests where marked as Fail: ToT crashed when running e.g. [1]
with chrome://flags/#enable-experimental-web-platform-features.

- Pixel_CanvasUnacceleratedLowLatency2D: is kept disabled on Android
because software compositing doesn't work at all; this test is
changed from Fail() to Skip() and bundled with similar expectations.
Other similar android-sw-compositor expectations are updated and
gathered in the same area for better reference (there are no plans
whatsoever to make this compositor mode work on Android)

- Pixel_CanvasLowLatency2D: I landed a fix recently for a crash
(crrev.com/c/1297469), with that the test works but produces a
sliiiightly different output (see e.g. the first row of [2]), so we
have to rebaseline the reference images. For that, the first step
is to mark the test as disabled for all platforms.

[1] http://htmlpreview.github.io/?https://github.com/chromium/chromium/blob/HEAD/content/test/data/gpu/pixel_canvas_low_latency_2d.html
[2] http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?868948046954e7d06d97eb10544ea3b27b320953_android_marshmallow_arm64_rel_telemetry

Bug: 865957
Change-Id: I45ccbc0a674cb6eb51f622d7c7af039162a2c071
Reviewed-on: https://chromium-review.googlesource.com/c/1294870Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603677}

We should not send out cached devices in the first place.
Double bugs involve here:

At the beginning of human history:
We call SendCachedDevicesFound() whenever we start discovery.
However, SendDevice() doesn't really send cached devices,

until I fix it in crrev.com/c/1105559......

But the problem is, in the first place, cached (inactive) devices
are not supposed to be reported in a discovery session.

Also note that DeviceFound() is completely independent from
LEDeviceFound(). If bluetooth service doesn't give an implementation for
DeviceFound() (which is not likely), it could still provide an
implementation for LEDeviceFound(), and LEDeviceFound() should still be
called in this case.

BUG=chromium:885339
TEST=manual test

Change-Id: Id97acd40fad19e4ee5a3ed64792a0598dce46ea7
Reviewed-on: https://chromium-review.googlesource.com/c/1303253Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Cr-Commit-Position: refs/heads/master@{#603676}

NOTRY=true
TBR=perezju@chromium.org
CC=perezju@chromium.org
BUG=899856

Change-Id: Idc6765a377b206722600f42b8127665bd524be51
Reviewed-on: https://chromium-review.googlesource.com/c/1306775Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603675}

R=dgozman@chromium.org

Bug: chromium:595206
Change-Id: Ic1088699d040b64e41a37360442d9765ec1f39ea
Reviewed-on: https://chromium-review.googlesource.com/c/1304488Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603674}

It was overlooked in
https://chromium.googlesource.com/chromium/src.git/+/4805b078411fc13ae107bcfd01a77c2abf929033

This change remedies that.

Also, revises histograms.xml entry for this.  The entry previously
had some copied text referring to changes in Session.TotalDuration
in earlier milestones.  These changes don't apply to the Max1Day
metric, as it was only implemented for M-69.

Bug: 856467
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2a011801f4e67dff72b018a0c0537962c77932df
Reviewed-on: https://chromium-review.googlesource.com/c/1298479Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603673}

R=futhark@chromium.org

Bug: 641877
Change-Id: I52878c9bca16765d3b32127b5637a7ec521e76dc
Reviewed-on: https://chromium-review.googlesource.com/c/1304416
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603672}

If a LayoutObject is removed we need to ensure the link highlight layers
are cleared. This may not set geometry_needs_update_ so we need to
check for this condition in LinkHighlightImpl::UpdateGeometry.

Bug: 899099
Change-Id: I306ae5b14e8d84e06b77794e6f5df93460193fc2
Reviewed-on: https://chromium-review.googlesource.com/c/1303398
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603671}

gpu_tests.depth_capture_integration_test.DepthCaptureIntegrationTest.DepthCapture_depthStreamToRGBAFloatTexture
and
gpu_tests.depth_capture_integration_test.DepthCaptureIntegrationTest.DepthCapture_depthStreamToRGBAUint8Texture
are flaky on Android Release (Nexus 5X).

TBR=kbr@chromium.org

Bug: 899748
Change-Id: I0c69c45f563b6eada65ea586a30bb8aa0d813d1b
Reviewed-on: https://chromium-review.googlesource.com/c/1306215Reviewed-by: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603670}

Since the finch params are constant during the whole chrome session, we
get nothing by reading it in real time.

Instead we only need to read it once in the constructor.

Bug: 871674
Change-Id: Id88f295028f2f52f17229ce685eb40548977e5a3
Reviewed-on: https://chromium-review.googlesource.com/c/1304041
Commit-Queue: Charles . <charleszhao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603669}

Allowed key_value_pair_delimeter to be any arbitrary substring rather
than limited to just a char. Functionality of current function upheld
and rewritten in terms of the new, more general one.

Test: Current and newly added tests pass
Bug: chromium:894274
Change-Id: I6b487dfeb0c4a38e94526f3931d15c8e1b83db66
Reviewed-on: https://chromium-review.googlesource.com/c/1302498Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603668}

https://chromium.googlesource.com/catapult.git/+log/25da2e8be18d..36a23a7b2851


git log 25da2e8be18d..36a23a7b2851 --date=short --no-merges --format='%ad %ae %s'
2018-10-29 dtu@chromium.org Revert "Pinpoint - Merge bugs with same root cause."


Created with:
  gclient setdep -r src/third_party/catapult@36a23a7b2851

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:840872
TBR=sullivan@chromium.org

Change-Id: Ic1e0dfc5fa3f3e02e81654c4f7bf52a3b53eb2bf
Reviewed-on: https://chromium-review.googlesource.com/c/1306213Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603667}

This CL consolidates ToolbarFieldTrials into OmniboxFieldTrials.

This was enabled by the recent move of everything in the toolbar
component into the omnibox component.

Bug: 898347
Change-Id: Ie879a9adc28b2b56fe30d1a86d42f78a846551a4
Reviewed-on: https://chromium-review.googlesource.com/c/1303019
Commit-Queue: Tommy Li <tommycli@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603666}

These changes affect the headless shell also, and similar to this,
C++ code elsewhere which is generated from the .pdl file, e.g.
client code, may be affected. However since the wire format
isn't changing, such code continues to work if it sticks with
string (and continues to encode/decode base64 manually).

Relevant prereqs:
Supporting binary in .pdl files:
https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1285695
Rolled into Chromium / v8.

Add protocol::content::Binary to protocol_string{.h,.cc}.
https://chromium-review.googlesource.com/c/chromium/src/+/1280555
https://chromium-review.googlesource.com/c/chromium/src/+/1281166

[DevTools] Add blink::protocol::Binary to v8_inspector_string{.cc,.h}.
https://chromium-review.googlesource.com/c/chromium/src/+/1280210

Bug: chromium:891377
Change-Id: Ie959e251730b68929440385be24075fb430bcb0b
Reviewed-on: https://chromium-review.googlesource.com/c/1303410
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603665}

BUG=839751

Change-Id: Iaaa73898f05263cbf70bdf0f6c71f302959d151f
Reviewed-on: https://chromium-review.googlesource.com/c/1305955Reviewed-by: Troy Hildebrandt <thildebr@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603664}

BUG=899660

Change-Id: Ifa94f6d473d7075259395fbce4b5789864f97d9c
Reviewed-on: https://chromium-review.googlesource.com/c/1305398Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603663}

https://skia.googlesource.com/skia.git/+log/c09dc8ac723f..71652e2a09b7


git log c09dc8ac723f..71652e2a09b7 --date=short --no-merges --format='%ad %ae %s'
2018-10-29 khushalsagar@chromium.org gpu: Dump GrTextBlobCache stats in memory dumps.
2018-10-29 brianosman@google.com Remove another GrColor helper function
2018-10-29 caryclark@skia.org fix const order in docs


Created with:
  gclient setdep -r src/third_party/skia@71652e2a09b7

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:898910
TBR=herb@chromium.org

Change-Id: I1b06544e357085b89ef37f60926f636f596e9319
Reviewed-on: https://chromium-review.googlesource.com/c/1306115Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603662}

Currently, in particular on Mac, CreateGpuMemoryBuffer can fail, in which case
we can't rasterize the corresponding tile in ZeroCopyRasterBufferImpl, and we
just create a GL texture without binding anything to it, which ends up showing
black when we display. This is somewhat problematic to emulate with SharedImage
where it is not a valid state (SharedImages must have well-defined dimensions
and format).
Instead, we handle the failure by not creating a texture at all, keeping a zero
mailbox, and falling back to OOM rendering mode (checkerboarding) for the
corresponding tile.

Bug: 882513, 554541
Change-Id: Iffd29a660f655c2dee8179fd90baa2a15ae42bf7
Reviewed-on: https://chromium-review.googlesource.com/c/1303393
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603661}

crrev.com/c/1300235 introduced the option to lower the quality of backdrop
filters.

This CL lowers the quality of the backdrop blur one the shelf and the
applist shield.

In this way the texture allocations needed to apply the filter by cc will
be significantly smaller/faster and applying the filter itself will also
be faster on the GPU.

Bug: 897369
Change-Id: I57be9434c02b77b38315e0f998d23eda5d277e43
Reviewed-on: https://chromium-review.googlesource.com/c/1306234Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603660}

Bug: 879306
Change-Id: I54d55e06ee6634cb7db9621c9c242001efd29137
Reviewed-on: https://chromium-review.googlesource.com/c/1303073
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603659}

Screenshot: https://screenshot.googleplex.com/80KUNU90ea7.png
Change-Id: Ida044559836c50ee693307567bc484ee1a4d2f01
Reviewed-on: https://chromium-review.googlesource.com/c/1304486Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603658}

This adds a new summary and sets the explanation for non-secure form
edits on HTTP pages in the DevTools security panel. This fixes a bug
where HTTP pages downgraded to the DANGEROUS security level (under the
HTTP-Really-Bad changes) would get treated as broken HTTPS instead.

Bug: 816184
Change-Id: I9440a20f970ff4daffd9c3a11a6a5a86a0b39160
Reviewed-on: https://chromium-review.googlesource.com/c/1277650Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603657}