- 04 Jun, 2014 40 commits
-
-
hamaji@chromium.org authored
chrome://tracing uses TimeTicks::NowFromSystemTraceTime in base/time/time_posix.cc. TEST=nacl_loader_unittests # on i686 and ARM Chrome OS TEST=trybot BUG=378063 Review URL: https://codereview.chromium.org/298163008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274784 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@chromium.org authored
BUG=322664 Review URL: https://codereview.chromium.org/307173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274783 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@chromium.org authored
PepperFileIOHost keeps a weak pointer of FileSystemOperationRunner so when it goes away it cannot delete the runner as expected by the fileapi implementation. This CL adds an adapter class in the middle so that when OpenFile completes after PepperFileIOHost destruction, the file is bounced back to another thread to be closed. BUG=377599 Review URL: https://codereview.chromium.org/306403005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274782 0039d316-1c4b-4281-b951-d872f2087c98
-
naiem.shaik@gmail.com authored
This class is the //chrome impl of TranslateClient. Rename the class as per convention. BUG=361115 R=blundell TEST=browser_tests,components_unittests --gtest_filter=Translate* Review URL: https://codereview.chromium.org/301403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274781 0039d316-1c4b-4281-b951-d872f2087c98
-
dconnelly@chromium.org authored
Revert "Reland 274558 - Move some extensions renderer resources to extensions_renderer_resources.grd." This reverts commit 43d0610a. Broke Win build: http://build.chromium.org/p/chromium/builders/Win/builds/21536 BUG=none TBR=yoz@chromium.org Review URL: https://codereview.chromium.org/318683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274780 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
Now that process backgrounding is controlled from within the renderer process on Windows, we need to wait for the process to handle the IPC message before the background state changes. This fix changes the test to wait for the result of a script from the renderer process before checking background status. Doing so ensures the renderer will process the background IPC before the check is performed. BUG=362294 TEST=Ran unittest on Windows. Review URL: https://codereview.chromium.org/305373004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274778 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
Fulfills the unit test request in the review of r273791. https://codereview.chromium.org/307783003#msg3 Use a no-op TextEditKeyBindingsDelegateAuraLinux. (replicates Emacs bindings ignoring [Shift+]Ctrl+Z) Minor cleanup and test renaming. BUG=377355 TEST=NONE R=oshima@chromium.org Review URL: https://codereview.chromium.org/310283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274777 0039d316-1c4b-4281-b951-d872f2087c98
-
sungmann.cho@navercorp.com authored
BUG=380224 Review URL: https://codereview.chromium.org/316723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274776 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
This splits views_content_client_main_parts_* into versions for ChromeOS, Mac and Desktop Aura, with a per-platform Create(..) function. ChromeOS and Desktop Aura sharing a common Aura part. desktop_test_views_delegate.cc is moved to an _aura version, and a _mac version added. views_content_client now loads content_resources.pak to access sandbox profiles required for mac. A macviews_builder target is added to expose views_examples_with_content_exe on Mac, and to give the fyi trybot something to build. BUG=366007 Review URL: https://codereview.chromium.org/297143009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274775 0039d316-1c4b-4281-b951-d872f2087c98
-
falken@chromium.org authored
Also remove browser tests for the fetch event that will be replaced with layout tests in the next Blink patch. Since layout tests can't test HTTP response headers, one of the browser tests remains. Multi-sided patch to implement blob-type fetch event response bodies: #1: blink-side: https://codereview.chromium.org/307063002/ #2: chromium-side, THIS PATCH #3: blink-side: https://codereview.chromium.org/304233017 BUG=379074 Review URL: https://codereview.chromium.org/304153015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274773 0039d316-1c4b-4281-b951-d872f2087c98
-
tbarzic@chromium.org authored
DesktopMediaPicker was getting created with web_contents returned by web_contents(), which is part of WebContentsObserver interface, and which does not get set when the target tab is not specified. Also, fix handling of a case when the method is called when there are no web contents to attach the picker dialog to. BUG=375576,364050 TEST=from a extension with desktopCapture permission: chrome.desktopCapture.chooseDesktopMedia(['screen'], undefined, function()) does not crash Review URL: https://codereview.chromium.org/307453010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274771 0039d316-1c4b-4281-b951-d872f2087c98
-
raymes@chromium.org authored
Previously in-process plugins could close the main URLLoader, which could result destruction of themselves. This only happens in-process because calling URLLoader.Close() results in synchronously calling in to blink, whereas the call is asynchronous due to IPC when OOP. This is fixed here by adding a hack to the in-process router. We should probably post every message to the message loop, but there is a chance this might break something and we will be removing in-process plugins altogether soon. There are also two other related bugs this fixes: 1) The PepperPluginInstanceImpl::DidDataFromWebURLResponse could be called after PepperPluginInstanceImpl::Delete() has been run, in which case the plugin instance may also be destroyed, so we should not run HandleDocumentLoad in that case. 2) The instance may be destroyed before the PepperURLLoaderHost so we need to check if it is null. BUG=372548 Review URL: https://codereview.chromium.org/314603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274770 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
In src/media/cast/transport, both TransportAudioSender and TransportVideoSender were identical classes/implementations. In addition, they did nothing but wrap RtpSender, passing EncodedFrame data through the encryption library. Instead of merging them into one class, both have been deleted, with the encryption calls moved into AudioSender/VideoSender. Testing: Confirmed all unit tests continue to pass. Also, manually tested with a browser build, with DVLOG output to confirm encryption was successfully enabled for a cast session. Review URL: https://codereview.chromium.org/314593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274769 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274768 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/1940df968da44ef95ddb332270aa23481552ca65..abc073376091e66f705674b825b1247148cb9c24 TBR=jvanverth@google.com BUG= Review URL: https://codereview.chromium.org/310963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274767 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
This is to ensure that we don't use GDI to query the device scale factor in renderer processes. This is in preparation for setting the MITIGATION_WIN32K_DISABLE policy on renderer processes, which will lock them out from making user32/gdi32 calls which enter win32k.sys. BUG=365160 Review URL: https://codereview.chromium.org/308003020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274766 0039d316-1c4b-4281-b951-d872f2087c98
-
jbauman@chromium.org authored
The handle_map_ was holding onto them, so they weren't being released. Instead, they should be removed from the map whenever that first SharedBitmap that was created is destroyed. BUG=362924 TBR=piman@chromium.org Review URL: https://codereview.chromium.org/310973003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274765 0039d316-1c4b-4281-b951-d872f2087c98
-
yoz@chromium.org authored
This patch fixes references in the .gyp to .js resource files. This breaks the remaining dependency from src/extensions to chrome resources files. BUG=368334 TBR=rockot@chromium.org,jam@chromium.org Review URL: https://codereview.chromium.org/312883004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274764 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
So that the launch error bubble is shown and recorded launcher error is cleared and no longer blocker future launch attempt. BUG=379973 Review URL: https://codereview.chromium.org/310213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274763 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
R=machenbach@chromium.org BUG=none Review URL: https://codereview.chromium.org/314933004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274762 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@chromium.org authored
BUG=322664 Review URL: https://codereview.chromium.org/307463004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274761 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
408s indicate a socket was left idle for too long before sending a request. It's possible these errors are being surfaced to users more often than previously due to https://codereview.chromium.org/169643006, for servers that very aggressively time out never-used sockets. BUG=377581 Review URL: https://codereview.chromium.org/303443011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274760 0039d316-1c4b-4281-b951-d872f2087c98
-
noamsml@chromium.org authored
GCD API flow for registration ticket creation BUG= Review URL: https://codereview.chromium.org/307353008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274759 0039d316-1c4b-4281-b951-d872f2087c98
-
mlamouri@chromium.org authored
The fix is a bit dirty but it should work and is straightforward. The clean solution would involve more changes on the Blink side or some wrapping of objects in WebURLLoaderMock. BUG=None Review URL: https://codereview.chromium.org/293003004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274758 0039d316-1c4b-4281-b951-d872f2087c98
-
dconnelly@chromium.org authored
Broke Mac tests: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests%20%281%29&number=52768 http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests%20%282%29&number=52019 http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%283%29&number=50243 http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%284%29&number=41693 > Use FSEvents for recursive file watch on Mac > > Brings back the old FSEvents code, changing it to support recursive watches only, and use dispatch queues instead of using the CFRunLoop from the UI thread. > > BUG=144491 > > Review URL: https://codereview.chromium.org/283423003 TBR=vandebo@chromium.org Review URL: https://codereview.chromium.org/316853003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274757 0039d316-1c4b-4281-b951-d872f2087c98
-
hirono@chromium.org authored
Previously if multiple files are selected for launching a file handler, Files.app sends multiple launch events for each file. But according to the specification of the launch event, we can put multiple entries in a single launch event. This CL lets Files.app follow the specificaiton. BUG=358694 TEST=manually R=benwells@chromium.org, kinaba@chromium.org Review URL: https://codereview.chromium.org/300063006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274755 0039d316-1c4b-4281-b951-d872f2087c98
-
nyquist@chromium.org authored
This CL changes the backing store for the InMemoryContentStore to now be of type base::MRUCache. This ensures that the growth of the store is not unbounded. Tests are also added to ensure the new functionality works as expected. BUG=379642 Review URL: https://codereview.chromium.org/302163005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274754 0039d316-1c4b-4281-b951-d872f2087c98
-
aurimas@chromium.org authored
BUG=380224 Review URL: https://codereview.chromium.org/315583004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274753 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274752 0039d316-1c4b-4281-b951-d872f2087c98
-
rouslan@chromium.org authored
This version contains guessing the administrative area based on the postal code. TBR=estade@chromium.org BUG=327046 Review URL: https://codereview.chromium.org/317533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274751 0039d316-1c4b-4281-b951-d872f2087c98
-
bajones@chromium.org authored
This was an oversight in https://codereview.chromium.org/305643004/ TBR=kbr@chromium.org Review URL: https://codereview.chromium.org/317523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274750 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
The only way this crash could occur is if we're trying to layout the titlebar, the delegate requests showing the icon, but there isn't an icon view. In such cases, we shouldn't try to set the bounds on a NULL view. (This fix is theoretical; I wasn't able to repro the bug.) BUG=376313 Review URL: https://codereview.chromium.org/310193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274749 0039d316-1c4b-4281-b951-d872f2087c98
-
aurimas@chromium.org authored
BUG=372926 Review URL: https://codereview.chromium.org/302283008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274748 0039d316-1c4b-4281-b951-d872f2087c98
-
sandersd@chromium.org authored
Depends on https://codereview.chromium.org/289373011/. BUG=104711 Review URL: https://codereview.chromium.org/308543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274747 0039d316-1c4b-4281-b951-d872f2087c98
-
ccameron@chromium.org authored
Link against IOSurface.framework instead -- this is an option starting in 10.6. BUG=314190 Review URL: https://codereview.chromium.org/301973010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274746 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274745 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175389:175413&mode=html TBR=jchaffraix@chromium.org,beverloo@chromium.org,eseidel@chromium.org BUG= Review URL: https://codereview.chromium.org/310253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274744 0039d316-1c4b-4281-b951-d872f2087c98
-
limasdf@gmail.com authored
ExtensionUninstallDialog into extensions namespace and remove unwanted extensions:: prefix in extension_uninstall_dialog.*. BUG=380149 Review URL: https://codereview.chromium.org/307413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274743 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=380568,380575 NOTRY=true TBR=bruening@chromium.org Review URL: https://codereview.chromium.org/318643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274742 0039d316-1c4b-4281-b951-d872f2087c98
-
qinmin@chromium.org authored
The delegated render layer can change when video enters/exits fullscreen Similar to other places in this file where layer_ is used, we should do a null check before using it. BUG=356671 Review URL: https://codereview.chromium.org/309353003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274741 0039d316-1c4b-4281-b951-d872f2087c98
-